- 18 Sep, 2018 40 commits
-
-
Khushal authored
Temporarily make sure we always fallback to using ES2 for all android versions to understand whether a particular crash spike associated with the oopr experiment is a result of oopr enabling ES3 for skia. R=ericrk@chromium.org Bug: 884659 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If5668a65d967294d07687f8d09a114153aa0d09f Reviewed-on: https://chromium-review.googlesource.com/1232198Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#592248}
-
Sam McNally authored
Bug: 883628 Change-Id: I5f4d81dd1a1d269a33091748def79d20941f1eca Reviewed-on: https://chromium-review.googlesource.com/1229638Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#592247}
-
David Tseng authored
Test: navigate within editable text. Hit the 'end' key. Verify the cursor lands on the extra cell padding after this change. Before this change, the cursor "disappears". Change-Id: I370bb2ae2bc458e4d94a1cd364c381fec3e976da Reviewed-on: https://chromium-review.googlesource.com/1231982Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592246}
-
Yuly Novikov authored
ANGLE's support for these formats has been available for a while, so remove the workaround converting sized formats to unsized. Bug: angleproject:556,angleproject:2567 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie5bddbe78a7231c9b90966573812f118abca379f Reviewed-on: https://chromium-review.googlesource.com/1231981 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592245}
-
bsheedy authored
Adds MacOS-only logic to run_gpu_integration_test.py that immediately aborts if the lockscreen is detected. The device should be automatically unlocked prior to the test starting, so a failure to do so needs to be easily identified for investigation. Bug: 884913 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I684a73ace61fd34484af815c7d55517613de16b3 Reviewed-on: https://chromium-review.googlesource.com/1229366Reviewed-by:
-
Tommy Li authored
This reverts commit 29028a2d. Reason for revert: Breaks Linux Msan tests. See https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/builds/11648 Original change's description: > [css-tables] Force layout when colgroups are removed or added > > When colgroups are modified via Javascript, Blink uses a stale computed > logical width, resulting in incorrect sizing of auto columns if layout > was previously done. This patch forces a fresh layout of the affected > cells, which corrects this behaviour. > > Bug: 870296 > Change-Id: I4a12d5a8db689ba1457c6c9960ae8ea9c1dd40d9 > Reviewed-on: https://chromium-review.googlesource.com/1162224 > Commit-Queue: David Grogan <dgrogan@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Reviewed-by: David Grogan <dgrogan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592115} TBR=dgrogan@chromium.org,eae@chromium.org,richard.townsend@arm.com,mstensho@chromium.org Change-Id: If7507718dddd3b84ceffdae3df5e35b8402f27ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870296 Reviewed-on: https://chromium-review.googlesource.com/1232480Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#592243}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I77c7dbeb1f412305091a49f239b1a5c9826a691a Reviewed-on: https://chromium-review.googlesource.com/1232207 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592242}
-
kylechar authored
VizProcessContextProvider relies on GLInProcessContext to own/initialize some classes necessary to support a command buffer. We'll need to access even more internal state from GLInProcessContext for memory reporting which means adding another accessor. Instead of adding another accessors, move initialization logic into VizProcessContextProvider. This removes a step of indirection and makes the code a bit easier to understand. Bug: 876508 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib66ad5596e6c349695a25279b65792260ea89105 Reviewed-on: https://chromium-review.googlesource.com/1231829Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#592241}
-
Joel Einbinder authored
Change-Id: I52f28ee062a9f651dbb0e95f6abeb762b6afab35 Reviewed-on: https://chromium-review.googlesource.com/1229673Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#592240}
-
Mark Pearson authored
Change-Id: Id2084ba5bf5e91f007417febdfa817f757fe6eb7 Reviewed-on: https://chromium-review.googlesource.com/940861Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#592239}
-
Xiyuan Xia authored
- Add testonly to service_manifest and grit GN template - Make test_ws service manifest testonly and update dependent targets; Bug: 874089 Change-Id: If9b46baf09e1b4457bdc05b252825d46b610d8ab Reviewed-on: https://chromium-review.googlesource.com/1231895 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#592238}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c623fabe..604c50c8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I434ce8edd5f44a20d7583187c68634be859bafbe Reviewed-on: https://chromium-review.googlesource.com/1231979Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592237}
-
Muyuan Li authored
Label seems to use heuristics to figure out number of lines of text when width is not specified, which causes problem when DPI changes. We add an explicit width to the greeting label to avoid this issue. Bug: b/112843496 Test: manual Change-Id: I12122de165a8c1071cf29c2970c97595820b7263 Reviewed-on: https://chromium-review.googlesource.com/1228892Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#592236}
-
Xida Chen authored
WidgetInputHandlerManager::DispatchEvent is the function where we run the callback that sets the touch action. There are some corner cases where the touch action is set to base::nullopt. This is fine previously when the TouchActionFilter::allowed_touch_action_ has a default value of kTouchActionAuto. However, now that we changed the |allowed_touch_action_| to Optional instead of having a default value (Auto), and rely on the fact that it will be set by the renderer when ack from the main thread, we have to set |allowed_touch_action_| to Auto for these corner cases. This CL sets it at receiver end, which is in InputRouterImpl::OnTouchEventAck. When receiving the ack for touch sequence start, if the |allowed_touch_action_| is not set, then we maybe hitting these corner cases. Bug: 851644 Change-Id: If1bb393580619eb7b7ba60ac2b01099c83c71f26 Reviewed-on: https://chromium-review.googlesource.com/1228295 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592235}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1904775ac35b..0c858b7a312a Created with: gclient setdep -r src-internal@0c858b7a312a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I45ea1d7289359703cfb57a333aec2b98735c123d Reviewed-on: https://chromium-review.googlesource.com/1232026Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592234}
-
Krishna Govind authored
R=benmason@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I795438ae4b19230303b07ce45df0e1e4724bb081 Reviewed-on: https://chromium-review.googlesource.com/1232476Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#592233}
-
khmel@chromium.org authored
TEST=locally BUG=879628 Change-Id: I69574cab1012efea5d87d786373b20eba543d616 Reviewed-on: https://chromium-review.googlesource.com/1232337Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#592232}
-
Patricia Hongo authored
Bug: 884872 Change-Id: Ic6dd2b2ba1e28400d2585aab5751763592a7ad86 Reviewed-on: https://chromium-review.googlesource.com/1228440Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Patricia Hongo <phongo@google.com> Cr-Commit-Position: refs/heads/master@{#592231}
-
Nico Weber authored
After this, for all targets where the warning is enabled on non-Win, it's now enabled on Windows too. Bug: 404525 Change-Id: I2518fe482e04ba3c4b9964c49ee3fc3c4217d170 Reviewed-on: https://chromium-review.googlesource.com/1231838Reviewed-by:
-
Sam McNally authored
Fallback to native copy when a file is unavailable (e.g. not yet synced to the server) or when offline. Bug: 870009 Change-Id: I974da5d56187812d2376d7ea97bda9d9e6c68f29 Reviewed-on: https://chromium-review.googlesource.com/1229714 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#592229}
-
Peter Kvitek authored
TaskDuration metric used different TimeTickNow sources when calculating the final task duration. This resulted in incorrect TaskDuration values when running headless Chrome in Virtual Time mode. Change-Id: I1c862cb783e768b4128ef6d55510c1a5151c2e40 Reviewed-on: https://chromium-review.googlesource.com/1231315Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#592228}
-
Manas Verma authored
Adding browser tests for the sign-in after local save flow. This includes user-action sign-in metrics, the sign-in promo, and the manage cards prompt. Bug: 855186 Change-Id: I8c1d15f79e6915230860d7f0f2529a10c01559b7 Reviewed-on: https://chromium-review.googlesource.com/1196918 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#592227}
-
Theresa authored
Snackbars are used in activities that don't have a button style set. Explicitly set a style on the snackbar action button. BUG=885095 Change-Id: I20bd7447475cc8da287a2a96b23f8a0f025dbcd6 Reviewed-on: https://chromium-review.googlesource.com/1232156Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#592226}
-
Michael Spang authored
The vulkan rendering code in ozone_demo uses code which has been removed such as gpu::VulkanSwapChain and gpu::VulkanImageView. Rewrite it to manage its own image views, render passes, and framebuffers just like VulkanOverlayRenderer has to. Bug: 861853 Test: ozone_demo --ozone-platform=x11 --enable-vulkan Change-Id: I358912b02a11d902803cc0a0682da769b47a5a65 Reviewed-on: https://chromium-review.googlesource.com/1228959 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
Michael Spang authored
Undesignate initializers since we can't use those yet. Bug: none Test: compile Change-Id: I42160e6cc4b88938c863659f5c709e9415b2631d Reviewed-on: https://chromium-review.googlesource.com/1231817 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
Ben Kelly authored
This line was accidentally deleted in https://crrev.com/c/1220563. R=mek@chromium.org Bug: 883052 Change-Id: I55438446ea228c9828b92845f7df6004244f2240 Reviewed-on: https://chromium-review.googlesource.com/1232274 Commit-Queue: Ben Kelly <wanderview@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#592223}
-
Khushal authored
StyleImage was not updating the image animation policy correctly, which was causing background-image images to animate even when disabled from the browser. R=chrishtr@chromium.org Bug: 882925 Change-Id: I54c6c5241f24925ddf67e86f2323b209bdf78b2b Reviewed-on: https://chromium-review.googlesource.com/1227490 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592222}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2426fe64bffb..57988b451c5c git log 2426fe64bffb..57988b451c5c --date=short --no-merges --format='%ad %ae %s' 2018-09-18 ahassani@chromium.org dev_server_wrapper.py: Add chromite bin directory when running devserver 2018-09-18 chingcodes@google.com signing: Add preamble_flag to BiosSigner 2018-09-18 dgarrett@google.com PublishUprevChangesStage: Use overlay_type for UprevPackages. 2018-09-18 dgarrett@google.com UprevStage: Use overlay_type instead of explict overlays list. 2018-09-18 chingcodes@google.com signing: Add FirmwareSigner.WriteSignerNotes 2018-09-18 chingcodes@google.com signing: Add FirmwareSigner and ResignImageFirmware 2018-09-18 dgarrett@google.com cros_sysroot_utils: Remove --chrome-only. 2018-09-18 dgarrett@google.com config_lib: Remove chrome_binhost_only option. Created with: gclient setdep -r src/third_party/chromite@57988b451c5c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie24576213e6dfa500af9f833c8749dab360f9612 Reviewed-on: https://chromium-review.googlesource.com/1232021Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592221}
-
Aldo Culquicondor authored
Bug: 778374 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I85cb90ae37a502fc86a0a28c22b1011ae66a6ed7 Reviewed-on: https://chromium-review.googlesource.com/1220571 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#592220}
-
Fabrice de Gans-Riberi authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I224be4100930f72cb9ed2b173b785a1597397d52 Reviewed-on: https://chromium-review.googlesource.com/1231980Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
-
Istiaque Ahmed authored
ExtensionServiceWorkerMessageFilter is constructed on UI and it *often* gets destroyed in IO thread, but there is no such gurantee. It is possible for it to be destroyed on UI thread as it also handles handful of messages on UI thread. Remove the IO thread restriction, also add DCHECK in constructor. Bug: None Change-Id: I15ec9ecd347c44a8fc8fdea031f72b27689190b2 Reviewed-on: https://chromium-review.googlesource.com/1231695Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#592218}
-
sahel authored
This cl changes the Autoscroll middle click logic to wait for the first GFS with none-zero velocity before sending the GSB. This is to make sure that the generated GSB has the proper delta hints for hit testing. In autoscroll browsertests I increased the mouse move deltas to make sure that the fling velocity is large enough and the tests are stable. Bug: 249063 Test: AutoscrollBrowserTest.AutoscrollFlingGSBDeltaHints Change-Id: I1714b70439fcc5abea28938e272f64ff27b4bc66 Reviewed-on: https://chromium-review.googlesource.com/1230582 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
inglorion authored
content_browsertests UtilityProcessHostBrowserTest.LaunchProcessAndCrash is flaky on Windows. Disabling the test so that it doesn't cause build bots to be red on non-breaking changes. Bug: 879555 Change-Id: If2aff8e69d240adf09173b82472db6c86eb6aa91 Reviewed-on: https://chromium-review.googlesource.com/1227303Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#592216}
-
Sahel Sharify authored
This cl adds threaded tests suites for fast/events/touch|wheel/* layout tests. Other than the following tests the rest of the tests are passing without any issues: Touchpad fling related tests: these tests are skipped since touchpad swipe is recently added to gpu benchmarking. I already have a bug for converting these tests to use gpu benchmarking. see crbug.com/857490 -virtual/threaded/fast/events/touch/gesture/pad-gesture-cancel.html -virtual/threaded/fast/events/touch/gesture/pad-gesture-fling.html -virtual/threaded/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html -virtual/threaded/fast/events/wheel/mainthread-touchpad-fling-latching.html -virtual/threaded/fast/events/wheel/wheel-fling-cancel.html The following test is flaky, but checking flakiness dashboard showed that its other variations are flaky as well. see crbug.com/884312 -virtual/threaded/fast/events/touch/multi-touch-user-gesture.html The following two tests are failing, but again so are their other variations. I updated all the expectations to point to the same bug and added expectations for the threaded versions. see crbug.com/876305 -virtual/threaded/fast/events/touch/compositor-touch-hit-rects-list-translate.html -virtual/threaded/fast/events/touch/compositor-touch-hit-rects.html Only the threaded version of the following tests are failing since they are using event sender. I filed a bug to convert it to use gpu benchmarking: crbug.com/884332 -virtual/threaded/fast/events/touch/gesture/gesture-tap-active-state-hidden-iframe.html -virtual/threaded/fast/events/touch/gesture/gesture-tap-frame-removed.html -virtual/threaded/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html -virtual/threaded/fast/events/touch/gesture/gesture-tap-active-state.html -virtual/threaded/fast/events/touch/gesture/focus-selectionchange-on-tap.html One additional test is failing when running with --additional-driver-flag=--enable-blink-gen-property-trees, for which I have filed a bug: crbug.com/884846 Bug: 874995, 884332, 884312, 876305 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifbc4ca54b48307320fe3a703b93cff1620dd1878 Reviewed-on: https://chromium-review.googlesource.com/1227331 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592215}
-
Francois Doray authored
Bug: 833989 Change-Id: If8927d294fc3e28791bdaac07294eace6b21c8ba Reviewed-on: https://chromium-review.googlesource.com/1231298 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
Xiaoqian Dai authored
For fling event, we also should do proper drag ending if splitview mode is active at the moment. Otherwise, the splitview divider bar won't be able to place on top properly. Bug: 885261 Change-Id: I992c2502090c2f4d6fd9e4f0401ca172f9041823 Reviewed-on: https://chromium-review.googlesource.com/1231893Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#592213}
-
Dave Tapuska authored
Use wtf_size_t when dealing with WTF types. BUG=879657 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic2d84e1ef5c07481c45d987a1ca1140ec4975442 Reviewed-on: https://chromium-review.googlesource.com/1228780Reviewed-by:
-
chrome://sys-internalsDave Tapuska authored
s/kernal/kernel BUG=884319 Change-Id: Ifd5c6470e62d2d15992253df65d1725d2b8b95df Reviewed-on: https://chromium-review.googlesource.com/1231977Reviewed-by:
-
John Delaney authored
THere metrics are now gated on there being non-zero ad bytes on page. Reflect this condition in the histogram descriptions. See: https://chromium-review.googlesource.com/c/chromium/src/+/1228433 Bug: 884678 Change-Id: I5320c4b8fff1e3e57ba45cb2c0100db9ea577d62 Reviewed-on: https://chromium-review.googlesource.com/1231154Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#592210}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/57efeca83c87..1904775ac35b Created with: gclient setdep -r src-internal@1904775ac35b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I56870fadcb526ba8967914bc5a27261b16b2ddfe Reviewed-on: https://chromium-review.googlesource.com/1231928Reviewed-by:
-
