GitLab

BUG=none
TEST=none.  just internal cleanup of a todo


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25735 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/196064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25734 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25733 0039d316-1c4b-4281-b951-d872f2087c98

DevTools: populate scopes with local variables when on a breakpoint. This feature was broken by one of the recent WebKit rolls.
Review URL: http://codereview.chromium.org/202021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25732 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/17452
TEST=Test should not be flaky.
Review URL: http://codereview.chromium.org/193058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25731 0039d316-1c4b-4281-b951-d872f2087c98

* Fix seg fault in deleting view from RemoveTabAtIndex
* move initialization of tabbed page to NativeControlCreated

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/196055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25730 0039d316-1c4b-4281-b951-d872f2087c98

TEST=See bug.
http://crbug.com/21006

Review URL: http://codereview.chromium.org/197044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25729 0039d316-1c4b-4281-b951-d872f2087c98

The difference between repaint areas is due to the difference in repaint logic. Safari/Mac port uses NSView's native 
rectangle collection/unification, and we just unify all into one damage rect.


R=jparent
BUG=8630
TEST=none

Review URL: http://codereview.chromium.org/195028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25728 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rafaelw
BUG=none
TEST=use mappy extension

Review URL: http://codereview.chromium.org/199059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25727 0039d316-1c4b-4281-b951-d872f2087c98

BTW, thanks Microsoft.

TEST=links on 32 bits OS
BUG=none
TBR=nsylvain
Review URL: http://codereview.chromium.org/200060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25725 0039d316-1c4b-4281-b951-d872f2087c98

Cmd-F to repeat a search.

BUG=http://crbug.com/18762
BUG=http://crbug.com/20273
TEST=See test cases in bugs.  Both should work now.
Review URL: http://codereview.chromium.org/200050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25722 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=asargent

Review URL: http://codereview.chromium.org/196052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25721 0039d316-1c4b-4281-b951-d872f2087c98

TEST=check the File menu in english to check what is seen
BUG=19928
Review URL: http://codereview.chromium.org/200057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25720 0039d316-1c4b-4281-b951-d872f2087c98

Update ignore for icu directory change.



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25716 0039d316-1c4b-4281-b951-d872f2087c98

Nuke some methods that now live in WebKit.

BUG=21277
Review URL: http://codereview.chromium.org/199055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25715 0039d316-1c4b-4281-b951-d872f2087c98

BUG=8198
TEST=net-purify test passes on Windows
TBR=erikkay
Review URL: http://codereview.chromium.org/196061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25713 0039d316-1c4b-4281-b951-d872f2087c98

Need to figure out why settings are inavailable through InspectorController.
For now, just stub them.

BUG=http://crbug.com/21277
TEST=none

Review URL: http://codereview.chromium.org/196060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25711 0039d316-1c4b-4281-b951-d872f2087c98

Replace icu38/icu38.gyp  with icu/icu.gyp in gyp files replace all the references to third_party/icu38 and icudt38.dll with third_party/icu and icudt42.dll in vsprops and cc files. Also, update the icu data module name and the icu data symbol in icu_util.cc


In addition, add a dummy C++ source file (xmldummy_mac.cc) to libxml to work around an Xcode bug (xmllint and xmlcatalog are linked with gcc rather than g++ even though it's linked to a "C++ library", libicuuc.a). 

Also updated is the test results for net_util_unittests.


This will not be landed until deps/third_party/icu42 is ready for all 3 platforms (Windows VS build files are not yet updated there). 

BUG=8198
TEST=On all platforms, all the targets are built fine.

Review URL: http://codereview.chromium.org/172031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25708 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rafaelw

Review URL: http://codereview.chromium.org/192051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25707 0039d316-1c4b-4281-b951-d872f2087c98

Likely will work now thanks to maruel!!!

BUG=None
TEST=None
TBR=gregoryd


Review URL: http://codereview.chromium.org/194053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25704 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/192050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25703 0039d316-1c4b-4281-b951-d872f2087c98

minor painting issues.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/199050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25701 0039d316-1c4b-4281-b951-d872f2087c98

when the request was for realloc(ptr, 0).  Calling realloc(ptr, 0)
is valid, and we should delete ptr and return NULL.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/194040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25700 0039d316-1c4b-4281-b951-d872f2087c98

Patch by Joel Stanley <joel@jms.id.au>

Review URL: http://codereview.chromium.org/197055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25699 0039d316-1c4b-4281-b951-d872f2087c98

BUG=20882

Review URL: http://codereview.chromium.org/199053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25698 0039d316-1c4b-4281-b951-d872f2087c98

This is based on the logic in the Firefox code.
It passes existing tests and one new test.

TEST=covered by new unit test

Review URL: http://codereview.chromium.org/200052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25697 0039d316-1c4b-4281-b951-d872f2087c98

It turns out that JSON[Reader|Writer] cannot handle periods in key
names(!). Because of this, an also to avoid leaking a sort of ForceTLS
browser history in the state file, we hash the domain names.

Also, this patch tries to implement the RFCs with respect to
canonicalising the names. Since IDN processing has already occured by
the time the name reaches us, there's only so much that we can do
however.

http://codereview.chromium.org/201033


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25696 0039d316-1c4b-4281-b951-d872f2087c98

BUG=21165

Review URL: http://codereview.chromium.org/201047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25695 0039d316-1c4b-4281-b951-d872f2087c98

It was failing to generate $(OutDir)\obj\global_intermediate\installer_util_strings\installer_util_strings.*

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/196046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25694 0039d316-1c4b-4281-b951-d872f2087c98

Add #include <stdio.h> for fclose et al.
Without stdio.h, we got errors like:
In file included from /usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.cc:5:
/usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.h: In destructor 'virtual PipeReader::~PipeReader()':
/usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.h:33: error: 'fclose' was not declared in this scope
/usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.cc: In member function 'virtual std::string PipeReader::Read(uint32)':
/usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.cc:11: error: 'fopen' was not declared in this scope
/usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.cc:12: error: 'fgets' was not declared in this scope
scons: *** [/usr/local/google/home/ukai/chrome/src/sconsbuild/Debug/obj/chrome/browser/chromeos/pipe_reader.o] Error 1

Review URL: http://codereview.chromium.org/199046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25693 0039d316-1c4b-4281-b951-d872f2087c98

BUG=19675

Review URL: http://codereview.chromium.org/193052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25692 0039d316-1c4b-4281-b951-d872f2087c98

TBR=levin
BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25691 0039d316-1c4b-4281-b951-d872f2087c98

Also remove std::vector<> from StackTrace to reduce heap usage during potential unstable execution.

TEST=none
BUG=http://crbug.com/20996
Review URL: http://codereview.chromium.org/201050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25685 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/14478

Review URL: http://codereview.chromium.org/196050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25684 0039d316-1c4b-4281-b951-d872f2087c98

Add beginDragWithFiles to EventSendingController. Also implement WebKitClientImpl::fileExists. With these, we're able to enable all drag-file related layout tests.

BUG=19884
TEST=none

Review URL: http://codereview.chromium.org/187015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25683 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none


Review URL: http://codereview.chromium.org/197049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25682 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/195029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25681 0039d316-1c4b-4281-b951-d872f2087c98

BUG=20927
TEST=none

Review URL: http://codereview.chromium.org/192039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25680 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=eroman


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25679 0039d316-1c4b-4281-b951-d872f2087c98

No significant code change, just preparing to redo the parsing
code and thinking I needed test coverage.

(Since the parse can fail now, made the parse error out
rather than continuing when it's unable to parse some fields.
This will have more failure cases in the next version of this
code.)

Review URL: http://codereview.chromium.org/193046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25678 0039d316-1c4b-4281-b951-d872f2087c98