- 16 Sep, 2019 40 commits
-
-
Adam Langley authored
The “Random” subgroup will alternate between offering CECPQ2 and CECPQ2b at run-time for each connection. This will allow the tail of slow clients to be better measured at the server. Installs in this subgroup will not send the PQ signal extension and thus will not record client-side metrics in the Net.SSL_Connection_Latency_PostQuantum histogram. Bug: 801302 Change-Id: I3ddbf65de87588e8de92b42dcf0e9a0522049a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804049Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#696994}
-
Andrew Xu authored
Some bugs are exposed by enabling scrollable shelf during tests: (1) In ScrollableShelfView::OnGestureEvent, event should be stopped from propagation if it gets handled. (2) In ScrollableShelfView::ShouldShowTooltipForView, it should check that the shelf item is not removed from the shelf model, (3) In FindFirstFocusableChild/FindLastFocusableChild, it should return early if the view model is empty. Bug: 1002576 Change-Id: I35a96d002bae88157e56622a880b6b3256e3e4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807562Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#696993}
-
John Delaney authored
Updates the expriy of this histogram. This histogram is still used for tracking behavior of display video creatives in Chrome. Bug: 990969 Change-Id: I973b18e9178ff1d10d006a0b9e26d9d366b33799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806078 Commit-Queue: John Delaney <johnidel@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#696992}
-
Gavin Williams authored
-Created a new variable in cr_input.html to control the placeholder's text spacing. Without this change it would inherit the input field's custom spacing which is too wide. Bug: 1002860 Change-Id: I6ad08bf800df733ec2c8db71e5d1930fd907a61e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806102Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#696991}
-
Peter Kotwicz authored
This CL: - Increases the maximum screenshot size (prior to PNG/JPEG encoding) that we transfer to Chrome. The new max will avoid downscaling on most phones (e.g. no downscaling on Pixel 3) - Uses JPEG encoding for large screenshots because JPEG encoding is faster than PNG encoding on Android. Although JPEG encoding is not lossless it is preferable to downscaling BUG=1001154 Change-Id: Ib9d61cee565b6d9a392272300bac71d6da46a861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787162 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#696990}
-
Shakti Sahu authored
When download offline content provider is enabled, we send redundant FAILED updates. However the notification layer removes it from the shared preferences the first time it sees a FAILED download. Hence it will result in two different notifications. The solution is to treat COMPLETED and FAILED as terminal downloads and filter out duplicate updates for them. Bug: 1003550 Change-Id: Ief7c4450d644259352d3626e4f9dbd7b15362091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801228 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#696989}
-
Theresa Wellington authored
Move find in page, accessibility tab switcher, tablet empty background view and incognito toggle, toolbar progress view, and control container interface to feature directories. BUG=951455 Change-Id: I722b6b8c5cd42fb7c8b7243d86ba0da07df8d42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804397 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#696988}
-
Yi Gu authored
HitTesting should skip surface layers that have pointer-events: none as well as their descendants. Bug: 1002245, 1002228 Change-Id: I2b471c4a7439857d6eabb1456ec42ed6a3c6b251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797092 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#696987}
-
Jesse Schettler authored
Send a PrintRendererAssociatedPtr to PrintRenderFrameHelper. When present, the associated interface pointer will be used to render print documents. An additional change will be made to perform the rendering. PrintViewManagerTest.*:PrintPreviewHandlerTest.*: \ PrintPreviewUIUnitTest.* Bug: b:140576300 Test: browser_tests --gtest_filter=PrintBrowserTest.* Test: unit_tests --gtest_filter=PrintPreviewDialogControllerUnitTest.*: \ Change-Id: Id344d85cc1113f40a93a25c756290246905c4d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789537Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#696986}
-
Peter Kasting authored
Bug: none Change-Id: I48941db4268e3b83a18909d83248fca9baa104e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808187 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#696985}
-
Donn Denman authored
This is a reland of a recent CL that required rollback due to test failure. The only change is to ContextualSearchManager to reset the internal state controller instead of asserting. OCL: https://chromium-review.googlesource.com/c/chromium/src/+/1769532 ---------- Allows Android Smart Text Selection to be enabled along with full Contextual Search semantics. Both systems look at page text. There used to be a bottleneck in getting surrounding text that only allowed a single request/response, but now that's been moved to Mojo, so multiple requests are allowed. The limitation was in the IPC browser/renderer connection, which Mojo avoids. This CL removes the logic that limited these systems when they were both active. Also annotate all the SelectionEventType ints correctly. BUG=961114, 1003725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769532Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#696125} Change-Id: Ic537bc9ff512a56086c1bf87c8c3d83cc8e08b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807957Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#696984}
-
Dmitry Gozman authored
This parameter is unused, and will not be available once DidFailProvisionalLoad becomes DidFinishNavigation. TBR=csharrison@chromium.org Bug: none Change-Id: Ieeeb3acaeba7cdfc8fb0f490686135e3a1683711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802096 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Charlene Yan authored
Bug: 905491 Change-Id: Ib9cd7e16a8d665fe6403a5b1b76ca872fe9d9383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804189 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#696982}
-
benwgold authored
Original Description: Pass signed in account name when available along with the deeplink intent. Also pass an indicator about whether incognito mode is available and do not send account name if enabled. Finally, refactor image sharing to separate out image retrieval from sharing functionality and use callbacks to get cleaner separation between lens and other sharing use cases. Remove unnecessary sign in setup Format Add error strings to lens asserts Add test coverage for both signed-in and signed-out cases Rebase and resolve conflicts Format Remove unused import Remove unused imports. Fix comments. Add comments and update tests Initial prototype of code to pass account information with intent. Testing fetching account + incognito status Bug: 1002247 Change-Id: I2f32270d3b1afaaa044db224c8b29d92f4951700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807607Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ben Goldberger <benwgold@google.com> Cr-Commit-Position: refs/heads/master@{#696981}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7a7f630ffbad..860369fc431e git log 7a7f630ffbad..860369fc431e --date=short --no-merges --format='%ad %ae %s' 2019-09-16 sugoi@google.com Enable vertexPipelineStoresAndAtomics feature 2019-09-16 sugoi@google.com Robust buffer access for vertex inputs 2019-09-16 sugoi@google.com Prevent extra vertices from being processed 2019-09-16 sugoi@google.com Point vertex processing optimization 2019-09-16 swiftshader.regress@gmail.com Regres: Update test lists @ 30847688 Created with: gclient setdep -r src/third_party/swiftshader@860369fc431e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Ife9478ae8445a9d344ceb110bfc88ca02e7b52b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807136Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696980}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I0499dc7535e9399d75a6b7fb6507221ca051de32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806077 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#696979}
-
Henrique Ferreiro authored
Convert the implementation and all users of the mojom::SiteEngagementDetailsProvider interface. Bug: 955171 Change-Id: I73e3cff072d5a9bfdcda98b668822dacfba59ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803290Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#696978}
-
Bill Budge authored
- Divides EnqueueAsPendingOperation into two methods, with a new TryBeginOperation method to check for any pending operations. This allows us to defer creating the PendingOperation until we know we need it. Otherwise, move semantics could potentially cause loss of data when we discard the PendingOperation. This worked before because the callbacks are copyable, and IOBuffer is ref-counted. - Adds some std::moves for callbacks, and some trivial renaming for consistency. - This is preparation for using mojo_base::BigBuffer for writing too. Bug: chromium:992991 Change-Id: Ia8b16ba9403da2b95c2c9a57da93a9112fd62b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801757Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#696977}
-
Jinsuk Kim authored
Shows a monogram icon for the gesture navigation sheet items whose favicon is not available. Bug: 1001303 Change-Id: I62a4d47878e1ba15b012471e8c7056888b3c3b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795539Reviewed-by:
-
James Cook authored
Emphasizing that it is not necessarily the actual state at runtime. For example, a Finch experiment can be at 100%, so a feature can be always-on despite being DISABLED_BY_DEFAULT. Bug: none Change-Id: I6dfaa86f4308f4c3f406c67d812c7ce7f5c0df22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804458 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c25802db30fa..ae8010776652 git log c25802db30fa..ae8010776652 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 jvanverth@google.com Revert "Add ETC2 support to Metal backend." 2019-09-16 reed@google.com update videoencoder, add scale option, remove motion-blur hack 2019-09-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-16 halcanary@google.com experimental/skottie_ios: Skottie iOS/Metal App 2019-09-16 nifong@google.com Add a wasm debugger test that uses a WebGL surface 2019-09-16 kjlubick@google.com [canvaskit] Add test for skottie to catch framebuffer issues 2019-09-16 halcanary@google.com gn: split out iOS templates to gn/ios.gni Created with: gclient setdep -r src/third_party/skia@ae8010776652 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I18c3c2a73ca5ea4abd301a1d18f07cc7e73a9792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807602Reviewed-by:
-
John Rummell authored
With the new Widevine CDM, support for AV1 has been added, so add AV1 to the list of codecs supported by Widevine on Linux and ChromeOS devices. Other OSes will get AV1 support from the manifest included with Widevine. Bug: 953504 Test: enabled browser_tests pass Change-Id: I33764dda1239c0ac4578d7ba09604fc59f2d1e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802834 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#696973}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c2da3ad9993b..542b7933970d git log c2da3ad9993b..542b7933970d --date=short --no-merges --format='%ad %ae %s' 2019-09-16 thestig@chromium.org Disable embedder tests that fail when Skia is enabled. 2019-09-16 thestig@chromium.org Disable embedder tests that fail when Skia or Skia Paths is enabled. 2019-09-16 thestig@chromium.org Change pdfium_test to show Skia build option. 2019-09-16 thestig@chromium.org Disable BarcodeTest when Skia or Skia Paths is enabled. 2019-09-16 thestig@chromium.org Delete dead CPDF_PageObject/CPDF_Path code. 2019-09-16 thestig@chromium.org Avoid some unnecessary copying in CPDF_TextPage. 2019-09-16 nigi@chromium.org [SkiaPaths] Avoid overlapping when drawing text. Created with: gclient setdep -r src/third_party/pdfium@542b7933970d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I02e52076d90726ec153f7a67c9b67338d8452f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806420Reviewed-by:
-
Nick Harper authored
The code that logged to these histograms was deleted in 2017, but I forgot to mark them as obsolete in histograms.xml. Change-Id: Idbca14571c01f0c81a76478d8967dd7f18bb61c4 Bug: 736978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802709 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#696971}
-
Aran Gilman authored
Bug: 1002664 Change-Id: If9515337d146721919edb3add59d205f1786d6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795999 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#696970}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/497d3d907b45..09feed378ddc git log 497d3d907b45..09feed378ddc --date=short --no-merges --format='%ad %ae %s' 2019-09-16 saklein@chromium.org cros_mark_as_stable: Add auto_merge for server-side rebase. Created with: gclient setdep -r src/third_party/chromite@09feed378ddc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2274fcb8ead59a10e455643ced1832aa5fce0b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807853Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4a60db4c3e62..64d4a375c810 git log 4a60db4c3e62..64d4a375c810 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 ehmaldonado@chromium.org git-cl: Return exit code of bb when executing git-cl try. Created with: gclient setdep -r src/third_party/depot_tools@64d4a375c810 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:976104 Change-Id: I94cb932a2063ece2f37df83bdd96ced4cb78293f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806419Reviewed-by:
-
Tina Lu authored
This is in preparation for enforcing, via a presubmit check, that all histograms specify either their units or an associated enum. Bug: 656625 Change-Id: If7c5ed41a20acff3aa9144c1977fa3ee0acdc33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802676Reviewed-by:
-
Kurt Horimoto authored
HTTP auth dialogs are now presented as child view controllers. This allows for usage NonModalViewControllerPresenter, which has the durations provided by UX. Also, since the view controllers can be presented immediately, this CL also prevents the flicker from occurring when exiting the tab switcher by avoiding the asynchronicity of view controller presentation. Bug: 979030, 999960, 999962 Change-Id: I8aec7617bd4900aa05859aea514f2429b95f7d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788513 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#696966}
-
Kurt Horimoto authored
App launcher dialogs are now presented as child view controllers. This allows for usage of NonModalViewControllerPresenter, which has the durations provided by UX. Also, since the view controllers can be presented immediately, this CL also prevents the flicker from occurring when exiting the tab switcher by avoiding the asynchronicity of view controller presentation. Bug: 979030, 999960, 999962 Change-Id: I8b2c967e9cbe393f107bcfb68124ed9f214a7125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788246 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to logic, only docs. This expands on //android_webview/README.md, taking some content from //android_webview/docs/README.md. I'm taking this opportunity to update links to provide better context (ex. link to the package-summary rather than individual frameworks classes). The distinction between these two README files is: * //aw/README.md describes WebView overall * //aw/docs/README.md describes how to work with WebView in chromium Bug: 918221 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: I89fb481b16c1fd7258fb409c6d61989497573182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807656Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#696964}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f5dec1c6af02..3d1647412c08 git log f5dec1c6af02..3d1647412c08 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 danilchap@webrtc.org in RtcpTransciever use lambdas with move capture. 2019-09-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1d12ff69..3cf04dec (696696:696812) 2019-09-16 danilchap@webrtc.org Delete deprecated rtc_event.h file Created with: gclient setdep -r src/third_party/webrtc@3d1647412c08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I4511e169e65c202958e7dadfa17b15970fed5356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806418Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I209c86526b663c5a216c1b9cebf88d2b9d41670f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807394Reviewed-by:
-
Shakti Sahu authored
This CL removes some usages of download snack bar since essentially download infobar has replaced it for showing download progress. However there are certain failure messages that are not covered which are not exactly related to an active download. For those messages, snack bar will continue to show. Bug: 1003153 Change-Id: I97d626ca69b77cacb2bfc52390c9b1dadf49a65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799924Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
Kurt Horimoto authored
When dialogs are displayed from the main frame, the requesting page's URL is already visible in the location bar, so we don't need to add source information as the title. The message text is used instead. Bug: 999966 Change-Id: I6ea4f5286c2626055e0350f5746fe8968dde1dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785013 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d8359680722c..eb8f5aa220f6 git log d8359680722c..eb8f5aa220f6 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 mohsen@chromium.org Remove main_thread_scroll_latency metric Created with: gclient setdep -r src/third_party/catapult@eb8f5aa220f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:1000697 Change-Id: I3f741d8a4a7f00a850736814678008733aec64e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807601Reviewed-by:
-
Avi Drissman authored
This reverts commit 2ce269f8. Reason for revert: Broke https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf util.build_utils.CalledProcessError: Command failed: ( cd /b/s/w/ir/cache/builder/src/out/Release; java -jar ../../third_party/r8/lib/r8.jar --no-desugaring --no-data-resources [...] lib.java/clank/third_party/compressed_resources/LemonStandaloneRuntime.jar lib.java/clank/java/build_hooks_android_impl_java.jar ) In ../../base/android/proguard/chromium_apk.flags: Ignoring option: -optimizationpasses In ../../base/android/proguard/chromium_apk.flags: Ignoring option: -optimizations Item java.lang.String org.chromium.chrome.browser.gcore.ConnectedTask.getName() was not discarded. java.lang.String org.chromium.chrome.browser.gcore.ConnectedTask.getName() |- is invoked from: | void org.chromium.chrome.browser.gcore.ConnectedTask.debugLog(java.lang.String) |- is invoked from: | void org.chromium.chrome.browser.gcore.ConnectedTask.run() |- is defined in library method overridden by: | org.chromium.chrome.browser.gcore.ConnectedTask |- is reachable from: | com.google.android.apps.chrome.icing.IcingController$IcingLightweightTask |- is reachable from: | com.google.android.apps.chrome.icing.IcingController$6 |- is instantiated in: | void org.chromium.chrome.browser.gsa.ContextReporter.reportUsageOfCurrentContextIfPossible(org.chromium.chrome.browser.tab.Tab,boolean,org.chromium.chrome.browser.gsa.GSAContextDisplaySelection) |- is invoked from: | void org.chromium.chrome.browser.ChromeActivity.createContextReporterIfNeeded() |- is reachable from: | org.chromium.chrome.browser.ChromeActivity |- is referenced in keep rule: | ../../base/android/proguard/chromium_code.flags:35:1 Original change's description: > Use assumevalues instead of assumenosideffects for proguard. > > This seems to have the same meaning, however use of "return" in assumenosideffects is not working for some versions of proguard. > > Change-Id: Ie6dde7612d25c7ee5fd2d2fd42dfe74444188c41 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804064 > Reviewed-by: Sam Maier <smaier@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Eric Roman <eroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696911} TBR=eroman@chromium.org,agrieve@chromium.org,smaier@chromium.org Change-Id: Ia68d499e59e0b9e1dcda34bfa9389fa1977079b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808018Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#696958}
-
jonross authored
We were trying to have all vulkan_pixel_skia tests not fallback to software with the flag '--disable-software-compositing-fallback'. However several tests wish to explicitly run in that mode. This removes the flag from the test configuration, while looking to add it to tests which actually only want to test hardware compositing. TEST=vulkan_pixel_skia, pixel tests Bug: 984973 Change-Id: I5b54bcde0c10be874ad5fe5cd00168dfd98ba08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795307 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#696957}
-
Yue Li authored
The cl replaces the use of webm video with lottie animation in Assistant opt-in flow. Bug: 1001713 Test: Manual Test Change-Id: I54162809464cdcb16e749dd74ec35122842f5237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804693Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#696956}
-
Alex Moshchuk authored
This CL adds two metrics, logged at ready-to-commit time: - Navigation.RequiresDedicatedProcess: whether or not the final SiteInstance picked for a navigation requires a dedicated process. - Navigation.IsLockedProcess: whether or not the process for a navigation has been locked to an origin. This will be useful to understand how many navigations are impacted by Site Isolation on Android (and other platforms). Bug: 1004371 Change-Id: I24defd60242056f01cc9ca1f68ecbfdec883fc12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807573Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#696955}
-
