GitLab

Breaks Google Chrome Linux x64 compile:
http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20Linux%20x64&number=50183

> [Metrics] Make MetricsStateManager take a callback param to check if UMA is enabled.
> 
> Also, remove a no longer needed testing pref.
> 
> BUG=374296
> TEST=compiles
> R=asvitkine@chromium.org
> 
> Review URL: https://codereview.chromium.org/284293003

TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/296703008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271822 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/292583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271821 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/292653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271820 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367239

Review URL: https://codereview.chromium.org/289373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271819 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374445
NOTRY=true

Review URL: https://codereview.chromium.org/289233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271818 0039d316-1c4b-4281-b951-d872f2087c98

In android_commands.py's GetFilesChanged function,
realpath command fails when the path does not exist.
Create the path before we call GetFilesChanged.

BUG=374859

Review URL: https://codereview.chromium.org/293803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271817 0039d316-1c4b-4281-b951-d872f2087c98

Rather than route this through RemoteWindowTreeHostWin (which can now
be NULL) I'm routing it through ChromeMetroViewerProcessHost. I'm also
adding a NULL check as it may be possible in some code paths for the
host to have been disconnected and therefor NULL.

BUG=374766
TEST=none
R=ananta@chromium.org

Review URL: https://codereview.chromium.org/297713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271816 0039d316-1c4b-4281-b951-d872f2087c98

This is a followup patch to r271682, where I const-ified GetPreferredSize() and GetMinimumSize(), but deferred this because that patch touched 400 files.

BUG=155363
R=sky@chromium.org
TBR=scheib@chromium.org

Review URL: https://codereview.chromium.org/296823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271815 0039d316-1c4b-4281-b951-d872f2087c98

SandboxBPF users are now required to always provide a SandboxBPFPolicy
instead of a SyscallEvaluator. CompatibilityPolicy can't be removed
just yet though because it's still used by the deprecated BPF_TEST
macros.

Review URL: https://codereview.chromium.org/286903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271814 0039d316-1c4b-4281-b951-d872f2087c98

Virtual keyboard starts with a height of 0, which makes us wait for a frame at
that size which will never come.
RWHI will skip the resizes for this, hence will not throttle the next (correct)
size, which will come in but then be discarded.

Make sure not to create a resize lock for empty sizes.

BUG=374196

Review URL: https://codereview.chromium.org/284413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271813 0039d316-1c4b-4281-b951-d872f2087c98

Maximize window vertically or horizontally when the maximize button is middle or right clicked on Linux respectively.

BUG=362546
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/288203005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271812 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367239

Review URL: https://codereview.chromium.org/290413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271811 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/297723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271810 0039d316-1c4b-4281-b951-d872f2087c98

This is a separate change to add the icon for Web MIDI permission.
Following change will use it to show infobar icon.

BUG=339767

Review URL: https://codereview.chromium.org/298753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271809 0039d316-1c4b-4281-b951-d872f2087c98

Original review: https://codereview.chromium.org/267743010/

BUG=364949
Test=MaximizeModeControllerTest.BlockRotationNotifications
TBR=flackr
TBR=sadrul

Review URL: https://codereview.chromium.org/291233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271808 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/288923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271807 0039d316-1c4b-4281-b951-d872f2087c98

Simple bit-flipping won't generate negative offsets (e.g. large
positive offsets that overflow), so we add a test where we specifically
create the possibility of such.

Also simplify argument passing in the cpp -> js direction, since there isn't
a need to build lists here.  We're only interested in the other direction.

Remove some stray "explicit" keywords and reduce the echo
test iterations since it doesn't prove much.

Review URL: https://codereview.chromium.org/292243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271806 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

R=rtenneti@chromium.org,wtc@chromium.org

Review URL: https://codereview.chromium.org/296433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271805 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromedriver:796

Review URL: https://codereview.chromium.org/275193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271803 0039d316-1c4b-4281-b951-d872f2087c98

BUG=230018
TEST=manual

Review URL: https://codereview.chromium.org/270663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271802 0039d316-1c4b-4281-b951-d872f2087c98

R=vmpstr@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/292883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271801 0039d316-1c4b-4281-b951-d872f2087c98

This CL extends the separation Factory/device
initiated in the other CLs part of the bug. Aside
from code cleanup, it allows for better testing
(via dependency injection) of the factory parts
(this is specially important for blacklisted devices,
of which there are none in Win ATM). It can also
be used to modify the GetDeviceNames() method to
an asynchronous API.

Both VideoCaptureDeviceWin and VideoCaptureDeviceMFwin 
(using DirectShow and MediaFoundation APIs resp.),
have a number of static methods Create(),
GetDeviceNames() and GetDeviceSupportedFormats().
Plus, there are overarching versions of those
at the VideoCaptureDevice level, that do library
initialisation and appropriate forwarding to one
or the other implementation. This CL extracts all
of those class-static methods and moves them to
a single VideoCaptureDeviceFactoryWin.

ScopedMediaType, previously file-level data type
moves to the public def of VideoCaptureDeviceWin
since is used in the Factory.

Every file-static function and variable that could,
has been moved to the Factory file. Previous 
file-level static functions that are used in the
Factory and the VCD have been changed to VCD
static methods and used in both ends.

TBR= dalecurtis@chromium.org (media/media.gyp)

BUG=323913

Review URL: https://codereview.chromium.org/276383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271800 0039d316-1c4b-4281-b951-d872f2087c98

Also, remove a no longer needed testing pref.

BUG=374296
TEST=compiles
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/284293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271798 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271797 0039d316-1c4b-4281-b951-d872f2087c98

This picks up a single change (r271557)

BUG=373542, 24502

Review URL: https://codereview.chromium.org/290333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271796 0039d316-1c4b-4281-b951-d872f2087c98

Some fixes to GetUserInfo flow to avoid superfluous GetUserInfo calls.

BUG=

Review URL: https://codereview.chromium.org/294813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271795 0039d316-1c4b-4281-b951-d872f2087c98

Once all pages are force composited by default, this allows these tests
to not explode when trying to create GraphicsLayers because of a lack of
Platform::compositorSupport.

BUG=361729

Review URL: https://codereview.chromium.org/287043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271794 0039d316-1c4b-4281-b951-d872f2087c98

Breaks linux chromiumos asan lsan test EventRewriterTest.TestRewriteFunctionKeys
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29&number=1454

> Add native event testing to chromeos::EventRewriter unit tests.
> 
> R=sadrul@chromium.org
> 
> Review URL: https://codereview.chromium.org/270633012

TBR=kpschoedel@chromium.org

Review URL: https://codereview.chromium.org/297783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271791 0039d316-1c4b-4281-b951-d872f2087c98

Breaks official mac builder. See bug.

> Fix RlzLibTest by setting OmniboxLog.is_popup_open to be true in function SimulateOmniboxUsage. 
> 
> BUG=369249
> 
> Review URL: https://codereview.chromium.org/282293003

TBR=yiyaoliu@chromium.org

Review URL: https://codereview.chromium.org/299703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271790 0039d316-1c4b-4281-b951-d872f2087c98

Breaks androidwebview_instrumentation_tests
org.chromium.android_webview.test.MediaAccessPermissionRequestTest#testGrantAccess

http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Tests%20%28dbg%29&number=20509

> Detaching from the VM after calling MediaStreamManager::SendMessageToNativeLog on Android.
> MediaStreamManager::SendMessageToNativeLog posts a task to the UI thread, which will attach the audio thread to the Android java VM. Unlike chrome created threads, the audio thread is owned by the OS and does not detach itself from the VM on exit, causing a crash.
> Since the log message is still crucial for diagnosing audio input issues, I'm detaching the VM after SendMessageToNativeLog, instead of removing the call on Android.
> 
> BUG=365915
> 
> Review URL: https://codereview.chromium.org/294803003

TBR=jiayl@chromium.org

Review URL: https://codereview.chromium.org/291173006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271788 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375538
TBR=palmer@chromium.org,agl@chromium.org

Review URL: https://codereview.chromium.org/292183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271787 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add OnDisplayMetricsChanged in DisplayObserver. (https://codereview.chromium.org/259253002/)

Reason for revert:
Breaks DesktopScreenX11Test.RemoveMonitorOnRight and AddMonitorToTheRight on Linux Tests

TBR=mlamouri@chromium.org
NOTRY=true
NOTREECHECKS=true

http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=11092

Original issue's description:
> Add OnDisplayMetricsChanged in DisplayObserver.
> 
> This replaces OnDisplayBoundsChanged and add a MetricsType
> parameter so consumers can now which metrics has changed. The
> current set of MetricsType include bounds, workarea and rotation.
> 
> BUG=162827
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271768

Review URL: https://codereview.chromium.org/294963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271782 0039d316-1c4b-4281-b951-d872f2087c98

Clean up unit_tests exclusions for Dr. Memory to reflect bugs fixed. Rotate the browser_test exclusions.

TBR=zhaoqin@chromium.org
BUG=http://code.google.com/p/drmemory/issues/detail?id=548

Review URL: https://codereview.chromium.org/292663006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271776 0039d316-1c4b-4281-b951-d872f2087c98

Update Gamepad API to match the latest specification:
https://dvcs.w3.org/hg/gamepad/raw-file/default/gamepad.html#widl-Gamepad-axes
https://dvcs.w3.org/hg/gamepad/raw-file/default/gamepad.html#widl-GamepadButton-value

Namely, Gamepad.axes / GamepadButton.value should be of type double, not float.

R=bbudge@chromium.org, jam@chromium.org, scottmg@chromium.org
BUG=344556

Review URL: https://codereview.chromium.org/280713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271775 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369249

Review URL: https://codereview.chromium.org/282293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271773 0039d316-1c4b-4281-b951-d872f2087c98

Currently:
- Based on #if, switches renderer rendering to PDF for preview
- Add PdfToEmfConvert based on PWGRasterConverter
- Various plumbing.

Preview works the same as other PDF based platforms. For getting
to EMF, the when PRINTING_WIN_USES_PDF_AS_METAFILE is on, the
renderer generates a PDF instead of EMF directly (this contains
all the pages in the desired range). This is returned to
PrintViewManagerBase, where it's passed to PdfToEmfConverter which
uses the sandboxed utility process and pdf.dll to convert via
RenderPDFPageToDC. The utility process renderers one emf page at
at time (into numbered files) to avoid having a very large emf file.

As this uses pdf.dll this is currently off-by-default controlled by
the gyp variable win_pdf_metafile_for_printing.

R=vitalybuka@chromium.org
BUG=170859

Review URL: https://codereview.chromium.org/255543006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271772 0039d316-1c4b-4281-b951-d872f2087c98

Attempting to move the header from src/trusted/validator into src/public:
https://codereview.chromium.org/261683002/diff/310001/src/trusted/validator/nacl_file_info.h

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3421

Review URL: https://codereview.chromium.org/292213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271771 0039d316-1c4b-4281-b951-d872f2087c98

This interface consolidates the on-demand functionality and it allows for selective friendship for the callers who are allowed to trigger an on-demand update.

BUG=375315

Review URL: https://codereview.chromium.org/292203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271770 0039d316-1c4b-4281-b951-d872f2087c98

Move it to be non-virtual methods on SingleThreadProxy and ThreadProxy.
LayerTreeHost only needs to call it on the SingleThreadProxy, and make
it do that before calling Composite() instead of having Composite()
early out.

Merge LTH::InitializeOutputSurfaceIfNeeded into LTH::Composite.

NOTRY=true
R=enne
BUG=374287

Review URL: https://codereview.chromium.org/286293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271769 0039d316-1c4b-4281-b951-d872f2087c98

This replaces OnDisplayBoundsChanged and add a MetricsType
parameter so consumers can now which metrics has changed. The
current set of MetricsType include bounds, workarea and rotation.

BUG=162827

Review URL: https://codereview.chromium.org/259253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271768 0039d316-1c4b-4281-b951-d872f2087c98