GitLab

Changed NULL to nullptr where the presubmit complained (due to new line wrapping).

Generated by: https://chromium-review.googlesource.com/c/chromium/src/+/1689216

Bug: 981415
Tbr: gab@chromium.org
Change-Id: I1f9c781cd980150ad1eecee9342be2e3116617b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763040Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689209}

ASAN has not yet fully initialized by the time the CIG intercepts
execute. Most of the code works fine but the call to
std::unique_ptr ends up hitting an uninitialized instrumentation
and crashing.

Various options were considered including:

 * Add all of the std::unique_ptr calls used in the interception
   code to the exclusion list.
 * Implement our own smart pointers in the interception.
 * Just use stack allocations and/or dumb pointers in interception.

It seemed, upon reflection, the best use of engineering resources
to just disable CIG on ASAN builds.

BUG=995986

Change-Id: I5078a21c70864d7e14a8196ec05bb217b3251f41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763095Reviewed-by: James Forshaw <forshaw@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689208}

As described.

TEST=Manually,autotest to be added
BUG=b:122555793

Change-Id: Iebeafb130b659c8a573da460987598a8bf8f1326
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763638Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689207}

Bug: 994721
Change-Id: I59513333ac07d472c4ce66f8b54e606e3fd07bcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758035Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689206}

Originally the Printers mock specified to display a button with
"Configure" for configuring discovered printers. This was
changed to display a button with "Set up".

Bug: 993816
Change-Id: I20409dd3661e7ee78d91122eed112d4dae26579c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758838Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689205}

Walter is definitely not the right owner for these anymore.  Looks like
the histograms expired and we weren't aware of it (I caught it by luck,
thanks to the UMA dashboard highlighting the expiration.)

Also removes their expiries, because we do use these histograms to
determine the latency difference between Google Payments server calls
and what Chrome sees in the end, due to added latency getting the calls
to/from mobile devices, etc.

Bug: 975010, 975231, 975638
Change-Id: Id11faa3c73b14758064558a0da0893feed1066aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759390
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689204}

Change-Id: I41d7bd3a3b1225ad0aba49f75e3b0113f7f43ab8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757416
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Julian Watson <juwa@google.com>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689203}

This CL corrects comments for the |request_initiator| parameter in
WillCreateURLLoaderFactory. The current comments say that navigation requests
are not associated with an initiator which is incorrect.

Also, add a check for a null |render_frame_host| to
ProxyingURLLoaderFactory::MaybeProxyRequest to prevent a null pointer dereference
and fix associated crashes.

BUG=996041

Change-Id: I4a468ded6006c19f0a321d685fa40aa7f6ad1331
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761607Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689202}

This reverts commit 66630f37.

Reason for revert: Breaks compile on linux-chromeos-rel.

BUG=996442

Original change's description:
> Removing dead ServiceManager constants
> 
> Since ServiceManager went away, we're clearing up some leftover
> CupsProxyService constants. Trivial change.
> 
> Bug: chromium:945409
> Test: confirmed service behavior unchanged
> Change-Id: I45ffdeb3b0ad1990798a4a4d5115e791a6eefbfe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764430
> Auto-Submit: Luum Habtemariam <luum@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#689164}

TBR=dcheng@chromium.org,rockot@google.com,skau@chromium.org,luum@chromium.org

Change-Id: Ic9914332352bc21a15ce96e14f192eefdbed499e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:945409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764333Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Auto-Submit: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689201}

Enables the ContextualSearchTranslationModel Chrome Feature for
testing.  This feature is currently used to switch from the
custom Contextual Search translation logic and the Chrome
Translation Model.  This might have an impact on testing
or stability.

Also fix a logic error which switching between translation
models -- the disable switch should be considered.

TBR=twellington

BUG=644909

Change-Id: Ia155461999d983d952e1ce4c1c1c422a3cd89da0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763298
Commit-Queue: Donn Denman <donnd@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689200}

The light mode color (#BABABA) dates back well before Material Design (v1), and
doesn't seem to have an updated spec anywhere.  kGoogleGrey300 matches button
borders.  (Dialog borders use a different color that's based on alpha-blending
black, and has a surrounding shadow, so it doesn't seem quite as parallel.)

Using kGoogleGrey800 in dark mode happens to provide the same contrast against
the menu background (1.37) as GG300 does in light mode.

Bug: 995442
Change-Id: If8c668ad58c90f4a82dd1869219330b811894fca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762479
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689199}

It's a very edge case that a percentage may be resolved against a
negative value, which is allowed only in 'background-position' property.

To support this without massively changing existing code, this patch
adds an indicator flag to |CSSMathFunctionValue|, so that when the flag
is set, the resolution of calculated percentage values is delayed to when
a reference value is available. When the flag is not set, we still use
the existing code path where a calculated percentage value can be
resolved immediately.

Together with this patch is a test suite on parsing and evaluation of
comparisons on percentages.

Bug: 825895, 978682
Change-Id: I2a6aabd48313ccda82b50f6dc00fd62c4548bc84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762970
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689198}

NullValue() is represented as a NaN in a double. We could better return
a base::Optional<double> and use the undefined base::Optional as null
value. Also there is no need for the IsNull() call as we could just use
the returned value as a boolean.

Bug: 994811
Change-Id: I236fb8dbf2f0fd6ea879a6996e2a11a143406b09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761272
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Yi Gu <yigu@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689197}

This reverts commit 371290bf.

Reason for revert: Flexbox does not play well with the colors menu

Original change's description:
> [NTP] Position richer picker elements using flexbox
> 
> Position elements with flexbox instead of inline-block. This allows us
> to remove the "font-size: 0" hack that fixed the extra space between
> inline-block elements.
> 
> Change-Id: Ie3b6f02281795e60806259a00b2ee948df3b0959
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725334
> Commit-Queue: Kristi Park <kristipark@chromium.org>
> Reviewed-by: Kyle Milka <kmilka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#688355}

TBR=kristipark@chromium.org,kmilka@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I4a5a2a70e58e2d1d03d15505d9c5be5b866fe959
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763340
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689196}

Bug: 996344
Change-Id: I0d81bb75ee75ae0b9c58bebb555c8c037261ec44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764240
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689195}

The crash key is no longer needed, and it's suspected that the code
for logging it is contributing to further instability. Remove it.

R=aleventhal@chromium.org

Bug: 974444
Change-Id: I38ae47c60258f2a48f383d3b20c35910b81cd296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764122
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689194}

Hide the entire MV container rather than just the iframe. This fixes an
issue with keyboard focus when the tiles are hidden.

Bug: 996156
Change-Id: Ia0e19920b3d06e916851334a1b223161736bf100
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763299Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689193}

This CL re-enables all tests in the suite. browser_tests are flaky, but
all known differences with SkiaRenderer have been fixed.

Please add vasilyt@chromium.org and jonross@chromium.org for new bugs
related to flakes in this suite.

Test: skia_browser_tests
Bug: 982933
Change-Id: I6e5427d427aa22d5a4d38645b58f9b718c3239af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764251Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689192}

This reverts commit eb651697.

Reason for revert: the culprit was another one of my CLs!

Original change's description:
> Revert "[TaskEnvironment] Standardize paradigm for classes forwarding traits"
> 
> This reverts commit 7472b906.
> 
> Reason for revert: sheriff suspects this caused a build break on win{,32}-archive-rel:
> 
> https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/4309
> 
> In file included from ../../chrome/chrome_cleaner/ipc/proto_chrome_prompt_ipc_unittest.cc:14:
> In file included from ../..\base/test/scoped_task_environment.h:15:
> In file included from ../..\base/task/lazy_task_runner.h:17:
> ../..\base/task/task_traits.h(263,5): error: static_assert failed due to requirement 'has_thread_pool ^ has_extension' "Traits must explicitly specify a destination (e.g. ThreadPool or a named thread like BrowserThread)"
>     static_assert(
>     ^
> ../..\chrome/chrome_cleaner/ipc/proto_chrome_prompt_ipc.h(108,39): note: in instantiation of function template specialization 'base::TaskTraits::TaskTraits<base::MayBlock, void>' requested here
>       base::CreateSequencedTaskRunner({base::MayBlock()});
>                                       ^
> 1 error generated.
> 
> Original change's description:
> > [TaskEnvironment] Standardize paradigm for classes forwarding traits
> > 
> > As discussed @
> > https://chromium-review.googlesource.com/c/chromium/src/+/1749538/6/ash/test/ash_test_base.h#84
> > 
> > Usage of explicit everywhere also avoids implicit copy construction
> > and is the reason for changes to a few unit tests that previously
> > used operator= to initialize their task environments.
> > 
> > TBR=dcheng@chromium.org
> > (for widespread mechanical change)
> > 
> > Bug: 992483
> > Change-Id: I321576674f3b387a6f5069e8e71eebf41c98e7ed
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758338
> > Reviewed-by: Gabriel Charette <gab@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Commit-Queue: Gabriel Charette <gab@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#689098}
> 
> TBR=dcheng@chromium.org,gab@chromium.org
> 
> Change-Id: I69b71b220ab583bc3a18e8fb07213fa1b6a75b50
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 992483
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762475
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#689122}

TBR=ellyjones@chromium.org,dcheng@chromium.org,gab@chromium.org

Change-Id: Ibc0ab9c4df6dcbc4a65fd26e0356c78e8b0f90b3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 992483
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764390Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689191}

Bug: 982018
Change-Id: Idb97cf0d324b4addc23a8ced0c75facb4096c126
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757508
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Auto-Submit: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689190}

When the daily refresh toggle was deselected it was applying the
selected state to the wrong element.

Bug: 996147
Change-Id: I76bbb4590701636a56439940f1d69afe359661ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763339Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689189}

https://android.googlesource.com/platform/external/perfetto.git/+log/2891cbc02f12..2d256c406cde

git log 2891cbc02f12..2d256c406cde --date=short --no-merges --format='%ad %ae %s'
2019-08-21 treehugger-gerrit@google.com Merge "[GPU TRACE] Add GPU scheduling trace events"
2019-08-21 primiano@google.com Merge "Remove use of -isystem for googletest"

Created with:
  gclient setdep -r src/third_party/perfetto@2d256c406cde

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I19c290c53bb20801185f414fa8c8026a29108089
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764456Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689188}

Adjusts the icon of the Kerberos tickets based on the mocks in
go/cros-kerberos-ux part IV: The Forgotten Things.
- Adds a toast for ticket refresh
- Removes space for general error in kerberos-add-account-dialog and
  makes the dialog resize when error shows up.

BUG=952232
TEST=Compare Kerberos UI with UX mocks, see go/cros-kerberos-test and
     go/cros-kerberos-ux. Observe in awe that they match.

Change-Id: Ic98a6abdf44aae881dfac1953cf599986f3f0cbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728576
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689187}

Bug: 996098
Change-Id: Ia7486e26c3225ff40a8fb9af36520788db0b58e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763342Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689186}

https://chromium.googlesource.com/angle/angle.git/+log/1d83e1e8a17e..24456989e21b

git log 1d83e1e8a17e..24456989e21b --date=short --no-merges --format='%ad %ae %s'
2019-08-21 lujc@google.com Fix incorrect parameter in gl_angle_ext.xml
2019-08-21 syoussefi@chromium.org Vulkan: Support non-pow2 buffer alignments

Created with:
  gclient setdep -r src/third_party/angle@24456989e21b

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jonahr@chromium.org,jonahr@google.com

Bug: None
Change-Id: Iedab9f61f80cc099be0eb53d6afcd52bd200ea19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764454Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689185}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d60490eeff86..7719c19e556f


Created with:
  gclient setdep -r src-internal@7719c19e556f

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I6ecf830dcdd39567fc86d6ed33005e577c5c95a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764458Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689184}

Bug: 994989
Change-Id: I92f7cf9a1ee321e46cd5d3cf65ea50e0c18b9f4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761334Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Jong Ahn <jongahn@google.com>
Cr-Commit-Position: refs/heads/master@{#689183}

https://skia.googlesource.com/skia.git/+log/aa3cbb81b706..9e081d164c81

git log aa3cbb81b706..9e081d164c81 --date=short --no-merges --format='%ad %ae %s'
2019-08-21 herb@google.com Don't send strike with no pending glyphs
2019-08-21 jlavrova@google.com Bug fixes for Flutter
2019-08-21 brianosman@google.com SkRuntimeShaderMaker -> SkRuntimeShaderFactory
2019-08-21 egdaniel@google.com Move CopyOps to CopyRenderTask.

Created with:
  gclient setdep -r src/third_party/skia@9e081d164c81

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@google.com

Bug: None
Change-Id: Ie046f8dd97d6c03e32b0ac85a9310a2759a67fb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764453Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689182}

The thread ServiceWorkerContextCore lives on (the "core thread") will
move from the IO thread to the UI thread.

This CL makes PaymentAppBrowserTest tests pass when run with
ServiceWorkerOnUI enabled. It is fairly mechanical. One tricky
part is whether the callbacks here need to be called asynchronously.
In some cases we may already be on the thread the callback needs
to run on, the CL still uses PostTask() to run the callback in case
sync callbacks are not ok.

Bug: 824858
Change-Id: I195d4ce93d267d9417a1e671d64b3d6ae4a8acc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763551
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689181}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ad86dfbd3219..722aa0bc8abe

git log ad86dfbd3219..722aa0bc8abe --date=short --no-merges --format='%ad %ae %s'
2019-08-21 tcwang@google.com afdo: Add empty builders to verify and publish kernel profiles.

Created with:
  gclient setdep -r src/third_party/chromite@722aa0bc8abe

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I9ae317959212b22b4b578349e5e36537f2651580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764329Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689180}

This CL adds a call to a Win32k API to check if it is really disabled
by the mitigation.

Change-Id: Ibab06e93db59c326b0df79ea562198e055beb88a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764178Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689179}

The test is leaking. Not sure if it's also failing, so removing the
suppression from 64d6e9f9

Bug: 996235
Change-Id: Ie1e5d11dbc7225e47fff3a6c0e62be5b193bdcd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764492Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689178}

Move the source of truth about GPU compositing status from
ImageTransportFactory to GpuDataManagerImpl, add an accessor, and check
the value in ImageTransportFactory initialization. Update
|gpu_feature_info_| with the status. This is done to reduce reduce gpu
state duplication.

ImageTransportFactory and CompositingModeReporterImpl still contain a
bool for gpu compositing, but they're only privately available, and used
as a cache for the compositing state in GpuDataManagerImpl to make sure
the fallback action isn't performed more than once.

Bug: 819474
Change-Id: I3e28762f34a2ad6c170ca59a72611e65153a6176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708422
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689177}

This will be submit after crbug.com/985705 for
https://ci.chromium.org/p/chromium/builders/webrtc/WebRTC%20Chromium%20Linux%20Tester

Bug: 954875
Change-Id: I486cb6de5604f00cdfb4a3b9079647e8c21be3d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757417
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689176}

It's also failing.

https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/1377

TBR=kyleju@chromium.org

Bug: 856601
Change-Id: Ia58b1682355390080f2faa732dcc5d2570effdb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763260Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689175}

This adds the capability to replace a dialog's ModelList while the
dialog is being displayed. More details can be found in the crbug.

Bug: 993528
Change-Id: I43f8934cd4e138f7a4b99e1ad923b7515dacb46b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758547Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689174}

This change:
1) Removes some stub code that was trying to disable a test
2) Fixes SwitchTabsMac on 10.14+, where SendGlobalKeyEventsAndWait CHECKs

Bug: 852232
Change-Id: I304c12488de83dcf6c361018f359c776a23cf1d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762485
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689173}

This CL makes AppCache for frames use new BrowserInterfaceBrokerProxy mechanism
instead of DocumentInterfaceBroker.

Before this CL, AppCache used DocumentInterfaceBroker for frames, and
BrowserInterfaceBrokerProxy for workers. That complicated the code. After this
CL, both frames and workers use the same BrowserInterfaceBrokerProxy mechanism.

Relevant CL for AppCache for workers: https://crrev.com/c/1746128

Bug: 936482
Change-Id: I6f30ddec6d2055c9e4748c42a41c031f6c220b82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758038
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689172}

This patch fixes logic for snapping layers to physical pixel boundaries,
when pixel canvas is not enabled, by allowing the subpixel offset to be
dynamically computed. Previously, layers could get stuck at 100% DPI
pixel boundaries (making some UI blurry on platforms where fractional
scale factors are used, e.g. Windows), as once an explicit value was
set, the offset would no longer be dynamically computed.

This patch
 - Updates SnapLayerToPixelBoundary to stop View from setting explicit
   subpixel offsets for non-pixel-canvas platforms so that they may be
   auto computed.
 - Updates view_unittest.

Bug: 992730
Change-Id: I8e8c87107f13157e92f125bcfb281226ebc6c422
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761301Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brian Liu Xu <brx@microsoft.com>
Auto-Submit: Brian Liu Xu <brx@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#689171}

Moved the key for this pref and the logic for getting / setting it from
ScriptingPermissionsModifier to ExtensionPrefs. This lays the groundwork
for making it cleaner to set this value on installation if permissions
were withheld on installation.

Bug: 984069
Change-Id: I5580dfbdd57f4e2a3e92dd7b62b02bf04b35fee9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762720Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Tim Judkins <tjudkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689170}