- 27 Jan, 2016 40 commits
-
-
rdevlin.cronin authored
When we override a URL like chrome://bookmarks by an extension, it maps it to the chrome-extension:// url, but should still display the chrome://bookmarks url in the omnibox. crrev.com/5fafa5aa changed the way prefs were read, so it broke this. Fix the breakage, and add a unittest so that it doesn't happen again. BUG=579389 Review URL: https://codereview.chromium.org/1635663002 Cr-Commit-Position: refs/heads/master@{#371824}
-
mseaborn authored
Use the timer interface from base/ instead. This removes a dependency on nacl_time.h from native_client/, which is #included indirectly in utility.h. I tested this manually by adding some logging to print the times, and I checked that they're roughly the same before and after the change when running NaClBrowserTestPnacl.PPAPICore (which tests PNaCl translation). BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832 TEST=see above Review URL: https://codereview.chromium.org/1636303002 Cr-Commit-Position: refs/heads/master@{#371823}
-
wfh authored
BUG=514250 TEST=Make sure Flash still works and you can enable/disable it. Review URL: https://codereview.chromium.org/1633363002 Cr-Commit-Position: refs/heads/master@{#371822}
-
cwallez authored
The _ANGLE version of the ANGLE libraries were loadable_module targets linking against their respective shared_library. It worked in Debug build but in Release builds the --as-needed linker flag removed the dependency. Release Chromium would then be enable to find eglGetProcAddress in libEGL_ANGLE and fail to start the GPU process. This commit replaces the loadable_module scheme by a simple copy of the libEGL and libGLESv2 shared libraries from PRODUCT_DIR/lib to PRODUCT_DIR. The drawback to doing this is that the GYP and GN code diverge (there is no need for the copy in GN). BUG=522967 Review URL: https://codereview.chromium.org/1635243002 Cr-Commit-Position: refs/heads/master@{#371821}
-
lpromero authored
With this CL, calling becomeFirstResponder on a web view proxy makes the potential web view first responder. BUG=556455 R=eugenebut@chromium.org Review URL: https://codereview.chromium.org/1646573002 Cr-Commit-Position: refs/heads/master@{#371820}
-
fs authored
y=20" -> y="20" Review URL: https://codereview.chromium.org/1633093002 Cr-Commit-Position: refs/heads/master@{#371819}
-
shreyasv authored
BUG=579249 Review URL: https://codereview.chromium.org/1625633003 Cr-Commit-Position: refs/heads/master@{#371818}
-
dcheng authored
BUG=none Review URL: https://codereview.chromium.org/1641533003 Cr-Commit-Position: refs/heads/master@{#371817}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/f42fca4027ed..ccfdaa5f2aee $ git log f42fca402..ccfdaa5f2 --date=short --no-merges --format='%ad %ae %s' 2016-01-27 joshualitt Add primitive url handling system to skiaserve 2016-01-27 yujieqin Update DEPS to use new PIEX version from AOSP. 2016-01-27 joshualitt Allow clients to upload skps to skiaserve CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=msarett@google.com Review URL: https://codereview.chromium.org/1645623002 Cr-Commit-Position: refs/heads/master@{#371816}
-
bnc authored
BUG=581035 Review URL: https://codereview.chromium.org/1628353002 Cr-Commit-Position: refs/heads/master@{#371815}
-
cmumford authored
leveldb::Iterator's must be deleted before leveldb::DB. No known crashes for these two functions have been observed. Review URL: https://codereview.chromium.org/1639973002 Cr-Commit-Position: refs/heads/master@{#371814}
-
jochen authored
R=pfeldman@chromium.org BUG=580337 Review URL: https://codereview.chromium.org/1637413003 Cr-Commit-Position: refs/heads/master@{#371813}
-
lhchavez authored
It turns out that we were under-specifying the dependencies in that directory, so if the .mojom files in components/arc/common change, this might trigger a compilation error. BUG=None TEST=ninja -C out/Release -t commands \ obj/chrome/browser/ui/app_list/arc/browser_ui.arc_app_item.o | \ grep mojom_bindings_generator.*arc/common Review URL: https://codereview.chromium.org/1580183002 Cr-Commit-Position: refs/heads/master@{#371812}
-
jochen authored
v8::Global also clears itself on destruction R=pfeldman@chromium.org BUG=580337 Review URL: https://codereview.chromium.org/1636343002 Cr-Commit-Position: refs/heads/master@{#371811}
-
mvanouwerkerk authored
This enables making smarter decisions in StandardNotificationBuilder#build in future. BUG=581336 Review URL: https://codereview.chromium.org/1639163003 Cr-Commit-Position: refs/heads/master@{#371810}
-
riku.voipio authored
chrome fails to start with user namespace sandboxing: [866:866:0120/134742:FATAL:zygote_host_impl_linux.cc(182)] Check failed: process.IsValid(). Failed to launch zygote process With strace.. clone(child_stack=0x7ffd28fd98, flags=CLONE_NEWUSER|CLONE_NEWPID|CLONE_NEWNET|SIGCHLD) = -1 EINVAL (Invalid argument) Which compared to kernel sources[1], shows that stack needs to be 16 bytes aligned. because stack grows downward, this patch assumes PTHREAD_STACK_MIN is dividable by 16 too. [1] http://lxr.free-electrons.com/source/arch/arm64/kernel/process.c#L267 BUG=581018 R=keescook@chromium.org,jln@chromium.org,rsesek@chromium.org,thakis@chromium.org TEST=base_unittests ProcessUtilTest.* and sandbox_linux_unittests NamespaceSandboxTest.* Review URL: https://codereview.chromium.org/1617763002 Cr-Commit-Position: refs/heads/master@{#371809}
-
mstensho authored
Most of our painting-related operations take place after fragmentation, i.e. via PaintLayerPainter::paintFragmentWithPhase(). All such operations can just sit back and relax and not worry about fragmentation, since translation and clipping for a given fragmentainer (column) has already taken place. This is not the case for filters, though. They are set up before fragmentation. Therefore, we need to make the bounding box of the layer visual (convert out of the flow thread coordinate space) on our own. We now do this specifically for filters, or we'd upset other parts of the code, such as clip path. BUG=530074 R=wangxianzhu@chromium.org Review URL: https://codereview.chromium.org/1645583002 Cr-Commit-Position: refs/heads/master@{#371808}
-
jaydasika authored
This CL : * deletes is_hidden * computes if a layer is drawn using the effect tree BUG=575413 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel patch from issue 1588093004 at patchset 250001 (http://crrev.com/1588093004#ps250001) Review URL: https://codereview.chromium.org/1633203002 Cr-Commit-Position: refs/heads/master@{#371807}
-
xlai authored
This is a combined revert of https://codereview.chromium.org/1491653002 and https://codereview.chromium.org/1614173002. One more additional edit is the addition of "testRunner.dumpAsText();" in canvas-toBlob-defaultpng.html and canvas-toBlob-toDataURL-race.js. Reason for this revert is that we found out idle-task performs much better (has less negative impacts on other activities) than threaded implementation on majority of machines. BUG=581574 Review URL: https://codereview.chromium.org/1637163002 Cr-Commit-Position: refs/heads/master@{#371806}
-
georgesak authored
BUG=551995 Review URL: https://codereview.chromium.org/1646513002 Cr-Commit-Position: refs/heads/master@{#371805}
-
bnc authored
Remove status text "OK" from SpdyTestUtil::ConstructSpdyPush() and SpdyTestUtil::ConstructSpdyPushHeaders(), because HTTP/2 bans the use of status text. Update net_unittests. Review URL: https://codereview.chromium.org/1637033002 Cr-Commit-Position: refs/heads/master@{#371804}
-
kolos authored
[Password Manager] Enables processing invisible username fields even if visible password field was found. BUG=554052 Review URL: https://codereview.chromium.org/1645493002 Cr-Commit-Position: refs/heads/master@{#371803}
-
sullivan authored
Review URL: https://codereview.chromium.org/1643523003 Cr-Commit-Position: refs/heads/master@{#371802}
-
tmoniuszko authored
trace_event.h is redundant in header file. It also causes compilation issues when Blink precompiled headers are used on Windows (Bug 495697). BUG= Review URL: https://codereview.chromium.org/1585693002 Cr-Commit-Position: refs/heads/master@{#371801}
-
treib authored
This started out as the Mac counterpart to https://codereview.chromium.org/1614523002/ (removing old supervised user code) but got a bit larger :) BUG=none Review URL: https://codereview.chromium.org/1631283002 Cr-Commit-Position: refs/heads/master@{#371800}
-
yfriedman authored
Rather than having these tests being forced into the flaky bucket, condition their execution on a new restriction. It has the nice side-effect that one bad bot or configuration doesn't cause the test to get disabled and hopefully these will be running *somewhere*. Tested locally that the tests passed, then removed all updates to google play services and they were ignored. BUG=514449 Review URL: https://codereview.chromium.org/1582513003 Cr-Commit-Position: refs/heads/master@{#371799}
-
pkotwicz authored
BUG=None Review URL: https://codereview.chromium.org/1640003002 Cr-Commit-Position: refs/heads/master@{#371798}
-
jbudorick authored
BUG=561837 Review URL: https://codereview.chromium.org/1634043003 Cr-Commit-Position: refs/heads/master@{#371797}
-
tyoshino authored
BUG=none R=yhirano,isherman,mkwst Review URL: https://codereview.chromium.org/1612993003 Cr-Commit-Position: refs/heads/master@{#371796}
-
johnme authored
This was usually already an origin, and is used for security-sensitive purposes such as de-duplicating permission bubble requests (see also https://codereview.chromium.org/1610753002), so renaming it to GetOrigin to be explicit. BUG=577313 Review URL: https://codereview.chromium.org/1637913002 Cr-Commit-Position: refs/heads/master@{#371795}
-
charliea authored
This reverts commit 5897360a. TBR=thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581693 Review URL: https://codereview.chromium.org/1641573003 Cr-Commit-Position: refs/heads/master@{#371794}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/727b7d27afd0..f42fca4027ed $ git log 727b7d27a..f42fca402 --date=short --no-merges --format='%ad %ae %s' 2016-01-27 robertphillips Add gpu implementation of OverdrawXfermode GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1607253002 2016-01-26 caryclark move more geometry to simd CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=msarett@google.com Review URL: https://codereview.chromium.org/1639303002 Cr-Commit-Position: refs/heads/master@{#371793}
-
rego authored
The spec has changed and now all the implicit lines should be considered when we're resolving named grid lines with an unknown name. The relevant part of the spec is (http://dev.w3.org/csswg/css-grid/#line-placement): "If a name is given as a <custom-ident>, only lines with that name are counted. If not enough lines with that name exist, all implicit grid lines are assumed to have that name for the purpose of finding this position." Modified the code to resolve named grid lines in GridResolvedPosition. We need to keep the old behavior of considering "auto" unknown named grid lines for the case of positioned grid items. Updated current tests to the new expected behavior and created a new test checking different cases explicitly. BUG=442954 TEST=fast/css-grid-layout/grid-item-unknown-named-grid-line-resolution.html Review URL: https://codereview.chromium.org/1576993003 Cr-Commit-Position: refs/heads/master@{#371792}
-
robhogan authored
Ensure that ancestors that no longer need to track percentage descendants after the split have them removed from their tracking lists. BUG=568387 Review URL: https://codereview.chromium.org/1551573002 Cr-Commit-Position: refs/heads/master@{#371791}
-
tmoniuszko authored
BUG= Review URL: https://codereview.chromium.org/1646483002 Cr-Commit-Position: refs/heads/master@{#371790}
-
dnicoara authored
Followup to https://codereview.chromium.org/1631073002/ to make sure that the OnMessageReceived returns false for unhandled IPC messages. BUG=558602 Review URL: https://codereview.chromium.org/1640263002 Cr-Commit-Position: refs/heads/master@{#371789}
-
loyso authored
We always create new animations with unique ids. So the removeAnimation(unique_id, target_property) call on adding a new animation is meaningless. This change allows us to forward declare WebCompositorAnimation class for WebLayer interface. BUG=577016 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1637083004 Cr-Commit-Position: refs/heads/master@{#371788}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/89d5fb66..aa81c816 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1643543002 Cr-Commit-Position: refs/heads/master@{#371787}
-
horo authored
This cl will fix the bug reported at https://crbug.com/253465#c26. With this patch, MediaMetadataRetriever can get the metadata of the local video file which is selected with the file input element. BUG=253465 Review URL: https://codereview.chromium.org/1626283002 Cr-Commit-Position: refs/heads/master@{#371786}
-
jkarlin authored
BUG=410201 Review URL: https://codereview.chromium.org/1636613002 Cr-Commit-Position: refs/heads/master@{#371785}
-