GitLab

 Made ShuttingDownWithoutCloseBrowsers a explicit flag.
 Use END_SESSION shutdown type if chrome recieves SIGTERM AND there are tabs that may
 block shutdown.
 Make sure APP_TERMINATING is sent only once.

This fixes SIGABORT crash in two shutdown scenarios:
1) powering off when chrome has beforeunload handler, or
downloads in progress.
2) singout from screen locker when chrome has beforeunload handler or downloads in progress.

 This is simple version of fix to merge to release branch. I'm working on
another CL that will (hopefully) cleanup a bit more.

BUG=chromium-os:20460
TEST=see bug for repro step


Review URL: http://codereview.chromium.org/8262009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106988 0039d316-1c4b-4281-b951-d872f2087c98

This is to help get the compositor free memory when appropritate

BUG=none
TEST=unit tests

R=vangelis@chromium.org


Review URL: http://codereview.chromium.org/8369010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106987 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106986 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yuzo, yurys
Review URL: http://codereview.chromium.org/8387004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106985 0039d316-1c4b-4281-b951-d872f2087c98

base/base.gyp: 
  - exclude test/test_file_util_linux.cc on OpenBSD because of
    missing fdatasync()

base/base.gypi:
  - include linux_util.cc on OpenBSD too
  - exclude some linux specific files from the OpenBSD build
    because the openbsd implementation is different

base/file_util_posix.cc:
  - Use file_util::GetTempDir directly to get the shm dir
    on !linux

base/sys_info_freebsd.cc:
   - return 0 and do a NOTREACHED() in case sysctlbyname() fails

base/sys_info_openbsd.cc:
  - cleanup includes
  - use arraysize() in the sysctl() call
  - implement SysInfo::MaxSharedMemorySize()

build/common.gypi:
  - -Wno-deprecated is C++ only flag so move it to cflags_cc
  - Do not exclude linux specific files, dirs on OpenBSD since
    90% of it is sharable

base/sys_info_linux.cc:
  - DCHECK if the read string is empty
  - Use base::StringToInt64() to convert the string
    to an int64
  - DCHECK if the returned int64 is okay for a size_t
  - call NOTREACHED() and return 0 if fails

BUG=
TEST=runs on linux?


Review URL: http://codereview.chromium.org/8382001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106984 0039d316-1c4b-4281-b951-d872f2087c98

Harden audio output controller making it safe to call Pause() before Play() really started. Not sure if it really fixes the crash, but crash started happening only after Play() was split into several tasks and become much slower (http://codereview.chromium.org/8229013/ change 105311).

Added unit test.

BUG=100650

Review URL: http://codereview.chromium.org/8371013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106983 0039d316-1c4b-4281-b951-d872f2087c98

In order for this to be on for real, the PNaCl toolchain still needs to
available

Since NaCl is still turned off by default on ARM, this code should be a no-op
for all other cases.

This also moves the compilation a step forward for ARM. 
 
There is a bootstrap dependency on memset on ARM - so SYSROOT on the
ChromiumOS chroot is required to gain access to libc.

R=bradnelson,robertm
BUG=http://code.google.com/p/chromium/issues/detail?id=61695
BUG=http://code.google.com/p/chromium/issues/detail?id=38909
BUG=http://code.google.com/p/nativeclient/issues/detail?id=135


Review URL: http://codereview.chromium.org/8364019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106982 0039d316-1c4b-4281-b951-d872f2087c98

Remove temporary hack necessary while webkit change was landing: https://bugs.webkit.org/show_bug.cgi?id=70076
Review URL: http://codereview.chromium.org/8365022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106981 0039d316-1c4b-4281-b951-d872f2087c98

This also fixes a bug in PluginLoaderPosix where if the last N plugins in the
canonical list crash, the callbacks are never run.

BUG=17863
TEST=On Linux, plugins work as before.


Review URL: http://codereview.chromium.org/8372015

TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/8351014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106977 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8004005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106973 0039d316-1c4b-4281-b951-d872f2087c98

Make Cryptographer emit notifications whenever the set of encrypted types changes and also when encryption is complete.  Propagate that up to the ProfileSyncService.

Since retrieving the encrypted types info requires holding a transaction,
that may lead to deadlocks.  This prevents that.

Remove some unnecessary functions and append ForTest to some other ones.

BUG=95619,100698
TEST=

Review URL: http://codereview.chromium.org/8356026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106972 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=git status
TBR=ronghuawu

Review URL: http://codereview.chromium.org/8383015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106970 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101109
TEST=chrome/browser/prefs/incognito_mode_prefs_unittest.cc


Review URL: http://codereview.chromium.org/8373019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106969 0039d316-1c4b-4281-b951-d872f2087c98

We're moving all the extension api implementations out of
browser/extensions into the directory with the code they are
automating.

BUG=101244


Review URL: http://codereview.chromium.org/8372021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106968 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98273

TEST=none
REVIEW=http://codereview.chromium.org/8052016/
Review URL: http://codereview.chromium.org/8052016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8360023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106966 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:21738, chromium-os:20525
TEST=none
Review URL: http://codereview.chromium.org/8271025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106964 0039d316-1c4b-4281-b951-d872f2087c98

missed a cast in XYZZY magic function.  sigh.

TBR= sehr@google.com

BUG= http://code.google.com/p/chromium/issues/detail?id=87490
Review URL: http://codereview.chromium.org/8373024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106963 0039d316-1c4b-4281-b951-d872f2087c98

This also fixes a bug in PluginLoaderPosix where if the last N plugins in the
canonical list crash, the callbacks are never run.

BUG=17863
TEST=On Linux, plugins work as before.


Review URL: http://codereview.chromium.org/8372015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106962 0039d316-1c4b-4281-b951-d872f2087c98

Add a new switch (--show-component-extension-options) that causes
the built-in component extensions to be displayed on
chrome://settings/extensions.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8332006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106960 0039d316-1c4b-4281-b951-d872f2087c98

Handles two cases: Last window close (-> shuts download browser), and 
last incognito window in an incognito profile (-> cancels downloads
on that profile).  

Note that this doesn't cover the macintosh, which goes through different
code (http://crbug.com/88419) and the warning for incognito close is not 
ideal (http://crbug.com/88421).  This CL includes some modularization 
to make resolving those issues easier.

BUG=61257

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105662

Review URL: http://codereview.chromium.org/7466033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106958 0039d316-1c4b-4281-b951-d872f2087c98

omnibox.OmniboxTest.testOmniboxSearchHistory is failing once in a while on Linux 64 bit ubuntu builder. Disabled to investiagte.
Bug=91033
Review URL: http://codereview.chromium.org/8375031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106954 0039d316-1c4b-4281-b951-d872f2087c98

Currently only support run base_unittests

BUG=
TEST=

Review URL: http://codereview.chromium.org/8364020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106953 0039d316-1c4b-4281-b951-d872f2087c98

I also fought a terrible (but educational) fight with Thread Local Store, and its ability to do cleanup (call destructors) at thread exit (notably applicable to Worker Threads). Thta is why there were soooo many test bot runs and tiny checkins. I now have a plan in mind that won't rely on that functionality.  The code seems to work cross-platform, but if I have trouble with Linux, I'll repeatedly leak ThreadData contexts temporarily on that platform.  Given that the code is only enabled under Debug, this is not yet a real problem.

Each CL I write for this code also includes a bunch of cleanup.  In this case, I changed the Write() methods to WriteHTML(), since I didn't want any confusion with JSON writing etc.  I also did a bunch of tiny cleanups which should not have  changed what the code does.

r=rtenneti
Review URL: http://codereview.chromium.org/8313013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106952 0039d316-1c4b-4281-b951-d872f2087c98

Because other binaries, besides chrome.dll need this, or else they will fail
to load on vista or xp, once we remove the manual binding to win7-only apis.

BUG=none
TEST= waterfall is not red

Review URL: http://codereview.chromium.org/8370019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106950 0039d316-1c4b-4281-b951-d872f2087c98

Convert URLFetcher::Delegates to use an interface in content/public/common. Also remove the old URLFetcher delegate callback while I'm touching all of them.BUG=98716,83592
Review URL: http://codereview.chromium.org/8373021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106949 0039d316-1c4b-4281-b951-d872f2087c98

It is caused by using a TabContentsWrapper pointer after it has been freed.

BUG=100680
TEST=BrowserTest.TestFullscreenBubbleMouseLockState should work on
Linux.


Review URL: http://codereview.chromium.org/8369013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106948 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100658
TEST=Try to add an invalid URL in start pages list in chrome://setttings. It should have no effect.


Review URL: http://codereview.chromium.org/8349030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106947 0039d316-1c4b-4281-b951-d872f2087c98

These methods exist for casting a basic id to a more specific (NSObject derived) type.

BUG=86004
TEST=Initialise common NS objects and confirm ObjCCast*<>() casts to the expected result.


Review URL: http://codereview.chromium.org/8356024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106946 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106945 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yuzo, yurys
Review URL: http://codereview.chromium.org/8379010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106944 0039d316-1c4b-4281-b951-d872f2087c98

Support turning on webkit transparency by setting a background image.
- Update RenderWidget::PaintRect to handle background transparency;
- Update BackingStoreSkia::PaintToBackingStore to handle webkit transparency;
- Turn on compositing of RenderWidgetHostViewAura's layer when we set a background with transparency;

BUG=98311
TEST=Verify when applist change (chromium:98308) is in.


Review URL: http://codereview.chromium.org/8369006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106943 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106942 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none.
TEST=DOMView should be visible in Aura.


Review URL: http://codereview.chromium.org/8373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106941 0039d316-1c4b-4281-b951-d872f2087c98

Committing for krasin@chromium.org
Review URL: http://codereview.chromium.org/8379007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106935 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95573
TEST=none

Review URL: http://codereview.chromium.org/8384001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106933 0039d316-1c4b-4281-b951-d872f2087c98

We're moving all the extension api implementations out of
browser/extensions into the directory with the code they are
automating.

BUG=101244


Review URL: http://codereview.chromium.org/8374024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106932 0039d316-1c4b-4281-b951-d872f2087c98

Special case download interrupt reason if we get a CANCELED/ABORTED status.

BUG=101044
TEST=None


Review URL: http://codereview.chromium.org/8369005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8359005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106927 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98345
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8369007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106926 0039d316-1c4b-4281-b951-d872f2087c98