- 01 Oct, 2019 40 commits
-
-
Luca Hunkeler authored
Adds tests for CloseCustomTab, OnClientSettingsChanged and OnOverlayColorsChanged. Also deleted the default implementation of methods in ControllerObserver. Bug: b/141163294 Change-Id: Idc6439ec7a83a09d34eba92fd3ac7521596d0193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831806 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#701503}
-
Kuo Jen Wei authored
Bug: 980812 Test: Test firing single intent, firing consecutive intent, firing intent when non-intent CCA window already opened, see if all scenario conform with UX mock. Change-Id: I4019d836a25ee0013a9bc3dd341dd81ea99c958f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752483 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#701502}
-
Rafał Godlewski authored
Saves credentials in the leaked credentials table when the leak detection confirms that they are leaked, removes them otherwise. It is currently hidden behind a feature. Bug: 1005746 Change-Id: I23277b3cd395a9464e0dd0f4f1e4976b901d2a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826998 Commit-Queue: Rafał Godlewski <rgod@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#701501}
-
Henrik Boström authored
It's flaky, see https://crbug.com/1009964 TBR=xhwang@chromium.org NOTRY=True Bug: 1009964 Change-Id: I81b753a5ceb879e0c9ed3753bfc381d81c60925e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829716Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#701500}
-
Jérôme Lebel authored
Removing _prefChangeRegistrarApplicationContext from PrivateTableViewController. This should have been done in: crrev.com/c/1798709 Bug: 951313 Change-Id: I4288d6f830197e4c8e326e752bc6aac779ead7c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829702 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#701499}
-
Christoph Schwering authored
Stopped casting votes for A-Z, 0-9 because they're not used on the server side. The newly freed voting capacity is spent on voting for special symbols (previously in 6 out of 9 cases, now in 8 out of 9 cases). Bug: 990748 Change-Id: I8d6086310ce73e3ba0e9124be597a5767ff95c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811039 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#701498}
-
Andrei Chulkov authored
This CL adds integration tests for the automatic and manual generation features in the password manager. Bug: 894756 Change-Id: I03f5c88e7eef220658dec05b732063c16fb5a701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826785 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#701497}
-
Tsuyoshi Horo authored
This CL introduces BundledExchangesHandleTracker class to track navigations within a bundled exchanges file. A BundledExchangesHandleTracker is created by BundledExchangesHandle while loading a page in the bundled exchanges file and passed to the next navigation from the page. And MaybeCreateBundledExchangesHandle() creates a new BundledExchangesHandle to load the page if the next page is in the bundled exchanges file. TBR=toyoshim@chromium.org Bug: 995177 Change-Id: Ib4faaa70390d432f74424fd278f53d86d20f28d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800811 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#701496}
-
Henrik Boström authored
This reverts commit 7c390807. Reason for revert: Speculative revert due to failures on ChromeWorkerBrowserTest.SharedWorkerScriptFetchWithThirdPartyBlocking on windows. First one on the Win7 (32) Tests: https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/52766 Original change's description: > [PM] Add SharedWorkerWatcher > > This class observes running shared worker instances, keeps track of > the connection to their client frames and manages the lifetime of > worker nodes in the Performance Manager graph. > > Bug: 993029 > Change-Id: I2e0c7cd9f194a06405293c22fd543a14ff3c6cbc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757283 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701445} TBR=falken@chromium.org,pmonette@chromium.org,siggi@chromium.org Change-Id: I60357d4217f658967920dc456517764b5123c77c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 993029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832266Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#701495}
-
Colin Blundell authored
Bug: 1008813 Change-Id: Id4a9aebe519f5a495d956ab4fcff046402edfbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832803 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#701494}
-
Harald Alvestrand authored
The old test did not check that RTCPeerConnections were garbage collected, due to an inverted condition, so failed to detect that synchronous GC did not work. The new test uses asynchronous garbage collection. Bug: 825576 Change-Id: I4a4b35c3731007153365d8b22e03fb323ea9b55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831807 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#701493}
-
Kazuhiro Inaba authored
The two source, display_util and display_change_observer, needs to agree on the precise values of DSF so that the correct zoom table is picked up. A previous CL crrev.com/c/1815353 did that by consolidating the constants to 1.77778 and 2.66667. The current CL does the reverse: use the rounded-down values 1.77777 and 2.66666. In many places, pixel-to-dip conversion looks to be done by flooring down. 1920 / 1.777..... = 1080 floor(1920 / 1.77778) = 1079 floor(1920 / 1.77777) = 1080 Using a bigger value (1.77778) can cause 1 DIP diff, leading to a strange screen size (like 1079*674) or bigger errors (b/141898654). Bug: b/141325696 Bug: b/141898654 Test: screen.width on the devloper console of Krane returns 1080 (not 1079) Test: chrome settings show multiple choices for display size Change-Id: I8cbe719b13cd5b6ca5f73bb25c0d27465f6a3e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832846Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#701492}
-
Keishi Hattori authored
Support remote objects in WorldSafeV8Reference by skipping the world check when creation context is not available. Since ScriptValue is backed by WorldSafeV8Reference since r701030, remote objects may be assigned to WorldSafeV8References. Bug: 1009159 Change-Id: I1117dffcd9a09279ea6add1d45f56ac69c6dfa25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832844Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#701491}
-
Ricky Liang authored
This CL allows us to soft-apply cropping and scaling on opaque buffer handles. The wrapping frame retains no resource regarding the opaque buffer handles and acts simply as a decorator to expose different visible rectangle and natural size. Any operation involving the opaque buffer handles are relayed to the wrapped frame. Bug: 982201 Change-Id: If51308c92adeb33d60627386545cadfe1f17edcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830243 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#701490}
-
Canon Mukai authored
I added three tests. - empty input - splitting a chunk - check the output really is Uint8Array Bug: 999091 Change-Id: Ifa4374f85d02150ea2059f6190df71f420467151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831958Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Canon Mukai <canonmukai@google.com> Cr-Commit-Position: refs/heads/master@{#701489}
-
Matt Falkenhagen authored
We had a bug where WebURLLoaderImpl was mistakenly constructed without a keep alive handle. Remove the constructor that doesn't accept the handle, to force callers to be aware of it. Bug: 1008494 Change-Id: I2a1706b4f0b556313cb3914a093054f54297f2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832842Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#701488}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/35e16bac7b41..a39aa78ade7b Created with: gclient setdep -r src-internal@a39aa78ade7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I11e76e1c1ac487e8258a29fa911589ea338f5ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833048Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701487}
-
François Beaufort authored
This CL redefines GPUColor as not only a GPUColorDict, but also a sequence of double as specified in https://gpuweb.github.io/gpuweb/#typedefdef-gpucolor Bug: 877147 Change-Id: If375f0663bb93bf66bd14d2e3f5dd6847983db6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826883Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#701486}
-
Finnur Thorarinsson authored
When an onSelectionStateChange comes in, it is not safe to call super while mBitmapDetails is null, because it may in some cases call back into us (like the crash dumps are showing). Bug: 1006823, 656015 Change-Id: Ia487d8e304d940ab7d681b39189c72d30c12ac8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829707 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#701485}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0335627777d66303090e6299b87798577ac40159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833047Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701484}
-
Evan Stade authored
This allows it to be forward declared and is necessary to avoid circular dependencies that arise when browser_non_client_frame_view.h includes tab_strip.h. It is motivated by the linked bug. Some IWYU changes were necessary due to removal of transitive includes. Bug: 998625 Change-Id: Id2c0b82b6fdaf4af686751405a710282ad1d58b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829746 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#701483}
-
Austin Tankiang authored
This code was used to deal with mounting rar files located in the legacy drive file system. Now that DriveFS is default, this is no longer needed. Bug: 1003238 Test: manually mounted/unmounted zip and rar files on DUT Change-Id: I75ab0da2ba26f8f004f1b48ac5bb9f2d2158c6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826752 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#701482}
-
Askar Aitzhan authored
Currently UMA metric called Enterprise.PolicyRefresh and Enterprise.DevicePolicyRefresh record state "Invalidated; Changed" if policy_changed and invalid_ are true, and record state "Invalidated; Unchanged" if policy_changed is false and invalid_ is true. The problem here is in variable called invalid_, it is true whenever there is a unacknowledged invalidation. So every call to OnStoreLoaded will cause a record of "Invalidated" whenever there is a unacknowledged invalidation, even if "Policy Fetch Job" is caused by scheduled job. The case when there is an unacknowledged invalidation cap happen when "Policy Fetch Job" caused by invalidation fails, this invalidation will not be acknowledged so all the intermediate scheduled jobs will be recorded as "Invalidated" which is not true. Bug: 1000974 Change-Id: I613802148295b2db699a16493d08ec14185cb688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787377 Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#701481}
-
Thomas Tangl authored
This was caused by using an unscaled bitmap for the circle in the image manipulations. Bug: 995720 Change-Id: I2a2cc58ee2abea6d90a1fdeee048169d1ec7a967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831759Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#701480}
-
Hiroshi Ichikawa authored
This change involves: - Use net::CookieStoreIOS instead of using WKHTTPCookieStore directly. -[WKHTTPCookieStore getAllCookies] has a bug that it sometimes doesn't call its completion handler immediately (https://openradar.appspot.com/39470983). net::CookieStoreIOS implements a workaround of the bug. Bug: 938123 Change-Id: Ica8f3855d3f7355a3903f56e7744abd9f5edb024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511094 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#701479}
-
Alex Danilo authored
Bug: 1009318 Change-Id: Ib894dd7b3930006211c13e89f26bd5617b4df97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833030Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701478}
-
François Beaufort authored
This CLs adds the lost attribute to GPUDevice. It is used to track fatal errors in WebGPU. See https://gpuweb.github.io/gpuweb/#fatal-errors Bug: 877147 Change-Id: I81fea6cdc300a577825d098f3c040e4969dcb0de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827562Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#701477}
-
Morten Stenshorne authored
Even when there's a forced break deep inside a break-inside:avoid subtree, we should allow the break. https://www.w3.org/TR/css-break-3/#breaking-controls Bug: 829028 Change-Id: I2e098113d3bd73b506cffa22aa87c90e1f7186e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829348 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#701476}
-
Dominik Röttsches authored
Windows DWrite based fallback API may return a fallback font that differs from the regular style, for example Segoe UI Semilight with Georgian character coverage over a version of Segoe UI regular that would not have Georgian coverage. Keep weight, style, slant information to pass to the renderer, update the FontDescription object there to instantiate the font that's closest to the fallback information we have reiceved from DWrite. This applies to Windows 8.0 and below, as otherwise, a different fallback code path is taken. Bug: 1008901 Change-Id: Ib46a3cdbe164b69768780b798200bc5bbb8a5b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829378 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#701475}
-
Tsuyoshi Horo authored
TBR=csharrison@chromium.org Bug: 1009885 Change-Id: Iddfb99a599c5337b650a6766935e79bbb9580f70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833011Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701474}
-
Jeremie Boulic authored
When creating new folders from the directory tree, the new entry was sometimes added in the wrong spot due to the way labels were compared. The folders were then immediately reordered, causing the new folder to lose its renaming state with the corresponding input box. Issue fixed using the util.compareName function. Test: browser_tests --gtest_filter="*FilesApp*dirCreateMultipleFolders" Bug: 1004717 Change-Id: If2bc4d559a7a74811204d198a2aa8579ee3a6889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827110 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#701473}
-
Darren Shen authored
These aren't actually used in rule-based engine. No point sending them. Bug: 1009903 Change-Id: Ic0add4ecba3d4341c2976f6abce8e9c86465d116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833032Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#701472}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/839a023619b5..c912690d22ab git log 839a023619b5..c912690d22ab --date=short --no-merges --format='%ad %ae %s' 2019-10-01 apodtele@gmail.com * src/base/ftstroke.c (ft_stroker_inside): Speed up. 2019-09-30 wl@gnu.org * src/sfnt/sfwoff2 (woff2_open_font): Initialize `woff2.ttc_fonts'. Created with: gclient setdep -r src/third_party/freetype/src@c912690d22ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I27a51d179205fb38034959648f91910990916e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833105Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#701471}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e06f01be719a..deb28ea45d0d git log e06f01be719a..deb28ea45d0d --date=short --no-merges --format='%ad %ae %s' 2019-10-01 jiawei.shao@intel.com D3D12: Implement ASSERT_SUCCESS as macro instead of function 2019-10-01 bryan.bernhart@intel.com D3D12: Use ringbuffer allocator for descriptor heaps. Created with: gclient setdep -r src/third_party/dawn@deb28ea45d0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I6d9e0cd64a2af9db3bf4172a45a331acfe8a4091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832985Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701470}
-
Marc Treib authored
Bug: 1007942 Change-Id: Ibf1dd753fbd6a8922b0c909a8657728eab6af2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831901Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#701469}
-
Piotr Bialecki authored
Bug: 1009129 Change-Id: Iea0ee4259c894db49a76f8f4e1ca9b53f95f69ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829296 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#701468}
-
Hwanseung Lee authored
Use enum class instead of enum for PaintButtonMode enum class is more type safety. Bug: 940736 Change-Id: If4135af54748a1f9383aba3605916a593aaba0cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824052 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#701467}
-
Ricky Liang authored
When we use VideoFrame::WrapVideoFrame to soft-apply a different set of format, visible rectangle, and natural size on a source VideoFrame, we have to make sure the source VideoFrame outlives the wrapping frame in most if not all the scenarios. This CL explicitly retains a reference to the wrapped frame inside the wrapping frame when WrapVideoFrame is called. Along with the change, we can remove several empty destruction callbacks that are only used for retaining a reference to the wrapped frame. Bug: 982201 Change-Id: Id81ad65c500fe4f0b47a60d98819408522314129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830241 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#701466}
-
Benedikt Meurer authored
When hovering an expression within the Sources panel (during debugging), we try to evaluate it's value and show a popover with the result of that. However this is all best effort and might fail for various reasons. If it fails because we guessed the wrong substring (for an expression), we currently display a popover with a SyntaxError or a ReferenceError in that. But this popover is confusing and doesn't serve a purpose. Instead we should just not display anything in this case as well. Bug: chromium:995036 Change-Id: Id70e2212fe0af58078b2a33731688ec1c5507434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831814 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#701465}
-
Fredrik Söderquist authored
While flag-waving may be considered somewhat ugly, it's quicker (no hash lookups) and slightly more flexible (then providing access to the tracking set) if you want check for reentrance earlier (which is what we want to do). Bug: 998526 Change-Id: I91f9df93879e4446bd5908513cd8a4226c657bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831906Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#701464}
-