- 19 Jul, 2018 40 commits
-
-
Chris Hamilton authored
Allow tabs to be discarded more than once. The heuristics have changed so much in in the last 6 months that this additional protection isn't needed. BUG=794622 Change-Id: I094af452b5a7190f229fefbc77f4571ac0601a17 Reviewed-on: https://chromium-review.googlesource.com/1142479 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#576485}
-
Travis Skare authored
Bug: 864302 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: If94e1b5b1cff588da4b83dcee1bdc652889bc05f Reviewed-on: https://chromium-review.googlesource.com/1141119 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#576484}
-
Justin Cohen authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I60c506d9c15bce437c32c844162ec5df243bb501 Reviewed-on: https://chromium-review.googlesource.com/1142957 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#576483}
-
Samuel Huang authored
This CL is similar to: https://chromium-review.googlesource.com/1133688 BufferRegion::FitsIn() (and BufferViewBase::covers()) decides whether a BufferRegion fits inside a buffer. A special case is whether an empty region fits at the end of a buffer? Previously this was considered to be a pathological case, so the result is "false". However, this led to a DCHECK failure found by the DEX fuzzer: a CodeItem with insns_size = 0 is checked against an empty buffer. It may seem straightforward to change the DCHECK to a handled failure. However, the failing code (in CodeItemParser::GetCodeItemInsns()) occurs after CodeItem have been supposedly validated, so the DCHECK is correctly placed! Two causes are: (1) Technically insns_size should be > 0, as dictated by constraint A1 ("The insns array mus tnot be empty") in Dalvik spec. (2) The FitsIn() check is too stringent. This CL focuses on relaxing (2). This makes checking slightly more permissive elsewhere in code (patch_reader.cc and Win32 disassembler), but this looks like the right thing to do. As for (1), we plan to visit https://source.android.com/devices/tech/dalvik/constraints and implement more rigorous checks. So we simply add a TODO for now. Bug: 863478 Change-Id: Iacbb2bb9bf26701db960192c7b727351ea5afdec Reviewed-on: https://chromium-review.googlesource.com/1142517Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#576482}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3cfe9e51. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21550 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: Iff1eed3e65d8617ecc6f96b72b0d719768426321 Reviewed-on: https://chromium-review.googlesource.com/1143133 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#576481}
-
Justin Cohen authored
Adds two fixes for Xcode 10 / iOS 12. Bug: 843236 Change-Id: If619d0899e65fd86cf98a980dd0e6b741a4f5d90 Reviewed-on: https://chromium-review.googlesource.com/1142601Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576480}
-
Leonard Grey authored
Also fixes assumption in AXPlatformNodeCocoa that all children are also AXPlatformNodeCocoa Bug: 861756, 833638 Change-Id: I3fbf05858b00f8a8ee06d8c5d0af988252ca26a8 Reviewed-on: https://chromium-review.googlesource.com/1138793 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576479}
-
chrome://conflictsChris Hamilton authored
This makes it so that all the information needed to diagnose whitelist issues is available in one place. BUG=847544 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Idef99fa83d84ff1d7258c65f9ca4f481267758f8 Reviewed-on: https://chromium-review.googlesource.com/1142515 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#576478}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c3318d5f367c..2ec2b508e610 git log c3318d5f367c..2ec2b508e610 --date=short --no-merges --format='%ad %ae %s' 2018-07-19 nednguyen@google.com Update screenshot taking method on Linux to use gnome-screenshot Created with: gclient setdep -r src/third_party/catapult@2ec2b508e610 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:862996 TBR=sullivan@chromium.org Change-Id: I009a3ce12d60d85f97ae4070ebd93c8c8a73594f Reviewed-on: https://chromium-review.googlesource.com/1143031Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576477}
-
stkhapugin@chromium.org authored
Moves the logic to retrieve the image for the topmost suggestion in the omnibox from omnibox_popup_view_ios to the left image consumer. Bug: 865000 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1b839bb546d5aa652e7db87c91fe88fcbc2b594e Reviewed-on: https://chromium-review.googlesource.com/1143184Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576476}
-
Koji Ishii authored
Following bot results are included. dummy 0 lines were removed and 0 lines were deflaked by consecutive results since 0. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I681f0fa76c214b616b904a9d55d29b34a71e1f56 Reviewed-on: https://chromium-review.googlesource.com/1142053 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576475}
-
cathiechen authored
Like the legacy layout, make single li as list-style-position: inside. We consider li is with ul/ol by default. If not, use not_in_list_changed_ to indict that we should UpdateMarker(). Bug: 725277 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I5a245fd12c204f5dd4d68c6ce7aacd4582cedb78 Reviewed-on: https://chromium-review.googlesource.com/1141745 Commit-Queue: cathie chen <cathiechen@tencent.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576474}
-
Alex Clarke authored
Bug: 863341 Change-Id: I591ec517b11e206e5249578d0ca5583790ef0be4 Reviewed-on: https://chromium-review.googlesource.com/1143390Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#576473}
-
Wang Hui authored
BUG=None Change-Id: I1eae52d89a5023ca853ffd3de1f884e174bdd0da Reviewed-on: https://chromium-review.googlesource.com/1143173Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#576472}
-
Calder Kitagawa authored
Rearrange the WebAPK resources such that a higher density app_icon_<density>.png can be used as the splash_icon.xml and add app_icon.xml to not break anything as a result of moving and renaming the app_icon.png files. Also adds a splashId to the AndroidManifest.xml for use in Chrome such that the WebAPK can update the splash screen image rather than using the primaryIcon for the splash screen. Modifies Chrome code to support decoding XML aliases to images. TBR=dominickn@chromium.org Bug: 819755 Change-Id: Id42c2e898a5996dfba46ad6608cc1d3103300521 Reviewed-on: https://chromium-review.googlesource.com/1128256 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576471}
-
Ian Clelland authored
external/wpt/workers/modules/dedicated-worker-import-blob-url.any.worker.html has been semi-consistently timing out on WebKit Linux Trusy bot. Bug: 865432 Tbr: dullweber@chromium.org Change-Id: Ie5c494138c9226cb37d690f0aa526227c652381d Reviewed-on: https://chromium-review.googlesource.com/1143136Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#576470}
-
Thomas Tangl authored
- strings for the spell check hint are added - the autocomplete-searches description is updated Bug: 855945, 864793 Change-Id: I33b520fbef30122e6add794d71d8f48053fc253c Reviewed-on: https://chromium-review.googlesource.com/1143304Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#576469}
-
Mathieu Perreault authored
Bug: 788432 Change-Id: I0c6b058149896f693caeb0420dd3475aa5486e08 Reviewed-on: https://chromium-review.googlesource.com/1141925 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#576468}
-
Elly Fong-Jones authored
This change adds a high-contrast theme supplier (IncreasedContrastThemeSupplier) and enables it on Mac when the system "Increase Contrast" setting is enabled, or when --force-high-contrast is passed at startup. This theme maximizes contrast between UI elements. Bug: 831769 Change-Id: I6cbb1b67fd95372dd65501feab6639942f767019 Reviewed-on: https://chromium-review.googlesource.com/1142030Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#576467}
-
Maja Kabus authored
Existing implementation of setHref() changed, older version is abandoned. Added new function href() to accept URLString as an argument. Bug: 739170 Change-Id: Id57e361574c50b13df1876fe83e8693429b66fc8 Reviewed-on: https://chromium-review.googlesource.com/1136635 Commit-Queue: Maja Kabus <kabusm@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#576466}
-
Maja Kabus authored
Modified data and codeBase attributes definition in *.idl file. Bug: 739170 Change-Id: Ia332493450d0e780e4e6eb332708216da02060d1 Reviewed-on: https://chromium-review.googlesource.com/1137824 Commit-Queue: Maja Kabus <kabusm@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#576465}
-
Michael Hablich authored
This is a roll-back to V8 6.9.427. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org NOTRY=true Change-Id: I4d7f1c1a1408f37cfcab66001ceba90851183cb3 Reviewed-on: https://chromium-review.googlesource.com/1143278 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#576464}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ed4c83aac3f1..e34766b47b67 git log ed4c83aac3f1..e34766b47b67 --date=short --no-merges --format='%ad %ae %s' 2018-07-19 hidehiko@chromium.org Add four more boards to pre-cq. 2018-07-19 xixuan@chromium.org SkylabSuite: Separate create and wait for buildbot silency check. Created with: gclient setdep -r src/third_party/chromite@e34766b47b67 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5759c93332ddaec1c7cd63f5f72c3ff043282a11 Reviewed-on: https://chromium-review.googlesource.com/1143028Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576463}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1b013420703b..c6f7ba31d255 git log 1b013420703b..c6f7ba31d255 --date=short --no-merges --format='%ad %ae %s' 2018-07-19 hjd@google.com Merge "perfetto-ui: Increase correctness of build" 2018-07-18 hjd@google.com perfetto-ui: Increase correctness of build Created with: gclient setdep -r src/third_party/perfetto@c6f7ba31d255 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iac780d43d91857fa9265da29b695e1f075ecc7bf Reviewed-on: https://chromium-review.googlesource.com/1143030 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576462}
-
Rayan Kanso authored
Collect errors per registration on initialization, and clear the corrupt data if applicable. Change-Id: I4f8da3c389e70a6d041c72a0e08c3ae1b5a85051 Reviewed-on: https://chromium-review.googlesource.com/1141881 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#576461}
-
Thomas Tangl authored
When sync is paused, i.e. the user has an auth error, the sync section on the syncSetup page will be hidden. Bug: 864754 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic72c9c02f0479feff27b73199a80702bfa7a5514 Reviewed-on: https://chromium-review.googlesource.com/1141577Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#576460}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b423247bc239..0b0043392bfd git log b423247bc239..0b0043392bfd --date=short --no-merges --format='%ad %ae %s' 2018-07-19 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-07-19 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 38971fd13599..6a5d98c4b528 (5 commits) 2018-07-19 rmistry@google.com Revert "Update markdown files" Created with: gclient setdep -r src/third_party/skia@0b0043392bfd The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I05d7b8ad5c954d7be817c5827eca418b90aaffdb Reviewed-on: https://chromium-review.googlesource.com/1143027Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576459}
-
Mark Cogan authored
This CL special-cases NTP URLs (chrome://newtab) in the tab grid mediator to set no title or favicon in the grid items sent to the consumer; this means that the corresponding cells in the tab grid will have no titles or favicons. In order to cleanly support cells having no icons, the icon image view background is set to be clear when there is no image. Bug: 865074 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I13eeeb3c494f7c5f300f2b179da4887dfeb9cdca Reviewed-on: https://chromium-review.googlesource.com/1143262Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#576458}
-
Henrique Grandinetti authored
Bug: 850589 Change-Id: Ic7fbe53143ac5ffb940822a0af76e89f5060e084 Reviewed-on: https://chromium-review.googlesource.com/1142207Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Cr-Commit-Position: refs/heads/master@{#576457}
-
Christian Dullweber authored
Disable failing tests on Linux: virtual/outofblink-cors-ns/http/tests/fetch/chromium/call-extra-crash-tee.html virtual/outofblink-cors-ns/http/tests/fetch/chromium/release-handle-crash.html https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/8969 Tbr: yhirano@chromium.org Bug: 862184 Change-Id: Ib65bb4bb3b3b2d4cd58f8ffb10e2f49b5772e632 Reviewed-on: https://chromium-review.googlesource.com/1143273Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#576456}
-
chrome://flagsUlan Degenbaev authored
- Adds chrome://flags entry - Adds a FeatureFlag - Make existing Blink flag dependent on the Chrome flag Bug: 808143 Change-Id: Ib48328a63cda8007cf863741cae92957757538e2 Reviewed-on: https://chromium-review.googlesource.com/1140328 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#576455}
-
Christian Dullweber authored
This reverts commit 93488940. Reason for revert: PictureInPictureWindowControllerBrowserTest.UpdateVideoSrcKeepsPictureInPictureWindowOpened is very flaky: https://crbug.com/865410 Original change's description: > [Picture-in-Picture] Update window playback when video src changes. > > This CL make sure the Picture-in-Picture window playback state is > reflected when video src changes. It is a follow-up to > https://chromium-review.googlesource.com/1089331 > > Bug: 726619 > Change-Id: Ic756c03aa023d3e4e229c7495686ea8f322503e3 > Reviewed-on: https://chromium-review.googlesource.com/1133168 > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576428} TBR=dalecurtis@chromium.org,wolenetz@chromium.org,beaufort.francois@gmail.com,mlamouri@chromium.org,jochen@chromium.org Change-Id: I2b35b9ef8c119915b1c07f9f12321439c3242ab2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 726619, 865410 Reviewed-on: https://chromium-review.googlesource.com/1143324Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#576454}
-
Mythri Alle authored
Storing the generated code for javascript resources in a separate cache gives more flexibility in the implementation of the code cache.More details in the design doc [1] This cl just adds the GeneratedCodeCache class but does not use it yet. There will be follow up cls to actually use the cache. [1] https://docs.google.com/document/d/1O_PVZPn37Ev3_DWJjQLX-gid__OKxnXP1UsE8g_YkRY/edit?usp=sharing Bug: chromium:812168 Change-Id: I04b709d8e443217f8235859731e75fdf94c62971 Reviewed-on: https://chromium-review.googlesource.com/1107703 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#576453}
-
Orsi Batiz authored
Attribute src of HTMLIFrameElement changed from USVString to URLString Attribute src of HTMLTrackElement changed from USVString to URLString Attribute src of HTMLInputElement changed from USVString to URLString Attribute src of HTMLFrameElement changed from USVString to URLString Tests created for assignment to src Bug: 739170 Change-Id: I52254462ab7325264420aac989f08a30adfe4933 Reviewed-on: https://chromium-review.googlesource.com/1139062 Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#576452}
-
Ned Nguyen authored
This CL also add extra validation to perf_json_config_validator script (run on PRESUBMIT) to prevent this bug from happening again Bug:865181 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ie68f426d3e5f073c5239ef05e14b67ac89b6911b NOTRY=true # webkit_layout_tests flaky Change-Id: Ie68f426d3e5f073c5239ef05e14b67ac89b6911b Reviewed-on: https://chromium-review.googlesource.com/1142950 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#576451}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6a5d98c4b528..da92a476b50a git log 6a5d98c4b528..da92a476b50a --date=short --no-merges --format='%ad %ae %s' 2018-07-19 jiawei.shao@intel.com Clean up VaryingPacking Created with: gclient setdep -r src/third_party/angle@da92a476b50a The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I4313ba5fe706e374e0b75686d1929b60348831a3 Reviewed-on: https://chromium-review.googlesource.com/1143029Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576450}
-
Christian Dullweber authored
Fix spelling mistake. The constant is called FILTERABLE_DATA_TYPES and not FILTERABLE_DATATYPES. Tbr: jochen@chromium.org Change-Id: Id01c1081169aadc7544d1bd2beaf5050bdb26cf1 Reviewed-on: https://chromium-review.googlesource.com/1142782Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#576449}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I91b1172aaa09d35ae2e2500c374bec1ade9dccea Reviewed-on: https://chromium-review.googlesource.com/1143130 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576448}
-
tzik authored
This CL updates all remaining user of base::Timer to use its subclasses, and renames base::Timer to base::TimerBase to ensure there's no user anymore. Bug: 850247 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I73d70cbbe338e17f5d7de34acd1c961ce05c4305 Reviewed-on: https://chromium-review.googlesource.com/1124200 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#576447}
-
Christian Dullweber authored
This reverts commit 016ff4b3. Reason for revert: LoginCursorTest.CursorHidden is still failing: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/6897 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28314 Original change's description: > Reland "Enable powerwash shortcut in views-based login screen." > > This reverts commit 14fd238a. > Removes the chrome.send('showAddUser') in md_login.js to avoid a race > between the powerwash dialog and the Gaia signin screen. > > Bug: 837501 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I7ab656ebe522cbd164073b73b3dd927cca7b1f13 > Reviewed-on: https://chromium-review.googlesource.com/1129384 > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576306} TBR=derat@chromium.org,dcheng@chromium.org,jdufault@chromium.org,qnnguyen@chromium.org Change-Id: I7044802f815396b7c918f1153342d531122d8852 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 837501 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1143206Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#576446}
-