GitLab

Record the total visible content area and the approximated visible content
area. Approximated area is the visible area covered by low-res or missing tiles.
These statistics will be used in a follow-up patch to report the percentage of
pixels that were approximated in smoothness benchmark.

R=vmpstr@chromium.org,enne@chromium.org,
BUG=308652

Review URL: https://codereview.chromium.org/258093005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267088 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/252893006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267087 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
Test=None

R=brettw@chromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/259823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267086 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368255

Review URL: https://codereview.chromium.org/259183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366315
TEST=ash_unittest's and visual tests

Review URL: https://codereview.chromium.org/255063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267084 0039d316-1c4b-4281-b951-d872f2087c98

function doesn't require divergent return value semantics depending on subclass.

BUG=365732
R=rockot@chromium.org
TBR=pkasting@chromium.org,dtseng@chromium.org

Review URL: https://codereview.chromium.org/252653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267083 0039d316-1c4b-4281-b951-d872f2087c98

Implementation is not complete yet, but enabling to shake out bugs.

BUG=354841

Review URL: https://codereview.chromium.org/255143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267082 0039d316-1c4b-4281-b951-d872f2087c98

The user has to grant permission to specific files via a file picker,
which is considered permission enough.

BUG=363399

Review URL: https://codereview.chromium.org/253433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267081 0039d316-1c4b-4281-b951-d872f2087c98

See mock at slides 29-34 of
https://docs.google.com/a/google.com/presentation/d/1UMAexroivw01osOXpnEqbQcE3FMyDkc9eZoIszm4DP4/edit#slide=id.g12716c613_09

Snapshot at
https://x20web.corp.google.com/users/gu/guohui/www/question_mark.png
https://x20web.corp.google.com/users/gu/guohui/www/feedback_tutorial.png
https://x20web.corp.google.com/users/gu/guohui/www/disable_mirror_view.png

BUG=358265

Review URL: https://codereview.chromium.org/255203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267080 0039d316-1c4b-4281-b951-d872f2087c98

2. Introduce a template class GuestView<T> to handle the    *guestview-specific functions in guestview.h:
   . Rename GuestView to GuestViewBase, introduce GuestView<T> class, and move *ViewGuest-specific functions to     GuestView<T>:
        -- FromWebContents<T>(...)
        -- From<T>(...).
   . Introduce a template member function As() in      GuestViewBase to replace all of the As*View functions.

3. In each derived *ViewGuest class , e.g., WebViewGuest &    AdViewGuest, define a static variable to show its view type    (string).


BUG=351824

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266297

Review URL: https://codereview.chromium.org/237533008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267079 0039d316-1c4b-4281-b951-d872f2087c98

This patch modifies judgment condition whether is equal to zero for double type, avoid unnecessary sqrt calls in more case.
If "a" and "b" are both equal to zero, and "c" is less then zero, currently ScaleOnAxis will return "c" which is negative. So, we should ensure that the result is greater than zero.

BUG=none.

Review URL: https://codereview.chromium.org/253083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267078 0039d316-1c4b-4281-b951-d872f2087c98

chrome.test.fail cannot be used as ErrorCallback because it throws exception when the number of arguments doesn't match.
This wrong use of chrome.test.fail makes the error output useless when something goes wrong.

BUG=None
TEST=browser_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266271

Review URL: https://codereview.chromium.org/258523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267077 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267076 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=172819:172885&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/260523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267075 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117261

Review URL: https://codereview.chromium.org/257983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267073 0039d316-1c4b-4281-b951-d872f2087c98

It is true that kModeDraw will be called with UI blocked. But it is
possible for kModeProcess to be called asynchronously. We don't access
the state object in kModeProcess, but better be safe than sorry.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/260213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267072 0039d316-1c4b-4281-b951-d872f2087c98

Changes to ContentViewRenderView that will enable to us to extend
functionality.

BUG=353293

Review URL: https://codereview.chromium.org/201583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267071 0039d316-1c4b-4281-b951-d872f2087c98

BUG=356226

Review URL: https://codereview.chromium.org/254673010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267070 0039d316-1c4b-4281-b951-d872f2087c98

This CL,
- Adds a new EmbeddedSearchPageVerion variant to enable EmbeddedSearch API in Android Chrome search results page.
- Adds an experiment flag to enable "EmbeddedSearch API" for Android Chrome.
- Creates SearchTabHelper for TabAndroid WebContents.
- Uses EmbeddedSearch API to submit search queries if the underlying search results page supports Instant.
- Assigns Instant search URL renderers to a priviledged Instant process.
- Uses "chrome-search://" scheme for Instant search URLs.
- Creates new test to verify the embedded search page version.

To test: Enable EmbeddedSearch API flag from about://flags page and run Android Chrome against demo server URL (cl/64511863).
Server side bug: b/10402468

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/215733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267069 0039d316-1c4b-4281-b951-d872f2087c98

Consolidate all uses into main helper class.

Details about new api: https://developers.google.com/+/api/latest/people/get

Format of returned response: https://developers.google.com/+/api/latest/people#resource

BUG=320354

Review URL: https://codereview.chromium.org/257773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267068 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366312

Review URL: https://codereview.chromium.org/255393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267067 0039d316-1c4b-4281-b951-d872f2087c98

BUG=b/14249697
R=mef@chromium.org,byungchul@chromium.org

Review URL: https://codereview.chromium.org/251213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267066 0039d316-1c4b-4281-b951-d872f2087c98

Several tests are using AuraTestHelper and were relying on it to set up the DefaultActivationClient, so I had to have them instantiate the DAC directly after calling SetUp() on the helper. I also had to make the DAC delete itself after the root window it's bound to is destroyed.

R=sky@chromium.org
http://crbug.com/308710

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266616

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266975

Review URL: https://codereview.chromium.org/250113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267065 0039d316-1c4b-4281-b951-d872f2087c98

> Build remoting for PNaCl
> 
> BUG=276739
> R=jamiewalch@chromium.org
> 
> Review URL: https://codereview.chromium.org/234023003

TBR=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/254243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267064 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354217

Review URL: https://codereview.chromium.org/256623008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267057 0039d316-1c4b-4281-b951-d872f2087c98

Previously on Windows, WebInputEvents generated from ui::Events would call
|GetMessageTime()| to initialize the WebInputEvent timestamp. There are no
guarantees that such a call is valid at that time.  Instead, use the MSG.time
timestamp generated when the ui::Event was first created from the HWND message.

BUG=367156

Review URL: https://codereview.chromium.org/252083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267056 0039d316-1c4b-4281-b951-d872f2087c98

The new spec for the keyboard shift-light is a square in the upper left corner. Changing this to be consistent with the IME keyboard.


BUG=364468

Review URL: https://codereview.chromium.org/251593011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267055 0039d316-1c4b-4281-b951-d872f2087c98

* Also add explicit destructors (to decrease code size due to inlining)

BUG=365101.

Review URL: https://codereview.chromium.org/255943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267054 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267053 0039d316-1c4b-4281-b951-d872f2087c98

Adding a test for the problem
Fixing the problem
Adding a minimum checkin interval

BUG=359254

Review URL: https://codereview.chromium.org/252933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267049 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361318
TEST=Add VP9 to unittests.

Review URL: https://codereview.chromium.org/252513005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267047 0039d316-1c4b-4281-b951-d872f2087c98

Move all the production code of bookmarks to the components folder as
they form a cyclic graph and moving them separately would be more work
for little gain.

BUG=359565, 360637, 360640, 360643, 364881
TBR=willchan

Review URL: https://codereview.chromium.org/253753005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267046 0039d316-1c4b-4281-b951-d872f2087c98

Previously MediaStreamManager is not notified when a video capturing device has stopped due to error (e.g. the shared window is closed), so the notification UI is still shown when the stream already stopped.
This change fixes it by populating the state to MediaStreamManager through VideoCaptureHost --> VidoeCaptureManager --> MediaStreamProviderListner.

BUG=360181

Review URL: https://codereview.chromium.org/248113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267045 0039d316-1c4b-4281-b951-d872f2087c98

Avoid reporting that 60 minutes remain when the time
interval is just under an hour boundary.

BUG=368261

Review URL: https://codereview.chromium.org/258303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267044 0039d316-1c4b-4281-b951-d872f2087c98

after the idle state has changed.

BUG=366580
R=courage@chromium.org

Review URL: https://codereview.chromium.org/251173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267043 0039d316-1c4b-4281-b951-d872f2087c98

This patch ensures that iterators cannot be copied..
Since we rely on a member heap that points to another member vector,
we can't do a naive copy. Instead we would have to reconstruct the
heap to point to the new members, but it's better to just restrict
copy altogether.

R=enne

Review URL: https://codereview.chromium.org/251003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267042 0039d316-1c4b-4281-b951-d872f2087c98

This patch makes it possible to compile Android's chrome_shell_apk target
whilst setting notifications=1 in the GYP_DEFINES. It also adds a stubbed
version of the NotificationUIManagerAndroid, which will be responsible
for displaying notifcations (through the Android framework).

Chrome for Android will not be using the new Message Center, because
displaying notifications will be done by the platform directly.

BUG=90795

Review URL: https://codereview.chromium.org/247943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267041 0039d316-1c4b-4281-b951-d872f2087c98

to diagnose failures.

BUG=362847

Review URL: https://codereview.chromium.org/239703014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267040 0039d316-1c4b-4281-b951-d872f2087c98

This ports the gyp's changes from r258918 (
https://codereview.chromium.org/205963004/)

To test:

$ gn gen out/Release_gn --args='is_debug=false is_clang=true'
$ ninja -C out/Release_gn sdch

BUG=367597,324299
TEST=see above
R=brettw@chromium.org
TBR=brettw

Review URL: https://codereview.chromium.org/253493007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267039 0039d316-1c4b-4281-b951-d872f2087c98

It's failing intermittently, causing jobs to fail the Chromium commit queue.

Tested locally with 'python tools/perf/run_tests --browser=release'.

BUG=368386
R=ernstm@chromium.org

Review URL: https://codereview.chromium.org/264433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267035 0039d316-1c4b-4281-b951-d872f2087c98