GitLab

This CL changes the constructor of blink::WebFetchClientSettingsObject
to set blink::WebFetchClientSettingsObject::outgoing_referrer to a null
string when given outgoing_referrer argument is a non-null empty string.
outgoing_referrer is not allowed to take a non-null empty string (i.e. String("")).
However, null string are converted into non-null empty string when
outgoing_referrer is passed via mojo which takes url.mojom.Url.
To keep prohibiting blink::WebFetchClientSettingsObject::outgoing_referrer
to be non-null empty string, this CL converts empty strings back
to null string at constructors.

Bug: 1047612
Change-Id: Iac8ea9ca4e752454f524e6ee28a9dce932ca572c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033004
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738070}

BUG=1038487

Change-Id: I067e0e6be20415b17cba391c1bef4c4175a58c07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035639Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738069}

https://chromium.googlesource.com/chromium/deps/icu.git/+log/dbd3825..9f4020916


Bug: chromium:1044570
Change-Id: If3612265bae968fdb64cbd5eeb3ec9d2e0ce3c4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036515
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738068}

https://chromium.googlesource.com/codecs/libgav1.git/+log/16e312f50668..25dc90ee0776

$ git log 16e312f50..25dc90ee0 --date=short --no-merges --format='%ad %ae %s'
2020-02-01 wtc Rename AppleCVPixelBufferPool.
2020-01-31 wtc Add apple_gav1_decode_8bit, use CVPixelBufferPool.
2020-01-31 linfengz extended kCoeffBasePositionContextOffset[] size
2020-01-31 johannkoenig arm: use store from common_neon.h
2020-01-31 johannkoenig arm: add helper versions of Load{2,4}()
2020-01-30 jzern weight_mask_sse4: use LoadAligned16()
2020-01-30 jzern mask_blend_sse4: use LoadAligned16()
2020-01-30 jzern distance_weighted_blend_sse4: use LoadAligned16()
2020-01-30 jzern average_blend_sse4: use LoadAligned16()
2020-01-30 jzern common_sse4: add LoadAligned16()
(...)
2019-11-13 jzern film_grain_neon.h: rm FilmGrainSynthesis defines
2019-11-13 chengchen Reduce memory usage for super res.
2019-11-11 petersonab Use memcpy for ConstructNoiseStripes functions
2019-11-11 wtc Allocate all noise stripes in one heap allocation.
2019-11-11 wtc Make ParseMetadata() work for ITU-T T.35 and HDR metadata.
2019-11-11 johannkoenig arm: use an array for cdef intermediate value
2019-11-11 wtc Add CountTrailingZeros(uint32_t n).
2019-11-11 petersonab Refactor ConstructNoiseImage and move to DSP table
2019-11-11 linfengz Update data sizes in BoxFilterPreProcess()
2019-11-08 johannkoenig cdef directional filter

Created with:
  roll-dep src/third_party/libgav1/src

Bug: b:142835450
Test: Build chromium
Change-Id: I33612f8956e21af21a81475df4d4e24fb050c114
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007799Reviewed-by: James Zern <jzern@google.com>
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738067}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: Id34b699e8a79610a6c1a4bdf742274ad63bbed21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036646Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738066}

When an extension message is received, we check `MessageSender.id` to
disallow requests from unknown clients.  Unfortunately,
`MessageSender.id` is currently not trustworthy (issue 982361) and
therefore this CL switches to using `MessageSender.origin` instead.

Bug: 10321587
Change-Id: Ia4b63bbb0bff361b6695d930eb44fdd25a8b789e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035866
Commit-Queue: Shik Chen <shik@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738065}

This was causing a crash during uninstallation of apps when file
handling was enabled.

Bug: 1047481
Change-Id: Ib5657eb48b439058e236f9abe91c8c21a0fb3be9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016783
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738064}

Bug: 1012527
Fixed: 1012527
Change-Id: Id9ef248aadb0aa24704dec973b60ea23c9e1f1ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032332
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738063}

Legacy code was not enforcing 2 invariants of colspan
redistribution.
- min_width <= max_width
- redistribution should never shrink width.

The fix introduces a part of new colspan redistribution
test suite.

Bug: 958381
Change-Id: I3cc6e55af86dd376ffbc0a4c4710900df8bccce5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030805
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738062}

R=xinghuilu

Fixed: 1047696
Change-Id: Id567a2bd419dcb83d9b19a6ba231cc62cfa93b53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036811
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738061}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aae8a22141d0..42ede502db2f


Created with:
  gclient setdep -r src-internal@42ede502db2f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I7ba365d855776fc1c522e7523e732377c8b65c27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036924Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738060}

Bug: 873178
Change-Id: I58082258d173cd90281500c5ae5499c1e7df20f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031111Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738059}

Before the change, on the storage page, the row "Android storage"
displayed the size of the android apps. The size of the apps and
extensions installed from the chrome web store were not reflected
anywhere on this page.

This row is renamed "Apps and extensions", and displays the size of
- android apps (including the default ones, which can be deleted if the
user disables the Play store)
- apps and extensions installed from the web store, which data is
located in the Extensions folder of the user's cryptohome, as opposed
to the system apps/extensions.

The size of web store apps/extensions and android apps are calculated
separately. The UI is always updated with the sum of both. Bytes
formatting happen on the C++ side, so summing web store and android
apps has to happen on the C++ side.

androidRunning_ on the JS side was used to display or hide the
"Android storage". The "Apps and extensions" row is now always
visible. androidRunning_ is not needed anymore.

unit_tests --gtest_filter="*StorageHandlerTest.AppsExtensionsSize"
browser_tests --gtest_filter="*OSSettingsDevicePageTest.StorageTest"

Test: 
Bug: 1039916
Change-Id: I4aeffad4a258356ab1cb48834b6bf2cba155f33a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032703Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Jeremie Boulic <jboulic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738058}

We used bindings original name style converter, and this CL changes to
use NameStyleConverter for dictionary accessors.
Because of the difference of acronyms' lists, there are few updates in
C++ API names;

  e.g.
  hasURL => hasUrl
  hasURLs => hasUrls
  hasJSMemoryEstimate => hasJsMemoryEstimate


Bug: 839389
Change-Id: If8803899d3359d8a3d5db8d22221b788fe19c97f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032555
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738057}

Specifically adding the following to settings_resources_v3.grdp
 - global_scroll_target_behavior.js
 - page_visibility.js
 - route.js
 - settings_routes.js
 - site_favicon.js (also port tests and add type-checking)

Bug: 1026426
Change-Id: I921ede15bc636b1b1ba3457cfd1cb3a3ec06a379
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036276
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738056}

GetApplicationLocale() should only be called on the UI thread. In
r303655, GetApplicationLocale() calls in ResolveUILanguageList() got
moved off the UI thread but nobody noticed because
GetApplicationLocale() didn't have any DCHECKs. In the process of adding
the DCHECKs, this issue now becomes apparent.

Fix the issue by calling GetApplicationLocale() on the UI thread first,
before posting a task to ResolveLanguageListInThreadPool(). This also
replaces 4 GetApplicationLocale() calls with 1. Rearrange the logic
inside ResolveLanguageListInThreadPool() slightly as well.

Bug: 1033644
Change-Id: I3c350c34cf253052bad18b850381e2c92003b7f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036373Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738055}

Followup from:
https://chromium-review.googlesource.com/c/chromium/src/+/2031547

Change-Id: I06de15554a90534978ef11c0516e81742058b834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035860
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738054}

ScrollableShelfView's layer is masked to create the gradient shader.
In fact, when the scrollable shelf is not in overflow mode, the mask
layer is not needed. This CL sets the mask layer to null when the
scrollable shelf is not in overflow mode.

Bug: 1045265
Change-Id: I32fce5bd13da47a1d0b89968a5be54cd68a13738
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033540
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738053}

This relands https://crrev.com/c/1688957

It also updates it make it controlled by a feature-flag and parameterizes
all render frame hosts tests to try with the flag on and off.

- https://crrev.com/c/2006996 lands some CHECKs to help debug
  https://crbug.com/1006814
- https://crrev.com/c/2010511 lands some CHECKs to help debug
  https://crbug.com/1014212
- https://crrev.com/c/2011585 adds a test for the bug in
  https://crbug.com/993701 however this bug is no longer triggered.


> On same-site navigations, the browser reuses the current
> RenderFrameHost, even if the current RenderFrameHost is crashed.
>
> Instead of reviving the crashed one, we should get a new RenderFrameHost.
>
> This can be seen as a small step in the direction of RenderDocument, which
> intend to get a new RenderFrameHost every time, even if the previous
> RenderFrameHost is not crashed.
> https://docs.google.com/document/d/1C2VKkFRSc0kdmqjKan1G4NlNlxWZqE4Wam41FNMgnmA/edit


Bug: 981339
Change-Id: I0d89d65d2c12acaccd84454ecb4a1d00901f750b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006890
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738052}

Previously they were not checking whether they were running on the
expected GPU (low-power or high-performance). In fact, they were
accidentally misconfigured in test_suites.pyl, and were not exercising
the desired code paths on the bots.

Stop forcing the discrete GPU when running the pixel tests - allow
them to use the natural GPU configuration of the browser - and make
assertions about which GPU is active at various points during the
low-to-high-power and high-to-low-power tests.

Bug: 1047573
Change-Id: Icdb85c6fe2625ccce489f8bba4c053f5248e1e55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032190
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738051}

The existing port forwarding class interface was meant to only handle
one vm / container. The interface has been extended for multiple VMs and
containers. The actual implementation however has not as it will
introduce too much complexity.

Additionally, the IPv4 address will be extracted from the crostini
manager based on the current vm+container on every rule add + activate.
This IPv4 address is saved by the CrostiniManager on signals from
Cicerone.

Includes small refactors.

BUG: chromium:848127
TEST: crostini_port_forwarder_unittest.cc passes, crostini*, path_util*
Change-Id: I13b1df2e910213611a22c9201130da49a30ac1c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029474Reviewed-by: David Munro <davidmunro@google.com>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Fergus Dall <sidereal@google.com>
Commit-Queue: Matthew Chen <matterchen@google.com>
Cr-Commit-Position: refs/heads/master@{#738050}

This change exposes hierarchical level for tablist in the accessibility
tree. Hierarchical level is determined from `aria-level` or the DOM
structure of the tablist in relation to its parent tablist.

https://www.w3.org/TR/wai-aria-1.1/#tablist
https://www.w3.org/TR/wai-aria-1.1/#aria-level

Change-Id: I1d6aba1bf47b3998a7622a98ec75dae1e41c9452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996263
Commit-Queue: Victor Fei <vicfei@microsoft.com>
Reviewed-by: Ian Prest <iapres@microsoft.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738049}

We allow ElapsedTime metrics to expire. We'll remove these as they are
not proving useful: crbug.com/1046642

Bug: chromium:1036897 and several others
Change-Id: I6fac1a693e6778190758f0d3ff0452f8c1ee95ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026915
Auto-Submit: Andrew Moylan <amoylan@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738048}

TBR=benmason@chromium.org

Change-Id: Ibc6bc6cbd0df4492caa9577cd156463b2622b54a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036909
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738047}

Currently GvrConsentHelper also ensures that the VR DFM is or gets
installed if needed. However, the permissions API bypasses this flow. In
order to enable the Permissions API logic by default, this logic needs
to be separated out.

This mimics the pattern of the ArCoreInstallHelper; however, there is an
outstanding bug which blocks installing VrCore at this time. That will
be addressed in a separate, future, change.

Also drops the FPS timer in gvr_scheduler_delegate down to DVLOG(2), as
it's rate of logging proved a bit difficult to debug during development.

Fixed: 1043223
Change-Id: I2475403b4df62fa2b9db0ca15642be2ff7d6b4ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036643
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738046}

This CL moves Privacy Personalization strings from AddPrivacyStrings()
to the shared string provider, and moves strings from the function
that are OS exclusive from browser settings string provider to OS
settings strings provider.

Bug: 967888
Change-Id: I72c7b27a4e04a091ff347b420dde53ea7baf418d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029329Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738045}

This change allows the prediction manager to fetch models from the
remote optimization guide even if the top host provider is not
available. The top host provider will only be provided to the manager
if the Lite mode infobar has been shown to the user. Prediction
models can be fetched even without this check as it does not
disclose any information about the hosts that a client has visited.

Bug: 1046848
Change-Id: I95512073bac029177029e29200f8f52fc8fbc1e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036870
Auto-Submit: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738044}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e4d329cc0082..e93101895e74

git log e4d329cc0082..e93101895e74 --date=short --first-parent --format='%ad %ae %s'
2020-02-04 ynovikov@chromium.org Also set LIBPATH in Windows toolchain environment
2020-02-03 ehmaldonado@google.com presubmit_unittest: Mock time_time for ThreadPoolTest

Created with:
  gclient setdep -r src/third_party/depot_tools@e93101895e74

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1032635,chromium:1047631
Tbr: agable@chromium.org
Change-Id: I11cf7861373bd293685ad23b8f839a3a169e9957
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036926Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738043}

Bug: None
Change-Id: Icde3c290e2cb136b15542ce2fc9d1884b08d335d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035811Reviewed-by: Austin Tankiang <austinct@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738042}

Otherwise, a line containing '#is_asan=true' can add run_with_asan to
the beginning of the command, which will fail.

R=brucedawson@chromium.org, thakis@chromium.org

Change-Id: I31cf9c35cfc0ca04f4c6cc3b5f2376b0c0c58f3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033630Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738041}

Test: Inject a failure and check logs.
Bug: chromium:1048056
Change-Id: Ib48aa40afc15206bf933343091b1c94a55a4ef89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035814
Auto-Submit: David Munro <davidmunro@google.com>
Reviewed-by: Nic Hollingum <hollingum@google.com>
Commit-Queue: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#738040}

Avoids having decode()s at callsites.

Traceback (most recent call last):
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 556, in <module>
    sys.exit(main())
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 551, in main
    return args.func(args, remaining_args)
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 334, in _Parse
    _ParseFile(args, RelativePath(filename, args.depth))
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 323, in _ParseFile
    _PickleAST(tree, _GetPicklePath(rel_filename, args.output_dir))
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 295, in _PickleAST
    WriteFile(pickle.dumps(ast), output_file)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 118, in WriteFile
    f.write(contents.encode('utf-8'))
AttributeError: 'bytes' object has no attribute 'encode'

Bug: 941669
Change-Id: I116e469dd5ff7903779226b7ea18cdd5e4cc2fe7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031112
Commit-Queue: Ken Rockot <rockot@google.com>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#738039}

The indentation for setting wide color gamut on Android is misleading.
It implies that it is nested inside another if(). But it is not. It is
independent.

This CL corrects the misleading indentation.

Change-Id: I42bcbbd7f727967bf81e617b33a93e5d178263d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036895Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738038}

We already enable ChromeosVideoDecoder feature at stable channel for 2
weeks. It's time to enable it by default.

Bug: 984482
Test: ninja media/base
Change-Id: I905d12fb0a53f16b76afd4975f90db6013e07b9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035212Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738037}

CanApplyOptimization

This is necessary if all consumers use the async API which doesn't set
the bit.

Change-Id: Ibb9936a6b2a2ae6207598b905bc5ead55c669574
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030065
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738036}

https://chromium.googlesource.com/openscreen.git/+log/76cf904a4fd4..36c6ca3e8f7f

git log 76cf904a4fd4..36c6ca3e8f7f --date=short --first-parent --format='%ad %ae %s'
2020-02-03 miu@chromium.org Cast Streaming: Pass expected codec to the Standalone Receiver decoder.

Created with:
  gclient setdep -r src/third_party/openscreen/src@36c6ca3e8f7f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: Ic8e8713bbb9e97cfb0c1945130c52f084c6f0d8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036912Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738035}

The QuotaLimitType enum is currently declared in //storage/browser/, but
is only used in //storage/browser/file_system. This CL:

1) Moves the header to //storage/browser/file_system
2) Removes the unused enum value kQuotaLimitTypeLast
3) Converts the enum to an enum class.
4) Forward-declares the enum class in headers.
5) IWYUs the enum class header in the relevant .cc files.
6) Removes unnecessary storage:: qualifiers on QuotaLimitType.
7) Fixes clang-tidy errors in the changed files.

Change-Id: I51cde407e18965c06c650dcbcca5bf6b9ffc9856
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033760
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738034}

- Add task affinity string to DevUI activities so they would be launched
  in a separate task other than the app's task (especially useful in
  Monochrome case).
- Explicitly define an icon for MainActivity (rather than the
  activity-alias), so this icon is used in the Android task switcher as
  well as for the launcher icon.

Bug: 1044294
Test: Launch Monochrome browser and DevUI, check they show in separate tasks and use different icons in app switcher
Change-Id: I0bbeda3b01ea24475cdc6dabd148b8e6c3c722d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032845
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738033}

Previously multiple consecutive self-painting layers with the same
property tree state were in the same paint chunk causing the layers to
be "merged" too early.

Now force paint chunk for self-paint layers so that
PaintArtifactCompositor can see them and do proper overlap testing
and merge for them.

compositing/layer-creation/overlap-transformed-3d.html is an example
that previous lacking of separate paint chunks caused unnecessary
extra composited layers.

Change-Id: I080fe36528c3d05c47158931560e028a1bab617b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029127Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738032}

When shutting down overview session, make sure the
OverviewModeFocusedWidget is hidden (and deactivated), to prevent it
from handling key pressed events (when the overview session is active,
key press events are handled by OverviewSession before they get
dispatched to the active window).
Without this, the OverviewModeFocusedWidget might end up handling tab
key event, and cause a crash when the focus manager attempts to find the
next focusable view within an childless widget.

BUG=1033972

Change-Id: I0b817cb5784b6ffd79d5a4b011a233cd410863c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036258Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738031}