GitLab

Compiling frontend runs in ~13 seconds (including dependency check) instead of 22 seconds.

Examples of the RegEx match:
http://regexr.com/3etk5

The following CL needs to land before this CL lands:
https://codereview.chromium.org/2623743002/
BUG=673445

Review-Url: https://codereview.chromium.org/2588843002
Cr-Commit-Position: refs/heads/master@{#442754}

This requirement is missing from content_utility's manifest.

BUG=None
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2621203002
Cr-Commit-Position: refs/heads/master@{#442753}

This is to fix the reported bug before branching. Will reintroduce
this together with what's being handled in https://crrev.com/2595263002.

This reverts commit 603de249.

BUG=671967, 671401
TBR=boliu@chromium.org, tedchoc@chromium.org, dtrainor@chromium.org, bshe@chromium.org

Review-Url: https://codereview.chromium.org/2626723003
Cr-Commit-Position: refs/heads/master@{#442752}

VC++ was initializing all of the static PathElement arrays in
GetPathForVectorIcon and GetPathForVectorIconAt1xScale at runtime, which
meant that these were the largest and sixth largest functions in
chrome.dll, and similarly in chrome_child.dll. Tagging the arrays and
types as constexpr shrinks these functions down to nothing, saves about
~50 KB of per-process private data, and actually helps them compile
slightly faster.

The approximate section size changes are:
       .text: -164224 bytes change
      .rdata:   51984 bytes change
       .data:  -54976 bytes change
      .reloc:  -23204 bytes change

These gains apply both to chrome.dll and chrome_child.dll.

BUG=679539

Review-Url: https://codereview.chromium.org/2620653004
Cr-Commit-Position: refs/heads/master@{#442751}

This is crashing on Xiaomi phones
Android API doc never deprecates the call, so it is their ROM issue
Catch the exception so Chrome will not crash.
But click on download completion notification will not have any effect.

BUG=678938

Review-Url: https://codereview.chromium.org/2616893005
Cr-Commit-Position: refs/heads/master@{#442750}

This will allow other GL Surface implementations than
ChildWindowSurfaceWin to create a child window on a new thread.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2623763003
Cr-Commit-Position: refs/heads/master@{#442749}

Make AppShell always the "unknown" channel, instead of always being "stable",
because (a) it doesn't have channels, (b) we want to test unstable APIs too, and
(c) saying app_shell is "dev channel" would be insulting to chrome dev channel.

This allows APIs like chrome.hid.getUserSelectedDevices to exist in app_shell. (That particular one crashes, but what can you do...)

BUG=none
R=steel@chromium.org

Review-Url: https://codereview.chromium.org/2580063003
Cr-Commit-Position: refs/heads/master@{#442748}

BUG=615892

Review-Url: https://codereview.chromium.org/2607103003
Cr-Commit-Position: refs/heads/master@{#442747}

https://skia.googlesource.com/skia.git/+log/3444cadedd47..fb00390b46b3

$ git log 3444caded..fb00390b4 --date=short --no-merges --format='%ad %ae %s'
2017-01-10 mtklein pretty up some SkSplicer code

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2625863002
Cr-Commit-Position: refs/heads/master@{#442746}

When the hardware-accelerated video decoding path is in use, the
expected size of the destination WebGL texture is the video's natural
width and height. However, the code was blindly copying the entire
video source texture, which might include padding rows from the video
encoder.

Change to using CopySubTextureCHROMIUM in these code paths, and rely on
the caller to allocate the destination texture with the expected size.

A regression test for this bug is being added to the WebGL 2.0 conformance
suite in https://github.com/KhronosGroup/WebGL/pull/2202 .

BUG=672895
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2562003003
Cr-Commit-Position: refs/heads/master@{#442745}

BUG=670147

Review-Url: https://codereview.chromium.org/2549393004
Cr-Commit-Position: refs/heads/master@{#442744}

Improves on element-id-to-layer-id followed by layer-id-to-node-index lookups.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2619383004
Cr-Commit-Position: refs/heads/master@{#442743}

Revert of A simple, practically zero cost fallback crash handler for Crashpad handler process. (patchset #14 id:260001 of https://codereview.chromium.org/2596463002/ )

Reason for revert:
Sorry, it looks like the new patch also has a build failure. See crbug 679920. (I'm not 100% sure, this is my best guess, apologies if it turns out incorrect).

Original issue's description:
> A simple, practically zero cost fallback crash handler for Crashpad handler process.
>
> This implements a fallback crash handler launcher. The launcher will be instantiated in the Crashpad handler process, where it pre-computes a command line to be launched on crash. This will be triggered off the UEF, under some form of single-instance locking.
>
> BUG=678959
>
> Review-Url: https://codereview.chromium.org/2596463002
> Cr-Original-Commit-Position: refs/heads/master@{#442596}
> Committed: https://chromium.googlesource.com/chromium/src/+/d4e43bb5146c7a59123ff5f3b6e853d8e8c29130
> Review-Url: https://codereview.chromium.org/2596463002
> Cr-Commit-Position: refs/heads/master@{#442698}
> Committed: https://chromium.googlesource.com/chromium/src/+/f87fdaa12b09ff286d873e7a3ea459507d7adb83

TBR=scottmg@chromium.org,siggi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=678959

Review-Url: https://codereview.chromium.org/2620213002
Cr-Commit-Position: refs/heads/master@{#442742}

It was updating the child window instead.
This CL hooks up the bounds change to the desktop widget correctly.

BUG=612270
TEST=fixed test harness to do the correct check.

Review-Url: https://codereview.chromium.org/2583873002
Cr-Commit-Position: refs/heads/master@{#442741}

BUG=618624

Review-Url: https://codereview.chromium.org/2623613009
Cr-Commit-Position: refs/heads/master@{#442740}

Revert of Sub-sample accurate start of OscillatorNode (patchset #11 id:200001 of https://codereview.chromium.org/2186813003/ )

Reason for revert:
Added test is failing on WebKit Mac10.11 (retina)

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29

Original issue's description:
> Sub-sample accurate start of OscillatorNode
>
> Previously, an oscillator would start at the nearest sample frame
> boundary.  This can produce noticeable effects.
>
> Instead, make the oscillator start at the requested sample time and
> sample the curve appropriately.
>
> BUG=631576
> TEST=Oscillator/start-sampling.html
>
> Review-Url: https://codereview.chromium.org/2186813003
> Cr-Commit-Position: refs/heads/master@{#442669}
> Committed: https://chromium.googlesource.com/chromium/src/+/7909df464ca46a1ea121b0c54e5d04cfa521e38c

TBR=hongchan@chromium.org,rtoy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=631576

Review-Url: https://codereview.chromium.org/2623063002
Cr-Commit-Position: refs/heads/master@{#442739}

Android InputConnection has two related methods

- setComposingText() replaces the current compose region with a given piece of
  text and sets a composing span around the new text

- commitText() replaces the text the same way but then closes out the compose
  region instead of putting it around the new text.

Support was added for parsing BackgroundSpan and UnderlineSpan annotations in
setComposingText() to support the Google Japanese Input IME (newly entered text
in the compose region is underlined and highlighted in a blue background).

The Android Voice IME instead uses commitText() because it wants the highlighted
regions to persist after the compose region is closed out. Closing out the
compose region after calling setComposingText() would clear the highlight
regions. So to support this, we need to parse the spans for commitText() in
ImeAdapterAndroid just as we do for setComposingText(), and also thread this
information all the way back to InputMethodController as we do for
setComposingText().

I tested this by forwarding calls of setComposingText() to commitText() and
verifying that highlighting works for the Google Japanese IME. It's highlighting
the character immediately ahead of the insertion point instead of the newly
typed character when I do this; I suspect this may be because the IME is
expecting something about the setComposingText() behavior (e.g. the compose
range) that's different in commitText(), but it's also possible I have a bug in
the new logic.

Once I write some code to start parsing out SuggestionSpans from the Voice IME,
I'll be able to test this better (I might be able to get this done tomorrow).

BUG=673491

Review-Url: https://codereview.chromium.org/2568093003
Cr-Commit-Position: refs/heads/master@{#442738}

This CL homogenises the behaviour of the ShapeDetector's
detect() in case of an input element with any zero dimension.
Assuming such input element pass the cross origin test and
its underlying pixel data can be retrieved, then if either width
or height is zero, detect() Promise is resolved with an empty
array.

LayoutTests are adapted/extended/cleaned up.

BUG=674306

Review-Url: https://codereview.chromium.org/2626743002
Cr-Commit-Position: refs/heads/master@{#442737}

This patch moves NetworkRequest.prototype.url to a proper getter/setter
function to be within our styleguide.

R=caseq,luoe,einbinder,dgozman
BUG=679105

Review-Url: https://codereview.chromium.org/2626553002
Cr-Commit-Position: refs/heads/master@{#442736}

String IDS changes only so, TBR'ing owners.
// For chrome/browser/ui/cocoa
TBR=asvitkine
// for
TBR=msw

BUG=660349

Review-Url: https://codereview.chromium.org/2626723002
Cr-Commit-Position: refs/heads/master@{#442735}

BUG=none

Review-Url: https://codereview.chromium.org/2613033003
Cr-Commit-Position: refs/heads/master@{#442734}

To make snackbars and infobars animate, snackbars were moved to be child
of CompositorViewHolder, and TabContentViewParent was introduced to handle the
animation. One side effect of such design is that many Android views in
CompositorViewHolder now rely on a behavior to receive touch event.

This CL removes such behavior, as it is not the standard Android routine and it
makes our view hierarchy no longer extensible. Instead, a parent of
CompositorViewHolder is introduced to harbor all Android views that may display
on top of content.

This CL also moves infobars to be a sibling of snackbar, and their parent will
be a new FrameLayout called bottom_container.

BUG=640710

Review-Url: https://codereview.chromium.org/2623493003
Cr-Commit-Position: refs/heads/master@{#442733}

BUG=675359, 675358

Review-Url: https://codereview.chromium.org/2623713002
Cr-Commit-Position: refs/heads/master@{#442732}

unique, but clients aren't.

Also, dump whether the SB check for the URL returned by the DBManager had timed
out.
Also, make the dump buffer smaller hoping to get more minidumps.

BUG=660293

Review-Url: https://codereview.chromium.org/2616653002
Cr-Commit-Position: refs/heads/master@{#442731}

This caused RunOldLayout to use wrong PercentageResolutionSize

<main style="width:500px;height:150px;position:relative;border: solid black">
  <div style="position:absolute;top:25%;width:50%;background-color:yellow;">hi</div>
</main>

This used to display at 1/2 width in NGLayout.

BUG=635619

[ng_constraint_width]

Review-Url: https://codereview.chromium.org/2616093004
Cr-Commit-Position: refs/heads/master@{#442730}

BUG=679084
R=qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2620103002
Cr-Commit-Position: refs/heads/master@{#442729}

Current items (Copy link address, Copy link text) shown in the context
menu for tel tag link do not make sense.

Update the items shown in the context menu when long pressing a tel
link. The items include:
1. Call: acts the same as clicking on the link
2. Send message: navigates to the default message app to send a text
message for given telephone number.
3. Add ot contacts: navigates to Contacts and add the given phone number
to the contact.
4. Copy: copys the phone number.

BUG=394299

Review-Url: https://codereview.chromium.org/2619493006
Cr-Commit-Position: refs/heads/master@{#442728}

Change Picture subpage can get into an odd state when the user navigates
away and then back again. This CL fixes that regression and adds a test.

BUG=674844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626733002
Cr-Commit-Position: refs/heads/master@{#442727}

This bug caused LayoutTest to fail:
virtual/layout_ng/css2.1/20110323/absolute-replaced-width-055.htm

BUG=635619

[ng_bug_margin_top]

Review-Url: https://codereview.chromium.org/2628583003
Cr-Commit-Position: refs/heads/master@{#442726}

roll-dep src/third_party/chromite chromiumos/chromite.git

https://chromium.googlesource.com/chromiumos/chromite.git/+log/de4d8e3236c7..267bf6a6bbd0

$ git log de4d8e323..267bf6a6b --date=short --no-merges --format='%ad %ae %s'
2016-12-08 laszio Add chell-chrome-pfq to waterfall.
2017-01-07 laszio afdo: fix a python syntax problem
2017-01-06 laszio afdo: initialize gsurls before using it in AFDOUpdateEbuildStage
2016-12-02 vapier patch: handle gerrit results that omit http/https results
2016-09-22 aaboagye Paygen: Split up Paygen into Build + Test stages.
2016-11-23 achuith cros_run_vm_test: --vm-sanity for running vm_sanity.py.
2016-11-01 dgarrett bootstrap: Create script to launch cbuildbot on branch.

BUG=

Review-Url: https://codereview.chromium.org/2626803002
Cr-Commit-Position: refs/heads/master@{#442725}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d49320dbc448..854df3eb017b

$ git log d49320dbc..854df3eb0 --date=short --no-merges --format='%ad %ae %s'
2017-01-10 sullivan Remove former contributors from OWNERS

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2620173002
Cr-Commit-Position: refs/heads/master@{#442724}

Merge internal change 144001562.

BUG=

Review-Url: https://codereview.chromium.org/2619993003
Cr-Commit-Position: refs/heads/master@{#442723}

Generated via src/content/test/gpu/gather_swarming_json_results.py.

BUG=679899
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2627733002 .
Cr-Commit-Position: refs/heads/master@{#442722}

In Widevine CDM component updater, when we copy the adapter, we should
also copy the adapter signature file.

BUG=660287
TEST=Manually tested

Review-Url: https://codereview.chromium.org/2617023004
Cr-Commit-Position: refs/heads/master@{#442721}

https://skia.googlesource.com/skia.git/+log/356f7c2600ef..3444cadedd47

$ git log 356f7c260..3444caded --date=short --no-merges --format='%ad %ae %s'
2017-01-10 mtklein Invalidate icache in copy_to_executable_mem()
2017-01-10 brianosman Add Gray8 pixel config
2017-01-10 mtklein SkSplicer: no need to set_k() manually.
2017-01-10 mtklein disable splicer on MSAN bot
2017-01-10 halcanary Remove last of SK_SUPPORT_LEGACY_IMAGE_ENCODER_CLASS
2017-01-10 mtklein SkSplicer: fix aarch64 jump offset, turn on testing on aarch64 Android bots
2017-01-10 mtklein SkSplicer: test and fix loop logic
2017-01-10 brianosman Revert "Add Gray8 pixel config"
2017-01-10 mtklein Test SkSplicer on x86-64 bots, except Windows.
2017-01-10 brianosman Start including 'winrt' in Windows toolchain
2017-01-10 msarett Respect SkColorSpace in SkPNGImageEncoder
2017-01-10 halcanary Clean up unused SK_SUPPORT_LEGACY_IMAGE_ENCODER_CLASS code

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2620133002
Cr-Commit-Position: refs/heads/master@{#442720}

BUG=

Review-Url: https://codereview.chromium.org/2620163002
Cr-Commit-Position: refs/heads/master@{#442719}

https://chromium.googlesource.com/angle/angle.git/+log/037340d..98e3407

BUG=chromium:678526,chromium:679607,chromium:679725

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2623983002
Cr-Commit-Position: refs/heads/master@{#442718}

Assertion.h provides macros active only in Debug builds, but also ones
active in all builds, including ones used to crash out on when security-
sensitive conditions are violated, so it's important to test they work
as intended.

Review-Url: https://codereview.chromium.org/2626813002
Cr-Commit-Position: refs/heads/master@{#442717}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5f24a96d..1f92260e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2623923002
Cr-Commit-Position: refs/heads/master@{#442716}

on the offline interstitial

BUG=674717

Review-Url: https://codereview.chromium.org/2625553002
Cr-Commit-Position: refs/heads/master@{#442715}