- 07 May, 2020 40 commits
-
-
Jesse Schettler authored
Add support for cros_healthd's new Bluetooth events to ServiceConnection. Bug: chromium:1067641 Change-Id: Icd578de268f3627f61c98ed735dfa792331d86bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182403Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#766531}
-
Mugdha Lakhani authored
Bug: 1058595 Change-Id: I53dd3ecfce6393b0eaeddbd98a4622dac1f1d73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188290Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#766530}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/4aa11daaa679..a44d04ae6681 git log 4aa11daaa679..a44d04ae6681 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 jophba@chromium.org Rename util/logging.h to avoid collisions Created with: gclient setdep -r src/third_party/openscreen/src@a44d04ae6681 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I8bfd6d7824aff11dbbdb7f325473d68321286c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187909Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766529}
-
Mason Freed authored
Prior to this CL, this would not work correctly: <template id=target> <div> <template shadowroot=open>Content</template> </div> </template> <script> document.body.appendChild(target.content.cloneNode(true)); </script> The inner declarative Shadow DOM (<template shadowroot>) would not get cloned from the template content to the clone. With this CL, it now works correctly. Several tests were added to test nested template and declarative Shadow DOM nodes. This CL mirrors the DOM spec changes made in [1]. [1] https://github.com/whatwg/dom/pull/858 Bug: 1042130 Change-Id: I05792e038dc694ac00d13531c657afaed754f747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175062Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#766528}
-
Sam Bowen authored
Fuzz tests the single json string input to the extractor. Bug: 1069230 Change-Id: I96c5f44b249b4b24363d4b431e97b4fff6194792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186456Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#766527}
-
Joe Downing authored
Since we no longer need to juggle TURN and GTURN ICE configs, we can remove the relay_mode_ member and code needed for it. This simplifies things a bit in preparation for the removal of the ICE Config caching logic. Change-Id: Ibcc34368c6f3df943cbcb6b1365bc87d30af2dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187201Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#766526}
-
Patrick Monette authored
Bug: 1077305 Change-Id: I9dc0120fc976741cd2ef1a7acc1d0c92d1daf928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176257 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#766525}
-
Yu Han authored
Because the dsf change isn't propagated to the popup which is causing inconsistency in the popup after dsf change. We also close a popup when page zoom is changed [1], and this makes display zoom and page zoom consistent. This CL original came from http://crrev.com/c/2148683. I've added a test to ensure validity of this behavior. Big thanks to oshima@ and danakj@ [1] https://source.chromium.org/chromium/chromium/src/+/master:content/renderer/render_widget.cc;drc=c946131d9ba26f27d720710cebfba72953276cad;l=988?originalUrl=https:%2F%2Fcs.chromium.org%2F Bug: None Change-Id: Id811be4f7b7f948d3493bb69b7693055bf61c4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176289Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#766524}
-
Dominik Röttsches authored
Fixes AAT shaping of certain ligatures in Geeza Pro font. https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/e53c44e3260d..100d40c827eb $ git log e53c44e32..100d40c82 --date=short --no-merges --format='%ad %ae %s' 2020-05-06 jfkthame [aat] Fix implementation of AAT kerning for Geeza Pro. (#2388) 2020-04-30 ebrahim minor spacing 2020-04-30 khaledhosny [blob] Try to support resource fork fonts on macOS 2020-04-28 rene.meusel FIX: -Wextra-semi-stmt in Clang9 2020-04-28 ebrahim [ci] enable experimental apis in coverity scan 2020-04-28 ebrahim [ci] enable more on coverity 2020-04-28 ebrahim [ci] remove trigger-coverity.sh 2020-04-28 ebrahim [blob] close file reader handle 2020-04-28 ebrahim [ci] install fonttools in linux-ci bot 2020-04-28 ebrahim [ci] Add coverity scan bot 2020-04-28 ebrahim [ci] fix linux-ci bot 2020-04-28 ebrahim [ci] remove travis's clang bot 2020-04-28 ebrahim [ci] run apt-get with sudo 2020-04-28 ebrahim [ci] Add a GitHub CI bot 2020-04-28 ebrahim [ci] Remove coverity and codecov 2020-04-28 ebrahim [ci/meson] temporarily disable check-symbols Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,jshin@chromium.org Fixed: 1071154 Change-Id: Ib63c26fbde52c5d8c91d9461a8ab480a9aba2506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183951 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#766523}
-
Vikas Soni authored
1. Remove existing gpu driver bug workaround. 2. Add a finch feature flag to enable this workaround instead. Bug: 1031383 Change-Id: I0934bd8934bd12b5dfe5cf565b5173b68851a099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152893 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#766522}
-
Ilia Samsonov authored
Copying additional buildbot config from mac10.14 to mac10.15. This enables running tests on mac10.15-blink-rel. The builder will fail for now, but enables fixing tests and rebaseline. Bug: 1077312 Change-Id: I370fea5b3da10ec857f503b5a939fe4678657bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185790Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#766521}
-
Nnamdi Theodore Johnson-Kanu authored
- Add top-level JS/HTML files that will host the V3 version. - Use a JS import for the generated chromeos/search_handler.m.js as a proof of concept. - Update BUILD.gn files as needed. - Currently only works when optimize_webui = false Bug: 1045266 Change-Id: I421f9090833731748d18ac2d19013faef3199648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171981Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#766520}
-
James Cook authored
We're moving the launch to M-85. Bug: 1013466 Change-Id: I864d118f8b79e7c564477c4cf7a0731e9c4982aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183169Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#766519}
-
Victor Costan authored
Change-Id: I189b3bbcd90dd131b6c68dd4f6715cd06ad95e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183710 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#766518}
-
chrome://flagsDoug Arnett authored
Adds #enable-translate-sub-frames flag for Feature "TranslateSubFrames" Bug: 797328 Change-Id: Ib210a1d5566b43a0dbe75b22ef4e0cd101a404d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186366Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#766517}
-
Carlos IL authored
InterstitialPage is not used with committed interstitials. This CL removes the class and cleans up its usage. Follow ups to this CL: -Remove InterstitialPage specific methods from WebContents Observers (crrev.com/c/2147921). -Remove transient entries concept (crrev.com/c/2149954). Bug: 1077074 Change-Id: I0e08a3f8df77a91f3cea5a030793b405c2eef29d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146137Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#766516}
-
Nicolas Ouellet-Payeur authored
TBR: pastarmovj@chromium.org Bug: 1079242 Change-Id: I78eaff424ef6d580c03be7a06fac3b8343746ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188237Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#766515}
-
Peter Wen authored
Linting chrome_public_test_apk and any other test apks that opt-in to linting makes it easier for test targets to be brought up on various platforms, ensuring that our test code does not use APIs that are not available on the platforms it tests on. Add disable flags for some common checks that are not useful for test targets. Follow-up to: https://crrev.com/c/2163728 Bug: 1017190 Change-Id: Ica7f24b3081f74e79799c52a094839dd11b23601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185515Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#766514}
-
James Cook authored
I need to turn SplitSettingsSync off by default so I can move the launch to M85. However, wifi config sync is tied to SplitSettingsSync, and wifi config sync is on track to launch in M84. Let's make it possible for these features to launch in any order. Introduce UserSelectableType::kWifiConfigurations and rename the OS selectable type to kOsWifiConfigurations. Take the same approach as OS apps sync -- when SplitSettingsSync is enabled, map the UserSelectableType::kWifiConfigurations to ModelType::UNSPECIFIED. UserSelectableType::kWifiConfigurations is not wrapped in #ifdef OS_CHROMEOS for consistency with other sync code. There are other platform specific UserSelectableTypes and ModelTypes (reading list) that are not wrapped. Add the data type toggle back to the shared pre-SplitSettingsSync OS/browser sync settings WebUI. Duplicate the string label so each settings WebUI has strings available that are consistent with its naming conventions and file locations. The underlying string value will be deduplicated before being translated, so there's no extra translator work here. Bug: 1013466, 966270 Test: browser_tests, unit_tests, sync_integration_tests Test: tried all combinations of SplitSettingsSync and SyncWifiConfiguration flags on device Change-Id: I16116379c920bb76dee143ef54a2b7f39dfe6eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185577Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#766513}
-
Dominique Fauteux-Chapleau authored
This allows the correct Connector policy to be read by this method and means CheckContentCompliance and SafeBrowsingSendFilesForMalwareCheck are not needed on the upload path when Connector policies are used. Changing GetAnalysisSettings from an async signature to a sync one is required for this change. Bug: 1067631 Change-Id: I36fc0f6de030270642dc5086e79fe65bcbd6ccdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183029Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#766512}
-
Mila Green authored
Bug: 1072061 Change-Id: I81a3376d3f717f4b6dd29e458e24fbc10d238ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185435Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#766511}
-
Zach Trudo authored
Previously record.proto wasn't depending on record_constants.proto. Bug: chromium:1078512 Change-Id: I62616eb92c09c3c81859fc6e5aaa1b5968cc692b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186115 Commit-Queue: Zach Trudo <zatrudo@google.com> Auto-Submit: Zach Trudo <zatrudo@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#766510}
-
Jazz Xu authored
Relocate enter_pip and exit_pip icon to components/media_message_center/vector_icons/ since these two icons are not generic icons from material.io/resources/icons. Bug: 1047479 Change-Id: I1d93e117720701854fe4bbbe822596e49f8213da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183092Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#766509}
-
Charlie Hu authored
Previously when document policy is parsed, parsing errors are silent, which can cause difficulties in debugging. This CL adds parsing error output for DocumentPolicyParser. Bug: 993790 Change-Id: I8e7f88abf73990793a456f3f6a39bf4054d4b6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136186 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#766508}
-
Brian Sheedy authored
Switches the GPU Mac Intel experimental bot to run tests on 10.15.4 and sets its set of tests to be identical to the non-experimental bot. Also suppresses/skips the few failing tests that were encountered on the trybot. Bug: 1078489, 1078988, 1078982 Change-Id: Icbd53b7fa53653f0786d0524c195ef387f437018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185516Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#766507}
-
Andrii Shyshkalov authored
CQ already cancels tryjobs by default. R=martiniss Bug: 959436 Change-Id: Ieef402fc1e488427aa1c444928a6cf0c98bb7cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187190 Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#766506}
-
Maksim Sisov authored
UpdateCursorPositionFromEvent may crash because GetCurrentFocusedWindow may return nullptr. What is more, the logic we have there is pretty complicated and must be simplified. Thus, call UpdateCursorPositionFromEvent after the events have had their location converted to bounds of the window that dispatches the events, and UpdateCursorPositionFromEvent will just convert them to the parent top level window. Test: WaylandScreenTest.GetCursorScreenPoint Bug: 1079228 Change-Id: Ib0362dfc003861e2c0163801073e99f09c019634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187631Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#766505}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I12d447ba9568b8401a380dce1914e5f3f66e3366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187907Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766504}
-
Katie D authored
NOTRY=true Bug: 1065520 Change-Id: I08bc2df7c2ad66f808f42e4695ab7e84b2307932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186116Reviewed-by:
Aran Gilman <gilmanmh@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#766503}
-
Antonio Maiorano authored
is_swiftshader should be set to true if Chrome is launched with "--use_gl=swiftshader" or "--use_gl=angle --use_angle=swiftshader". Bug: b/146423360 Change-Id: I99a510bc92ecabdf5ef6a4954df8c251d83b674b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186996Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com> Cr-Commit-Position: refs/heads/master@{#766502}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e8bf706d161d..071fe56ffe73 git log e8bf706d161d..071fe56ffe73 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 enga@chromium.org Support depth32float sampling on D3D12 Created with: gclient setdep -r src/third_party/dawn@071fe56ffe73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I823d2f5cd477ebede3edbf63a038cb8021ac673c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187904Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766501}
-
Jesse McKenna authored
Currently, autotest.py doesn't support the forward slash '/' as a path separator on Windows. For example: Succeeds: python3 tools/autotest.py -C out/bug base\at_exit_unittest --gtest_filter=*Exit* Fails: python3 tools/autotest.py -C out/bug base/at_exit_unittest --gtest_filter=*Exit* This is because RecursiveMatchFilename() considers a file a match with the requested filename if the requested filename is a substring of the file's full path. On Windows, file paths as returned by os.scandir() use '\\' as a path separator, so a path using '/' will never match (e.g. 'base/at_exit_unittest' is not a substring of 'C:\\src\\chromium\\src\\base\\at_exit_unittest.cc'). With this change, either type of path separator works on Windows. Change-Id: Ic21eff291d86e7ca994faeda807f6aeaff737562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181744 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#766500}
-
Andrew Xu authored
This CL creates a new attribute - HotseatWidget::is_forced_dense_ to indicate whether app icons should be scaled from the normal size (56 * 56) to the dense size (48 * 48). In detail, this CL does the following things: (1) Change kShelfAppScaling to a ash feature. (2) |is_forced_dense_| should be associated with hotseat widget because app scaling should handle multiple display issues (on one display app scaling may be triggered and on another one it may not). (3) Functions in ShelfConfig, which return the size of app button, the size of app icon and the hotseat size, should accept a boolean value as parameter which indicates whether app scaling is triggered. This CL should not introduce any noticeable difference. Bug: 1019397 Change-Id: I35f79059afd9e17b348253815f0db295f6a0253d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176101Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#766499}
-
Aran Gilman authored
Bug: 1027612 Change-Id: Id22e86cb78ba35af83a46a27b46a01227fce2c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163328Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#766498}
-
chromium-autoroll authored
Roll airmont AFDO profile from 84-4103.6-1587379457-benchmark-84.0.4124.1-r1 to 84-4129.0-1588587148-benchmark-84.0.4136.1-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I4a90bcf1b40d58bf376cd7198f87b3c1c6544c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188374Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766497}
-
Mehran Mahmoudi authored
This fixes a problem where only the initial call to PlayerFrameMediator#setLayoutDimension was respected. We need to resize the view port when a call to this method is made, without altering the bitmap matrix. Bug: 1079352 Change-Id: I7fd64988028dfb0d9e170abbef5306fbb228d683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188211 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#766496}
-
Andrew Grieve authored
Using different extensions fixes an issue where files were not being rebuilt when toggling from ijar->turbine. Bug: None Change-Id: I1bc9a36bc296bdddc16a62e6d5ed5af80b5c0313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187199Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#766495}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38dda5a415a4..dd424f385b69 Created with: gclient setdep -r src-internal@dd424f385b69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC iclelland@google.com,sinhak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1043080,chromium:1065456 Tbr: iclelland@google.com,sinhak@google.com Change-Id: Ic83a180f8f9a7086c38ebd490fb4cda8a4fff86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187894Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766494}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3b6afeeed0a9..b8a9630e9e23 git log 3b6afeeed0a9..b8a9630e9e23 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 peah@webrtc.org Add a Release method for file wrapper Created with: gclient setdep -r src/third_party/webrtc@b8a9630e9e23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ide54ac367d8f2e56b4c44f63395b44d6f90ecf05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187905Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766493}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 84-4103.6-1587378376-benchmark-84.0.4124.1-r1 to 84-4129.0-1588586778-benchmark-84.0.4136.1-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I3aa506f7d9bc08b615c5ef06ef8d4c886fe769a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766492}
-