- 02 Oct, 2018 40 commits
-
-
Alex Clarke authored
This reverts commit c8c4a655. Reason for revert: I fixed a bug in LazilyDeallocatedDeque here https://chromium-review.googlesource.com/c/chromium/src/+/1253982 which might be responsible for the crashes. Lets re-enable LazilyDeallocatedDeque and see. Original change's description: > Revert "Second try at using LazilyDeallocatedDeque instead of circular_deque in TaskQueue" > > This reverts commit 6410ee3d. > > Reason for revert: This is causing some crashes. > > Original change's description: > > Second try at using LazilyDeallocatedDeque instead of circular_deque in TaskQueue > > > > Previous patch: https://chromium-review.googlesource.com/c/chromium/src/+/1080792 > > > > Our usage pattern is unfortunate for existing queues such as > > base::circular_deque. We tend to fill up an empty queue and then drain all > > those tasks until it's empty. This means the queue yo-yos in size which > > confuses the memory reclamation schemes of most queues. > > > > As an optimisation we introduce a deque specialised for TaskQueueManager's > > usage patterns. For performance (memory allocation isn't free) we don't > > automatically reclaim memory when the queue becomes empty. Instead we rely > > on the surrounding code periodically calling MaybeShrinkQueue, ideally when > > the queue is empty. > > > > We keep track of the maximum recent queue size and rate limit > > how often MaybeShrinkQueue actually shrinks the buffer to avoid unnecessary > > churn. > > > > This yields a nice win on our microbenchmark: > > > > Patch: us/run for 10000 delayed tasks with N queues > > 1 queue 4 queues 8 queues 32 queues > > 33448.166666666664 33215.75496688742 33484.34 34018.37414965987 > > 33972.18243243243 33846.91891891892 34489.737931034484 34727.90277777778 > > 33367.90666666667 33167.54304635762 33392.96 33906.89864864865 > > 33392.13333333333 33107.17763157895 33340.18 33718.73825503356 > > 37921.01515151515 39379.06299212598 38851.27906976744 39366.03125 > > 38171.564885496184 37401.72388059701 37640.32330827068 37800.51127819549 > > 34691.2275862069 34359.61643835616 34993.468531468534 35366.795774647886 > > 35981.20863309353 35089.18881118881 38530.230769230766 39280.3515625 > > 39262.8671875 36411.384057971016 33576.10067114094 33939.69594594595 > > 37913.59848484849 38324.076335877864 38061.59848484849 39921.00793650794 > > Average 35812.1871 35430.24471 35636.02188 36204.63076 > > > > ToT: us/run for 10000 delayed tasks with N queues > > 1 queue 4 queues 8 queues 32 queues > > 40459.540322580644 40536.04838709677 38994.573643410855 38696.2 > > 39422.149606299216 39299.5 37888.18939393939 37874.74436090225 > > 38419.70229007633 38025.742424242424 37844.41353383459 38020.469696969696 > > 35052.72027972028 38147.80303030303 35504.89361702128 34138.02721088436 > > 37096.77777777778 34942.541666666664 37003.529411764706 37579.60447761194 > > 38818.67441860465 38233.068702290075 37978.628787878784 37867.57142857143 > > 38455.49618320611 37903.05303030303 38106.143939393936 38129.5 > > 40609.33064516129 37721.75187969925 34656.441379310345 34294.33561643836 > > 35273.704225352114 34646.324137931035 34335.643835616436 34311.82876712329 > > 35821.41428571429 35362.035211267605 37522.27611940299 35429.281690140844 > > Average 37942.951 37481.78685 36983.47337 36634.15632 > > > > Percentage improvement > > 5.61570422 5.473437399 3.643388159 1.172472933 > > > > NB the reason the improvement goes down with the number of queues is because > > we're saving malloc overhead in the queue, but a constant number of tasks are > > posted across N queues. This means the more queues we have in this test, the > > less loaded the queues are individually. > > > > Change-Id: I975d7f864dc55715fb9f949ef65321da93e4cef4 > > Reviewed-on: https://chromium-review.googlesource.com/1169043 > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#582586} > > TBR=skyostil@chromium.org,alexclarke@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: Id8290646dba1dcea9fcf92d490b9ce4ac63ae702 > Reviewed-on: https://chromium-review.googlesource.com/1177561 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584314} TBR=skyostil@chromium.org,alexclarke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia3931cc50bc18fda4df3f385927498728c7a2e8f Reviewed-on: https://chromium-review.googlesource.com/1254301Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#595772}
-
Mikel Astiz authored
This is part of a patch series where we leverage the recently introduced layer that allows integrating legacy SyncableService implementations within the newest architecture, USS. This requires forking custom controllers because a different class hierarchy is used. Bug: 870624 Change-Id: I0931243109eef8f757692c5a932f03004f8ce039 Reviewed-on: https://chromium-review.googlesource.com/1254211 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#595771}
-
Gauthier Ambard authored
The toolbar model is only used by the location bar. It is called toolbar model to because of the components code. It has nothing to do with the ios/chrome/browser/ui/toolbar. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3161f3bb47ec16e21331266a4e1a2bcfa091b325 Reviewed-on: https://chromium-review.googlesource.com/1246164Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#595770}
-
Mark Cogan authored
Bug: 884724 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I53368d4beeb536695e2190f0fdebf64f4198c6a4 Reviewed-on: https://chromium-review.googlesource.com/1251545 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#595769}
-
Gauthier Ambard authored
This CL removes the method allowing the web controller to decide if the location bar needs to display the hint text or not. It keeps the SetShouldShowHintText in the LocationBar for now as I don't know the code well enough to remove all of it. Bug: 374984, 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3612e999ac7648620db958e0f6913727f3f64c80 Reviewed-on: https://chromium-review.googlesource.com/1245364 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
stkhapugin@chromium.org authored
Moves the shortcuts experiment flag from iOS-only list to omnibox flags, and disables ZeroSuggest provider when it's on. Bug: 884687 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iaa709a78b0ae0a5862edec457ec0f2555e45dced Reviewed-on: https://chromium-review.googlesource.com/1233454Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Kouhei Ueno authored
Bug: 890180 Change-Id: I3cedfd4b03b534eabeb9573c226123bd3d70068e Reviewed-on: https://chromium-review.googlesource.com/1250686Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#595766}
-
Daniel Bratell authored
In jumbo builds a whole build target can compile together and share the same anonymous namespace. Then two methods with the same name and arguments will clash which happens in chrome/common. This resolves that clash twice over by giving one GetInfo a longer name and inlining the other one since it was only used once in a one line function. Bug: 890323 Change-Id: Icbb1d768bdf9c1385f35bebd54d0d008e4be49d9 Reviewed-on: https://chromium-review.googlesource.com/1251603Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#595765}
-
Marc Treib authored
PersonalDataManager.addServerCreditCardForTest adds a server credit card directly to PDM's cache, without going through Sync. That creates an inconsistent state, which makes the tests fragile to unrelated changes (e.g. https://crrev.com/c/1251041). Instead, this CL uses FakeServer::SetWalletData, which needed to be plumbed through to Java. Bug: 889941 Change-Id: Ie70a2f8ca311d36267c9aa16dca9363b60b4ee2c Reviewed-on: https://chromium-review.googlesource.com/1255062Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#595764}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9fe56ff9c6f8..674c0aa15399 Created with: gclient setdep -r src-internal@674c0aa15399 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I519019be1efa6e3a1934e55f494ac1879aa2b238 Reviewed-on: https://chromium-review.googlesource.com/1256076Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595763}
-
Henrik Boström authored
Adds destructor traits to ensure WebRtcMediaStreamTrackAdapter, which is reference counted, is destroyed on the main thread. Due to references in base::Bind-ings, possibly from third_party/webrtc or elsewhere, destruction did not always occur on the main thread. The mix of reference counting and usage on multiple threads is just inherently risky. This change allows us to add a DCHECK in the destructor and fixes one of the most common crashes currently in Canary. Bug: 888460 Change-Id: I30948f1ade16769bfc3c94a6a2893df7c56c8d5a Reviewed-on: https://chromium-review.googlesource.com/1254206Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#595762}
-
Sergio Villar Senin authored
Users of ProfileOAuth2TokenService should use instead the IdentityManager API so that they could eventually use the identity service. Bug: 887245 Change-Id: I2ac628d92759488530ee699d438dea920b8b6a9b Reviewed-on: https://chromium-review.googlesource.com/1245784 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#595761}
-
Tetsui Ohkubo authored
This CL fixes two issues related to UserChooserView in UnifiedSystemTray. * Ensure the UnifiedSystemTray bubble is expanded before showing UserChooserView. * Show error messages when number of added users reaches the limit. BUG=890720,890722 TEST=manual Change-Id: I2ea7c807da18e165f66345e50b9c6cf39e954840 Reviewed-on: https://chromium-review.googlesource.com/1255745Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#595760}
-
Miyoung Shin authored
This CL reimplements to use one CF_HDROP clipboard format having series of file path's strings instead of series of CF_HDROP having a file path string to get multiple file paths correctly for dragging. BUG=878690 Change-Id: I167e93f6411f866cb143b910b1fc7d4896481ffc Reviewed-on: https://chromium-review.googlesource.com/1195176Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595759}
-
Morten Stenshorne authored
AbsoluteContentBox() used to cast directly from float to int, and if the float value was sufficiently large, we'd end up with a negative integer value. Changed the two former callsites to using PhysicalContentBoxRect() + LocalToAbsolute() instead. AbsoluteContentBoxOffset() was unused. Bug: 888510 Change-Id: Id1447973f23cabf40a45180aa95a69ba402688c6 Reviewed-on: https://chromium-review.googlesource.com/1245782Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#595758}
-
Kent Tamura authored
security_context.h is used in 2,700+ compilation units. crrev.com/594074 increased its pre-processed size by 1.32MB, and this CL fixes it. Bug: 242216, 888668 Change-Id: I623ad22e5351328f934a0b1cd7caece6b4b07944 Reviewed-on: https://chromium-review.googlesource.com/1256470Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#595757}
-
Mitsuru Oshima authored
ui/views dependency will be addressed as a part of crbug.com/890403 Bug: b/116028711 Test: Tested using following apps with and without chrome caption, in windowed, maximized, fullscreen using Japanese IME. hangout, hangout inline reply (in notification), Google play, FB chatheads I couldn't test with Docs due to b/116855183 Change-Id: Ie371f44286ca0e42e6f0a7f4bb40c9e19e2717da Reviewed-on: https://chromium-review.googlesource.com/1252012Reviewed-by:
Elijah Taylor <elijahtaylor@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#595756}
-
Manuel Rego Casasnovas authored
r595201 fixed how overflow is clipped in paint containment, there were two tests failing because of that so we can now unskip them. TBR=eae@chromium.org,vmpstr@chromium.org BUG=882322 Change-Id: I029cad3f873f90894bd66a531aee2e2e94b62eb0 Reviewed-on: https://chromium-review.googlesource.com/1256682 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#595755}
-
Stephane Zermatten authored
With this change, Autofill Assistant only runs when the feature is enabled and the Intent contains: org.chromium.chrome.browser.autofill_assistant.ENABLED. Bug: 806868 Change-Id: I6bc81181b9f16a2d13e56ff657c6bd9076621808 Reviewed-on: https://chromium-review.googlesource.com/1254281 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595754}
-
Ramin Halavati authored
kMediaDeviceIdSalt is removed from incognito persistent preferences list. After this CL, the changes to this preference in incognito mode are not written to user profile. Bug: 861722 Change-Id: If9328b582523573fb0f9cbcc7dbe89ff8b36c8b4 TBR: perkj@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1255525 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#595753}
-
Christopher Cameron authored
In theory, views::Widget::ReparentNativeView and views::Widget::InitParams allow specifying any NSView* as the parent of a views::Widget. The only parent ever actually specified in production is the NSView* corresponding to the root views::View of another views::Widget. Add a CHECK to verify that this is the case. If the CHECK is not hit, then we remove this functionality. Continue to allow testing of this path (for now) by disabling this CHECK via a static method. Bug: 859152 Change-Id: I70a9a22352e22b1949d37c86c36388ed5380316b Reviewed-on: https://chromium-review.googlesource.com/1255863 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#595752}
-
Christopher Cameron authored
The NSView hierarchy for most windows is - BridgedNativeWidget - WebContentsView (*) - RenderWidgetHostView This patch adds a cross-process interface for WebContentsView. This interface created via the NSViewBridgeFactory interface, using the new mojo method CreateWebContentsNSViewBridge. Add the mojo interface content::mojom::WebContentsNSViewBridge and content::mojom::WebContentsNSViewClient. - The interface that is exposed is motivated by the native Cocoa calls made by views::NativeViewHostMac (which are targeting the WebContentsViewCocoa). - Note that this interface is public (unlike RenderWidgetHostNSView) because it doesn't have any content-private dependencies. Add methods to the C++ interface ui::ViewsHostableView (which is implemented by WebContentsViewMac), to perform all of the functions currently done by Cocoa calls on WebContentsViewCocoa. Add the class content::WebContentsNSViewBridge, which implements the new mojo interface. - This performs the same Cocoa calls that are done in the browswer process. - Note that this class does not instantiate WebContentsViewCocoa (the NSView sub-class used by WebContents), rather, it uses a vanilla NSView. This may change in the future, if need be. - Note that this NSView is in addition to the WebContentsViewCocoa created in the browser process (not in place of it). Update RenderWidgetHostMac::MigrateNSViewBridge to take the arguments that content::WebContentsViewMac will send it. Bug: 821651 Change-Id: Ic1dd5c469a8dab32837cdf23cdda34d24d6240cb Reviewed-on: https://chromium-review.googlesource.com/1253095 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595751}
-
David Jean authored
- Resize on rotation. - Disable scrolling of table when active. Bug: 889012,889506, 889461 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I54d4f41d31a0fb3ec7e248a3cb25bb985e58cf72 Reviewed-on: https://chromium-review.googlesource.com/1249483 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#595750}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/421d954080fe..9fe56ff9c6f8 Created with: gclient setdep -r src-internal@9fe56ff9c6f8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I211ebf858b183eefe6dd0830ee82ebdffa50ccef Reviewed-on: https://chromium-review.googlesource.com/1256074Reviewed-by:
-
Alice Boxhall authored
Previously, ChildrenChanged() was being called while layout was in-progress, potentially causing crashes as certain AXObject attributes require walking the flattened DOM tree. This change instead queues up changes which would trigger ChildrenChanged() calls, and processes all updates to the accessibility tree after layout is complete. Change-Id: Ifd99b31a229cbabd48bfa6515951d0aba32c1cc6 Reviewed-on: https://chromium-review.googlesource.com/1239296 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#595748}
-
Noel Gordon authored
The QuickView text <webview> provides no signal that it is loaded, but it does have a src attribute. That can used as a proxy for loaded, and help make a test that is robust (to load / script timing) on the bots. - make the text <webview> selector precise (.text-content class) - change the text scroll test to check the webview src attribute is non-empty before proceeding. - change to use scrollBy, and send incremental scrolls until the the scroll limit is reached [1]. [1] if the bot misses or drops a JS scrollBy request, no problem: just ask for it again. Bug: 891150 Change-Id: I0bb49c2b08b3535172819a3c1088fca5ba6fda94 Reviewed-on: https://chromium-review.googlesource.com/1256469Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#595747}
-
Christopher Cameron authored
Add integer handles for NSViews that may be created in the app shim process. This includes the BridgedNativeWidget content view and soon will include the WebContentsView. A handle is not added for RenderWidgetHostView because there are no planned methods that would use it. These handles will be needed for methods that require interactions between NSViews created by different interfaces. Add as an example the method RenderWidgetHostNSViewBridge::SetParentWebContentsNSView. This will allow constructing the NSView hierarchy in the app shim process: - BridgedNativeWidget - WebContentsView (coming in subsequent patches) - RenderWidgetHostView Bug: 821651 Change-Id: I225eb03f122baa9aea770d28e98a44c938943434 Reviewed-on: https://chromium-review.googlesource.com/1253094 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595746}
-
Hsin-Yu Chao authored
Web app selecting echo canceller type to system AEC is behind an experimental origin trial. Removing the flag report from Chrome OS system, so it's easier to control testing for this feature. Bug: 880708 Change-Id: I10f981d2bd27e04a372d12644eae2903521c7ea1 Reviewed-on: https://chromium-review.googlesource.com/1248063 Commit-Queue: Hsinyu Chao <hychao@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#595745}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 76a1ed51. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." 534cd7bb "isXXX methods added to TrustedTypePolicyFactory" a9d61b8e "Implement RTCIceTransport.onselectedcandidatepairchange" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25747 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Icf4d4ab700f254867844a14a518b4859326adea7 Reviewed-on: https://chromium-review.googlesource.com/1256366 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595744}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4b7de4a5..573561bf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iece2651aa1d1ff01e4a211dc5477445ae0b5a007 Reviewed-on: https://chromium-review.googlesource.com/1256602Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595743}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: If9c1c2e59ed0f603be7a84a508bebd7d12566f8b Reviewed-on: https://chromium-review.googlesource.com/1256075Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595742}
-
Jinho Bang authored
This reverts commit 941c32aa. Reason for revert: <INSERT REASONING HERE> Original change's description: > PaymentRequest: Fix a memory leak in retry() > > In the current implementation, memory leaks occur becuase the internal > view_stack_ for payment sheet grows incrementally whenver calling > retry(). So, this patch uses GoBackToPaymentSheet() instead of > ShowInitialPaymentSheet() in RetryDialog(). The method has a logic to > reduce stack's size internally. > > Bug: 861704 > Change-Id: I2cb94772485165d1fa96463f16f39edf20ccf7bc > Reviewed-on: https://chromium-review.googlesource.com/1255082 > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Jinho Bang <jinho.bang@samsung.com> > Cr-Commit-Position: refs/heads/master@{#595644} TBR=rouslan@chromium.org,jinho.bang@samsung.com Change-Id: Ibf67fa672afee9b3da73b6fb22f325641b011186 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 861704 Reviewed-on: https://chromium-review.googlesource.com/1256394Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#595741}
-
Mikel Astiz authored
We add integration test coverage for PREFERENCES under pseudo-USS, and factor out some duplicated code to a newly introduced FeatureToggler, a helper class to run tests with a feature switch enabled and disabled. Bug: 870624 Change-Id: I6b1b446439969d5c6e948e21ca160876e14c5cdb Reviewed-on: https://chromium-review.googlesource.com/1253762 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#595740}
-
Xi Cheng authored
Bug: 851163 Change-Id: Ie02bf11865d1f84254d14723dfd55e26c1987609 Reviewed-on: https://chromium-review.googlesource.com/1256012 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Chih-Yu Huang authored
In CL:1195175 we change the formula for Vaapi VEA. However, the formula still failed at small resolution. According to the investigation at crbug.com/889739 comment 1 and 2, using the fixed buffer size might be the choice before we can update the buffer size when the bitrate and framerate are changed. Also, Because this function is general for Vaapi VEA and V4L2 VEA, we move it to gpu_video_accelerator_util. BUG=b:113309237 BUG=chromium:889739 TEST=pass VideoEncoderTest CTS on eve and scarlet device TEST=pass RTC lookback on eve at H264 HD TEST=pass VEA unittest on eve Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0aa6fd8b67c19ad93bae6e62430105dc9ccf6a80 Reviewed-on: https://chromium-review.googlesource.com/1253315 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#595738}
-
Steve Anton authored
This reverts commit a9d61b8e. Reason for revert: flaky test Original change's description: > Implement RTCIceTransport.onselectedcandidatepairchange > > Bug: 864871 > Change-Id: I710b18f8644be51d08b33b9852c00f4fbacec286 > Reviewed-on: https://chromium-review.googlesource.com/1208961 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Henrik Boström <hbos@chromium.org> > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Commit-Queue: Steve Anton <steveanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595700} TBR=dcheng@chromium.org,hta@chromium.org,haraken@chromium.org,hbos@chromium.org,steveanton@chromium.org Change-Id: I946ade2587e49b3273d9dd303a3e383e8f5f16a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864871 Reviewed-on: https://chromium-review.googlesource.com/1256622Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/40b52f789661..ee216640ddcc git log 40b52f789661..ee216640ddcc --date=short --no-merges --format='%ad %ae %s' 2018-10-02 buildbot@webrtc.org Roll chromium_revision 7d2cf7c4..81efb6d0 (595610:595716) Created with: gclient setdep -r src/third_party/webrtc@ee216640ddcc The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7f6f9edbe610f5d0f71de33a62a81695ed8a7a7e Reviewed-on: https://chromium-review.googlesource.com/1256227Reviewed-by:
-
Mikel Astiz authored
We leverage the recently introduced layer that allows integrating legacy SyncableService implementations within the newest architecture, USS. This requires forking the custom controller, because a different class hierarchy is used. The new codepath is behind feature toggle kSyncPseudoUSSHistoryDeleteDirectives. Bug: 870624 Change-Id: Ief8fb0d5f5d0472aeea1e0edf42e905632bc33fb Reviewed-on: https://chromium-review.googlesource.com/1251262Reviewed-by:
-
Sammie Quon authored
The crash stack shows OnGridEmpty being called because of WindowDestroyed while overview is shutting down because of leaving tablet mode. The feedbacks report say this is play store related, but i have been unable to reproduce. This cl introduces a early exit in OnGridEmpty if overview is currently shutting down. The cause seems like play store is getting destroyed while in overview tablet and perhaps causing a race condition, but we should prevent overview from crashing if play store closes its window unexpectedly. Test: none Bug: 881089 Change-Id: I8e8daceb53d2ac56f92662b14d33fd86979dff25 Reviewed-on: https://chromium-review.googlesource.com/1256168Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#595734}
-
Noel Gordon authored
Add sendBrowserTestCommand that expects a 'string' result: this helper retries until a 'string' result is received, and logs errors. Update sendTestMessage docs (change message -> command) and update the test extension harness to use sendBrowserTestCommand. Bug: 891148 Change-Id: I5840668919672e68787eccd8dece3eae5f2d8c45 Reviewed-on: https://chromium-review.googlesource.com/1256482Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#595733}
-
