- 28 Mar, 2019 40 commits
-
-
Patrick Monette authored
A recent change made it so that only modules loaded in certain process types are considered for both the IncompatibleApplicationsUpdater and ModuleBlacklistCacheUpdater, but the tests were not updated. Bug: 946999 Change-Id: I522f7bbf00eb239de59a9e7401f74a6183f35d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542427Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#645345}
-
David Grogan authored
I don't foresee us fixing this until NG. This is a test only, no behavior change. Bug: 764031 Change-Id: I9afddd0bf09231d2f0981e75eb70e7ba1828ee58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542305Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#645344}
-
Karolina Soltys authored
Bug: 863341 Change-Id: Id113dae0e511e6a2d2c89ae29d5a92abdc23d5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543393Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#645343}
-
Michael Thiessen authored
Bug: 942577 Change-Id: I61985da174bda2dd1dfa35b971b7738b7aaaeef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543452 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#645342}
-
Ella Ge authored
This reverts commit edae7679. Reason for revert: suspect CL is reverted, don't need to disable anymore Original change's description: > Disable 3 AuraWindowVideoCaptureDeviceBrowserTest on Linux > > Test failing skia_renderer_content_browsertests on linux bot > https://ci.chromium.org/p/chromium/builders/ci/linux-xenial-rel/7843 > > Tbr: sergeyu@chromium.org > Bug: 947043 > Change-Id: Id014029fa3495c521be170a5040f086a21c6b9b4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543461 > Reviewed-by: Ella Ge <eirage@chromium.org> > Commit-Queue: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#645335} TBR=eirage@chromium.org Change-Id: I3c50ef020a09db385252e6e9e4c717655ae83eb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 947043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543467Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#645341}
-
Céline O'Neil authored
Bitmaps allocated for TileDrawQuads cannot be located by the SoftwareRenderer when the time came to DrawAndSwap. This is caused by two issues: 1. The message queue is not flushed before drawing, leading to an attempt at drawing bitmaps before they are allocated. 2. The bitmaps are allocated by a different SharedBitmapManager than is accessed by the renderer. This CL fixes both of these issues. The contents of TileDrawQuad resources are now actually drawn to the output surface. R=kylechar@chromium.org, riajiang@chromium.org Bug: 923088 Change-Id: Ia835dcc139f1e9b8e7803203d5c8296ae695a3a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542153Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Céline O'Neil <celineo@google.com> Cr-Commit-Position: refs/heads/master@{#645340}
-
Nektarios Paisios authored
Previously if an assertion failed in an accessibility specific web test such as assert_equals(accessibilityObject1, accessibilityObject2) the output would look like Expected object "object object" but got object "object object". Now the output looks like Expected object "StaticText: Hello" but got object "InlineTextBox: Hello2". R=dmazzoni@chromium.org, kinuko@chromium.org, haraken@chromium.org Tested: By changing one of the assertions in a web test to the wrong expectation Change-Id: Id4d4e47b4c7ed0c067819c28d791d2e473ab5883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542050 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#645339}
-
Ella Ge authored
This reverts commit e60e1e6e. Reason for revert: MediaNotificationBackgroundTest.BoundsSanityCheck MediaNotificationViewTest.UpdateArtworkFromItem failure on Linux ChromiumOS MSan Tests bot: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/12036 Original change's description: > [Media Notification] Derive background color from artwork > > The media notification should derive its background > color from prominent colors in the artwork. This > uses as similar algorithm from Android. > > Also breaks out some of the logic of CalculateProminentColors > so we can use it without the reset of the function. This > is because we want uninteresting colors and do not want > the color profile matching. > > BUG=944598 > > Change-Id: I60df7f600f6fc881dfb38d2057c903a5679845df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534923 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644985} TBR=sadrul@chromium.org,estade@chromium.org,beccahughes@chromium.org,steimel@chromium.org Change-Id: Ie18b564a68ffdf2560492eb1e7cf53c59447ea54 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543464Reviewed-by:
-
Nektarios Paisios authored
Affinity is retrieved from the frame selection, i.e. from the currently visible selection. Text fields don't expose their affinity in Javascript, so it doesn't make sense to cache its value so that it could be retrieved when the text field is not focused. Any time the text field is not focused, we return a cached selection that has a downstream affinity. R=dmazzoni@chromium.org, yosin@chromium.org Bug: 639340 Change-Id: If488edc29cd72e9835c7120466ea8dfa01d5841d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535051Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/78a282f49b55..edf562397eed git log 78a282f49b55..edf562397eed --date=short --no-merges --format='%ad %ae %s' 2019-03-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/skia@edf562397eed The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I1b5d8bb41a9c4fa5fbf2b7a8372f9fbdc36c46a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541742Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645336}
-
Ella Ge authored
Test failing skia_renderer_content_browsertests on linux bot https://ci.chromium.org/p/chromium/builders/ci/linux-xenial-rel/7843 Tbr: sergeyu@chromium.org Bug: 947043 Change-Id: Id014029fa3495c521be170a5040f086a21c6b9b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543461Reviewed-by:
-
Matthew Jones authored
This patch adds the basic framework for modal dialogs on touchless devices. This patch adds a custom presenter and several properties specifically for touchless devices. The main addition to the dialog is the list of options that the user can select (instead of the usual buttons). The presenter is created and used by the NoTouchActivity. Bug: 944512 Change-Id: I7a9a9e864b2cce5f76e57beb984f3cdf80558e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534185Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#645334}
-
Noel Gordon authored
Flakes as [ Crash Timeoout Pass ] in Release. Tbr: findit@ No-try: true No-presubmit: true Bug: 946713 Change-Id: I736e981938e7329c6e5e3f30eb45b6ceed9bae2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543374Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#645333}
-
Lukasz Anforowicz authored
Bug: 945621 Bug: 945894 Bug: 945901 Bug: 946069 Bug: 946141 Change-Id: Icf70ae575e75f32bbd5cae614bf9039679c23694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539865Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#645332}
-
Peter Beverloo authored
R=peconn, mvanouwerkerk Change-Id: I133b381279d1765fe86026089c3c6d91bf7a0df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543509Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#645331}
-
Ella Ge authored
This reverts commit 51d085f8. Reason for revert: AutofillCacheReplayerDeathTest unit_test filing on multiple builder: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/41018 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/89733 Original change's description: > Made a cache replayer that allows replaying cached Autofill Query requests. > > Query requests can have a different request signature between version A and B, we want to serve the same response cached at the moment of capture. The > replayer generates a cache-lookup key that is likely to remain stable across > versions. > > The cache replayer reuses the WPR capture file. There is no need for extra test > artifacts. > > Bug: 945929 > Change-Id: I504a407265a4b1d8e62dfbaf3135a8abbd1fdac2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531574 > Commit-Queue: Vincent Boisselle <vincb@chromium.org> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#645298} TBR=dvadym@chromium.org,ftirelo@chromium.org,uwyiming@google.com,vincb@chromium.org Change-Id: Icc8cad1ae5176ad0470288aedbe6f515ae5a8473 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 945929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542970Reviewed-by:
-
Morten Stenshorne authored
Use SetForceReattachLayoutTree() instead. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I47811d822eafeac54fecc6aaecc275ce0c0e4954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541792Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#645329}
-
Noel Gordon authored
Crash Timeout Pass on Release bots. Tbr: findit@ No-try: true No-presubmit: true Bug: 946712 Change-Id: I352415197750005c3fe75938793f8ef3db217241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543472Reviewed-by:
-
Gang Wu authored
Feed should report NotSynthetic instead of Nonsynthetic. Bug: 943833 Change-Id: I851d7e2c7f604812466ff1df61e1cb2d4bf518e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542961Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#645327}
-
Rune Lillesveen authored
EnsureComputedStyle will force a ComputedStyle in display:none, but the bounding rect checked further down will be empty. Change-Id: Id92ea806ca445879149117c2b3e8f916edeb0949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536177Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#645326}
-
Guido Urdaneta authored
This reverts commit 3d8e2c2a. Reason for revert: This was merged and reverted in M74. I broke the M74 build due to a missing #include. Reverting with the purpose of adding the #include and relanding, to make it easier to merge to M74. Original change's description: > [AudioOutputDevices] Check frame before checking device authorization. > > This attempts to address an unusual crash involving WebLocalFrame and > SetSinkIdResolver. > This CL also removes a timer to fire an asynchronous task and uses > a per-frame task runner instead. > > Bug: 941380 > Change-Id: I9acf17ca3fd7d3dd8253b4e278adf583f4205f85 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524267 > Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641563} TBR=guidou@chromium.org,marinaciocea@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 941380 Change-Id: I4e035766f4236049b8158c3d2ae5271c7671adb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543264Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#645325}
-
David Dorwin authored
KeyframeEffect is controlled by RuntimeEnabled=WebAnimationsAPI not the AnimationWorklet origin trial. KeyframeEffect was added along with the fix for https://crbug.com/903953, but the fix does not work because of https://crbug.com/946246. This issue was hidden by https://crbug.com/946599. Bug: 903953 Change-Id: I6fc28b4434057fabe974991b4a696f976c58fa43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542456Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#645324}
-
Noel Gordon authored
Flakes with [ Timeout Pass Crash ] in Release. Tbr: findit@ No-try: true No-presubmit: true Bug: 946711 Change-Id: I2f1472f3b39d0ecca7e218f49d4bac30b19f3ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543471Reviewed-by:
-
Lukasz Anforowicz authored
Requests using HTTP methods other than GET (e.g. OPTIONS used for CORS preflight or POST used for form submissions) do not need to report warning messages about CORB, because: - For XHR/fetch the *CORS* message should be sufficient - If no-cors mode was forced for XHR/fetch, then the response is opaque and therefore CORB warning message is not needed - Other subresource requests (e.g. for img or script) tag should only use the GET method. Bug: 945767 Change-Id: I9302362aabe407d2bc3cae305e59be0f64f2cb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539206 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#645322}
-
James Cook authored
When disconnecting an external monitor the display manager shuts down the associated RootWindowController, but defers deletion of the RootWindowController via a posted task. This means an ash::Shelf can exist without a ShelfWidget. A similar code path exists for entering tablet mode, which turns on display mirroring, and shuts down the RootWindowController for the external display. If there's a pending task that changes session state (for example, the user's sign-in completes), then SessionController observers can fire and attempt to update the alignment of the shelf. Add null checks to ash::Shelf for shelf_widget_. I think we used to have these many years ago, and I think I removed them in 2016 when when cleaning up ash::Shelf. Sadly, they are still needed. Bug: 937495, 738011 Test: ash_unittests Change-Id: I794c610ba1f56483dae49f49e6d955ccf15ce10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542572Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#645321}
-
Etienne Pierre-doray authored
This is a reland of 6ddc0ac9 Reason for revert was: Indirect-leak in base::internal::VectorBuffer The leak was caused by unmatched AddRef/Release when IsEmpty become false when the last task is executed (see TaskSchedulerImplTest::NoLeakWhenPostingNestedTask). This was fixed by changing the requirement for AddRef/Release: - Before this was triggered by a change on IsEmpty(). - Now, this is triggered by a change on NeedsWorker(). In addition, a potential bug was fixed in DidRunTask by avoiding member access after ReleaseTaskRunner. Original change's description: > [TaskScheduler]: Refactor TaskRunner ownership cycle. > > This CL takes Task out of the reference loop, so that TaskSource > refers to its TaskRunner directly. Task can be replaced by PendingTask > as a result (will be done as a follow-up). > A TaskRunner reference is cleared when the TaskSource becomes empty > and set by the caller when pushing a task to a Sequence. > > > Change-Id: I9ffeca51d392ba286494ef85bac9697da48b893d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506769 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#643019} Bug: 945087 Change-Id: I82753eab504b624ef34554faa484c5e7a980ca8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541659 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#645320}
-
danakj authored
These messages are only used by web_test/blink_test_{controller,runner}. So move them into common/web_test, to indicate they are for tests not content shell. Also give them their own target so that test_runner can be made to use them, since they are only for tests. I believe this would let us move BlinkTestRunner into test_runner, and remove WebTestDelegate interface out of content/shell/renderer. R=avi@chromium.org TBR=inferno Bug: 866140 Change-Id: I4e397f3bb2b3ae834f62f429761edc184d16151f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525181 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#645319}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e810ad90799c..2e5afde1d68b git log e810ad90799c..2e5afde1d68b --date=short --no-merges --format='%ad %ae %s' 2019-03-28 jmadill@chromium.org Add suppressions for Mac dEQP [Part 3]. Created with: gclient setdep -r src/third_party/angle@2e5afde1d68b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org Change-Id: I90bb6e2d37fada186138819a2a7539baeabc7a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541744Reviewed-by:
-
Noel Gordon authored
Now has graduated to a timeout on release, and a crash at times. Tbr: findit@ No-try: true No-presubmit: true Bug: 946710 Change-Id: Iaeed92e95d7399642cb74e000024cda73d1b19b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543373Reviewed-by:
-
danakj authored
R=dcheng@chromium.org Bug: 939262 Change-Id: I50dde139f30df747f622402315c927b6f9e69fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542230Reviewed-by:
-
danakj authored
They are disabled on android forcing us to keep a whole heap of legacy code around that is not even understandable at this point (the whole CompositeAndReadbackAsync() path). In order to remove this old code, which is also dead when Android layout tests aren't running, turn the new mode on always. If pixel-based Android layout tests are wanted to run, they should resolve whatever is busted for them in the new path rather than keeping a whole other compositing mode around just for them. I will follow up with CLs to remove the flag once this proof of concept lands, and to remove all the dead code in RenderWidget, WebTestSupport, etc. R=piman@chromium.org Bug: 912193 Change-Id: I4bfb14101073ea5086ada901cf618ef1c5d08d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542229Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#645315}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2c0fe38105ea..590a1c7799c9 git log 2c0fe38105ea..590a1c7799c9 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 fmayer@google.com Delete stale comment. 2019-03-28 lalitm@google.com Merge "traced_probes: add caching for process stats to reduce duplicate events" 2019-03-28 lalitm@google.com Merge "trace_processor: add parsing of power rail events" Created with: gclient setdep -r src/third_party/perfetto@590a1c7799c9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I621eb818120c211cf1afa14058d77ce69cd38f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542317Reviewed-by:
-
Ian Kilpatrick authored
This patch splits up resolving different types of lengths (min, max, and content) into their own functions. This has two effects: 1) The functions are now (arguably) easier to follow. All of the preamble logic within ResolveInlineLength/ResolveBlockLength are moved to their respective functions. 2) Slightly faster in the common cases due to less branches. Bug: 635619 Change-Id: I35d305b458f4dfbb25cb6f55c21db2d3361e046e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533385 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#645313}
-
Edwin Joe authored
Currently, Button::SetTooltipText will always call OnTooltipTextChanged even if the new tooltip text is the same as the old one. With this change, it exits early if the new tooltip text doesn't change. This reduces the time spent inside LocationBarView::RefreshContentSettingViews from ~1 - 2.5 ms to ~0.02 - 0.06 ms since it will eventually call Button::SetTooltipText multiple times for eachContentSettingImageView. Bug: 933546 Change-Id: I2051a9eef19faa04898956fc172ac7bc6bc7ca9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515641Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Edwin Joe <ejoe@google.com> Cr-Commit-Position: refs/heads/master@{#645312}
-
Aditya Keerthi authored
The PurgeRendererMemoryWhenBackgrounded (formerly PurgeAndSuspend) feature sends a critical memory pressure signal within 4 minutes of a renderer being backgrounded. This feature was introduced to improved memory usage. Whenever a critical memory pressure signal occurs within a renderer, the font cache is invalidated. This behavior always causes a full layout to occur when the renderer is foregrounded, which would negatively impact tab switch time. This idea is validated by benchmarks collected in the associated bug. The PurgeRendererMemoryWhenBackgrounded was shipped due to its positive impact on memory usage, and font cache invalidation may play a role in the gains. An experiment is being introduced to assess the impact of font cache invalidation when purging. The experiment will only run on desktop clients, to avoid changing behavior during low memory situations (signal sent only on Android). Bug: 939543 Change-Id: Ieb814417d70f2881d0d6ddd61d4a9dc142e0b666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532908Reviewed-by:
-
Mike Wittman authored
The frame that's currently executing can be immediately recorded from the values in the register context, independent of any unwinding. This change separates the initial frame recording from the recording within the native unwinding, which will be required to support restarting native unwinding after v8 unwinding. Also adds comments documenting the overall structure of the frame unwind algorithm. Bug: 909957 Change-Id: I981fe7c7c8b6019d8fc34dcdb08c22ec744b08ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540314 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#645310}
-
Pavel Shmakov authored
CustomTabActivityTabController Extracting CustomTabNavigationController will consist of (at least) two steps: - Extracting navigate() method - Extracting back/close navigation This CL is the first step. Currently the url navigation code is in CustomTabActivityTabController#loadUrlInTab. In addition to exposing this public method, the TabController also calls it itself to load the initial url when the tab is ready. Both of these things are not good from single responsibility perspective, and need a separate class each. To achieve that it became necessary to expose the way the initial tab was created and update the Observer interface correspondingly. To keep things tidy, holding onto the Tab, the creation method, and observer management was extracted into CustomTabActivityTabProvider (this is something we were planning to do eventually anyway). In this CL the code becomes structured as follows: TabController - minds the tab creation and initialization business, no longer navigates to any urls. Updates TabProvider (via package-local methods). TabProvider - hold the current tab and information about how the initial tab was created. Dispatches changes to observers. Typically, the features should only need to use TabProvider, but not TabController. NavigationController - navigates to urls. Will also contain back/close navigation in future. InitialPageLoader - observes TabController and commands NavigationController to navigate to the initial url. Bug: 916528 Change-Id: Ic26ef955ab8e3e0bd926461c71ef740361686f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530884 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#645309}
-
Ehsan Karamad authored
Removing unused methods and includes. TBR=wjmaclean@chromium.org Bug: None Change-Id: I2464652110bfa2fd9a2749d48c9ddcca5add92b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543449Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#645308}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a82d8927e675..68845f14d6d5 Created with: gclient setdep -r src-internal@68845f14d6d5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: I425976b759b0a07a707b0a73e90abd25b3335475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543121Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645307}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/events, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ifeab051f00cf5846910c14e2aebdb7183fc16646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541550Reviewed-by:
-
