GitLab

This frequently flakes on our Windows Clang ToT bots.

TBR=vabr@chromium.org
BUG=804398

Change-Id: I1d67c8de3df9b6868c9444403bd72aae1bc5fade
Reviewed-on: https://chromium-review.googlesource.com/974283Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544886}

There are ScrollY() and ScrollX() methods, so one would imagine
Scroll(point) is the combination of both. In reality, ScrollY() and
ScrollX() send a message to the js, which moves the viewport and
calls Scroll().

Change-Id: If4e75f537e1d08eb6c7b7095a0a14107cef7b515
Reviewed-on: https://chromium-review.googlesource.com/974169Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544885}

This switch is similar to the existing --wm-window-animations-disabled switch,
which is Aura/Ash-specific, but more tightly scoped and available only on Mac.
This allows tests to disable closure animations for modal dialogs, which take
a few hundred ms each and introduce test flake.

Bug: 817408
Change-Id: Id6d2703d58b25f0efa34085d34f467ad1bf5a912
Reviewed-on: https://chromium-review.googlesource.com/973463
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544884}

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If137f14a5bd9cb23585629710b62e9b018cced96
Reviewed-on: https://chromium-review.googlesource.com/969704
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544883}

ZeroSuggestProvider::OnMostVisitedUrlsAvailable() can be called back
multiple times asynchronously from the respective ::Start() calls.
(TopSites::GetMostVisitedURLs() will happily queue up infinite
requests.) Currently there's only a single state variable protecting
against late replies. This change adds a counter to remember the
last valid request, and adds a test to challenge it.

It also cleans up the inconsistent scoping of the enumerations.

This reland initializes the counter in question, to pass MSAN,
even though it isn't strictly important which value it starts with.

Change-Id: Ie43feffd25c83319e04fc17b32d87e4037a6e7a3
Reviewed-on: https://chromium-review.googlesource.com/973185Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544882}

This patch moves the display zoom state for a display from display
manager to the display's corresponding ManagedDisplayInfo.

Bug: 823922
Change-Id: Ib50e5d62102987900e80a1a866fc29f696e5482b
Component: ManagedDisplayInfo, Display Manager, Display Zoom
Reviewed-on: https://chromium-review.googlesource.com/972428
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544881}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ab2ca46a..8943d0bd

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ib4fa3f68926daac7ab18965292216bebe06e574c
Reviewed-on: https://chromium-review.googlesource.com/974117Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544880}

TBR=afakhry@chromium.org
BUG=735078, 823634
TEST=None

Change-Id: I6351b02d21fd3d64ca0963204f22fdd97910dc4b
Reviewed-on: https://chromium-review.googlesource.com/974293Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544879}

https://chromium.googlesource.com/angle/angle.git/+log/40b1c77070fd..3395c8b96333

$ git log 40b1c7707..3395c8b96 --date=short --no-merges --format='%ad %ae %s'
2018-03-21 cwallez Make infra.cq to point to new Mac configs.
2018-03-21 ynovikov Revert "Skip TransformFeedbackLifetimeTest.DeletedBuffer on Win Intel GL"
2018-03-20 lucferron Vulkan: Support of npot textures

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: I8ffc6d5277866416ccb29112d967d3f0f1c11917
Reviewed-on: https://chromium-review.googlesource.com/974063Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544878}

Chromebooks have an additional hardware button that allows them to
toggle windows fullscreen.  This bypasses the ExclusiveAccessManager,
which is only tied to the normal platform shortcut (e.g. F11).  This
change adds a window observer for Chrome OS to watch for fullscreen
changes outside the ExclusiveAccessManager.

Bug: 809682
Change-Id: I021815dd4aff07bc1b389286d24d85380f380e0e
Reviewed-on: https://chromium-review.googlesource.com/905447
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544877}

Also retires legacy URL for downloading Canary cleaner version.

Bug: 786964
Change-Id: I0026545eee940501f38c6b65a76e03dc2427481a
Reviewed-on: https://chromium-review.googlesource.com/965943Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Veranika Liaukevich <veranika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544876}

https://pdfium.googlesource.com/pdfium.git/+log/36bbc24e2d7e..19a33e4ece99

$ git log 36bbc24e2..19a33e4ec --date=short --no-merges --format='%ad %ae %s'
2018-03-21 hnakashima Rewrite CPDFXFA_DocEnvironment::GetPopupPos.
2018-03-21 thestig Add functions to convert various FPDF_ types.

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:820106


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Icbc4e87948a22899f2b3ae2102629eb5f9402f34
Reviewed-on: https://chromium-review.googlesource.com/974103Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544875}

Since SearchActivityLocationBarLayout built off of LocationBarLayout,
it looked fine on tablets but the URL text/buttons overlap problem still
existed for phone. This is caused by a discrepancy in the LayoutParams
used for calculating the URL bar margin between the different location
bar layouts.

This CL makes #getUrlContainerMarginEnd generic so we can use
LinearLayout.LayoutParams where necessary instead of
FrameLayout.LayoutParams. It also adds #getUrlContainerViewsForMargin,
and puts the onus on LocationBarTablet to override this and provide its
unique set of views to be taken into account for margin calculation.

Tested on tablet and phone, in browser and search widget, no more
overlap (including with voice icon always showing in omnibox on phone)

Bug: 822136
Change-Id: I73915be984d96e5e4613601b5f6b75ef82afff61
Reviewed-on: https://chromium-review.googlesource.com/966597Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544874}

A "MAYBE_" was lost in the shuffle.

BUG=823543
TBR=ellyjones@chromium.org
This missed the https://chromium-review.googlesource.com/c/chromium/src/+/972329 train.

Change-Id: I74a9037f6a8e35350203eae8136f9e9b6295501e
Reviewed-on: https://chromium-review.googlesource.com/974163Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544873}

The API |isScrollInProgress| is defined in ContentViewCore while
scroll-related state handling is spread across GestureListenerManager
and SelectionPopupController.

This CL tidies it up by moving the API to GestureListenerManager,
and making it the main class that takes care of all the scroll stuff.

Bug: 598880
Change-Id: Ib5abdddd361b93b823465b978aabfe9903d7cf68
Reviewed-on: https://chromium-review.googlesource.com/965863Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544872}

VM regions are necessary to symbolize mixed stacks.

Change-Id: I90571853483f33ed448b36fd061e57d8c9c8d7bc
Reviewed-on: https://chromium-review.googlesource.com/969334
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544871}

Previously the function was a static function which didn't know the
current paint offset so was unable to calculate the accurate pixel
snapped border box rect, so used a conservative border box rect which
caused some unnecessary OverflowControlsClip() whose change of
existence was not updated.

Now make it a method of FragmentPaintPropertyTreeBuilder to return
the accurate needs, so the change of needs is covered by existing
SetNeedsPaintPropertyTreeUpdate conditions.

Bug: 823935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I07578033d202af3c996004a88f25711eaac245a2
Reviewed-on: https://chromium-review.googlesource.com/974167Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544870}

Replaces message_center_style::{kActiveButtonColor,kInactiveButtonColor}
with kMenuIconColor and kMenuIconColorDisabled respectively.

Also replaces message_center_style::kActionIconSize with kMenuIconSize.

Bug: None
Change-Id: I52aefb39f9bbeb82d09b746d96f16b820faae0ef
Reviewed-on: https://chromium-review.googlesource.com/973910
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544869}

This signal will be used to implement proactive tab discarding.

Bug: 727353
Change-Id: If4ea5bf5ee93de61d933f87385dc9595900f9cf9
Reviewed-on: https://chromium-review.googlesource.com/973699
Commit-Queue: Varun Mohan <varunmohan@google.com>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544868}

Some autotests require this, such as login_SameSessionTwice.

Bug: 784495
Change-Id: I140aa2824f8a536c85c8f1f7ce5bc8e06748cb55
Reviewed-on: https://chromium-review.googlesource.com/973888
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544867}

cr-shared-style hides any .subpage-arrow or .icon-external that isn't
actionable. Making the paper-icon-button light actionable makes these
icons visible again.

Bug: 821688
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I91b2063530a70efe8a8781f9df888883e4221dde
Reviewed-on: https://chromium-review.googlesource.com/972580Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544866}

Adds a class, WindowedAnalyzer, that maintains the worst
mean, RMS, and SMR values of a metric within a certain
window of time.

The results are updated only by looking at the oldest and
newest samples in the current window, so fixed-point
accumulators are used to avoid accumulation of error.

A client interface is provided that allows the client
to transform the units of the result.

Bug: 807463
Change-Id: Ifdb5729bf59c5479f254c4409f8d2c3d1b6eb996
Reviewed-on: https://chromium-review.googlesource.com/963730
Commit-Queue: Brian Anderson <brianderson@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544865}

Just creating a new BlobDataHandle doesn't actually update the mimetype
of the blob (if later the blob is requested through a blob: URL for
example), so instead actually create a new blob wrapping the existing
blob to properly change the mimetype.

Bug: none
Change-Id: I93b6d584178a02a74d68bdd6fcace1514ca90ec0
Reviewed-on: https://chromium-review.googlesource.com/967271Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544864}

This patch enforces operations over g_instance_count in one
impl thread.

R=caseq, pfeldman

Change-Id: Id0301554d2619280cfb6718ff07d870dfb7d8ac5
Reviewed-on: https://chromium-review.googlesource.com/974076Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544863}

This reverts commit c8f117ce.
This reverts commit c18cd561.

Reason for revert: causes rendering corruption in Android WebView

BUG=823232
TBR=piman@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I56df8c34b7bbf2e80eb818f8ca4595f220dbffd0
Reviewed-on: https://chromium-review.googlesource.com/974064
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544862}

This CL refactors TelemetryLogWriter to use the centralized token getter from
ChromotingClientRuntime. This change gets rid of special handling logic for
authorizing the log writer.

Change-Id: I9ce3481408759b20546801b1f96294f7223b3076
BUG: 780736
Reviewed-on: https://chromium-review.googlesource.com/967520
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544861}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a68d82cb2fde..b3065fb6a19f

$ git log a68d82cb2..b3065fb6a --date=short --no-merges --format='%ad %ae %s'
2018-03-21 tandrii bot_update: don't repack, don't gc in main repo of builder's checkout.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:822437


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I51da70698709b41506098aa74e59301efe3a85a2
Reviewed-on: https://chromium-review.googlesource.com/974126
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544860}

This reverts commit 6f420a45.

Reason for revert: We need rails setting to make swipe left/right for navigation change gesture. User can still scroll to any direction, but more events would restrict to XY rails.

Original change's description:
> Allow any direction scroll on Windows Touchpad
> 
> In this patch, we remove the rails configuration on Direct Manipulation.
> The rails configuration would restrict scroll events on X or Y rails.
> After this changes, user able to scroll to any direction by touchpad as
> touch screen on Windows, Android and touchpad on Edge.
> 
> Bug: 779372
> Change-Id: Idf1da1eb85c2a73f432b78b0002fde28609a4cfe
> Reviewed-on: https://chromium-review.googlesource.com/963043
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543271}

TBR=sky@chromium.org,chaopeng@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 779372
Change-Id: I296a0a1ef3c1a30aaa4d66d5bf24a29932dac543
Reviewed-on: https://chromium-review.googlesource.com/973469Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544859}

The existing flow is not correct, where the decidePolicyForNavigationAction
uses shouldAllowLoadWithNavigationAction to check if it will reject the
request or not before the webstate policy decider, the reason is this
function in some cases return false and launches external applications
without consulting the webstate policyDecider.
the new order guarantees that if the webstate policyDecider rejected the
request, then no external application is going to launch.

Note: There is a todo to move the applaunching code out of that function

Bug: 623016
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I244a497d5c218ecbdd704989ebe5bdc201badcd5
Reviewed-on: https://chromium-review.googlesource.com/973983
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544858}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/6ea47f17c992..1d37d531d536

$ git log 6ea47f17c..1d37d531d --date=short --no-merges --format='%ad %ae %s'
2018-03-16 ayatane Fix moblabvm readme path

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:None


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I19952fda76ae15ed27d42415d1ab47d56ccf6b74
Reviewed-on: https://chromium-review.googlesource.com/974125
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544857}

BUG=823087
TEST=none yet

Change-Id: I5c3c57fb380b2d7ec863d43b2e317f634ed40e5b
Reviewed-on: https://chromium-review.googlesource.com/973899Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544856}

Increases the timeout of the VR instrumentation tests on the VR FYI bot,
as the current amount of time has started flakily timing out due to the
addition of the WebXR tests.

Change-Id: I717c4862782a9089e32944d6f9465f42b602bc9f
Reviewed-on: https://chromium-review.googlesource.com/972195Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544855}

Update the policy documentation and the pref's default value
accordingly.

BUG=511300

Change-Id: I1160474dbe48478d95bfdcdd17017e808b398492
Reviewed-on: https://chromium-review.googlesource.com/968523Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544854}

This test is flaky on the Linux_CFI bot.

TBR=imcheng

Bug: 822337
Change-Id: I65b5eb16c71e43a57dad248deba22b970784f603
Reviewed-on: https://chromium-review.googlesource.com/974162Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544853}

This change:
1) Adds an AppMenuTestApi interface, exposing utility functions for tests to
   use the app menu;
2) Adds implementations of that interface: AppMenuTestApiViews and
   AppMenuTestApiCocoa;
3) Changes the MediaRouterBrowserUITest suite to use AppMenuTestApi instead of
   assuming a Views browser window;
4) Disables MediaRouterUIBrowserTest.OpenDialogWithMediaRouterAction on Mac,
   since it seems to not work (it is already disabled on Win, Linux, and CrOS)

Bug: 817408
Change-Id: I2b977b0c8225a75f2b6298c17832b1b1423dff83
Reviewed-on: https://chromium-review.googlesource.com/968881
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544852}

handle->is_valid() will try to de-reference the handle. This CL changes
->is_valid() to .is_valid() so that the validity check is performed correctly.

Bug: 824144
Change-Id: Ie6f7a5cfa2a7568cdbaceb30e0667d990d1326e3
Reviewed-on: https://chromium-review.googlesource.com/973914Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544851}

This is preparation to move the orientation request protocol
to exo remote shell.

* ash's orientation logic was originally deisnged
for w3c spec, which doesn't have "current" orientation, so it was implemented in
ArcAppWindowLauncherController. I'm moving this to ash so that exo can
implement it without re-implementing it. It'll also make it easy to
test.

* This also moves the logic "apply orientation only in tablet mode" logic
 to ash. I believe this is correct even for html as
ScreenOrientationDelegateChromeos::ScreenOrientationProviderSupported()
returns true only in tablet mode.

* Updated ScreenOrientationControllerTest to switch to tablet mode to
 match the expectation above.

BUG=735078, 823634
TEST=Updated unit tests. See comment above.

Change-Id: Id26ca7e02fd8dcb5396ab05ce61a52c635f6eb54
Reviewed-on: https://chromium-review.googlesource.com/967684
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544850}

TBR=gklassen@chromium.org, jmadill@chromium.org
NOTRY=true

Bug: 824438
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib92b27fe4a418cbb570a565cf3f1213375f35290
Reviewed-on: https://chromium-review.googlesource.com/974174
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544849}

Change-Id: I45bd5319c04220ea2bd9ceb5dbb5568ad9e1b241
Reviewed-on: https://chromium-review.googlesource.com/973896
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544848}

This change enables incognito tab spawning and closing of all incognito
tabs from the new overflow menu.

BUG=817614

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0d5348ad2cbf740259d8cbd77be4437d59c480c4
Reviewed-on: https://chromium-review.googlesource.com/972156
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544847}