- 11 Jul, 2019 40 commits
-
-
Omer Katz authored
Bug: 981043 Change-Id: I405ec5da96e34a5bf5665ea338130976614d8237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697188 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#676589}
-
Malay Keshav authored
Render surface textures have the surface content scale already applied to them when they are generated. Because of this, the surface content scale component of the target draw transform needs to be removed. In the case of a mirror layer, a RenderPassDrawQuad (RPDQ) is used that points to the render surface texture of the mirrored layer. Similar to the RPDQ of the mirrored layer, the RPDQ of the mirror layer also has to have its surface content scale component removed from its target draw transform. However, since this RPDQ points to the render surface texture of the mirrored layer, the inverse surface scale content of the mirrored layer must be applied rather than that of the mirror layer. This patch makes this change. Change-Id: I2696d7af8f62872c623ea6516485671a9341484d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696581Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#676588}
-
Patrick To authored
XRCompositorCommon::MaybeCompositeAndSubmit calls ExitPresent() when SubmitCompositedFrame() fails, which clears pending_frame_. pending_frame_ is accessed below, causing a nullptr exception. Bug: 974406 Change-Id: Iea89aee7c4eb5cb7e1fba57d1f79901de52efb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698669Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#676587}
-
Lei Zhang authored
Change-Id: I5aaf82e84c9429bbbbf142f532db03325c026a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696175 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#676586}
-
Toni Barzic authored
BUG=975460, 974995, 975862, 975448, 975722 Change-Id: I9ffb4e6cca9954ac9435f09d8f800e96eaaea3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698561 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#676585}
-
Anastasia Helfinstein authored
This reverts commit 53c528aa. BUG=983246 TBR=dpapad@chromium.org Change-Id: Id590280240a32ada77d452abedd3478d102be7ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697763Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#676584}
-
Fredrik Söderquist authored
Remove some unused conversion helpers that would otherwise need similar treatment. In the case of ToFloatSize(const DoubleSize&) it was used in one instance but erroneously so, promoting to DoubleSize just so that it could convert back to FloatSize/ScrollOffset again. Bug: 983032 Change-Id: I416f24fc125b447c881edbdebf5d1796483bec85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698507Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#676583}
-
Xiaohui Chen authored
Remove Keyboard.Shortcuts.CrosSearchKeyDelay metrics. It is used for search key related shortcut analysis a while ago. Bug: 975475 Test: locally build and CQ TBR=nikunjb@chromium.org Change-Id: I32e9afc2a556fbc58b45029a3f2d24b5b00ced16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685327 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#676582}
-
Jacques Chen authored
Change-Id: I138af52f02c412448708fda7e535cbb0bd61fff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696999Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jacques Chen <jacqueschen@google.com> Cr-Commit-Position: refs/heads/master@{#676581}
-
Lei Zhang authored
Having GetScreenRect() as a standalone function, separate from PDFiumEngine, makes it easy to test. Add unit tests for GetScreenRect(), and update comments to reflect reality, since the tests show the function does not return empty rectangles. Change-Id: Ibe807c0edd957c61bd4907ed87c3708f7cd21b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696174 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#676580}
-
yilkal authored
Bug: 977019 Change-Id: Ieb42dab51dc15ce636363e6969311762588bcf91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684812 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#676579}
-
Evan Stade authored
Replace with an observer interface on FindTabHelper. This CL also moves some enum types to their own file in order to prevent circular includes. Bug: 268984 Change-Id: I92e8cf64d87d2b45cb421ee8aaa24a55bf360316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691369 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#676578}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4e5a41a08674..66b3860fc95c git log 4e5a41a08674..66b3860fc95c --date=short --no-merges --format='%ad %ae %s' 2019-07-11 orphis@webrtc.org Remove WebRTC-SimulcastScreenshare and enable it by default 2019-07-11 sukhanov@webrtc.org Integrate datagram feedback loop 2019-07-11 yvesg@webrtc.org Let git-hyper-blame ignore new format cleanup. Created with: gclient setdep -r src/third_party/webrtc@66b3860fc95c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I38faf2f89c60aa95c4ca1621554979dda488f644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696912Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676577}
-
Matt Wolenetz authored
Deprecates histograms and removes reporting code for the following which expire in M77 (also updates their owners and updates the expiration for the video metric): Media.DetectedTrackCount.Audio Media.DetectedTrackCount.Text Media.DetectedTrackCount.Video The text metric was added to see if in-band text demuxing for SRC (or MSE) might be motivated based on usage of SRC= media playback; it never showed significant counts. The audio/video track counts were typically as expected (vast majority either 0 or 1 track of each of audio, video). If we wish to later add media element audio mixing (based on dynamically enabled audio tracks at runtime), we may wish to add some audio track mixing metrics, though UKM may be better suited for that purpose. BUG=975315 Change-Id: I7cc208c7860a588d7013ec04d8b46a7d4dea8e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693582Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#676576}
-
Evan Stade authored
Bug: 268984 Change-Id: I0d1a5f3fc18643055fb7f78f44996c93a493132c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698671 Commit-Queue: Evan Stade <estade@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#676575}
-
Peter K. Lee authored
As of 2019-07-02, Manual Translate is enabled on 100% of stable channel for iOS as well. See http://cl/256232225 Bug: 938576 Change-Id: If2e50a5070c3738e83362035d7d218929a7f9950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693506 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Auto-Submit: Peter Lee <pkl@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#676574}
-
Khushal authored
The copy-on-write path with shared images relies on CanvasResource ref-counting to guarantee that the CanvasResourceProvider has exclusive access to the resource before writing to it. This misses a case where read operations on the resource are deferred in skia and get executed when the SkSurface is flushed during the copy-on-write operation itself. Avoid the above by flushing SkSurface before doing the copy-on-write to avoid doing it in the cases above. R=fserb@chromium.org Bug: 981585 Change-Id: I889fa451467b3e39f9d37b09d1782b89c9030410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693942Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#676573}
-
Natalie Chouinard authored
Migrate the Google Assistant in Chrome Settings screen from deprecated framework preferences to the preferences Support Library. Bug: 968592 Change-Id: I899aff6125d5213aac424bae99e74ce09ee90892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696284Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#676572}
-
Victor Costan authored
UI review requested a different string in 2016, and the request regrettably got lost in our bug tracking system. Bug: 638291 Change-Id: I95b9c7dbed47acbd163ced6cdb22f9b101f30a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697761Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#676571}
-
Robert Ma authored
Bug: https://github.com/web-platform-tests/wpt/issues/17749 Fix: https://github.com/web-platform-tests/wpt/pull/17785 This bug would prevent the manifest from updating when local changes are made in the working tree, which severely affects the daily workflow of Blink engineers (bots are not affected). Change-Id: Icf080553a8c8626c10d7973eb21ec4214c889d16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697371Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#676570}
-
Siddhartha S authored
The perfetto tracing config always sets ring buffer mode for perfetto tracing. Check the chrome config and set the right buffer mode. Also fix error from previous CL, which did not remove old code that sets buffer size. https://chromium-review.googlesource.com/1659607. But keep the event limit which is used in legacy backend. Also, add flow events in startup traces which are useful for critical path. Change-Id: Iba5e065aef59c096570d09c40800e806f0334840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696133Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#676569}
-
Matt Wolenetz authored
Removes these two metrics' reporting and deprecates them, per https://bugs.chromium.org/p/chromium/issues/detail?id=975367#c1 This change addresses part of: BUG=975367 Change-Id: Ib5af97117def1f5af3492491329eada591d55c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692978Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#676568}
-
Dale Curtis authored
These are all maintained by the standard media/ team now. BUG=none R=qinmin Change-Id: I0ea040b5a2108d1996042399f8e0cc103aefbd83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698666 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#676567}
-
Chris Davis authored
This change fixes a linker issue to allow is_multi_dll_chrome set to false to build successfully. I also had to change some of the delay load entries based on this flag to prevent crashes in the sandboxed processes that now load chrome.dll instead of chrome_child.dll. This has no change on the default build configuration where this flag is set to true. Bug: 726150 Change-Id: Ia1bd322193ef0883ab3d5746874fb4a124ad6f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697368Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Chris Davis <chrdavis@microsoft.com> Cr-Commit-Position: refs/heads/master@{#676566}
-
Luum Habtemariam authored
This is a reland of ee11d579; which was reverted in 6a82096a. This reland fixes the failing unittests. Original change's description: > PpdProvider non-USB printer log spam fix > > Currently calling ResolveUsbManufacturer for ALL printers that fail ppd > matching; now correctly filtering for usb printers. > > Bug: none > Test: manually confirmed removed log spam > Change-Id: I71b601d496001fc2c1ea14ca1281046f245d1c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696187 > Reviewed-by: Sean Kau <skau@chromium.org> > Commit-Queue: Luum Habtemariam <luum@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676123} Bug: none Change-Id: Ia9b50f5eac54005fb77a742ab92febd9a59e841b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697527Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#676565}
-
Chris Hamilton authored
BUG=950668 Change-Id: I9762c7a08de53ab229ead509c669dd80ef7613de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610091Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#676564}
-
Reilly Grant authored
Ayu has been making substantial contributions to these projects. Change-Id: I52946c8b9be4a96c62c2657c33be401b02489212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698642 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#676563}
-
danakj authored
The TextInputClient IPC messages are handled by a channel filter, which observes all incoming IPCs and does not depend on the routing id, so going through RenderWidget and using its routing id is not needed. The TextInputClient functions (incorrectly but...) while the main frame RenderWidget is frozen. We do not want to have the RenderWidget sending any IPCs while frozen and want to CHECK() that, so move TextInputClient out of the way. Also does some cleanups in the TextInputClientObserver class, and removes it from the build outside of mac since it is not used. R=creis@chromium.org, dcheng@chromium.org Bug: 419087 Change-Id: I6e4c5dbf9af9368dd732a79352984d1dd18bdf6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695809Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#676562}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8db211bc8d28..60e2f11eb584 git log 8db211bc8d28..60e2f11eb584 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 cwallez@chromium.org Rename StaticType's kInstance to instance. 2019-07-11 clemendeng@google.com WGL implemetation for OpenGL tutorial 2019-07-11 syoussefi@chromium.org Vulkan: Prepare for variable-stage pipelines 2019-07-11 lujc@google.com Vulkan: Recycle vkFence 2019-07-11 timvp@google.com Vulkan: Clean up deqp_gles3_test_expectations.txt 2019-07-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 8aa9a7bb8f74..c538b5d796fb (2 commits) 2019-07-11 jiajia.qin@intel.com Fix the RTV and SRV conflict 2019-07-11 shrekshao@google.com Add flags to shader translator to emulate gl_BaseVertex and gl_BaseInstance 2019-07-11 kbr@chromium.org Support blitFramebuffer to and from IOSurface-backed textures. Created with: gclient setdep -r src/third_party/angle@60e2f11eb584 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: chromium:981610,chromium:891861 Change-Id: I13773fcaa987c74812105c8fe116a585d07ac2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697077Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676561}
-
Amin Hassani authored
Use this newer DBus in favor of AttemptUpdate D-Bus. In the future we need to move back to AttemptUpdate after it has been modernized with protobuf. Bug: 982438 Test: tryjob Change-Id: If304a96d5f81ec7291b7f3d1bbc5aa245ab92c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687779Reviewed-by:
Xiaochu Liu <xiaochu@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Amin Hassani <ahassani@chromium.org> Auto-Submit: Amin Hassani <ahassani@chromium.org> Cr-Commit-Position: refs/heads/master@{#676560}
-
Becky Zhou authored
Bug: 951955 Change-Id: I64cce0788cf3d8273f8a7edd0fd163cd35b18c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698663Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#676559}
-
A Olsen authored
User-policies are not available at time of sign-in. Device-policies would not have the desired behavior - This should work for all users at a particular domain, regardless of which device they use. So I have re-introduced the feature flag we had earlier. Always parsing these attributes if the feature flag is enabled is the best way forward - then the results of parsing are discarded later if the policy is disabled for that logged in user. Also hardens parsing JS against bad input. Bug: 930109 Change-Id: I761e35b4eac6c2ead62400440aaa583b7e68626d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692987Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#676558}
-
Jun Cai authored
Currently SMS API listens to timeout events from the JNI android SmsRetriever API. This CL updated SmsReceiverImpl to handle timeout using a OneShotTimer per request so that the API uses the timeout value that the user sets up. Bug: 969130 Change-Id: Ie99c2e1650a5689a2dbd65c0708324b71df97639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682329 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#676557}
-
Matthias Körber authored
Change-Id: Iabd6ee61bfed56dca7c074cd41f835bcd18a74d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631706 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#676556}
-
Nate Fischer authored
No change to production logic. Although writing JavaScript console.log() messages (and related methods) to android logcat is a privacy issue if done in production (see https://crbug.com/905251), it's perfectly fine to do during automated tests, where all the web content is written by chromium contributors. This changes onConsoleMessage() to print the actual text passed to console.log() into logcat, including other attributes (ex. source code file the log message came from). This also changes the behavior to log every console message to logcat, rather than the previous implementation which was gated behind the TRACE variable. This is to help catch JavaScript errors (which also generate console messages). Bug: 983005, 964471 Test: used this patch when investigating another test, verified logs in logcat Change-Id: Ied627d106f6ef9af4b05c67556d62d80c6462b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696908Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#676555}
-
David Bokan authored
Turning on FractionalScrollOffsets allows scroll offsets to have floating point precision. This means scroll into view on an element might land mid-pixel. In the case of this test, the height of the element meant that the scroll offset expectations all changed by 0.5. This CL changes the height of the scrolled-into-view element by 1px to avoid landing on a fractional pixel. This causes the test to pass when the fractional scroll offset flag is turned on as well as keeping it passing until we do. Bug: 414283 Change-Id: I4239c8b424df7343cd671a760327093402826aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697304Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#676554}
-
Madeleine Barowsky authored
This change reduces boilerplate by using a CreateDrawImageInternal method that has default arguments for all variables except PaintImage. It also removes the is_decomposable parameter from CreateMatrix since that was never passed as anything other than true. The GpuImageDecodeCache also caps the image filter quality at kMedium_SkFilterQuality, so this removes kHigh_SkFilterQuality as default. Change-Id: I811e6f17ff83f3100d2c3fee470fc91908594639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695970Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#676553}
-
Eric Stevenson authored
212f516e changed the way R.java files work so that all resources are stored in a base R.java file, but accessed through R.java classes that subclass the base R.java. Currently for synchronized proguard, we combine all of the jars produced by the APK's java_library_impl() step. This dedupes class files, but also requires classes with the same name to be identical. With R.java inheritance, each APK will have a base module R.java with different contents, and Chrome will crash at runtime due to missing resources. We can't just rename the base module name in the various APKs that are part of synchronized proguarding because the subclass R.java files can only be included once, and can only have one direct superclass. Instead of creating a more complex R.java class hierarchy, this CL changes the compile_resources() step of the static library APK to generate a base R.java that contains the resources of both Chrome and Webview. Bug: 901465 Change-Id: Iaa2a05c75cd431b95afe6318da8c7982fffbc242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695699 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#676552}
-
Carlos IL authored
The data from this histogram is currently being used for efforts to change the optionally blockable mixed content UI. Change-Id: I43df2f777e6b96bc7b99615e4eb4f8784c1d7b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692450 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#676551}
-
Danan S authored
Bug: 927957 Change-Id: Ice1b2239f8b8c5444be1c289b41d4fec09f0a3ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692730Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#676550}
-