- 03 Dec, 2019 40 commits
-
-
Mitsuru Oshima authored
Bug: 141898654 Change-Id: If41d13054daf681f1502c3c0c2d35777ba03b261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921207 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#720804}
-
Leon Han authored
Use the following union type instead of 'any' to define NDEFRecordInit#data. " typedef (DOMString or BufferSource or NDEFMessageInit) NDEFRecordDataSource " The spec change: https://github.com/w3c/web-nfc/pull/454 BUG=520391 Change-Id: Ic917be001d5e3502caeea29ff4a3401ff7197298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941083Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#720803}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ca84a4265921..42f2c4bd8176 git log ca84a4265921..42f2c4bd8176 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 fancl@chromium.org Change the docker script to get the user using gcloud 2019-12-03 abennetts@google.com Add gitignore of *_pb2.py to dashboard/dashboard. Created with: gclient setdep -r src/third_party/catapult@42f2c4bd8176 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029242 Tbr: nuskos@google.com Change-Id: I968ed4b928d7ed6b978cf85d628b0ca448cf51de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947819Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720802}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for media::mojom::RemotingDataStreamSender from RemotingSenderTest and CastRemotingSenderTest using Remote. Bug: 955171 Change-Id: I87a63709a4063266897cb8be585eb6ee4e8d89a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941537Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#720801}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8ebac1732c99..bf6b0b251ec0 git log 8ebac1732c99..bf6b0b251ec0 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-02 rosasco@google.com skqp CIPD upload infra for Fuchsia Created with: gclient setdep -r src/third_party/skia@bf6b0b251ec0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I4dcf64d9df859f78db70c5572a3cfbc0ae064e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947818Reviewed-by:
-
Piotr Pawliczek authored
The epson-inkjet-printer-escpr package was upgraded from version 1.6.23 to 1.7.6. BUG=chromium:1026359 TEST=none Change-Id: I5023723bcc49aeb1f0f2e7b21f8c80d8bd093316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928321 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#720799}
-
David Bokan authored
This was previously measured explicitly until https://crrev.com/1226828 merged that metric into the GestureScrollingThreadStatus histogram. At the time, it was expected this was equivalent. However, because multiple main thread reasons can be recorded for a single scroll, there is no way to tell what percentage of scrolls are handled on either thread. This CL adds back this simple metric that measures how many gesture scrolls are handled: - entirely on the compositor thread - on the compositor thread but must block on the main thread for event handlers - on the main thread. Bug: 1025789 Change-Id: Iffd1c67ef9841d6e79ca44ccfa9c76c8b5b9e8be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931104 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#720798}
-
Sean Kau authored
Removing DVLOG statements that were accidentally committed in a previous CL. Bug: None Change-Id: I064fe999dd594af0d3fb9f9c17b9dab442fc44ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947953 Commit-Queue: Sean Kau <skau@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Sean Kau <skau@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for chromeos::machine_learning::mojom::Model using Remote instead of ModelPtr. Bug: 955171 Change-Id: I33e8d7cbb84a51e21345b81fef2c202f17227678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939163Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#720796}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6d31ed5d639e..ba8d15b7d9af git log 6d31ed5d639e..ba8d15b7d9af --date=short --first-parent --format='%ad %ae %s' 2019-12-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@ba8d15b7d9af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I0b8fa436694b8309f99408be805f82412beb1a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947817Reviewed-by:
-
Yuki Shiino authored
Updates the old |CodeNode.upstream| to |upstream_of_scope| due to the distinction between SequenceNode and SymbolScopeNode. Bug: 839389 Change-Id: Ibefe6635030aa111c0ed8a3876abcb7b9ef8062b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946058 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#720794}
-
Tom Anderson authored
R=thestig Change-Id: I3a4d25202b81ab92f4ef551bb5f32595d88d4f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934779 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Leon Han authored
The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. This CL is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. 4. Removes NDEFMessage{Init}#url and old impl of the author record. The spec changes: https://github.com/w3c/web-nfc/pull/338 https://github.com/w3c/web-nfc/pull/340 https://github.com/w3c/web-nfc/pull/446 BUG=520391 Change-Id: Ie6f5b2978f78676c3aa607d09e7ffd5bbb5005d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928891Reviewed-by:François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
-
Eugene But authored
Update expiration date to 2021-01-15 for the following histograms: Download.IOSDownloadPassKitResult Download.IOSDownloadedFileAction Download.IOSDownloadFileInBackground All these metrics are useful for understanding the value of Download Manager feature. Bug: 1029845 Change-Id: Ibc884e27b022d151b7df7619794140184a3a21eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947770 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#720791}
-
Yuki Shiino authored
Introduces a new SequenceNode and replaces existing use cases of SymbolScopeNode with the SequenceNode if appropriate. The implementation of SequenceNode and SymbolScopeNode is incomplete, and the follow-up patches will complete the two classes. Bug: 839389 Change-Id: I6d578ffe94c386757e76764a4d02221ef0847f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946176 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
nancy authored
Update AppServiceProxy when the user is switched because AppServiceProxy is based on profile. Add MultiProfileBrowserStatusMonitor to ChromeLauncherController when kAppServiceInstanceRegistry flag is enabled. BUG=1011235 Change-Id: Id46f72d2334b94f601275560088112180c5bfc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940314 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#720789}
-
Yuki Shiino authored
Renames SequenceNode to ListNode so that we can introduce another SequenceNode that represents a "sequence of C++ code", where SymbolDefinitionNodes can be inserted. We'll have three list-ish code node. - ListNode = a list of CodeNodes, nothing related to C++ code - SequenceNode (new) = a list of C++ code where SymbolDefinitionNodes can be inserted - SymbolScopeNode = a SequenceNode that represents a C++ block (= a scope of C++ variables) Bug: 839389 Change-Id: I9478012b0449e754a953f4f02b2afbaaaaecb5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946175Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 210100a9. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ie73d5926222df8ec5a5dcdc6a77852e90103306e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947665Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720787}
-
Simon Que authored
CI: - chromeos-amd64-generic-asan-rel - chromeos-amd64-generic-cfi-thin-lto-rel - chromeos-amd64-generic-rel - chromeos-amd64-generic-dbg - chromeos-amd64-generic-rel-vm-tests - chromeos-arm-generic-rel - chromeos-arm-generic-dbg - chromeos-kevin-rel - chromeos-kevin-rel-hw-tests Try: - chromeos-amd64-generic-rel - chromeos-amd64-generic-dbg - chromeos-amd64-generic-cfi-thin-lto-rel - chromeos-arm-generic-rel - chromeos-arm-generic-dbg - chromeos-kevin-rel - chromeos-kevin-compile-rel Schedule of migration: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413, 1027312 Change-Id: I2af906a185e2a4be21662178f616860dd8e638ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930272Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#720786}
-
Gavin Williams authored
-This change will resolve the whitelisted users list flickering when adding a new user after OOBE. -The original CL(https://crrev.com/c/1786862) should not have included the call to GetUsersList. It was added because the tests failed which led me to believe it was needed for refreshing the user cache. In actuality the tests needed to be refactored to correct the failing tests. Bug: 1011774 Change-Id: I9fd03a463bd8a6375cf806a22cacaed025904e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940712Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I06d31846c4e7b763994266d9b4c9c2ec854defa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939813 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
shrekshao authored
Turning fboRenderMipmap on for D3D11 in ANGLE. Will remove when that is rolled in. TBR=kbr@chromium.org Bug: 1023747 Change-Id: Ie42feccd285e04bbf7b8177f87802dde64c2bc45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947808Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#720783}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/b8549ed88953..d2a5e26359be $ git log b8549ed88..d2a5e2635 --date=short --no-merges --format='%ad %ae %s' 2019-12-02 jianj Fix SVC regression in webrtc tests. 2019-11-25 venkatarama.avadhani Fix mutex free in multi-thread lpf Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com BUG=1029438 Change-Id: I39ad89f4edfd10a15d09dfb2ec269ebc04d8b3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946463Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#720782}
-
Megan Jablonski authored
Bug: 976352 Change-Id: I8ff40d3ebc74bf78083bfbde02f9c811d5bfa267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935176Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#720781}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for add_supervision::mojom::AddSupervisionHandler from AddSupervisionMetricsRecorderTest using PendingReceiver. Bug: 955171 Change-Id: I4b370ed8e32ad572df553a09cda237df9ea0f738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945950Reviewed-by:
-
Steven Bennetts authored
This provides support for type="chrome_messages_json_gzip" in grit/build.py, which compresses the output files (which should have .gz appended to the name, e.g. messages.json.gz). This makes it fairly simple to convert an extension (e.g. chromevox) to use compressed l10n files. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1913610 For changes reviewed in the original CL: TBR=agrieve@chromium.org TBR=dtseng@chromium.org TBR=rdevlin.cronin@chromium.org Bug: 1023568 Change-Id: I7f83e5de8e339aea2e47b84f3ec701350246b38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947386Reviewed-by:
-
Koji Ishii authored
This patch implements hit-testing text items, that was not implemented in the initial hit-test implementation in r720001 <crrev.com/c/1935773>. The LayoutNG specific logic for |NodeForHitTest()| was moved to |LayoutObject| in r720148 to share the logic with |NGFragmentItem|. 8 failures, ~110 passes. Bug: 982194 Change-Id: I4a1f3414cb1d299d4f1d6f57e64881f6aeddbff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943719Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#720778}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for mojom::PdfToPwgRasterConverter from PwgRasterConverterHelper using Remote instead of InterfacePtr. Bug: 955171 Change-Id: I8a44ec93c23433f04674a1e543fa6bdb9c7ba10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936067Reviewed-by:
-
Sean Kau authored
When the lifetime of the binders is changed, it can be initialized after the Profile or Settings objects. When this happens, we may never get a change event if the policies don't change. Alleviate this by querying the policy objects on initialization. Bug: chromium:1015949 Change-Id: I401e1c116c89b7a9165f60c7850a1a34f17c70ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940306 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
-
Mike Reed authored
Change-Id: I5e853241ba13d81787dd8546ef6157af78764525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947098 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#720775}
-
nancy authored
For Chrome apps for Web apps, if the window is opened for a browser, we don't need to register app window, because BrowserShortcutLauncherItemController sets the window's property. If register app window for the app opened with browser, the window is added to aura_window_to_app_window_, and when the window is destroyed, it could cause crash in RemoveFromShelf, because BrowserShortcutLauncherItemController manages the window, and sets related window properties, so it could cause the conflict settings. BUG=1011235 Change-Id: I80cd22dad1085a49ea30dc4f3b3a732c7924a834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937951 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
R=johnchen@chromium.org Bug: 1028125 Change-Id: I0837eee6aadaa8085161da96dda8e2a6a486de30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947663 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#720773}
-
khmel@chromium.org authored
This gives important information about app quality. TEST=Locally BUG=b/143532713 Change-Id: Icb6b1a37ed077b6a9aad5ed81e3b7b650c62cd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947185Reviewed-by:
-
Ahmed Mehfooz authored
The special case for letting the focus ring for the bottom most notification exceed it's bottom side bounds is not applicable with the recent message center changes. Bug: 1020546 Change-Id: Ib0242dddc6aeb922d50a8795ce16c150734a6f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947625Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#720771}
-
Scott Violet authored
There are more that need to be converted, but they are require other code to be converted. BUG=none TEST=none Change-Id: Ifc44aa4c015a32c49488b14bcda2c721767748bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947389Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ca1b0fb895ca..fb40d231c3e2 git log ca1b0fb895ca..fb40d231c3e2 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 jmadill@chromium.org Add new test runner harness. 2019-12-02 syoussefi@chromium.org Vulkan: implement external semaphore barriers 2019-12-02 syoussefi@chromium.org Fix RenderingLimitToDefaultFBOSizeWithNoAttachments test 2019-12-02 syoussefi@chromium.org Add test for multithreaded shared-context resource 2019-12-02 geofflang@chromium.org D3D: Log why a renderer fails to initialize. Created with: gclient setdep -r src/third_party/angle@fb40d231c3e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1026673,chromium:1029091 Tbr: geofflang@google.com Change-Id: Ie7249b58c3681e8f2a2238cfc86689216142593c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947424Reviewed-by:
-
Lambros Lambrou authored
PipeMessagingChannel takes ownership of the passed File objects, closing them. This means that stdin/stdout are closed, to prevent accidental corruption of the native-messaging streams. This CL reopens stdin/stdout against /dev/null, which protects them, preventing any future calls to POSIX open() returning these descriptors. For example, LaunchProcess (by default) treats FDs 0, 1, 2 specially (it closes all descriptors except them), so having stdin/stdout directed to some random file could cause unintended effects. This CL also fixes PipeMessagingChannel ctor to not interleave the dup() and close() calls: dup, dup, close, close instead of dup, close, dup, close so that the second dup() call now returns a high-numbered descriptor instead of 0 (freed up by first close() call). Bug: 1029858 Change-Id: I209f5734a06216323c54a680852b381fb6f2f96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947397 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#720768}
-
Mitsuru Oshima authored
Changed BuildWindowListIgnoreModal to keep the activation order. This also fixes the method not to add a window w/o parent. Bug: None Test: covered by unittests. Change-Id: I727b3af0421b9f0f61552ec4a25e440e30e903d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935287 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#720767}
-
Jay Harris authored
Explainer: https://github.com/WICG/file-handling/blob/master/explainer.md#example Summary of Changes: Old way: { "file_handler": { "action": "/files", "files": { "name": "Text", "accept": [ "text/plain", ".txt", ".md" ] } } } New way: { "file_handlers": [ { "action": "/files", "name": "Text", "accept": { "text/plain": [ ".txt", ".md" ] } } ] } Note: This change is behind the NativeFileSystemAPI and FileHandlingAPI flags, so this change won't effect any live web APIs. Bug: 829689 Change-Id: I85ea3abdc22f1b6c89749e051e2ce5dc592357dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877497 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#720766}
-
Tetsui Ohkubo authored
As the impact of the feature is unclear, we want to add a kill switch of the feature through Finch experiment, so that even when the feature lands in stable it can be disabled quickly. Android side CL: http://ag/9778557 TEST=Add --force-fieldtrials="ArcMinimizeOnBackButton/Enabled/" or "ArcMinimizeOnBackButton/Disabled/" to /etc/chrome_dev.conf to see TEST=ArcPropertyBridgeTest the setting is properly overridden BUG=972708,b:144896228 Change-Id: If82db66508f623a7a6f7846d8c7d702fa4bc4e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930367Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#720765}
-
