- 25 Aug, 2020 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium ac787558. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html" bd093e51 "[webcodecs] Dictionary based ctors for encoded video and audio chunks" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ia178bbe0dc0323664c63a7ab5a8aa2ff9bc4330f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372527Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801252}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598270291-b801bf78b6b55c941ccf8675be0d44cb7bb468ce.profdata to chrome-mac-master-1598313565-08e05b737624bbbe76926e73b436a35f99d64175.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I0ffbc5448632ec9183d447bafeeeca69c6e739d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373296Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801251}
-
Claude van der Merwe authored
Bug: 1045266 Change-Id: Id9424142a6da6137a0a667ab6deb7b00ce123a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370603 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#801250}
-
Andrey Kosyakov authored
TBR=sky@chromium.org, msisov@igalia.com Bug: 1119772 Change-Id: I6c1db3c46fa64ef217449993a3531adf5ae16e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372345Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#801249}
-
Jiewei Qian authored
This CL adds install source to thr return value of getAllInstalledApps. Bug: 1095524 Change-Id: Ief54598f1005657ccc6f3e674e396077a42b1ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371067 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#801248}
-
Haiyang Pan authored
The swarming tasks occasionally expire on these two builders. Increasing the expiration to fix the issue. Bug: 1115750 Change-Id: I4781e4e3ed4b7a1e1fc5fae247ad72bf6eadca24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373443 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#801247}
-
zhaoyangli authored
The CI builder has the config but it's lacking on try builder. Bug: None Change-Id: Ibe2c784a3f0672a5df7690a3358a25c0abe3f40c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373445Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#801246}
-
Yi Gu authored
This patch adds "Aborted" to the metric as a valid enum. Change-Id: I78f9f70f1e8ab384718c4d35bd2e5bb703a6601d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373396Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801245}
-
Darren Shen authored
Still needed to measure performance as we only launched recently. Bug: 1109935 Change-Id: I562d022c69764ecf35ce8de0138f007c54f8a8fd Fixed: 1109935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365553Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#801244}
-
Ilya Nikolaevskiy authored
This CL: * Adds two new feedback parameters for max frame-rate/resolution * Moves 3 existing parameters to a new VideoFrameFeedback struct in VideoFrame. * Changes callbacks/mojo interfaces to plumbs new information all the way back to the frame sink video capturer. This Cl does not set new feedback parameters at any consumers nor does it process them at the capturer. Bug: chromium:1116430 Change-Id: Ia27c1b84ded8ded2ef704ef5b41e848daa948bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353461 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#801243}
-
Tomasz Wiszkowski authored
Ensures that no suggestion updates are received after destroy() is called. Bug: 1119805 Change-Id: I431fb60038274a8c6f54eb89d034822d77b08d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373383Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#801242}
-
nancylingwang authored
|icon_scale_| is used to decode the compress icon file, and when encode the uncompressed icon, |icon_scale_for_compressed_response_| is used for the scale. |icon_scale_for_compressed_response_| is set for web apps in the function IconLoadingPipeline::LoadWebAppIcon, but not set for Crostini icon load function LoadCompressedIconFromFile, so the Crostini compress icon from chrome://app-icon always load failed. Modify LoadCompressedIconFromFile to set |icon_scale_for_compressed_response_|, the same as the web apps implementation. BUG=1115831 Change-Id: Ib55664acdcbaeb65a430375cba3a07560f015d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371723 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Tomasz Wiszkowski authored
The flag expired with M86 and does not show in most recent Canary builds of Chrome. Change-Id: If1cb6a2be57bd6f8e7c8027f334da48afd482897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372741Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/746445da75a4..cd8de1d295b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Icb679ae4f2dddb2d3d57c6aa6eadaa629b33ff6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373373Reviewed-by:
-
Kent Tamura authored
Revert "input[type=file]: display:inline-flex/flex/inline-grid/grid should not affect the internal layout" This reverts commit d04cef4c. Reason for revert: Specification violation. Changing ComputedStyle:: Display() affects web-exposed getComputedStyle(). Original change's description: > input[type=file]: display:inline-flex/flex/inline-grid/grid should not affect the internal layout > > In LayoutNG, we use LayoutNGBlockFlow for input[type=file]. If > flex/grid is specified, NGBlockLayoutAlgorithm is applied but children > are blockified. So the internal [Choose File] button and > "No file chosen" text were placed on different lines. > > This CL fixes it by adding "display" adjustment code. > > Bug: 1119312 > Change-Id: Id15bfa5a047f56ee00adb43d74e6b3d09f1f6433 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371066 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801209} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org Change-Id: I393b32565e44ea8dbfce2eb6c347d5b423470764 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371847Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#801238}
-
David Van Cleve authored
ManifestBrowsertest.MixedContentManifest currently passes because it catches a CORS error, not a mixed content error. This change fixes the test to pass for the right reason and additionally refactors the related test ManifestBrowsertest.CorsManifest to make sure the error message it sees is plausible. R=dominickn Bug: 1120888 Change-Id: Ic073a3becbbca782bb0ad63223a9cef472ab7717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369684 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0baaa2372201..b8f10b7bb745 2020-08-24 johnstiles@google.com Reland "Add a patch and an atlas to the ImageFilter GM slide." 2020-08-24 johnstiles@google.com Revert "Add a patch and an atlas to the ImageFilter GM slide." 2020-08-24 adlai@google.com A couple optimizations to Metal Shader Pipeline If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I7f1fb3917589fe17097302797a7db0c4d60ca627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373189Reviewed-by:
-
Anastasia Helfinstein authored
This change checks if the node is a keyboard before checking if it's a window, fixing the attached bugs. AX-Relnotes: n/a. Bug: 1120730, 1120734 Change-Id: I57fe00ec8c805bb887ed67a743cf8181cf1291cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369612 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#801235}
-
David Stevens authored
DRM supposedly supports subpixel source crop. However, according to drm_plane_funcs.update_plane, devices which don't support that are free to ignore the fractional part, and every device seems to do that as of 5.4. To deal with this, round source crops that are nearly integers and reject overlay candidates that actually require subpixel source crop. The rounding of nearly integer crops addresses an issue where floating point imprecision in a quad's uv_crop could lead to a visible difference depending on whether or not the quad was put in an overlay. The visible difference arose because drivers truncate the fractional part of the source crop, which could lead to a 1px discrepancy in the source crop. BUG=chromium:1099110 Change-Id: Ib20b16ef505574bd63502591db626a7e769f6e88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366397 Commit-Queue: David Stevens <stevensd@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#801234}
-
Darren Shen authored
Change-Id: I82abcab5d9300685fc58b81b300cac0ea0e0cff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371846Reviewed-by:
My Nguyen <myy@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#801233}
-
Brian Sheedy authored
Updates the GPU pixel wrangling documentation to point out //content/test/gpu/trim_culprit_cls.py as a potentially useful tool and updates the script's documentation to include example usages. Bug: 1120104 Change-Id: I2026e994408097bfee8b94984dc89e8110afba0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373391 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#801232}
-
Sam Sebree authored
This PR changes the dark mode text input search "X" cancel button from blue to white. Bug: 1119529 Change-Id: I5920c9c810c4b1fd7af6976143b2053d7d28c59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364963 Commit-Queue: Sam Sebree <sasebree@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Reviewed-by:
-
Jie Jiang authored
This patch exposes AddressType of a device via dbus, which is available since BlueZ v5.47. This is required by ARC++ for creating L2CAP LE sockets. BUG=b:164979158 TEST=device_unittests Change-Id: Id5691166ddc52fd75e6e62407352eb00c7e16e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366214 Commit-Queue: Jie Jiang <jiejiang@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#801230}
-
Kyle Horimoto authored
These flags were set to expire in M-86, but they need to be extended since clients have not yet been fully switched to v2. Bug: 1121385 Change-Id: I4f54eac75e8e951676cbc654a3672c799f92160c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373444 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#801229}
-
Garrett Beaty authored
Compile targets are copied from the recipe config in chromium/tools/build in anticipation of removing compile targets from recipe config. Bug: 1091004 Change-Id: Ie2df673b7c1dd9507411ae939d19ef4dcd7d6735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367700 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#801228}
-
Melissa Zhang authored
This CL removes the temporary button that was used to test the sharesheet during development. Bug: 1097623 Change-Id: Id75f93030cf07d67a33b061b432f38d8141500d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371862Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#801227}
-
Kelvin Jiang authored
Add a global rules constant that is not exposed programmatically. For this change, extensions can index up to (global limit + old static limit) rules per ruleset, and enable that many rules as well. Rulesets which exceed this limit are effectively ignored. This change is currently hidden under a feature flag. Bug: 983299 Change-Id: I63fba98e3a17fdb6e67ae78bb1ead9bf963d7b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309550Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#801226}
-
Justin Cohen authored
Bug: 1103822 Change-Id: I498e38838cbc15aba3787a43f411e978d9d50ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373264 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801225}
-
Yue Zhang authored
This reverts commit 5c9e2756. Reason for revert: Debug the failed test or disable it for x86 bot to unblock later patches. Original change's description: > Revert "Add an undo closure snack bar in TabGridDialog" > > This reverts commit 114425f8. > > Reason for revert: Failing on x86 bots > > Original change's description: > > Add an undo closure snack bar in TabGridDialog > > > > This CL adds a snack bar to TabGridDialog that handles closure within > > dialog. Note that this change doesn't prevent the original snack bar > > from showing when closure happens, so there will be two snack bars > > showing when a closure happens within dialog. This issue will be > > addressed by later CLs. > > > > Bug: 1119899 > > Change-Id: If0e5b010996a80c9a111c8bf2cb8af44feb63124 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368236 > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#801037} > > TBR=wychen@chromium.org,yuezhanggg@chromium.org > > Change-Id: I1c2ccc03142c50c203ec08817d8817cfa614b519 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1119899,1121363 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373232 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801169} TBR=twellington@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1119899 Bug: 1121363 Change-Id: Ide7bfe2cce812f11f92b6ca42fc3c0c4a8eae546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373288 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#801224}
-
Konstantin Ganenko authored
R=rdevlin.cronin@chromium.org Bug: 1020144 Change-Id: Idbfe0846af782c2beeb99ce2ceead892875eef0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893278Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801223}
-
Livvie Lin authored
Desktop/Android clears the URL from the omnibox for lookalike interstitials to avoid showing a confusing punycode URL, so this CL updates the iOS behavior to match. Screenshots: Before - https://drive.google.com/file/d/17wb35L2MsB8Kh4CGb_tvY370KGuXd_Xa/view?usp=sharing After - https://drive.google.com/file/d/1NDXYXPse94sriH4pseR9g1ir114tOPJD/view?usp=sharing Change-Id: I8962711b331e7d267f38576072868439500f45c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351968Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801222}
-
Shrek Shao authored
Per https://github.com/KhronosGroup/WebGL/pull/3138 Bug: 1000354 Change-Id: Ie25281b7160aae8ed3cbe871a79af673a6b69dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372899Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#801221}
-
Matt Menke authored
These two net::LoadFlags (along with net::LOAD_DO_NOT_SAVE_COOKIES) are being combined into network::mojom::CredentialMode::kOmit. This CL updates the remaining consumers of the two cookies to use CredentialsMode / allow_credentials / PrivacyMode instead. Unfortunately, there are still a bunch of consumers that are setting net::LOAD_DO_NOT_SAVE_COOKIES without either of the other two flags, so this CL leaves that one in place, for now. This CL also fixes the LOAD_DO_NOT_SAVE_COOKIES case, where we'd set privacy mode at the URLRequest layer, but then URLRequestHttpRequest would disable it in the RequestInfo struct unless cookies were blocked by the network delegate. The code now never sets PrivacyMode if only LOAD_DO_NOT_SAVE_COOKIES is set, which does slightly alter behavior in the LOAD_DO_NOT_SAVE_COOKIES + NetworkDelegate blocks cookies case, but the current behavior seems more consistent. This will also make it so that when the NetworkDelegate forces PrivacyMode, it will disable sending auth credentials. The impact on this is not expected to be significant, but it's worth being aware of. Bug: 799935 Change-Id: I773e4bf0a53ba45c9a58cea6b67dbd7aff616f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367394Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#801220}
-
Matt Wolenetz authored
BUG=1121383 TBR=fsandrade@chromium.org,pmonette@chromium.org Change-Id: Iaa01171f9bf3d6ff2ae522d528b6319ab99e7b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373390Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#801219}
-
Sinan Sahin authored
Bug: 1091491 Change-Id: Ieba9919f7c1363b5b39ca33081e2c84b6d166bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358434Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#801218}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/48246beb..bccf9d55 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I38a9f32618217ea9417c16bf9ab19b42c71abe4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372526Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801217}
-
Kuo-Hsin Yang authored
Also delete testing config. Bug: b/149833548 Change-Id: I314961ff0c037933572b81a909bf792f7678017f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366321Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#801216}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d32b1bc30216..25e9f126d8c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC wolenetz@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:912681 Tbr: wolenetz@google.com Change-Id: I12e65bfda60592678714a671f5f55417b230c77f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372646Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801215}
-
Albert J. Wong authored
Relanding https://chromium-review.googlesource.com/c/chromium/src/+/2351950 This mostly removes the refcount thrashes in Element::setAttribute() which accounts for nearly 13% of regression in blink_perf.bindings set-attribute.html story when StringImpl is made threadsafe. Because of some reentrant behavior in Element::setAttribute() -> Element::SetAttributeInternal() -> Element::DidModifyAttribute() -> Element::AttributeChanged() -> Element::ParseAttribute() -> Element::setAttribute(), the qname for the Attribute, the old value, and the new value cannot be easily transfered into the Element's internal ElementData::Attributes() collection while also publishing the change to observers via the DidModifyAttribute() call. Removal of that thrash will be done in a follow-up CL. Bug: 1083392 Change-Id: I7f7f4bfa22a2e553e703c0375bd04bb77f71de23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369348Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Auto-Submit: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#801214}
-
Yoichi Osato authored
This CL introduces caching in ChunkedDataPipeUploadDataStream (CDPUDS here in after) so that fetch upload streams manages inevitable replay required situations like socket time out. If the caching is enabled, CDPUDS caches streams content from the data pipe while uploading. 1 If we hit some error requiring CDPUDS restart, InitInternal() doesn't reset the data pipe and CDPUDS replays the cached content and continues data pipe withdrawing after that. 2 If we hit the error when the cache is over the max size, we will fail the request because we cannot replay the stream any longer. 3 If no error happens, the cache will never be used. We don't clear the cache because it is small and will be discarded after the transaction. CDPUDS caches chunks from the date pipe until whole size gets over the max size. For example, if the date pipe sends [60k, 60k, 60k] chunks, CDPUDS caches the first 2 60ks. If it is [120k, 1k,], CDPUDS caches the 120k chunk or any size if it is the first chunk. Since this change is neutral to the HTTP protocol, this works over H1/SPDY and QUIC. Bug: 1077174 Change-Id: Ib87b9d7ff97577f25e7355aa4b0764e03157d7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269622Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#801213}
-
