GitLab

Review URL: http://codereview.chromium.org/7794013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98768 0039d316-1c4b-4281-b951-d872f2087c98

This depends on https://bugs.webkit.org/show_bug.cgi?id=66746 and http://codereview.chromium.org/7461059/, neither of which have been landed. So this should be considered a preliminary review at this stage :)

BUG=
TEST=

Review URL: http://codereview.chromium.org/7714017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98767 0039d316-1c4b-4281-b951-d872f2087c98

Requested by jeffreyc.

BUG=92786
TEST=Open tab, go somewhere, go back to ntp. Swipe like a madman,
nothing but paneswitchery should happen.


Review URL: http://codereview.chromium.org/7792013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98766 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org
BUG=76354
TEST=none

Review URL: http://codereview.chromium.org/7792026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98763 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98762 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87811
Test=plugins.PluginsTest.testDisableEnableAllPlugins

Review URL: http://codereview.chromium.org/7745041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98761 0039d316-1c4b-4281-b951-d872f2087c98

Due to allowing users to configure without a passphrase if they don't have
passwords enabled, we can get into a situation where we require encryption of
datatypes, but don't have the cryptographer enabled. When in this situation
we need to ensure we don't corrupt any data. Once the user sets their
passphrase, we will reencrypt everything, which will overwrite unsynced entries
with their encrypted versions, allowing the sync cycle to finish.

BUG=93100
TEST=sync_unit_tests --gtest_filter="*GetCommitIdsFilterEntries*"
Also to manually test: set up sync on a machine with an explicit passphrase. Set up sync without passwords enabled on a separate machine and don't enter the passphrase. Enable encryption on the first client. Attempt to add a bookmark on the second client.

Review URL: http://codereview.chromium.org/7795002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98758 0039d316-1c4b-4281-b951-d872f2087c98

Automation for step 1-9 testplan @ go/NACL-SDK-testing
BUG=89467, 89470, 89479, 89610, 89612
TEST=None

Review URL: http://codereview.chromium.org/7633026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98757 0039d316-1c4b-4281-b951-d872f2087c98

Intial checkin of layout test analyzer. This is continuation of  http://codereview.chromium.org/7671049/. The goal of this tool is to provide
updated information about layout test status to help developers. The tool goes to Webkit SVN to get layout test cases and the test expectation file (chromium) and do some analysis and send out periodical emails.

Review URL: http://codereview.chromium.org/7693018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98756 0039d316-1c4b-4281-b951-d872f2087c98

R=hashimoto@chromium.org
BUG=chromium-os:18955
TEST=Manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96157

Review URL: http://codereview.chromium.org/7607028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98755 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org
BUG=94687,76354
TEST=none

Review URL: http://codereview.chromium.org/7806004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98749 0039d316-1c4b-4281-b951-d872f2087c98

while being investigated.

BUG=chromium:94683
TEST=

Review URL: http://codereview.chromium.org/7806003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98748 0039d316-1c4b-4281-b951-d872f2087c98

The echo message is essentially an async fence with event based notification. The client gets a notification when the GPU process has completed all the work up to the last flush.

I used it to replace the SwapBuffers / OnSwapBuffers synchronization and got rid of some of the callbacks in the lower layers of the stack.

The SwapBuffers callbacks in the GPU process are only needed on mac now and I will replace them with something more generic soon.
Review URL: http://codereview.chromium.org/7762013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98747 0039d316-1c4b-4281-b951-d872f2087c98

NULL nobject_ in the stub prior to deallocating the object, to avoid re-entrancy into NPObjectStub::DeleteSoon() during NPObjectStub::OnChannelError() from double-deleting the stub.

BUG=94179

Review URL: http://codereview.chromium.org/7792007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98746 0039d316-1c4b-4281-b951-d872f2087c98

So that we could pre-populated user email with Gaia UI.

BUG=chromium-os:18599
TEST=Verify fix for chromium-os:18599.


Review URL: http://codereview.chromium.org/7793007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98745 0039d316-1c4b-4281-b951-d872f2087c98

debug builds of reliability_tests.

BUG=90443
TBR=phajdan.jr
Review URL: http://codereview.chromium.org/7790019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98744 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/7767011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98743 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Pepper Flash


Review URL: http://codereview.chromium.org/7765011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98742 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94673
TEST=Visit https://www.diginotar.com and expect an invalid authority error.

Review URL: http://codereview.chromium.org/7795014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98741 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:19576
TEST=Requires updated libcros (166). Ensure tests pass. Thoroughly test Network UI.

Review URL: http://codereview.chromium.org/7765009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98737 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=BUILD

Review URL: http://codereview.chromium.org/7792021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98736 0039d316-1c4b-4281-b951-d872f2087c98

Remove handling for the ViewHostMsg_GetCookies and ViewHostMsg_SetCookies from Chrome. These messages
were being handled in Chrome only for ChromeFrame processes, i.e. to route the cookie requests to the
host browser.

We now send out the ChromeViewHostMsg_GetCookies and ChromeViewHostMsg_SetCookies IPCs for ChromeFrame
processes. These are sent out by the embedder instance which lives in the renderer. ChromeRenderMessageFilter
handles these messages.

This is a continuation of the changes to not handle IPC messages from content in Chrome and vice versa.

BUG=87335
TEST=No change in functionality. chrome frame net tests and chrome frame tests should pass.
Review URL: http://codereview.chromium.org/7764014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98735 0039d316-1c4b-4281-b951-d872f2087c98

This code will be removed again once histograms have been collected.
Review URL: http://codereview.chromium.org/7775003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98734 0039d316-1c4b-4281-b951-d872f2087c98

We now depend on GTK 2.18, and in fact we've been infobaring users
who don't have it informing them that Chrome will stop working.

Review URL: http://codereview.chromium.org/7791004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98732 0039d316-1c4b-4281-b951-d872f2087c98

broken in r98715

BUG=none
TEST=waterfall

Review URL: http://codereview.chromium.org/7793015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98731 0039d316-1c4b-4281-b951-d872f2087c98

as possible workaround for crash in NVIDIA driver on Mac. Also fixed
bug ID in comment.

BUG=94103
TEST=none (manually tested some WebGL content)
Review URL: http://codereview.chromium.org/7800006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98729 0039d316-1c4b-4281-b951-d872f2087c98

Stop using the default profile's proxy service for plugin proxy requests, and instead use the associated profile's proxy service. I proxy the IPC through the renderer first, as that makes it easy to get to the associated profile.

BUG=92361,64339
Review URL: http://codereview.chromium.org/7791005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98728 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93740
TEST=manual

Review URL: http://codereview.chromium.org/7757008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98727 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98726 0039d316-1c4b-4281-b951-d872f2087c98

Moving towards giving the user feedback when a file system error occurs during a download.

Split from CL 7134019.

BUG=85240
TEST=None


Review URL: http://codereview.chromium.org/7646025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98725 0039d316-1c4b-4281-b951-d872f2087c98

TBR=apavlov@chromium.org

Review URL: http://codereview.chromium.org/7799007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98724 0039d316-1c4b-4281-b951-d872f2087c98

TBR=csilv@chromium.org
BUG=94664
TEST=none

Review URL: http://codereview.chromium.org/7799010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98723 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=bots
Review URL: http://codereview.chromium.org/7764012

TBR=polina@google.com
Review URL: http://codereview.chromium.org/7800007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98722 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98719 0039d316-1c4b-4281-b951-d872f2087c98

Conceptually, the function to call is known at compile time.
There is no reason to save it into a static variable.  It turns out
doing causes the compiler to emit a static initializer to track whether
free_ has been initialized.

This change removes static initializers from eight .o files on my local
Release build.

BUG=87171

Review URL: http://codereview.chromium.org/7795008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98718 0039d316-1c4b-4281-b951-d872f2087c98

So that we show Gaia horizonally center.

BUG=chromium-os:19779
TEST=Verify fix for chromium-os:19779.


Review URL: http://codereview.chromium.org/7792009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98717 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manually


Review URL: http://codereview.chromium.org/7764006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98716 0039d316-1c4b-4281-b951-d872f2087c98

1. install to the correct page (0 -> -1 in crx_installer)
2. scroll to show the app (scrollTop change in apps_page.js)
3. reset tiles after trashing an app (trash.js change)
4. fix install-display for already-open NTPs. The old technique of always navigating stacked up history entries when the NTP had already been open. It was also flaky (seemed to be vulnerable to some race). Now we use an install notification which the NTP in question will be listening for.

BUG=92995,91583
TEST=manual

Review URL: http://codereview.chromium.org/7776001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98715 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98714 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=tree green
Review URL: http://codereview.chromium.org/7791007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98713 0039d316-1c4b-4281-b951-d872f2087c98