GitLab

This reverts commit 72d0f390.

Path to BLEHandler_jni.h in cablev2_authenticator_android.cc wasn't updated to remove 'internal', but the old generated file was still on disk for nearly all the builders.

Original change's description:
> Revert "Move caBLE v2 authenticator to a dynamic module."
>
> This reverts commit e7ea3e9e.
>
> Reason for revert: causing compile failure
> https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/10837?
>
> Original change's description:
> > Move caBLE v2 authenticator to a dynamic module.
> >
> > By moving the authenticator code to a dynamic module we eliminate
> > code-size concerns in the base module for a feature that is flag
> > protected and, for a while at the very least, will be used by a tiny
> > fraction of users.
> >
> > BUG=1002262
> >
> > Change-Id: I9418d7873091741e189629755033842023166ed6
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145759
> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> > Reviewed-by: Ilya Sherman <isherman@chromium.org>
> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
> > Reviewed-by: Martin Kreichgauer <martinkr@google.com>
> > Commit-Queue: Adam Langley <agl@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#758880}
>
> TBR=agl@chromium.org,isherman@chromium.org,martinkr@google.com,fhorschig@chromium.org,tiborg@chromium.org
>
> Change-Id: I535fa461c641edd4ba2a41d94f2fccf828cecb71
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1002262
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148818
> Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#758913}

TBR=xhwang@chromium.org,agl@chromium.org,isherman@chromium.org,martinkr@google.com,fhorschig@chromium.org,tiborg@chromium.org

Change-Id: Id338c6f8c63bd9a52ea781b56f4bf69d5ab46a06
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1002262
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149694Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759265}

- Make LayoutNGMixin<LayoutRubyRun> a friend of LayoutRubyRun because
  LayoutNGMixin<LayoutRubyRun> accesses some private functions.

- Add an Element* argument to LayoutRubyRun.
  LayoutNGMixin assumes that the constructor of its base class has an
  Element* argument.

- The layout behavior of LayoutRubyRun is not implemented yet in
  LayoutNGRubyRun.

This CL has no behavior changes because changes are behind a
runtime flag.

Bug: 1069817
Change-Id: I3b3d99e1d0b8648305ecea1b07460a893ee9e5ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149737
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759264}

https://webrtc.googlesource.com/src.git/+log/43245c56b086..4a5bce96e8c2

git log 43245c56b086..4a5bce96e8c2 --date=short --first-parent --format='%ad %ae %s'
2020-04-15 brandtr@webrtc.org Change to more idiomatic map erase.
2020-04-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 72d0f390..a775f4ae (758913:759199)

Created with:
  gclient setdep -r src/third_party/webrtc@4a5bce96e8c2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I49861aefbbeae3a273a6212f0028ae6e922fa538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150607Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759263}

We want to get rid of the single argument AddHeader() method as the two
argument AddHeader() and SetHeader() methods are safer and more flexible.

Bug: 1068194
Change-Id: I1c4778678db95002f8af57d24b4863f4daa595fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150034
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Auto-Submit: Matt Menke <mmenke@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759262}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/55adbeb1..0e4f9cf5

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2fc01b971da160d29e854b53140e4f2bbb5b5104
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143839Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759261}

https://skia.googlesource.com/skia.git/+log/eb1d5a2e233c..68626439f360

git log eb1d5a2e233c..68626439f360 --date=short --first-parent --format='%ad %ae %s'
2020-04-15 bsalomon@google.com Revert "GaussianConvolutionFragmentProcessor uses GrTextureEffect."
2020-04-15 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps
2020-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 dee4d7a54e44..6e0d718a48d8 (10 commits)
2020-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 8ab26431..cddb357f (417 commits)
2020-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 711867566999..81e08df29531 (9 commits)
2020-04-15 mtklein@google.com clean up SK_SUPPORT_LEGACY_COLORFILTER_NO_SHADER
2020-04-15 herb@google.com Fix to change reject behavior back to original
2020-04-14 mtklein@google.com MSAN fix for interpreter
2020-04-14 bsalomon@google.com GaussianConvolutionFragmentProcessor uses GrTextureEffect.
2020-04-14 bsalomon@google.com Pass description of GrSurface to GrSurfaceProxy lazy callbacks.
2020-04-14 egdaniel@google.com Only call glFlush in submit when it is required.
2020-04-14 herb@google.com Remove scheduler instruction dump
2020-04-14 herb@google.com Instruction dumper with extra notations
2020-04-14 robertphillips@google.com Add render task type to flush-time op spew
2020-04-14 tdenniston@google.com [svg] Implement currentColor for gradient stops
2020-04-14 jvanverth@google.com Some D3D cleanup.
2020-04-14 reed@google.com SkCamera.h is deprecated
2020-04-14 ethannicholas@google.com Add sample(child, matrix) to SkSL.
2020-04-14 westont@google.com Move Pixelbook build jobs to Docker Debian9.

Created with:
  gclient setdep -r src/third_party/skia@68626439f360

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1058517,chromium:1070474
Tbr: kjlubick@google.com
Change-Id: I30497f840a14e1f26c209889969d1f983e91a776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150606Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759260}

Add document on types of threads that execute inside ChromeDriver,
and how these threads interact with each other.

Notry: true
Change-Id: Ib88095005062efe6189ffc9d2a6e391be8ffe1a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146929Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759259}

It was previously being logged as an integer, but the value is a long so
it wouldn't obviously correspond to the actual value.

Change-Id: I79fde8d7f86cf929af36d400e2d7df84e1136b0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150296
Auto-Submit: Max Li <themaxli@chromium.org>
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759258}

These files were inadvertently missing ARC guards and were not being
compiled with ARC.

BUG=1070852,1070933

Change-Id: I1005d41c26233d858aaee3670d3ce8b69ab561a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150300
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759257}

Ban use of ComPtr::GetAddressOf() according to http://crbug.com/914910.

Bug: 914910
Change-Id: I4287f7acd6969d7f236f4dc64fb6a1c76a8d5c9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148673
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759256}

Image Doodles: Before, image doodles were only given a max width of
500x. This CL increases this to the width of the window since that is
what the local NTP does. Additionally, the doodle share button is now
placed relative to the top left corner of the doodle instead of the
previously fixed-size image doodle container.

Interactive Doodles: This CL uses the initial iframe size provided in
the doodle response instead of a fixed initial size of 500x230px.

Fixed: 1039910
Change-Id: Ibaa23976a02c9215e80f3cc55fa2a5fcbc4781e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150007
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759255}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/22287060ed91..3994d83c6bc2


Created with:
  gclient setdep -r src-internal@3994d83c6bc2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: ricea@google.com,nektar@google.com,guidou@google.com
Change-Id: I73c19f0e7468f7a06f0a03d3534abb8552c0e75a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150608Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759254}

https://android.googlesource.com/platform/external/perfetto.git/+log/aa333ac7985f..2cc24537de78

git log aa333ac7985f..2cc24537de78 --date=short --first-parent --format='%ad %ae %s'
2020-04-15 lalitm@google.com Merge changes Ice9239a7,I92fe8218,I2df6401e
2020-04-15 fmayer@google.com Merge "Allow to specify output dir for heap_profile."
2020-04-15 treehugger-gerrit@google.com Merge "traced_perf: optional periodic unwinder cache clearing"
2020-04-15 treehugger-gerrit@google.com Merge "traced_perf: support incremental state clears"

Created with:
  gclient setdep -r src/third_party/perfetto@2cc24537de78

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I979fd65d2967f4cae2b78dd486c2676d83733bd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150424Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759253}

https://chromium.googlesource.com/angle/angle.git/+log/5e7ef660be4a..2aa42d8b508b

git log 5e7ef660be4a..2aa42d8b508b --date=short --first-parent --format='%ad %ae %s'
2020-04-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 711867566999..81e08df29531 (9 commits)
2020-04-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src ae0f0ead3a56..1be434141625 (1 commits)
2020-04-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src e70d25f6fa5d..c018fc6ae667 (9 commits)
2020-04-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src bb8be13e3ffe..3f7e3cbf33a7 (9 commits)

Created with:
  gclient setdep -r src/third_party/angle@2aa42d8b508b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: timvp@google.com
Change-Id: I3975cf00941f7fe7f6401c257188a276a66555c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150423Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759252}

wrapped_sk_image()->GetSkSurface() may return nullptr if the deive is
lost, so we need to check the result before using it to avoid crash.

This CL also improves SharedImageAHB to recreate SkSurface, if surface
properties are changed. And it also resets the canvas when write access
is done.

Bug: None
Change-Id: Ic9a7a966ac7063a74f650c1b04c2ee6ba475d918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145467
Auto-Submit: Peng Huang <penghuang@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759251}

BUG=chromium:1058685

Change-Id: Ifa778623b50c373ac179e6e440f68f89d6b23abf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148981Reviewed-by: Sergei Datsenko <dats@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759250}

StartSurfaceLayoutPerfTest#testTabToGridFromLiveTabWith10TabsWithoutThumbnail
is flaky on an Android O builder as well [1], disabling it for all
Android versions.

[1] https://ci.chromium.org/p/chrome/builders/ci/test-o-phone/5910

TBR=wychen@chromium.org

Bug: 1045938
Change-Id: I40e38d36623add441be0c7e13db7d0b3561165d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144088Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759249}

This CL adds a missing enum case which resulted in a triggering a
DCHECK. As a drive-by, it fixes a wrong enum case.

Bug: chromium:1070234
Change-Id: Ie7f3776d517e43bc93cb93dba0dd9e3d02be253c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146546
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759248}

Previously Document was an instance of ExecutionContext. |document_| not
null is equivalent to ExecutionContext not null. However, after recent
migration of ExecutionContext to DomWindow, this assumption no longer
holds.

This CL adds null-check on |document_->GetExecutionContext()| to avoid
deref nullptr.

Bug: 1069848
Change-Id: Ifadc47b889bf5cd5fc3975b511c92d1dda7d4205
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149317Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#759247}

Design doc: https://bit.ly/chrome-io-jank-metric

R=olivierli@chromium.org

Bug: 1064645
Change-Id: If0b1ccf43303a6dcd2d77a0fd4b0bcb3d6dd99c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120288Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759246}

This CL updates the SendTabToSelf feature architecturally in several
respects. It:
  - Removes use of the deprecated TabModelList class.
  - Prepares SendTabToSelf for multi-window by factoring the keyed
    service (which is scoped to the whole app) into a BrowserAgent
    (which is scoped to a single window).
  - Moves the CreateNewEntry() utility method into the BrowserAgent
    class as SendCurrentTabToDevice().
  - Factors away the SendTabToSelf command, since its UI functionality
    is just a combination of existing commands, and it's invoked from
    a single location. This removes a responsibility from the BVC.
  - Adds unit tests to the new browser agent.

While this CL *prepares* SendTabToSelf for multi-window, it doesn't
add multi-window support -- currently every window will display an
infobar when a tab is remotely added to the model. crbug.com/1068482
tracks "full" multi-window support for this feature.

Bug: 1056199, 1046378
Change-Id: I1434cf6463b2f96a994345c465be1b952ec58c86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137444
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759245}

onBeforeShow() of checking-downloading-update element is not being
called due to which the oobe dialogs contained inside it are not
being rendered because these dialogs use lazy rendering in
OnBeforeShow() of the oobe dialog. This creates a situation with no
UI element on the screen but the update process running in the
background. Now, calling onbeforeShow() for this element from the
defaultControl() of update required screen.
This CL also adds a test to avoid such case in future. It tests
the update process along with the verification of the UI actually
being displayed.

Bug: 1048607
Change-Id: Ib1ac1c8d935ec059e62202095e7009f89e98a900
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146901Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Saurabh Nijhara <snijhara@google.com>
Cr-Commit-Position: refs/heads/master@{#759244}

https://swiftshader.googlesource.com/SwiftShader.git/+log/9418b511c73b..094974dab674

git log 9418b511c73b..094974dab674 --date=short --first-parent --format='%ad %ae %s'
2020-04-15 bclayton@google.com VkPipelineCache: Do not publically expose internal mutexes
2020-04-15 bclayton@google.com CMake: Fix build when building with `SWIFTSHADER_ENABLE_VULKAN_DEBUGGER`
2020-04-15 sugoi@google.com Fix fragments depth values not being clamped

Created with:
  gclient setdep -r src/third_party/swiftshader@094974dab674

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I5f72e5669020ef9745a19fc465bd6e2c000a00a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150417Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759243}

Bug: chromium:1068084
Change-Id: Icd3f70b6784ac22ef4e3bc1c99233f51145a917f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146542
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759242}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a5bcf59309b5..dc0359178572

git log a5bcf59309b5..dc0359178572 --date=short --first-parent --format='%ad %ae %s'
2020-04-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@dc0359178572

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Icd7165e312083aee0003f93c01cdb91f9e6cbb0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150605Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759241}

This reverts commit 01c325ec.

Reason for revert: Repro'ed locally and ensured fixed.
To elaborate:
 * The breakage occurred only in incremental builds, and only when
   building before / after this change.
   * E.g. Clean builds were correct, but the break was due to
     the transition of before this CL to after.
 * The fix I've done here is just to rename the output of the
   pre-dexsplitter r8 output so that the stale artifact does
   not break things.

I think there might be a bug in dexsplitter that contributed
to this breakage as well, but not going to dig into it since
I've got another change underway to remove the use of
dexsplitter.

Original change's description:
> Revert "Use .r8dex.jar and .mergeddex.jar rather than .dex.zip"
>
> This reverts commit 89a7ef17.
>
> Reason for revert: This is breaking WebView bundles on the official builders, see crbug.com/1069724. It looks like bundletool looks specifically for .dex extensions[1], and this change breaks that assumption.
>
> 1. https://github.com/google/bundletool/blob/3586f8630e08733503ddbd1e74e10d4fb50e0d69/src/main/java/com/android/tools/build/bundletool/validation/DexFilesValidator.java#L48
>
> Original change's description:
> > Use .r8dex.jar and .mergeddex.jar rather than .dex.zip
> >
> > This just renames the extensions in order to make build speed summaries
> > distinguish the two.
> >
> > Bug: 1067273
> > Change-Id: I0a1e14cfed3557d29cd6beb0987436cacfaf6b65
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140908
> > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > Commit-Queue: Peter Wen <wnwen@chromium.org>
> > Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> > Reviewed-by: Peter Wen <wnwen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#757855}
>
> TBR=wnwen@chromium.org,agrieve@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1067273, 1069724
> Change-Id: Ied71fc35aef250bdbf21ee4ec34f5bb2d0eb3423
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145860
> Reviewed-by: Clark DuVall <cduvall@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#758275}

Bug: 1067273, 1069724
Change-Id: I8c505ba68d1c5880a3b39eaec53455e804d48e29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149286Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759240}

The histogram records the wall time for each GPU task. This will
eventually be used to add a slow report trigger to capture traces for
long running tasks from canary.

Bug: 1064662
Change-Id: I30ec4a7f583fc197f916a55eae7dd3b1fbf57bf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144340Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759239}

Should make it easier for CL authors to find a reviewer.

Change-Id: Ic8edd07691599d308ed3adb2745e08b61387f9b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148540
Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759238}

Bug: skia:10139
Change-Id: I2d65477a32c6ff95a017000f0d94825dae3e710f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150301
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#759237}

This CL adds Cokkies description to the Cookies screen.
screenshot: https://drive.google.com/a/google.com/file/d/1Q_cwV1DR1CFZzFULvq23Rd8c-Z6LPxsC/view?usp=sharing

Bug: 1064961
Change-Id: I367c2e2e481687bd5bca7874c2ca7562672ba390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134257
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759236}

To align the footer with the other tableView items, this CL changes the TableViewLinkHeaderFooterItem padding to 16.

Bug: 1071013
Change-Id: I98206913b2319f9f51e747058405e86ded0d9e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144023Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759235}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b7b5fba5..55adbeb1

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I3b27b736260d721d8fbb0dd93f8b3a642f6d5e51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144249Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759234}

On iOS, the application has no access to source_root directly as
all applications are bundled. Thus the test data are bundled as
asserts and need to be located in DIR_ASSETS.

For most of the tests, the directory containing the app binary
is the directory containing the assets, but this is not the case
for EarlGrey2 test that are part of a PlugIns bundle.

Using DIR_ASSETS instead loads the correct path since it is
relative to the code that is running, not to the main application.

Bug: none
Change-Id: I25b0c7b9ac8a7686332591f4488440ffb7f5d4c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149427
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759233}

In WebLayer, both TabImpl and ContentView currently hold on to a
reference to the AutofillProviderImpl instance that should be used to
talk to the Autofill Service. TabImpl updates its reference when an
updateFromBrowser() call is received, and ContentView has its reference
set to that of the Tab by BrowserViewController on the Tab becoming the
active tab. However, this setup is brittle, as if
Tab#updateFromBrowser() is called after the Tab becomes the active Tab,
ContentView's reference will become stale.

Such a call has indeed crept in, as Tab#updateFromBrowser() is now
called from BrowserImpl#onFragmentStart(). This means that autofill no
longer works in the initial tab. This CL makes this setup more robust
by localizing interaction with AutofillProviderImpl inside TabImpl and
having ContentView go through TabImpl as necessary.

Bug: 1070296
Change-Id: I1c26ab8e5d8e9decfdcc3155e2577b1dbeda32b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149432Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759232}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3aa998dd83ac..22287060ed91


Created with:
  gclient setdep -r src-internal@22287060ed91

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: ricea@google.com,nektar@google.com,guidou@google.com
Change-Id: I62a7eb928f68b12667b9df54ec2c25121f57ac63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150419Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759231}

This CL eliminates //weblayer's custom implementation of
InterceptNavigationDelegate in favor of using the //components-level
implementation that Chrome uses. As part of this change, we adapt
//chrome's InterceptNavigationDelegateClient implementation as suitable
for WebLayer. With this change, WebLayer now eliminates stale
navigation entries left on intent launches as Chrome does and also
detects cases where tabs should be closed on intent launches as Chrome
does. Actual closing of tabs in those cases is left as a followup.

As part of this change, we add an implementation of
ContentBrowserClient::IsHandledURL() to //weblayer's
ContentBrowserClientImpl. This implementation is needed for the shared
InterceptNavigationDelegateImpl to behave as expected. The
implementation is based on that in //chrome, with Chrome-specific items
deleted (notably, the kChromeSearchScheme is not handled in WebLayer).

The diff between PS6 and PS8 contains the differences between //chrome's
InterceptNavigationDelegateClient implementation and //weblayer's. One
of the notable differences is that WebLayer's Tab objects (a) cannot
be directly observed and (b) do not change their associated WebContents
during their lifetime. Thus, the //weblayer
InterceptNavigationDelegateClient implementation observes WebContents
directly, with //weblayer's TabImpl additionally calling directly into
the client implementation as necessary.

Bug: 1031465
Change-Id: I010c4c3ef066bfb2d718f597c654a3ce3df890db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137441
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759230}

This reverts commit 8e795d5b.

Reason for revert: Introduces FlingControllerWithPhysicsBasedFlingTest
suite, in which ControllerDoesntBoostFinishedFling test flakes across
Fuchsia, Windows, Linux, and Mac platforms. 

Original change's description:
> FlingBoost with experimental fling animation curve
> 
> Currently, if physics based fling curve is enabled, even if the fling is
> boosted, the scroll distance is capped by upper bound which is three
> times the size of viewport. Thus it nullify the effect of fling boosting
> and travels the same distance as it would if fling is not boosted.
> 
> This CL fixes fling boosting with physics based fling curve. It does
> so by increasing the upper bound every time a fling is boosted.
> 
> Bug: 647137
> Change-Id: Ib2dd51b37df91168ae1f1e8d33888e3b5dc43e23
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118218
> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Reviewed-by: Daniel Libby <dlibby@microsoft.com>
> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#758878}

TBR=bokan@chromium.org,nzolghadr@chromium.org,dlibby@microsoft.com,sahir.vellani@microsoft.com

Change-Id: Ibfc9e51bf5f86c7d6a626d761c20b3ce97652af6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 647137, 1070776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144087Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759229}

https://dawn.googlesource.com/dawn.git/+log/93bea5cb50e3..e3f44e3cd6a1

git log 93bea5cb50e3..e3f44e3cd6a1 --date=short --first-parent --format='%ad %ae %s'
2020-04-15 cwallez@chromium.org ShutDownBase, only tick frontend facilities if they have been created
2020-04-15 cwallez@chromium.org Null: Properly fake commands being completed on WaitForIdle

Created with:
  gclient setdep -r src/third_party/dawn@e3f44e3cd6a1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: chromium:1068465,chromium:1068886,chromium:1068887
Tbr: cwallez@google.com
Change-Id: I22df67e28904c6733db151505b5bd93cac800e0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150420Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759228}

https://webrtc.googlesource.com/src.git/+log/3ebb6e93f417..43245c56b086

git log 3ebb6e93f417..43245c56b086 --date=short --first-parent --format='%ad %ae %s'
2020-04-15 handellm@webrtc.org Remove excessive log spam in large conferences in downstream project.
2020-04-15 mbonadei@webrtc.org Mark static const class/struct members as constexpr.

Created with:
  gclient setdep -r src/third_party/webrtc@43245c56b086

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1062963
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I69448bcc649674b067a036e87fa2b244d028f1be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150422Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759227}

In this CL password generation is extracted from SetFormFieldValueAction
to separate action.

Bug: 1064264

Change-Id: If111335c08ec91de250ad8ddc084d15d5ef73cc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146545
Commit-Queue: Milica Selakovic <selakovic@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Marian Fechete <marianfe@google.com>
Cr-Commit-Position: refs/heads/master@{#759226}