- 07 Jun, 2019 40 commits
-
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=hansberry@chromium.org Change-Id: I3659594870f528f8fa4523aeace161c246614ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649372 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#667306}
-
Yi Xu authored
Change-Id: Iabcb3d7c34f20376d02df420ef0baa4649d94219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645676 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#667305}
-
Ryan Hansberry authored
EasyUnlockServiceSignin assumes that it is called in a signin context, but in this particular codepath, ExistingUserController was calling it in a multi-signin context. In that multi-signin context, the EasyUnlockServiceSignin object being grabbed was already shut down, with deleted members -- its use caused a segfault. This CL makes that assumption clear and only uses EasyUnlockServiceSignin in a signin context. Also add check in EasyUnlockServiceSignIn::IsEnabled() that |pref_manager| is valid. Bug: 971202 Fix: 971202 Change-Id: Iccc86faaef74ac882bda34fbdde5e5c26394ceea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648674 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#667304}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c5c8ab626d5..452f5badf421 git log 4c5c8ab626d5..452f5badf421 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@452f5badf421 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I8febc0266c502bd7f60fa82df5757095d8132159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650042Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667303}
-
Wei-Yin Chen (陳威尹) authored
The thumbnails shown in the Grid Tab Switcher (GTS) were decoded from the ETC1 format, downsampled, and then transferred through the JNI boundary. This is not the most efficient way. This CL introduces JPEG thumbnails, which would be saved at the same time ETC1 thumbnails are saved, if GTS is enabled. The GTS would directly read and decode the JPEG files from the Java side. Bug: 971939 Change-Id: Iaf21ea2170afbb7b0385570459f4566715786ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648963Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667302}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cf4f55b6edc4..76904e283cfb Created with: gclient setdep -r src-internal@76904e283cfb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=thomasanderson@google.com,huangs@google.com,harrisjay@google.com,armax@google.com Change-Id: I577a60818594daf3f6aa75e18810567b15d80a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649646Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667301}
-
Charlie Reis authored
Now that we don't hit crashes from 575245 anymore, remove the DumpWithoutCrashing and update the CHECK to prevent regression. Bug: 575245 Change-Id: I9c66c870b978bd7db0e80f79703dd1c7864cc438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650148Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#667300}
-
Aleks Totic authored
While investigating youtube button, I've noticed that window resize was always causing double relayouts. What happens is that on window resize we do one layout, notice size has changed, and always force another layout. I think SetNeedsLayout call is not needed, as MarkViewportConstrainedObjectsForLayout will already mark ancestors for layout if needed. https://chromium-review.googlesource.com/c/chromium/src/+/1649086 Bug: 970171 Change-Id: I4b65486557a798ab00ca939baea93af3706bdccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649066Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#667299}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ac6fd191f872..139ad7226949 git log ac6fd191f872..139ad7226949 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 dhanyaganesh@chromium.org cros_buildresult: Do not initialize CIDB client 2019-06-07 kinaba@google.com chromeos_config: Switch reef-pfq from NYC to PI. Created with: gclient setdep -r src/third_party/chromite@139ad7226949 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I415affccf5b30f2d900a4a6024fc8adcc32a772b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649652Reviewed-by:
-
Ben Pastene authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/9b1b0ed1f31d..96f125709acf $ git log 9b1b0ed1f..96f125709 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 bpastene Revert "Fix logdog client library on windows." 2019-06-07 jbudorick subprocess42: allow configurable sleep duration in wait(). 2019-06-04 maruel Revert "[client] Rename third_party/pyasn1-modules to third_party/pyasn1_modules" Created with: roll-dep src/tools/swarming_client Bug: 971224 Change-Id: Ic7049a0c3cdc5388453458b66ab17f3f31fa7af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649307 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#667297}
-
Luum Habtemariam authored
Currently breaking a veyron build, bug linked below, since SocketManager is built regardless of libCUPS, but still technically depends on the kHttpMaxBufferSize constant in cups_proxy/public/cpp/cups_util. Though we could bring the constant to the SocketManager internals, there is no clear reason for SocketManager to be built this way so this just brings it in line with the rest of the service internals.. TBR=rockot@chromium.org,skau@chromium.org Bug: chromium:971906 Test: tests still pass && speculative build-breaking fix Change-Id: Ic9b873093152c4bff01ed940551db2cdf36605c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648747 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#667296}
-
Saman Sami authored
Skia's API is fixed to take be compatible with a const VkPhysicalDeviceFeatures. Change-Id: I5a38c1aeeace1788b1b46914c2201e56013bf6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650031 Auto-Submit: Saman Sami <samans@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#667295}
-
Matthew Webb authored
Builds out support for CTAP2.1 §5.7.5, cancelling an ongoing enrollment. The authenticator should always return success whether there is an enrollment or not. Change-Id: I1a99fb111c2f00d8fd016d2211e0fba9423dc1bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636227 Commit-Queue: Matthew Webb <noviv@google.com> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#667294}
-
Peng Huang authored
Bug: none Change-Id: I8e909c5f374198824ce843117b7cf9bed239c767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644152Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Nicolas Ouellet-payeur authored
This section shows: - URL configured for each of the 3 sitelists - Time of last refresh - Time of next refresh - A "Download now" button, to immediately refresh To make the "download now" button more usable, the entire page's contents also automatically refresh when LBS prefs change, or after XML sitelists are downloaded. https://imgur.com/a/yhRZnpZ Bug: 959379 Change-Id: I7517491d95bc9c570232d2080ee5aeead270b674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632001Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#667292}
-
Sean Gilhuly authored
Replce the DCHECK in SkiaOutputSurfaceImpl::RemoveRenderPassResource() with a test to see if the render pass has an entry in |render_pass_image_cache_| before trying to remove it. There isn't a known repro for this crash, but I suspect that using a bypass to draw the quad in SkiaRenderer::DrawRenderPassQuad() can cause the circumstances to arise. An entry for |render_pass_image_cache_| is created in MakePromiseSkImageFromRenderPass(), but this is skipped if a bypass quad is used, causing a difference between the render pass maps in SkiaRenderer and SkiaOutputSurfaceImpl. Bug: 959071 Change-Id: I4765f57eb30a7b4f14a559722e419ae526f79572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648326Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#667291}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ac53c42b09f3..28a5a4344adf git log ac53c42b09f3..28a5a4344adf --date=short --no-merges --format='%ad %ae %s' 2019-06-07 robertphillips@google.com Revise GrDataUtils to be more self-contained (take 3) 2019-06-07 egdaniel@google.com Reland "Reland "Remove support for copyAsDraw in gpu copySurface."" 2019-06-07 herb@google.com Remove advance only mode from SkGlyph. 2019-06-07 jlavrova@google.com SkParagraph 2019-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 386ae89d2b64..ed2c978cdeef (1 commits) 2019-06-07 jvanverth@google.com Another attempt at a shim to get sk_cf_obj landed. Created with: gclient setdep -r src/third_party/skia@28a5a4344adf The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: I0d156f2c4b62e8038d8f9f0b6762d213e38910eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649643Reviewed-by:
-
Xiaocheng Hu authored
When we encounter a preserved line break in relayout, we can't reuse its items if: - It was in a bidi context in a previous layout - It's in a bidi context in the current (re)layout We attempted to ensure that in crrev.com/c/1626498, but failed because a <span dir=ltr> creates bidi contexts without necessarily setting the NGInlineNodeData::is_bidi_enabled_ flag. This patch fixes the issue by adding a flag to LayoutText to indicate if the text has any bidi control items, so that when it's true and the text contains newlines, we don't reuse its old inline items. Bug: 966751 Change-Id: I63d95c9d1ddcffda62a5227d0d6166b2e9ce221a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649218 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#667289}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/24cf2606e421..17031afe184c git log 24cf2606e421..17031afe184c --date=short --no-merges --format='%ad %ae %s' 2019-06-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision add4dabf..25abf646 (667020:667125) Created with: gclient setdep -r src/third_party/webrtc@17031afe184c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7b3d35169c7783a3628a6ec8513dbc6fb004fc18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649386Reviewed-by:
-
siyua authored
Flag usage will be added in follow-up CL crrev.com/c/1616163 Bug: 964127 Change-Id: If68f27a302f78c3659b5bca31d042cf8a2062589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648600 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#667287}
-
Ryan Hansberry authored
Bug: None Change-Id: Ia1b97402c52c2de4e25e6b3cd7fb7cab906da78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646841 Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#667286}
-
Simon Que authored
CI Builders migrated: - Linux Builder - GPU Linux Builder Corresponding CQ builders migrated: - linux-rel - linux-dcheck-off-rel - linux_chromium_compile_rel_ng Bug: 950413 Change-Id: I5672b95ac72e46d9218c0b50c2ae361a502ffbcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648538Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Ahmed Fakhry authored
Depending on the availability of the Desks bar, windows in the grid as well as the no-recents widget should be centered in the effective grid bounds. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=970339 BUG=970339 TEST=Manual Change-Id: Ia81b7c100cbd124c8b74f8a9370449331012e5d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648558Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#667284}
-
Josh Nohle authored
Adds the abstract base class CryptAuthV2DeviceManager as well as a skeleton implementation, CryptAuthV2DeviceManagerImpl. These are top-level classes that coordinate CryptAuth v2 DeviceSync requests and local data storage between the CryptAuthScheduler, CryptAuthDeviceRegistry, CryptAuthKeyRegistry, and CryptAuthGCMManager. They also provide a top-level API for retrieving synced devices, forcing v2 DeviceSyncs, and accessing v2 DeviceSync request data such as last success time. The actual logic needed to perform the CryptAuth v2 DeviceSync flow will be delegated to a CryptAuthDeviceSyncer class that is not yet implemented. This class will operate in parallel with its CryptAuth v1 DeviceSync analog, CryptAuthDeviceManager. The CryptAuth v2 Enrollment analog is CryptAuthV2EnrollmentManagerImpl. Bug: 951969 Change-Id: I033c9f14102573cd3e057938b28882aa2edba12c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638351 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Alexei Filippov authored
BUG=967516 Change-Id: Ia459566db46fdde003c03ef9b14739ab739cb5b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636280 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#667282}
-
Thomas Tangl authored
...to track and record profile related usage metrics during runtime. Metrics are recorded per profile, i.e. each profile is assigned an ID which corresponds to a histogram bucket. The histogram Profile.BrowserActive.PerProfile is added. Bug: 965469 Change-Id: I2012eb8f3ec1a7ed6ddb54f703453d8d559d0f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625117Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#667281}
-
Erik Chen authored
When we use the hermetic toolchain, all binaries are specified by path. Since we no longer use xcrun to find the binaries, we also no longer need DEVELOPER_DIR. Bug: 971452 Change-Id: I46499bef18afc19e51aae943047fd33beecac75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650281Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667280}
-
Kurt Horimoto authored
This CL adds the classes to support showing JS confirmations via OverlayPresenter, and adds the confirmation coordinator to the OverlayModality::kWebContentArea supported classes list. Bug: 941745 Change-Id: Ib61f595fb2bf158ddfb05a83f3fe951a508fe5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639364 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#667279}
-
Natalie Chouinard authored
Before scheduling new notifications for prefetched offline pages, check the state of the Content Suggestions Notification preference setting. Start displaying the notification preference page on pre-O devices when the prefetched pages feature is enabled. On O+ devices, notifications are handled at the system level by Notification channels, so this pref can be ignored. Bug: 944912 Change-Id: I9e53fa2037952af4e98400416ed307ef8bbc3968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586595 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#667278}
-
Liquan(Max) Gu authored
Currently FCP++ is not enabled during web-test because the feature_list override the config of runtime_enabled_features. As FCP++ has now been enabled by default, we should change this config of feature_list as well. Bug:966216 Change-Id: I8785b6c31cf6fe7af3f9662c3af50262cd137977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645897Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#667277}
-
Zhenyao Mo authored
1) The unsandboxed GPU process exit message becomes an empty message. This is a regression. 2) We are still referring the GpuProcessHostUIShim class, which no longer exists in code base. BUG=971931 TEST=about:gpu R=piman@chromium.org Change-Id: I84caee9721fd6a9030fd310ba07505245245ff6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649184Reviewed-by:
-
Harley Li authored
In Application's service workers view, pass through the registrations' scope URLs directly from the backend to the frontend. Bug: 972106 Change-Id: Ieb20976e28e11c884d104a2a7f537fd78d7c686b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649305Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Harley Li <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#667275}
-
Alex Moshchuk authored
This is a reland of https://crrev.com/c/1647151, with the change to shorten one key's length to below 40 characters to avoid a failed breadpad assert on dbg bots. (See https://cs.chromium.org/chromium/src/third_party/breakpad/breakpad/src/common/simple_string_dictionary.h?l=206&rcl=1fc9cc0d0e1dfafb8d29dba8d01f09587d870026) Bug: 970046 Change-Id: I7564761b098ad7f8b64cc33527e01df135db9a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650202 Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#667274}
-
Chris Harrelson authored
Instead of computing deadlines and lifecycle counts relative to last observation, inject the latest lifecycle count of the releveant frame generator (LocalFrameView) and the actual start time of the lifecycle. This simplifies the code somewhat, improves dependencies, and has two concrete benefits: 1. Uses the same deadline for all locks executed on the same frame. Previously each lock would compute its own deadline at the time WillStartLifecycleUpdate was called. 2. Allows skipping lifecycles if desired. e.g. if a lock is updating, but we decide not to doing anything for it for a given frame, we can skip it. This CL achieves benefit #2; benefit #1 is a possible future addition. Note that WillStartLifecycleUpdate is still required for all locks which are currently acquiring, updating or committing (but not quiesecent locks). The reason it's required is that there may be forced style or layout computations between lifecycles, and those end up clearing the dirty bits of the lifecycle. There needs to be a mechanism to re-set those dirty bits, and WillStartLifecycleUpdate is that mechanism. Bug: 968928 Change-Id: Ibe7e2c51631e7a93101563db41a444d01ae54162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642789 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#667273}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=mattreynolds@chromium.org Change-Id: I36fdabd895249be6a9c2c00952b90a2ba3b0855e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648203 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#667272}
-
Sky Malice authored
Bug: 968213 Change-Id: I5270ccb000096f0517cb7c15ff14055a1bfb8471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649176Reviewed-by:
-
Michael Thiessen authored
Fixes https://chromium-review.googlesource.com/c/chromium/src/+/1639639 disabling shortcuts. Bug: 972130 Change-Id: I4947ba268586ee22832da795dea104be6a2f2b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649404Reviewed-by:
-
Jan Wilken Dörrie authored
This change replaces usages of base::ContainsKey() and base::ContainsValue() with base::Contains() in //device/fido. Reproduction: - sed -i 's/\bbase::ContainsKey\b/base::Contains/g' - sed -i 's/\bbase::ContainsValue\b/base::Contains/g' - git cl format This CL was uploaded by git cl split. R=engedy@chromium.org Bug: 970209 Change-Id: I00e6c5235e4e4e53429eed3cf3c3ac7d7df62165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648171 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#667269}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c843aa75..96e0999f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I59f0fae9aaedb0e16245843073fd6fe89f0cdb5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649149Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667268}
-
Lambros Lambrou authored
This changes OAuthTokenExchanger's default mode to offline. This ensures that a non-empty refresh token will actually be delivered to the caller on Windows, instead of an empty string. This CL also updates OAuthTokenExchanger so that it no longer triggers every hour if offline-mode is used to provide a refresh token. The effect of this CL on non-Windows platforms is that OAuthTokenGetter will get an exchanged refresh token and will cache it in memory, using it to get new access tokens every hour. This will avoid hitting the TokenExchange server every hour. Bug: 971920 Change-Id: Ic0d3e3a9ca5a5e627ae135bb005dc186ebfb4e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648730 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#667267}
-
