GitLab

Currently we clone all the layers to do animation during screen
rotation, which is slow on some of the devices. The solution is using
compositor copy request to flatten the layer hierarchy and make
animations more efficient.

BUG=678763
R=oshima@chromium.org, bruthig@chromium.org
TEST=Unittest with ScreenRotationAnimatorTest and Manual

Review-Url: https://codereview.chromium.org/2780823002
Cr-Commit-Position: refs/heads/master@{#462658}

The original metrics used units instead of enum.

BUG=699226

Review-Url: https://codereview.chromium.org/2802923003
Cr-Commit-Position: refs/heads/master@{#462657}

BUG=

Review-Url: https://codereview.chromium.org/2800683004
Cr-Commit-Position: refs/heads/master@{#462656}

Lots of interfaces, so can take a while to run. Use the 'long' timeout
option.

BUG=709030

Review-Url: https://codereview.chromium.org/2806513002
Cr-Commit-Position: refs/heads/master@{#462655}

This CL changes how new custom spelling words are added in the settings.
Rather than adding to the bottom of the list and trying to scroll to the
new word, the new word is added to the top of the list. This also keeps
the input field visible on long lists of words (it's frustrating to need
to repeatedly scroll to the top to add the next word).

BUG=708425
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2797133007
Cr-Commit-Position: refs/heads/master@{#462654}

This creates a D-Bus service that extracts a "Kiosk app" related method
from LibCrosService. Clients have to be migrated to this before the
corresponding method may be removed from LibCrosService.

BUG=703229
TEST=deploy_chrome, manually sent a message to new method, got response.

Review-Url: https://codereview.chromium.org/2798703002
Cr-Commit-Position: refs/heads/master@{#462653}

v8_enable_inspector was removed recently. Clean up remnants.

Also fixes a dependent gn check issue which blocked submission,
http://crrev.com/462467 did not update GN deps for new header.

BUG=645890,708965
TEST=none

Review-Url: https://codereview.chromium.org/2801123002
Cr-Commit-Position: refs/heads/master@{#462652}

All answer text (other than the suggestion text and positive/negative
text) is now dimmed.

BUG=709101

Review-Url: https://codereview.chromium.org/2798223004
Cr-Commit-Position: refs/heads/master@{#462651}

This patch adds a debugging function which can be used to retrieve
the current state of tile manager. Specifically, it logs some general
information like tree priority and memory use/limits. As well, it logs
the current raster queue and required for activation queue to see if
there is a mismatch between what is being rasterized vs what is being
considered for activation.

R=sunnyps@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2797883002
Cr-Commit-Position: refs/heads/master@{#462650}

Also, a little bit of cleaning mojo interface registration in
gpu_process_host.

BUG=698284

Review-Url: https://codereview.chromium.org/2803743002
Cr-Commit-Position: refs/heads/master@{#462649}

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Checkpoint| type
alias and a |checkpoint| accessor method (differing by case of the first
character); after a naive rename by the rewrite_to_chrome_style tool we
would end up with |Checkpoint| being the name of both the type and the
accessor method (with both living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=japhet@chromium.org

Review-Url: https://codereview.chromium.org/2800963003
Cr-Commit-Position: refs/heads/master@{#462648}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2e0c8d2c..126ec661

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2801993005
Cr-Commit-Position: refs/heads/master@{#462647}

Revert of cc: Always log shader compiler errors (patchset #2 id:20001 of https://codereview.chromium.org/2712033004/ )

Reason for revert:
Causes performance regression
BUG=699743

Original issue's description:
> cc: Always log shader compiler errors
>
> This is a catastrophic error, and should spam the console.
>
> BUG=695431
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2712033004
> Cr-Commit-Position: refs/heads/master@{#453019}
> Committed: https://chromium.googlesource.com/chromium/src/+/7d39070d75082cd35a08775dd792d67cd2beeb40

TBR=enne@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=695431

Review-Url: https://codereview.chromium.org/2799743005
Cr-Commit-Position: refs/heads/master@{#462646}

This patch starts removing script UISourceCodes when the parent
execution context gets destroyed.

Note: this patch removes only script-related UISourceCodes in
NetworkProject. The "debugger://" UISourceCodes, created by
DefaultScriptMapping, are kept intact. They come handy to reveal
location in old stacktrace/messages.

With this patch, all UISourceCodes created by networkProject have
a lifetime, defined by their parent model:
- DebuggerModel defines life-time for Script-related UISourceCodes
- CSSModel defines life time for CSS-related UISourceCodes
- SASSSourceMapping/CompilerScriptMapping define life-time of SourceMap
  Sources
- ResourceModel defines life-time for document/font/images
  UISourceCodes

For this reason, the NavigatorView no longer needs to listen to
FrameDetached/FrameNavigated events.

Drive-By: move DebuggerModel.scripts to the native Map.

R=dgozman
BUG=670180

Review-Url: https://codereview.chromium.org/2795193003
Cr-Commit-Position: refs/heads/master@{#462645}

1) Moved ComputeMarginsForChild to NGLayoutAlgorithm
2) Changed InlineLayoutAlgorithmTest to call ComputeMarginsForChild
   and pass them to NGFloatingObject

BUG=635619
TEST=NGInlineLayoutAlgorithmTest::PositionFloatsWithMargins

Review-Url: https://codereview.chromium.org/2798203002
Cr-Commit-Position: refs/heads/master@{#462644}

This was previously broken. Other input modalities were ignored during
multi-finger touch, and we incorrectly handled some of the multi-finger
cases as well, since we didn't update whether we were in a multi-finger
touch until the event ack.

BUG=None
TEST=RenderWidgetHostLatencyTrackerTest.WheelDuringMultiFingerTouch, MultiFingerTouchIgnored

Review-Url: https://codereview.chromium.org/2801043002
Cr-Commit-Position: refs/heads/master@{#462643}

virtual/gpu-rasterization/images/webp-color-profile-lossy.html
is passing, it seems, and needs new baselines.

virtual/gpu-rasterization/images/color-profile-filter.html
seems to be passing everywhere already.

virtual/gpu-rasterization/images/color-profile-background-clip-text.html
is no longer crashing and produces consistent result, but those results
are wrong due to crbug.com/670292. So rebaseline until we fix the bug.

TBR=noel@chromium.org
BUG=624709,587737,624233

Review-Url: https://codereview.chromium.org/2794403002
Cr-Commit-Position: refs/heads/master@{#462642}

For now we need to use the fake IME for both --mus and --mash.

There's still another startup crash, but that will take a little more
work to fix.

BUG=709097
TEST=manual
TBR=zork@chromium.org

Review-Url: https://codereview.chromium.org/2801923003
Cr-Commit-Position: refs/heads/master@{#462641}

This CL adds a few more methods that cause name collisions when Blink
is rewritten to match Chromium style:
- attrNodeList
- constructionStack
- counterMaps
- harfBuzzFontCache
- infoMap
- intervalArena
- originAccessMap
- presentationAttributeCache
- selectionVisualRectMap
- styleSharingList
- weakHeapObjectSet
- worldMap
- wrapperTypeInfo

BUG=582312

Review-Url: https://codereview.chromium.org/2799803003
Cr-Commit-Position: refs/heads/master@{#462640}

This CL reverts two landed CLs, namely:

https://chromium.googlesource.com/chromium/src.git/+/f59872240739c45017e90aa1be20548177d6df59
https://chromium.googlesource.com/chromium/src.git/+/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8

(reviewed in https://crrev.com/2771703002 and
https://crrev.com/2765723002, resp.), because they
seemed to have introduced a flake in the associated
LayoutTests.

TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org, bsalomon@google.com, tsepez@chromium.org

BUG=665488, 707689
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2799153005
Cr-Commit-Position: refs/heads/master@{#462639}

This is in keeping with other chromium code, and will let me take
advantage of other code that expects these types.

BUG=None

Review-Url: https://codereview.chromium.org/2801073002
Cr-Commit-Position: refs/heads/master@{#462638}

BUG=672263

Review-Url: https://codereview.chromium.org/2799683004
Cr-Commit-Position: refs/heads/master@{#462637}

BUG=702576

Review-Url: https://codereview.chromium.org/2786883008
Cr-Commit-Position: refs/heads/master@{#462636}

https://pdfium.googlesource.com/pdfium.git/+log/bf58fbb14a8b..deff61fe7368

$ git log bf58fbb14..deff61fe7 --date=short --no-merges --format='%ad %ae %s'
2017-04-06 dsinclair Cleanup tagged code.
2017-04-06 dsinclair Cleanup the tagged code
2017-04-06 dsinclair Remove the length reference from XMLSyntaxParser
2017-04-06 npm Change the CFDE_XMLSyntaxParser start and end types

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2803693005
Cr-Commit-Position: refs/heads/master@{#462635}

This change adds an ImageLayerBridge class that provides a direct
compositing path for displaying ImageBitmap objects, without
going through a blink paint pass.  As a consequence, there are
no more GPU readbacks when the source of the image is
GPU-accelerated.

In canvas rendering context classes, the notion of being
accelerated had to be decoupled from the notion of being
composited.  This is because non-accelerated canvases are
are directly composited with ImageBitmapRenderingContext.

BUG=696224, 585607
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2738573002
Cr-Commit-Position: refs/heads/master@{#462634}

Move all of the existing code for what used to be called
DisplayCompositor and is now MojoFrameSinkManager from various places to
a single target under src/components/viz/. This is the chunk of code that
both mus and non-mus will use to implement the FrameSinkManager
interface.

BUG=664547

Review-Url: https://codereview.chromium.org/2795823003
Cr-Commit-Position: refs/heads/master@{#462633}

This reverts sending the ECT header to the proxy server.
Note: doing this with fresh CL seems cleaner that backing out the
original 3 CLs - especially because we intend to revert this CL to put
back the ECT header after the M59 branch is cut.

[This is an alternative to gating behind a Feature in cl 2802463002]
BUG=707981

Review-Url: https://codereview.chromium.org/2807453002
Cr-Commit-Position: refs/heads/master@{#462632}

This allows us to capture what DirectComposition is actually displaying
and make GPU integration tests able to detect more possible problems.

The existing Aura capture path is used on Windows versions before 8.1,
because they don't support PW_RENDERFULLCONTENT and then PrintWindow may
not get the correct content.
NativeDesktopMediaList::CaptureAuraWindowThumbnail also will use the
aura path, because it's used in production for webrtc and needs to be
efficient.

BUG=702023
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2752373002
Cr-Commit-Position: refs/heads/master@{#462631}

Changes:
Reland reverted CL: crrev.com/2794153002 as it is not the reason causing the flaky test: AutofillInteractiveTest.AutofillAfterReload.

TBR=xiyuan@chromium.org, foolip@chromium.org
BUG=707977
test=none

Review-Url: https://codereview.chromium.org/2806583002
Cr-Commit-Position: refs/heads/master@{#462630}

In order to enable brightness adjustment from Android side, this cl provide
ArcBridge interfaces to ArcPowerManagerService on Android side:
- After PowerHost was initialized, UpdateScreenBrightnessSettings(.) will
 be called to notify Android side about current screen brightness.
- When changes occur for brightness setting on Android side,
 OnScreenBrightnessUpdateRequest(.) will be called to adjust the OS brightness.
- When OS brightness was changed, UpdateScreenBrightnessSettings(.) will
 be called to notify Android side about the change.

BUG=b/36129958

Review-Url: https://codereview.chromium.org/2805433002
Cr-Commit-Position: refs/heads/master@{#462629}

There are a slew of failures that need to be investigated. Rather than
early out all the tests I'm adding a filter file. This makes it easier
to retry tests as functionality is addded.

I've also cleaned up a handful of things in looking at failures.

BUG=705715
TEST=this is test change
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2803933003
Cr-Commit-Position: refs/heads/master@{#462628}

This CL adds a few more methods that cause name collisions when Blink
is rewritten to match Chromium style:
- accumulatorMap
- eventTargetDataMap
- heapObjectSet
- qualifiedNameCache
- selectorTextCache

BUG=582312

Review-Url: https://codereview.chromium.org/2805043003
Cr-Commit-Position: refs/heads/master@{#462627}

We add 3 'internal' metrics to make sure DelayNavigationThrottle is
adding the expected delays, and to understand the difference between
the specified delay and the actual delay. We expect there to be
differences in cases where the main UI thread is congested, for example.

BUG=704117

Review-Url: https://codereview.chromium.org/2803673002
Cr-Commit-Position: refs/heads/master@{#462626}

Will now parse the basic-card payment method and return that as the
|method_name| if appropriate.

BUG=708052
TEST=ios_chrome_unittests

Review-Url: https://codereview.chromium.org/2803543005
Cr-Commit-Position: refs/heads/master@{#462625}

BUG=706511

Review-Url: https://codereview.chromium.org/2806533002
Cr-Commit-Position: refs/heads/master@{#462624}

This one is for the existing DCHECKS which were already present.

BUG=697685
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2770203002
Cr-Commit-Position: refs/heads/master@{#462623}

All platforms now specify whether to emit frame pointers by default, rather than
relying on default compiler options.

This CL moves the logic from config("default_stack_frames") into compiler.gni.
The former is actually the right place for the logic to live, but there exists
code that relies on whether a frame pointer is emitted by default. Right now,
that logic is being duplicated/guessed by the code in question. This CL at least
unifies the logic in a single location.

There current exists code that uses a preprocessor definition
HAVE_TRACE_STACK_FRAME_POINTERS. Despite the name, the code really wants to know
if most stacks can be unwound using stack pointers. I've renamed it to
CAN_UNWIND_WITH_FRAME_POINTERS. Arguably, any code that uses
CAN_UNWIND_WITH_FRAME_POINTERS is broken and should be removed, since it relies
on the assumption that all stacks will either have or not have frame pointers,
but that can vary TU by TU.

BUG=706116, 706654

Review-Url: https://codereview.chromium.org/2782063005
Cr-Commit-Position: refs/heads/master@{#462622}

"host_whitelist" QUIC parameter is deprecated starting from version 31 (see https://cs.chromium.org/chromium/src/net/http/http_stream_factory_impl_job_controller.cc?type=cs&q=%22The+QUIC+whitelist+is+not+needed+in+QUIC+versions+after+30.%22&l=913).

Removed the parameter from the Cronet tests but kept it in the Cronet implementation since there still may be servers that speak QUIC prior 31.

BUG=702412
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2798403002
Cr-Commit-Position: refs/heads/master@{#462621}

This CL filters encoded binary protobuf signaled by "***BINARY RUN
STATS***" and program class information signaled by "ProgramClass:".
This extra output is introduced by updating proguard.

BUG=674152

Review-Url: https://codereview.chromium.org/2801443002
Cr-Commit-Position: refs/heads/master@{#462620}

BUG=709115
TBR=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2805533004
Cr-Commit-Position: refs/heads/master@{#462619}