- 12 Sep, 2017 40 commits
-
-
Bruce Dawson authored
This reverts commit 3b6c1aa7. Reason for revert: SUMMARY: AddressSanitizer: heap-use-after-free chromeos/network/network_state.h:56:33 in visible Original change's description: > NetworkStateHandler: Add EnsureCellularNetwork > > This CL provide support for Cellular devices with no service: > * Cellular networks all use the same specifier so that the guid > remains consistent (we only support one Cellular Service) > * Assume a SIM may be present unless Cellular.NetworkTechnology > is CDMA so that the SIM UI shows up even if NetworkTechnology > is unset (e.g. because there is no Service). > * Create a dummy Cellular NetworkState when none exists so that > Cellular Device properties are translated and passed to the UI. > This also allows Cellular network UI to be shown so that > Device properties can be viewed and SIM and FoundNetworks may > be selected. > > Bug: 717063 > Change-Id: I1e23e7ba48821124ad219bb67fea2ca86e2d6ccd > Reviewed-on: https://chromium-review.googlesource.com/653723 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Ben Chan <benchan@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501337} TBR=stevenjb@chromium.org,benchan@chromium.org,khorimoto@chromium.org Change-Id: I073a95d8160812923cbcc192f0afe934db672a40 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 717063 Reviewed-on: https://chromium-review.googlesource.com/662958Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#501412}
-
Stephen Martinis authored
Process for this was to look at the bot currently running blink_perf.owp_storage, and see if the bot had time. This is fairly manual right now; in the future we'll make this much more automated. Bug: 762468 Change-Id: I259a72919f113e99cf0dea8f3881059401271f79 Reviewed-on: https://chromium-review.googlesource.com/663837Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#501411}
-
Dmitry Gozman authored
Currently we mark targets as 'other' based on WebContents being present in TabStripModel, which is timing-dependent. This patch marks everything not quialified for other types as 'page', making target type consistent. Bug: 759783 Change-Id: I0b26ee12474b004121e3e0083d67eb809b4eba11 Reviewed-on: https://chromium-review.googlesource.com/639024Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501410}
-
Peter Kotwicz authored
Bug=713655 Change-Id: I0f5d91caf5568bfd2048c4895b45c9ab58067380 Reviewed-on: https://chromium-review.googlesource.com/651549 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501409}
-
Becca Hughes authored
Add a feature flag ("OverflowIconsForMediaControls") to hide/show icons on the overflow menu displayed on the native media controls. BUG=763301 Change-Id: I719e46b690ca52d5bfdd3619c18cbd1f1d9ebd2b Reviewed-on: https://chromium-review.googlesource.com/659917Reviewed-by:Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#501408}
-
Matt Mueller authored
cert_verify_proc_builtin.cc, cert_verify_proc_android.cc, cert_issuer_source_aia.cc Bug: Change-Id: I94988d1de99cb8395701b4ce50c302cb504a51d3 Reviewed-on: https://chromium-review.googlesource.com/662157Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#501407}
-
Geoff Lang authored
Revert changes to gl_tests that worked around the missing default framebuffer. BUG=665521 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8d7f69790eba8a8a13c240708e3143b726c7e05c Reviewed-on: https://chromium-review.googlesource.com/639193Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#501406}
-
Helen Li authored
This CL removes SDCH code from src/chrome/. This CL is one of the CLs to remove SDCH from Chromium. SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread linked below. Bug: 762686 Change-Id: If9dbf8ce17aa026f9b0f2ce631669756f4be1e28 Reviewed-on: https://chromium-review.googlesource.com/663621 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#501405}
-
Changwan Ryu authored
In my previous attempt to fix Japanese keyboard behavior (https://chromium-review.googlesource.com/636107), I was finishing composition text *after* restoring deleted text. This works on most Japanese keyboards, but Google Japanese keyboard behaves weirdly, as it calls setComposingText([text], 1) again which moves the cursor position. This can be fixed by finishing composition first, and then restoring text. BUG=758443 Change-Id: I1f3f4b64e1fa6aa6bdec198f4693be919e50681e Reviewed-on: https://chromium-review.googlesource.com/663202Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#501404}
-
Sergey Ulanov authored
UDPSocketTest.PartialRecv depends on MSG_TRUNC, which wasn't supported in older versions of SDK. The test needs to be disabled temporarily because the recent SDK roll had to be reverted. TBR=scottmg@chromium.org NOTRY=true Bug: 731302 Change-Id: I5b4ec03ccabb60d1719ce2088831183a8a54c045 Reviewed-on: https://chromium-review.googlesource.com/662881 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#501403}
-
Jingkui Wang authored
This patch removes the gaming seat implementation for evdev. All the gamepad support will use ozone implementation. This patch also removes the dummy interface for gaming_input_v1 in Wayland server. The dummy interface was there to make sure the system is robust when we moved the protocol to v2. Bug: 717246 Change-Id: I70b29d3c6a81761d1e15c502f78fd0615bf768fe Reviewed-on: https://chromium-review.googlesource.com/661100 Commit-Queue: Jingkui Wang <jkwang@google.com> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501402}
-
Alex Chu authored
from AwSettings. Change-Id: Id4092f3588713e76419c87afa5dabec0168e5bd5 Reviewed-on: https://chromium-review.googlesource.com/651748 Commit-Queue: Alex Chu <alexchu@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#501401}
-
Sergey Ulanov authored
This reverts commit 4de6f139. Reason for revert: net_unittests failures Original change's description: > Roll Fuchsia SDK to d7db7f4e971de73ccec78eaf6c34a0f424e8831f > > Following issues are fixed in this version: > 1. NET-170: MSG_TRUNC support in recvmsg(). > 2. NET-120: asynchronous connect(). > > NOTRY=true > > Bug: 731302, 707030 > Change-Id: I74047a9d86fe4bce6c384658676903b115ed437a > Reviewed-on: https://chromium-review.googlesource.com/661298 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501096} TBR=sergeyu@chromium.org,scottmg@chromium.org Change-Id: I30e9140ea3d7a1119a234e74828d527b9214c782 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 731302, 707030 Reviewed-on: https://chromium-review.googlesource.com/663498Reviewed-by:
-
Tom Anderson authored
This is a reland of 54a27d88 Original change's description: > Switch RPM packager to use new dependency system > > BUG=758654 > R=thestig@chromium.org > > Change-Id: Ib64eb4ace73d7803b083f4d40795193dedc288f7 > Reviewed-on: https://chromium-review.googlesource.com/655943 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501104} Bug: 758654 Change-Id: I120e58c8535e86b1504422af3847cdc899e3110a Reviewed-on: https://chromium-review.googlesource.com/663567Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#501399}
-
James Cook authored
For go/mustash chrome browser code cannot call directly into ash. ash/wm/window_util.h is one of the most common ash headers used in chrome, so eliminate some usage. Replace ash::wm::Foo() calls with their core wm::Foo() equivalents where the windows are clearly browser windows or browser-owned windows (like platform apps). Convert GetActiveWindow() usage to IsActiveWindow() where the activation client is not known. Fix DEPS to ban this header. Bug: 678705, 756085 Test: browser_tests, unit_tests, manually switch multiprofile users with multiple browser windows open Change-Id: Ifde5f1119b4818a7bde58dcdd3eafaef187ace71 Reviewed-on: https://chromium-review.googlesource.com/661793 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#501398}
-
Kyle Horimoto authored
This ensures that there is no possibility for pending network connection or disconnection requests when shutdown occurs. Leaving these pending could leave the network stack in a bad state. The original CL landed as [1] and was reverted as [2] due to an ASAN bot failure. I've uploaded the original CL as patch 1 on this CL, and my fix as patch 2. [1] https://chromium-review.googlesource.com/c/chromium/src/+/656570 [2] https://chromium-review.googlesource.com/c/chromium/src/+/659377 Bug: 761541, 672263 Change-Id: I3e9beb0ad62fb92ca202f391229dbc46c9110b18 Reviewed-on: https://chromium-review.googlesource.com/663673Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#501397}
-
Xi Han authored
In the WebAPKs' dialog, there are 12dp padding between the title and the content. Currently, these padding are added as the top padding of the content, leaving no padding below the title. It looks fine on L+, but looks tight on pre-L which has a blue line between the title and the content. In this CL, we split the padding as 6dp above the blue line, and 6dp under the blue line. Before: https://drive.google.com/open?id=0B7zEF5GgyYmpLU9SendyX00zZlk After: https://drive.google.com/open?id=0B7zEF5GgyYmpTEVBUnB6UXhaMDg Bug: 759582 Change-Id: Iabc96357fb0741889751d2c59ba35c829e6b6863 Reviewed-on: https://chromium-review.googlesource.com/663614Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#501396}
-
Kent Tamura authored
bindings: generate_conditional_features.py and generate_init_partial_interfaces.py should support snake_case generated files. Bug: 760462 Change-Id: I328d61432cbfb74e2490831543632f779940368a Reviewed-on: https://chromium-review.googlesource.com/662502 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#501395}
-
Dave Schuyler authored
This CL expands the usage of cr-link-row into settings. This doesn't replace all instances of link rows. It's a sampling of a few different cases. Changes UI for: device display overscan, customize fonts, passwords and forms links. Bug: 757663, 763177 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id63d8b8c5a6c3c36e6804018ea66d8d03679f1ad Reviewed-on: https://chromium-review.googlesource.com/656527Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#501394}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/79a1256c2233..a640c49b7ecf $ git log 79a1256c2..a640c49b7 --date=short --no-merges --format='%ad %ae %s' 2017-09-11 csmartdalton Minor cleanups for CCPR 2017-09-12 rmistry Fix behavior of automatically adding 'Cq-Include-Trybots' in presubmit 2017-09-12 rmistry Add checks for 'DO NOT''SUBMIT' in description and file content 2017-08-25 wangxianzhu Optimize filterBounds() of SkArithmeticImageFilter/SkXfermodeImageFilter Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I7ccba3de4e805caa2fe6bf54d44bd807bafe2b1a Reviewed-on: https://chromium-review.googlesource.com/664060Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501393}
-
Bin Zhao authored
Usage: "--enable-features=EnableCastDiscovery,EnableCastChannelRetry<MyStudyName --force-fieldtrials=MyStudyName/Group1 --force-fieldtrial-params= MyStudyName.Group1:initial_delay_ms/20000/max_retry_attempts/20/exponential/3.0" - Added a finch feature "EnableCastChannelRetry" and made retry strategy parameters configurable - Added CastMediaSinkServiceImpl::InitRetryParameters to parse feature parameters Bug: 752310 Change-Id: I13d4c3eb8d27de32bbe08fe62a8d4f3cd096776d Reviewed-on: https://chromium-review.googlesource.com/639671 Commit-Queue: Bin Zhao <zhaobin@chromium.org> Reviewed-by:Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#501392}
-
Sidney San Martín authored
A few times, I've seen the a download complete exceptionally quickly and leave the filename positioned as if there's status text, but there isn't. I can't reproduce it consistently, but one possibility is that `statusTextView_.hidden` is a bad signal for whether the layout needs to change (it can be hidden for other reasons, like a dangerous download). This change stops using `hidden` to decide whether to change states, which is an improvement either way. Bug: 589943 Change-Id: I491c06f57860315068fa719f046032353cb2db1e Reviewed-on: https://chromium-review.googlesource.com/664137Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#501391}
-
Yuke Liao authored
This CL adds an assertion to make sure that the user specified profile data file exists. Bug: 763962 Change-Id: I2a8830ad8fc7ca1a5f91e739ba3107ac70e3a2eb Reviewed-on: https://chromium-review.googlesource.com/662237 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#501390}
-
Matthew Jones authored
This change introduces the concept of 'state change reason' to the bottom sheet. Once setSheetState is called with a reason, that reason persists through all the events until the sheet reaches its final state or setSheetState is called again. This change allows users of the API to make more nuanced decisions based on what caused the bottom sheet to, for example, open. The first change to use this API is the placeholder content in the content controller. If the sheet is opened because of the omnibox focusing, the placeholder will be shown instead of suggestions. Previously this was done by immediately replacing the suggestions content when the omnibox gained focus. BUG=764391 Change-Id: I4fb129037b9fc8981ad5793fff5589524300b5a2 Reviewed-on: https://chromium-review.googlesource.com/656078 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/4588792ebfcf..8ac74971a335 $ git log 4588792eb..8ac74971a --date=short --no-merges --format='%ad %ae %s' 2017-09-12 rharrison Remove ASSERT that was added to understand what was occuring Created with: roll-dep src/third_party/pdfium BUG=763369 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ia6cc6d39429b22eebd3b830226173c444609deef Reviewed-on: https://chromium-review.googlesource.com/663604 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501388}
-
Mathieu Perreault authored
Bug: 764382 Change-Id: Ife477677e89c55257ba0cf537dedb0000e8c7d54 Reviewed-on: https://chromium-review.googlesource.com/663559 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501387}
-
Peter Kotwicz authored
BUG=None Change-Id: If8af3d78990904f6b934f54bc853ed690e0a1eeb Reviewed-on: https://chromium-review.googlesource.com/660718Reviewed-by:
-
Charles Harrison authored
This CL should not change behavior. We could probably remove the param from WebContentsDelegate::AddWebContents but some delegates actually set it, so the change would be more complicated and could change behavior. Bug: None Change-Id: I2b25c7ae4fb86c2aad386697832bb5017ea7744f Reviewed-on: https://chromium-review.googlesource.com/655126Reviewed-by:
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/000134387797..7370e9da6e0c $ git log 000134387..7370e9da6 --date=short --no-merges --format='%ad %ae %s' 2017-09-12 benjhayden Document diagnostics required by dashboard. 2017-09-12 hjd tracing: Add private footprint 2017-09-12 loloangela Fix errors related to invalid-name pt. 6 2017-09-12 stephen.kyle tracing: include start,end events in loading_metric's other timeTo metrics Created with: roll-dep src/third_party/catapult BUG=737325 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie0aed1db0d86824075dafd9cf7958f68be979999 Reviewed-on: https://chromium-review.googlesource.com/663613 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501384}
-
Pavel Feldman authored
Bug: 753159 Change-Id: I2415b1def48ab5ba7fbbd29e586304ce5655ad1e Reviewed-on: https://chromium-review.googlesource.com/646732 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#501383}
-
Nate Chapin authored
Cancelling a font load can start a new fallback load inside ResourceFetcher::StopFetching. This is a problem if StopFetching() is called due to the ResourceFetcher detaching, and leaves a semi-detached resource load in progress. Bug: 763040, 763387 Test: http/tests/webfont/multiple-font-src-detach.html Change-Id: If366431abc4752b61d760d10687fd4a81d78ebc1 Reviewed-on: https://chromium-review.googlesource.com/663880Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#501382}
-
Matt Wolenetz authored
Parameterizes all SourceBufferStreamTests by which version of the buffering API is being tested; the test ctor forces on/off the media::kMseBufferByPts feature accordingly. Immediate follow-on work will be to enable the kNewByPts versions of these SBS tests (possibly in incremental CLs) along with corresponding production impl, while still also testing the 'legacy' buffering-by-DTS implementation. BUG=718641 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I40e29ac5775301ad69e305e9f0a521a5d5b3711a Reviewed-on: https://chromium-review.googlesource.com/663879Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#501381}
-
mark a. foltz authored
The limit was in place for Cast applications as 64k message size is a limitation of the browser => Cast channel. However, this does not apply to generic presentations. Verified that the Cast SDK enforces its own limits. Bug: 524128 Change-Id: I16f5664329b9d5504154c6e0f79be666d4ab61b9 Reviewed-on: https://chromium-review.googlesource.com/634523 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#501380}
-
Sebastien Seguin-Gagnon authored
This reverts commit 3fc7721d. Reason for revert: Suspecting this CL for the 3 consecutive failures of the TextSuggestionMenuTest#menuDismissesWhenTappingOutside test. see builds: https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/15165 https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/15166 https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/15167 Log: junit.framework.AssertionFailedError: Criteria not met in allotted time. at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.assertTrue(Assert.java:20) at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:79) at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:117) at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:138) at org.chromium.content.browser.input.TextSuggestionMenuTest.waitForMenuToHide(TextSuggestionMenuTest.java:195) at org.chromium.content.browser.input.TextSuggestionMenuTest.menuDismissesWhenTappingOutside(TextSuggestionMenuTest.java:170) at java.lang.reflect.Method.invoke(Native Method) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37) at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55) at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:175) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:40) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:164) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at org.junit.runner.JUnitCore.run(JUnitCore.java:115) at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59) at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262) at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:98) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879) Original change's description: > Add support for Android SuggestionSpans > > This is the final CL to add support for Android SuggestionSpans (at least ones > not marked with FLAG_MISSPELLING; there will be one or more additional CLs to > add support for those). This CL includes: > > - Changes to ImeAdapter to make it pass SuggestionSpans into > InputMethodController > > - Changes to InputMethodController to make it create suggestion markers from the > passed-in SuggestionSpans > > - Additional methods in TextSuggestionController for getting the list of text > suggestions under the cursor, and applying a suggestion > > - More Mojo code to pass information about text suggestions back-and-forth > between browser and renderer code > > - Changes to SuggestionsPopupWindow and TextSuggestionHost so we can show either > a spell check or a text suggestion menu > > Bug: 672259 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I3f30543586901baec4648d265874a303efafbd44 > Reviewed-on: https://chromium-review.googlesource.com/627172 > Commit-Queue: Ryan Landay <rlanday@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Alexandre Elias <aelias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501335} TBR=yosin@chromium.org,dtrainor@chromium.org,torne@chromium.org,aelias@chromium.org,tedchoc@chromium.org,changwan@chromium.org,xiaochengh@chromium.org,rsesek@chromium.org,rlanday@chromium.org Change-Id: I24641a2a43dffe8056a231a676033bcff39bcae7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 672259 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/663760Reviewed-by:
-
Wenzhao Zang authored
The interface is used to close the note taking app from the views-based login shelf. Also added TestTrayActionClient which are shared by various unit tests. Bug: 701157 Change-Id: I88c871f1597369f11b5b2c9d1c3548c790c0b088 Reviewed-on: https://chromium-review.googlesource.com/656059Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#501378}
-
sebsg authored
Bug: 764464 Tbr: miu@chromium.org Change-Id: Ibe3cc60266d1c20c79fe6f4b742f882426796ced Reviewed-on: https://chromium-review.googlesource.com/664065Reviewed-by:
-
Brett Wilson authored
Part 3/4 to replace these namespace qualifications. TBR=dcheng@chromium.org Bug: 763556 Change-Id: I052b146dd2ce9f5e3997ab5ae1e362b2422fb03e Reviewed-on: https://chromium-review.googlesource.com/662140Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I64abe06057f9978289ec183a28a6c756fdf40aa1 Reviewed-on: https://chromium-review.googlesource.com/661784 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#501375}
-
Matt Mueller authored
Windows has been on use_byte_certs since M61. Bug: 671420 Change-Id: I78c7f7f2a2e94ebd18d4d0c76909a9549231ec85 Reviewed-on: https://chromium-review.googlesource.com/661885Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#501374}
-
John Rummell authored
Add versioning to functions that query the storage ID. This will enable changes in the future if Chrome ever needs to use a different method of determining the ID. Pepper will only support a single version (version 1). BUG=478960 TEST=EME browser_tests pass Change-Id: Iea2d3ef00f3e8a3316952e0061dbbf666a2798bb Reviewed-on: https://chromium-review.googlesource.com/661117Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#501373}
-
