GitLab

There are two places we check to see if we need uninstall-install. The first is on startup when the extension system is ready (in response to the ExtensionSystem::ready() OneShot timer). If the extension is currently pending, then we'll check again when we get the notification that the extension has installed when OnExtensionInstalled is called.

The function MaybeUninstallHotwordExtension does a series of checks to determine if we should uninstall the extension based on pending installs and previous vs. current locale. If an uninstall is necessary, it kicks it off. 

Upon Uninstall, OnExtensionUninstalled is triggered. When OnExtensionUninstalled is triggered for the hotword extension, it will reinstall it and update the previous locale (language). If the user goes in to try to uninstall the hotword extension manually, this change will also force it to be reinstalled.

This will trigger a second call to OnExtensionInstalled. To prevent a loop, we use HotwordService::uninstall_pending_ to prevent another uninstall attempt.

This CL also removes the dependency on the deprecated NOTIFICATION_EXTENSION_INSTALLED as a side effect.

Several unittests were added to the unittest suite to test various parts of the uninstall-install pipeline. In order to have access to the extension system during tests, the HotwordServiceTest now extends ExtensionServiceTestBase.

BUG=345806

Review URL: https://codereview.chromium.org/330193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278644 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
This is causing the following error when running gyp_chromium with disable_nacl=1:

Traceback (most recent call last):
  File "./build/gyp_chromium", line 314, in <module>
    gyp_rc = gyp.main(args)
  File "/chromium/src/tools/gyp/pylib/gyp/__init__.py", line 527, in main
    return gyp_main(args)
  File "/chromium/src/tools/gyp/pylib/gyp/__init__.py", line 503, in gyp_main
    options.circular_check)
  File "/chromium/src/tools/gyp/pylib/gyp/__init__.py", line 129, in Load
    params['parallel'], params['root_targets'])
  File "/chromium/src/tools/gyp/pylib/gyp/input.py", line 2759, in Load
    RemoveLinkDependenciesFromNoneTargets(targets)
  File "/chromium/src/tools/gyp/pylib/gyp/input.py", line 1483, in RemoveLinkDependenciesFromNoneTargets
    if targets[t].get('variables', {}).get('link_dependency', 0):
KeyError: '/chromium/src/components/nacl.gyp:nacl_loader_unittests#target'


Original issue's description:
> Isolate nacl_loader_unittests
> 
> Isolate the Linux-only nacl_loader_unittests.
> 
> BUG=384515
> TBR=maruel
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278620

TBR=vadimsh@chromium.org,mseaborn@chromium.org,maruel@chromium.org,jln@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=384515

Review URL: https://codereview.chromium.org/348803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278643 0039d316-1c4b-4281-b951-d872f2087c98

This is causing failures on  Linux Chromium OS ASan LSan Tests (3), see
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/1905


> Wire up component cloud policy to device local accounts.
> 
> This enables policy-for-extensions running in Public Sessions, and for
> extensions running as Kiosk Apps too.
> 
> TBR=bartfab@chromium.org
> BUG=224596
> 
> Review URL: https://codereview.chromium.org/341043005

TBR=joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/343103005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278642 0039d316-1c4b-4281-b951-d872f2087c98

Parse full names more intelligently with a rough port of the Android contact name splitter. Only does Western names well; CJK are TODO.

Save and sync the full name separately from the name pieces.

BUG=241886

Review URL: https://codereview.chromium.org/310463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278641 0039d316-1c4b-4281-b951-d872f2087c98

Pass in a set of requested favicon pixel sizes to the HistoryService instead of a desired size in DIP and a set of desired scale factors.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/336423006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278640 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/342983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278639 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278638 0039d316-1c4b-4281-b951-d872f2087c98

This is for supporting uploading files from those file systems
(MTP, providedFS) to web pages, by a workaround before the
long term solution resolving the issue crbug/126902 comes.

BUG=383207
R=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/339323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278637 0039d316-1c4b-4281-b951-d872f2087c98

Result: 283628 => 128506 bytes (155122 bytes: 54%)

R=newt@chromium.org

Review URL: https://codereview.chromium.org/334053007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278635 0039d316-1c4b-4281-b951-d872f2087c98

BUG=181082,181680,222880,222887,241932,243137,255718,290364,290405,290440,290443,290559,293033,332329
NOTRY=true

Review URL: https://codereview.chromium.org/343113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278634 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278633 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the bug of html-inliner (see the bug for detail).

BUG=383189
TBR=bratell@opera.com, pastarmovj@chromium.org

Review URL: https://codereview.chromium.org/345873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278632 0039d316-1c4b-4281-b951-d872f2087c98

The cause of the flakiness should have been fixed in r277688

BUG=248873,248500,294196

Review URL: https://codereview.chromium.org/345733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278631 0039d316-1c4b-4281-b951-d872f2087c98

BUG=309468
TBR=hajimehoshi@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/343073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278630 0039d316-1c4b-4281-b951-d872f2087c98

Includes some minor refactoring: merges launcher_item_util.cc into
ash:shelf_util.cc

BUG=385161
R=ben@chromium.org, skuhne@chromium.org

Review URL: https://codereview.chromium.org/332163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278629 0039d316-1c4b-4281-b951-d872f2087c98

Note: This file is just documentation, and not for actual use. It was
already previously actually removed from the bindings.

TBR=sky@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/347563007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278628 0039d316-1c4b-4281-b951-d872f2087c98

Make event filtered by viewInstanceId instead of instanceId for guests.

BUG=

Review URL: https://codereview.chromium.org/333713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278627 0039d316-1c4b-4281-b951-d872f2087c98

Added sandbox_linux_unittests test to
linux_arm_cross_compile/linux_arm_tester builders on the
tryserver.chromium waterfall.

R=phajdan.jr@chromium.org
BUG=386445
NOTRY=true

Review URL: https://codereview.chromium.org/342943007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278626 0039d316-1c4b-4281-b951-d872f2087c98

Implement fake methods in TestSearchTermsData to test TemplateURL's code without relying on UIThreadSearchTermsData's behavior.

BUG=371535
TEST=unit_tests

Review URL: https://codereview.chromium.org/344083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278625 0039d316-1c4b-4281-b951-d872f2087c98

Generated using
src/tools/metrics/histograms/update_use_counter_feature_enum.py

Corresponding Blink changes:
https://codereview.chromium.org/337283003 (by mahesh.kk@sumsung.com)
https://codereview.chromium.org/339563004 (by me)

NOTRY=true
BUG=383749

Review URL: https://codereview.chromium.org/342113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278624 0039d316-1c4b-4281-b951-d872f2087c98

Isolate the Linux-only nacl_loader_unittests.

BUG=384515
TBR=maruel
NOTRY=true

Review URL: https://codereview.chromium.org/322333006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278620 0039d316-1c4b-4281-b951-d872f2087c98

The source of the flakiness should have been fixed in r277688

BUG=171450

Review URL: https://codereview.chromium.org/337213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278619 0039d316-1c4b-4281-b951-d872f2087c98

This adds a few experimental versions of the new malware interstitial. They are all teh addition of an extra string.

1. Prior history
2. "(not recommended)" next to link
3. Advice
4. Social proof

BUG=386033

Review URL: https://codereview.chromium.org/346733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278618 0039d316-1c4b-4281-b951-d872f2087c98

This CL also re-enables NaClBrowserTestNewlib.Bad. This test was
disabled because there were unautomated "visual tests" embeded in the
test's html. These embeds declared a pdf content type.  When the PDF
plugin was open sourced, this content type started being recognized
and the test broke.

This test was historically flaky, however. One reason  was that pauses
caused by the OS crash catcher could cause the test to time out. The
OS crash catcher was triggering because NaCl calls abort() in response
to many fatal errors. This test is being re-enabled to show abort is
no longer triggering the crash catcher.

BUG=375103

Review URL: https://codereview.chromium.org/347803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278617 0039d316-1c4b-4281-b951-d872f2087c98

Fix up some references in content and webkit for targets that now exist.

TBR=hclam@chromium.org

Review URL: https://codereview.chromium.org/344873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278616 0039d316-1c4b-4281-b951-d872f2087c98

This makes the backspace key on the qwerty keyboard to behave like
an emulaed backspace key on a braille display when the IME is in braille
keyboard on standard keyboard mode.

BUG=310285
R=dtseng@chromium.org

Review URL: https://codereview.chromium.org/348533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278615 0039d316-1c4b-4281-b951-d872f2087c98

WTHMojo was unable to observe bounds changes from its associated Node. Instead WTHMojo is now bound to a Node & derives bounds from it.

R=sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/341953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278614 0039d316-1c4b-4281-b951-d872f2087c98

patch from issue 342553006

BUG=
android failures unrelated to this CL
NOTRY=True

Review URL: https://codereview.chromium.org/344793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278613 0039d316-1c4b-4281-b951-d872f2087c98

Current value is at 50k, which is actually the average log
size on a lot of platforms. Increase it to 100k for a more
reasonable default that should cover the majority of cases
where logs are discarded due to this size limit according
to UMA data.

BUG=380282

Review URL: https://codereview.chromium.org/313613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278612 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278611 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/30e6e2af14e84216b1c113fd7500d0822bc81daa..9efd66b8451f25465abd1027e09a3bcfa7b9c554

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=reed@google.com
BUG=
android_aosp failure unrelated
NOTRY=True

Review URL: https://codereview.chromium.org/338893005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278610 0039d316-1c4b-4281-b951-d872f2087c98

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3881

Review URL: https://codereview.chromium.org/345733007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278609 0039d316-1c4b-4281-b951-d872f2087c98

These components are needed by chrome/common.

This also adds a "components" meta-target to avoid listing all components in the root build file.

TBR=blundell

Review URL: https://codereview.chromium.org/344993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278608 0039d316-1c4b-4281-b951-d872f2087c98

This tool has not been maintained or used in a while, and tools such as UMDH work well as a replacement.

BUG=383024

Review URL: https://codereview.chromium.org/314253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278607 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357693

Review URL: https://codereview.chromium.org/345733006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278606 0039d316-1c4b-4281-b951-d872f2087c98

Instead of storing full copies of every backing file's path, re-generate
the paths as needed.

BUG=none

Review URL: https://codereview.chromium.org/340893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278605 0039d316-1c4b-4281-b951-d872f2087c98

When a layer adds a tiling, it syncs to its pending/active twin and
adds the tiling there. We "cleverly" do an UpdateTilePriorities() then
immediately if possible. But now UpdateTilePriorities() does much more
than it used to, and also adds new tilings etc, which can cause a sync
back to the other twin and re-entrancy and bad things.

Instead, split everything that isn't updating tiles priorities off to
UpdateTiles() which calls UpdateTilePriorities(), and have
UpdateDrawProperties() call that instead. This way syncing only updates
priorities, and doesn't do things like adding new tilings or changing
what is considered high res.

R=enne
BUG=386076

Review URL: https://codereview.chromium.org/343653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278604 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239879

Review URL: https://codereview.chromium.org/345493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278603 0039d316-1c4b-4281-b951-d872f2087c98

The current code is causing issues on the "Chromium Win Clang" builder,
and also contains redundancies and unneeded repacements for existing function.

BUG=82385

Review URL: https://codereview.chromium.org/343433008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278602 0039d316-1c4b-4281-b951-d872f2087c98

Now extension_icon_image and image_loader are safe to be used
outside of Chrome, like AppShell/Athena.

BUG=159265, 380421
R=yoz@chromium.org, jamescook@chromium.org
TBR=sky@chromium.org, fmalita@chromium.org
TEST=unit_tests, compile succeeds

Review URL: https://codereview.chromium.org/334053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278601 0039d316-1c4b-4281-b951-d872f2087c98