- 16 Jul, 2018 40 commits
-
-
Lei Zhang authored
Change it to 8 from 7. Do this programmatically rather than with hard-coded constants. BUG=851101 Change-Id: I638dfcfc641c92af860f4b0d4e630914bc6426f9 Reviewed-on: https://chromium-review.googlesource.com/1137236Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#575457}
-
Tommy Martino authored
* Introduces a maximum width for the Autofill dropdown. * Creates a subclass for Warnings with styles different from regular rows, and introduces logic to allow the long strings inside to wrap. This subclass also makes click events on the warning message a no-op, since the warning is not meant to be interactive. * Changes the color of the text in warnings to use a Refresh value. Bug: 860352 Change-Id: I320949e3965faf758286af8fbdf3487e0cb91794 Reviewed-on: https://chromium-review.googlesource.com/1130106 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#575456}
-
Victor Costan authored
This CL documents the thread-safety arguments for the thread-safe DatabaseTracker members mentioned in the class-level comments. It makes a member const, so that accessing it is indeed thread-safe, and renames a getter to hacker_case, to make it slightly more obvious that it's just accessing a const member. Change-Id: I9b8aa97ef84c504ea6b421de1091d35cf06a48c1 Reviewed-on: https://chromium-review.googlesource.com/1137983Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#575455}
-
Victor Costan authored
DatabaseConnections::connections_ is only mutable so that DatabaseConnections::GetOpenDatabaseSize() can use std::map::operator[] while being const. This CL removes the mutable qualifier and replaces operator[] use in GetOpenDatabaseSize() with find() and const_iterator, to make it easier to reason about thread safety and invariants. Change-Id: Ifb9df3733c099d9b686096f71156d0a4b2c6271a Reviewed-on: https://chromium-review.googlesource.com/1137929Reviewed-by:
-
Peter Mayo authored
These tests hit DCHECKs and so they only crashes on DCHECK enabled bots. (dbg on the waterfall and the blink-rel trybots.) see https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual/layout_ng_experimental/fast/pagination/auto-height.html%20virtual/layout_ng_experimental/fast/pagination/first-letter-inherit-all-crash.html%20virtual/layout_ng_experimental/fast/pagination/modal-dialog-crash.html%20virtual/layout_ng_experimental/printing/fixed-positioned-child-repeats-even-when-html-and-body-are-zero-height.html%20virtual/layout_ng_experimental/printing/fixed-positioned-child-shouldnt-print.html%20virtual/layout_ng_experimental/fast/multicol/multicol-becomes-paged-auto-height.html Bug: 626703,591099 Change-Id: I20f409e2dbba4246fee31c9c0e4d678e8a033685 Reviewed-on: https://chromium-review.googlesource.com/1138989Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Peter Mayo <petermayo@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#575453}
-
Chris Blume authored
Vulkan on Android was previously enabled by default in https://chromium-review.googlesource.com/c/chromium/src/+/1110754 However, it caused an increase in binary size. We want to take some time to investigate and attempt to reduce the binary size inflation. The next branch point will happen before we get a chance to investigate. So for now, let's put the Vulkan code behind a compile-time flag. That will let us easily switch it back on later & continue to test the Vulkan code path. BUG=862144 TBR=tobiasjs@chromium.org, qinmin@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I52e499c792f13aa7208400650bffbc31a200f0c5 Reviewed-on: https://chromium-review.googlesource.com/1137348Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#575452}
-
Yuri Wiitala authored
The new implementations have been live for a bit more than a milestone. It's safe now to delete the old ones. TBR=jam@chromium.org Bug: 806366 Change-Id: Icde37e386f975dcc0cee70c17ef482191e74ceba Reviewed-on: https://chromium-review.googlesource.com/1137453 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575451}
-
Theresa authored
BUG=814880 Change-Id: I1c4bab6db1d53b4cf91b4a549c286dd7d39789bb Reviewed-on: https://chromium-review.googlesource.com/1138869Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#575450}
-
Hongchan Choi authored
The refactoring CL (https://chromium-review.googlesource.com/c/chromium/src/+/1115516) removed the redundant checks for the destination node in some getters. In rare cases, however, these checks turned out to be necessary due to the problematic design, which needs a long-term solution. This CL adds those checks back in as a short-term workaround. Bug: 860626 Change-Id: I78acb597851249a09d00094e6f1984d8c5b76613 Reviewed-on: https://chromium-review.googlesource.com/1138650 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#575449}
-
Emircan Uysaler authored
Bug: webrtc:9376 Change-Id: I9a6b6c98705cd75243e5ee40926f493866b6b770 Reviewed-on: https://chromium-review.googlesource.com/1137437 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#575448}
-
Sammie Quon authored
Using OnCompositorStarted does not work for overview anymore. See stack trace in bug. Test: manual Bug: 863795, 843851 Change-Id: I3dc8965cbece03ac36f1dc404c9b19b7dcac5b5e Reviewed-on: https://chromium-review.googlesource.com/1138737 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#575447}
-
Evan Stade authored
Follow up to 0a98cc85 Bug: none Change-Id: I1295fe4dbf4ae913689b8d2b1bd57e8554483566 Reviewed-on: https://chromium-review.googlesource.com/1138986Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 94489a86. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21470 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: igrigorik@chromium.org, panicker@chromium.org: external/wpt/performance-timeline mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I8fbf4e8d2688224db02bc1adf954eab59bdb12ab Reviewed-on: https://chromium-review.googlesource.com/1138854 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#575445}
-
Reilly Grant authored
This change migrates users of net::URLFetcher in //services/device/geolocation to network::SimpleURLLoader. The asynchronous plumbing for requesting a net::URLRequestContextGetter in the device service is replaced with simply passing in a network::SharedURLLoaderFactory. The tests are migrated from net::TestURLFetcherFactory to network::TestURLLoaderFactory. Bug: 844976 Change-Id: Icdc35cb973554a9ac2592ced9873bf15bf0bc82d Reviewed-on: https://chromium-review.googlesource.com/1119398 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Matthew Jones authored
This patch adds the ability of the bottom toolbar to hide while the keyboard is showing. This patch is able to use existing simpler infra (KeyboardVisibilityListener) to solve this problem because we are trying to hide UI rather than show it on top of the keyboard. The challenge with showing UI above the keyboard is the inconsistency of the signals that we receive (with keyboard modes like PAN, RESIZE, etc.). If we receive no visibility signal, the keyboard simply draws on top of the bottom toolbar (making it invisible). In the more reliable case where the screen is resized, we hide the bottom toolbar's components and tell the renderer that the bottom controls height is 0. Bug: 852109,860071 Change-Id: I056c47bea33dd426f3b488925ff169735ac95c2f Reviewed-on: https://chromium-review.googlesource.com/1125326 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#575443}
-
John Rummell authored
BUG=861869 Change-Id: I72d0a581e3d82980f5da30aa12d794b1f9abe0ad Reviewed-on: https://chromium-review.googlesource.com/1130007Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#575442}
-
Christopher Cameron authored
Update logic for counting spare compositors (otherwise would be broken by this change), and add optional "force new compositor" argument. This is a speculative "revert", to determine the cause for GPU crashes in GLFence::Create. Bug: 863817 Change-Id: I47cae1fb78e73481d1272d4ce9d56b19dcb4079c Reviewed-on: https://chromium-review.googlesource.com/1138872Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#575441}
-
Shimi Zhang authored
We still need to do 3-way patch to avoid break downstream. We remove the usage of ClassRegister first then remove the declaration in part 2. part 2: http://crrev/c/1137105 Downstream CL: http://crrev/i/651721 Bug: 850652 Change-Id: I9148fdd7dfcb61e4f804b23e817e5bbd3dabc75d Reviewed-on: https://chromium-review.googlesource.com/1138815Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#575440}
-
Scott Chen authored
Bug: 855205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id7c7ea9aa79c704c6971fe477a386f755261e822 Reviewed-on: https://chromium-review.googlesource.com/1135842 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#575439}
-
Peng Huang authored
This CL will create Vulkan instance and Vulkan GrContext when --enable-vulkan is specified. And SkiaOutputSurfaceImpl and SkiaOutputSurfaceImplOnGpu will use the Vulkan GrContext to renderer to replay the SkDDL. Known issues: * RasterDecoder still produces GL textures, it should use the GrContext from GpuServiceImpl. * Media still produce GL textures. * WebGL still produce GL textures. * Browser UI doesn't use RasterDecoder. Bug: 838899 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1026c70e0916d25a9878767336b106299b9dbce7 Reviewed-on: https://chromium-review.googlesource.com/1126166Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#575438}
-
rbpotter authored
Due to a bug in createCloudJobTicket(), portrait printing to cloud, extension, and privet printers was not working correctly. While auditing new vs old UI in cloud print tickets, also discovered that the old UI sent copies as an integer, not string, and changed new UI to match. Also added tests for createPrintTicket() and createCloudJobTicket(). Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I064a8e323b40cf411d2e12a72d4ffd1d501cd4a0 Reviewed-on: https://chromium-review.googlesource.com/1137475Reviewed-by:
-
Fady Samuel authored
When surface synchronization is off, we lock the UI compositor on Android during the first frame and resize in order to avoid producing a CompositorFrame until the renderer has an appropriate frame ready. Prior to this CL, with surface sync on, we used the default deadline for synchronization. With this CL, we use the same deadlines that were used prior to surface sync on versions of Android O or newer. On versions older than O, we set the deadline for resize to 0. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Idb8f2b3891a9ae1bd43be4d81dbec3ccdb5ff436 Bug: 672962, 857542 Reviewed-on: https://chromium-review.googlesource.com/1132324 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#575436}
-
Xiaocheng Hu authored
Bug: 833380 Change-Id: Ibbe5e66786930313ea10bcba1988df93e91f05e3 Tbr: kenrb@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/1138993 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575435}
-
Mustafa Emre Acer authored
Change-Id: I0d891c28e8e1adb48ab1bd19dbb1aff35970bb5a Reviewed-on: https://chromium-review.googlesource.com/1136977Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#575434}
-
Jacob Dufault authored
LoginDisplayHost owns WizardController, this makes it more obvious. Bug: 851012 Change-Id: Ideb743276be051024b237cd04e68838a02a85ef7 Reviewed-on: https://chromium-review.googlesource.com/1124944 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#575433}
-
Rohit Rao authored
BUG=805213 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I347e8d51e721b776de1a3e484de21b48a8a27a15 Reviewed-on: https://chromium-review.googlesource.com/1138337Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575432}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/70331946770e..ee72342a5342 git log 70331946770e..ee72342a5342 --date=short --no-merges --format='%ad %ae %s' 2018-07-16 dgarrett@chromium.org Revert "InitSDKStage: Remove chroot_replace argument." Created with: gclient setdep -r src/third_party/chromite@ee72342a5342 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib0a81249ccd43c255400430c58918e00dfabaeb6 Reviewed-on: https://chromium-review.googlesource.com/1138416Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575431}
-
Ken Rockot authored
The term "View" is too overloaded and has been deemed confusing as the root of so many names central to the Content Service. It also tends to imply visual representation, and the central concept of a navigable-thing encapsulated by the Content Service client library does not in fact require any associated visual representation. Better to rename now than later, sooo... This renames View to NavigableContents, a name which accurately embodies the purpose of the thing without colliding other names or implying more meaning than it should. Also updates some documentation and adds a few missing class comments. No real functional changes. TBR=rsesek@chromium.org Bug: None Change-Id: I8576b62f622116be5effaf4963fc0ea746183931 Reviewed-on: https://chromium-review.googlesource.com/1135915 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Erik Chen authored
ui::Accelerator had a member platform_accelerator() which was only used on macOS, and provided redundant information. This CL removes the member. Change-Id: Ib3954a2c8ff7197606c946e207dd5d3bd75af66d Bug: 846893, 702823 Reviewed-on: https://chromium-review.googlesource.com/1135644 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#575429}
-
Amy Qiu authored
Update all top real world desktop pages to current websites. In some cases, this required modifying html selectors or removing unnecessary logins. Certain websites were replaced due to no longer existing (yahoo games with twitch.tv) or unusable results (weather.com with accuweather). Expectations related to fixed recordings were deleted, since the tests appear now to be passing. Fixed expectations are tracked here: https://docs.google.com/spreadsheets/d/1GBXuDNh1tZmZWcPZFLtm5UB8MyVPavfdVmi712XP6og/edit?usp=sharing The associate bugs can be resolved if the pages appear to pass consistently later. Bug: 852530 Change-Id: I760f0933d24cf067a4d8148f44c4995d32e1e768 Reviewed-on: https://chromium-review.googlesource.com/1125211Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Amy Qiu <amyqiu@google.com> Cr-Commit-Position: refs/heads/master@{#575428}
-
Lambros Lambrou authored
This applies a rate-limit on sending data over a relayed connection, to avoid lots of packet loss because the b/w estimator does not work well with the relay server implementation. The cap level was determined based on internal discussions with the TURN server team. We may decide to change it in future. For example, the max-bitrate of the connection could be expressed by the TURN service in the ICE config response. Bug: 857287 Change-Id: I5de96749ebd8f647d211738f01bd039edbc94241 Reviewed-on: https://chromium-review.googlesource.com/1125411 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#575427}
-
Ethan Kuefner authored
Let's see how much time making the HistogramSet (which includes the call to add_reserved_diagnostics) takes. TBR=eyaich Bug: 857283 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I0f153df2653612fabe627e70e88fcee1c88f9f20 Reviewed-on: https://chromium-review.googlesource.com/1138730 Commit-Queue: Ethan Kuefner <eakuefner@chromium.org> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Reviewed-by:
Ethan Kuefner <eakuefner@chromium.org> Cr-Commit-Position: refs/heads/master@{#575426}
-
Ian Kilpatrick authored
This fixes floats-do-not-fit-on-line.html which was two bugs combined. 1) List-markers shouldn't be positioned next to empty line boxes (unless point 2 occurs). This occurs in particular with floats, the list marker should follow the text down (which was the primary bug here). 2) List-markers should only be positioned next to empty line boxes if we are at the "last" line. I believe this includes forced \n breaks. We should produce a line box in these circumstances. This patch also cleans up the "is empty line" logic inside: NGInlineLayoutAlgorithm. Which was previously inconsistent :). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9bdc76a5cc40bf8c15651916594c44fd2383097c Bug: 636993 Reviewed-on: https://chromium-review.googlesource.com/1136799Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#575425}
-
Pete Williamson authored
Bug: 758690 Change-Id: I1776317786a6e11e1c966b15cc1921f03360ffe9 Reviewed-on: https://chromium-review.googlesource.com/1121241Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#575424}
-
Anna Offenwanger authored
The VRMagicWindowProvider in WebVR was handed out on device creation. For XR, we want to delay the creation of magic window until the developer indicates that they want a session that requires it. Therefore we are making it so that the VRMagicWindowProvider is only created and returned in RequestSession. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I152b2287a05a0524b32c5017bb0a0b6feb0bda6b Reviewed-on: https://chromium-review.googlesource.com/1108925 Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#575423}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b965fcb47296..c45a5c559365 git log b965fcb47296..c45a5c559365 --date=short --no-merges --format='%ad %ae %s' 2018-07-16 fmalita@chromium.org [skottie] Treat color properties as optional (default black) 2018-07-16 senorblanco@chromium.org GrTessellator: collinear edges during sanitize. 2018-07-16 herb@google.com Device interface uses glyph run list Created with: gclient setdep -r src/third_party/skia@c45a5c559365 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:860655 TBR=bungeman@chromium.org Change-Id: I491d21ea6bdd24a7af0debf9ce017d957ebd164e Reviewed-on: https://chromium-review.googlesource.com/1138695Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575422}
-
Max Moroz authored
Was disabled for non ChromeOS platform in https://chromium-review.googlesource.com/1006742 TBR=inferno@chromium.org Bug: 789981 Change-Id: Iab8985e3dd5210bd4ce177cf8f3b60ff63a268d0 Reviewed-on: https://chromium-review.googlesource.com/1138868 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575421}
-
Peter Kasting authored
This fixes inconsistent separator positioning in non-integral scale factors. Bug: none Change-Id: I4fe92a4b8206db13478d7a0d3176d77e29435db7 Reviewed-on: https://chromium-review.googlesource.com/1137704Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#575420}
-
Xiaocheng Hu authored
Flakes seen in https://goo.gl/WQMoLM Change-Id: I359c43949c7756e71dffbaade185bd7cb6865e6c Tbr: twellington@chromium.org NoTry: True Bug: 813589 Reviewed-on: https://chromium-review.googlesource.com/1138520Reviewed-by:
-
Peter Mayo authored
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=block%2Ffloat%2F003.html show that this test has been consistently passing for a while now. This looks like it was fixed here https://chromium-review.googlesource.com/1124071 but the Expectations were not fixed in the main expectations too. Bug: 810335 Change-Id: Id01dcb0032e57cd191da746275b4ca4d9438c1e6 Reviewed-on: https://chromium-review.googlesource.com/1138733Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#575418}
-
