- 18 Jun, 2019 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9283b2559c05..67180a07f8d5 git log 9283b2559c05..67180a07f8d5 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 capn@google.com Fix building with Clang 4.0 Created with: gclient setdep -r src/third_party/swiftshader@67180a07f8d5 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/130335507 TBR=swiftshader-team+autoroll@google.com Change-Id: Icc0c65a60bc4d2241167ee72fcda2a2c16126a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664645Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670168}
-
Ahmed Fakhry authored
This reverts commit 5bb00348. Reason for revert: Breaks the docked magnifier and breaks the stacking of ash containers. BUG=969630 Original change's description: > Force Accessibility Panel to show above all other windows > > Bug: 946616 > Change-Id: I5fa49fe568ab0aecbd2b270c32a714c463d92605 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542162 > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Cr-Commit-Position: refs/heads/master@{#645374} TBR=dtseng@chromium.org,anastasi@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 946616 Change-Id: I7ead2ab4cc12499be816fbb2f56ea841ab633242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663366Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#670167}
-
Evan Stade authored
Move GetArcAppIdByPackageName from AshMessageCenterClient to its own C++ interface. Also delete ash::mojom::AshMessageCenterClient since it's now empty. Bug: 958191 Change-Id: I605ae6ae081e54010348dd3e9c4d01ece8aaaed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658846 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#670166}
-
Esmael El-Moslimany authored
This CL replaces tap event usages with click for oobe-back-button elements. Bug: 967793 Change-Id: I32d95983f80b025acaf75bb4f2390ec97eeae430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658837 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#670165}
-
Victor Costan authored
This CL converts URLFetcher::FetchType into an enum class, makes URLFetcher instances uniquely owned, and cleans up URLFetcher's internal state. Change-Id: If1553123fdc8edc9bf4889a60135207f39f5dba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662125 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#670164}
-
Irina Yatsenko authored
Modified CrashKeyBreakpadTest tests to possibly run in a non-clean state with some chunks already present. The change is prompted by CL https://chromium-review.googlesource.com/c/v8/v8/+/1658505 that adds crashkeys to V8's isolate so, depending on the test execution order, asserts might fire about having unexpected count of chunks. Bug: v8:9323 Change-Id: Id89335fcab04ab0eb37bd13ba2a11ecb964e66c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661082Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#670163}
-
Jon Mann authored
This moves the sub-label text from roaming status to the enable roaming toggle, and removes the status-only row. Bug: 924237 Change-Id: I3ba0dbc4795ff07ef4ae279ced67319baf853ed6 Screenshot: http://screenshot/wYecCFJobTu.png Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661044 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#670162}
-
Bailey Berro authored
Change-Id: Idc1552d411007c357321ed0b28b7f5e963094f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649298 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#670161}
-
Joel Einbinder authored
Inkscape generated weird output for svg masks, which caused some icons to render incorrectly in Chromium. Change-Id: I82778af43ce31c7c3f10e93923931a1f172a13bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663477Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#670160}
-
Jian Li authored
For picture element, we should not remove srcset attribute from source child elements and we should add image resource for ImageSourceURL(). Bug: 915982 Change-Id: I6374ab2177eb5c0324d4fcb036cb9b67beb90c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662949Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#670159}
-
Victor Hugo Vianna Silva authored
Change-Id: Id967aba3dcbb5e08311f4f9ccc913dc91d664aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660501Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#670158}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/61d8ee10b611..e1814403169a git log 61d8ee10b611..e1814403169a --date=short --no-merges --format='%ad %ae %s' 2019-06-18 sakal@webrtc.org Fix documentation in BitrateAdjuster. 2019-06-18 srte@webrtc.org Removes unused dependency on RTP/RTCP from loss based controller. Created with: gclient setdep -r src/third_party/webrtc@e1814403169a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iacc8576378c546730e70cfef12a29f1f074fcfe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664427Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670157}
-
Eugene But authored
Ali fixed a number of complex navigation bugs and has very deep understanding of WebKit navigation code. Bug: None Change-Id: Ia7d16605c1434812210a835b0fb97c9cd6deff37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663364 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#670156}
-
Sergey Ulanov authored
The script was failing in new SDK because the new SDK added new part type 'device_profile' that the script didn't recognize. Added the new type to the list. Also fixed the error-handling code - previously it was failing with NameError while trying to throw an exception to report the unrecognized part type. Change-Id: I5f9e59edf4ed1532c1ed7fd6a23007a3f11c5ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664791 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#670155}
-
Vasilii Sukhanov authored
Bug: 976007,969960 Change-Id: Iaad780b29bc1e43274a61549c851c98d15e01174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664149 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#670154}
-
Sean Gilhuly authored
Change PixelResourceTestCase to a struct that can independently specify the renderer type and the raster type. This will make it easier to add Skia Vulkan as a renderer option. Bug: 963446 Change-Id: Ibcd87d5c2adbcee1a0940387c924adbb54875e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664104Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#670153}
-
Johannes Henkel authored
This reverts commit 65941216. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "[DevTools] Roll inspector_protocol and migrate to std::vector." > > This reverts commit 3a73cee4. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Revert "[DevTools] Roll inspector_protocol and migrate to std::vector." > > > > This reverts commit dc15ca61. > > > > Reason for revert: suspected to be causing link failures on android > > "ld.lld: error: thunk creation not co" when linking lib_components_browsertests__library.so > > eg: https://ci.chromium.org/p/chromium/builders/try/android-kitkat-arm-rel/288408 > > > > Original change's description: > > > [DevTools] Roll inspector_protocol and migrate to std::vector. > > > > > > New revision: 83b1154a9661d22bba9a368d368214cc20880419 > > > > > > This updates the usages of the protocol types to the new > > > definitions, using std::vector-based implementations > > > of protocol::Array. > > > - In many places we can now use the C++11 style for( : ) loops. > > > - We use std::make_unique for creation. > > > - We use emplace_back to insert elements, which sometimes > > > allows us to create strings etc. in place. > > > - Accessing strings in arrays is cheaper, since vector[i] > > > returns a reference (protocol::Array::get made a copy!). > > > - One can assert equivalence of vectors with strings > > > in tests (EXPECT_THAT(foo, testing::ElementsAre("bar", "baz")); > > > - Overall the code is shorter, as the vector API is > > > more concise. > > > > > > Change-Id: I6c8e152987fb0dcfbb01f9086ee48b284a0e5adb > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657628 > > > Commit-Queue: Johannes Henkel <johannes@chromium.org> > > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > > Reviewed-by: Leonard Grey <lgrey@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#669857} > > > > TBR=alph@chromium.org,caseq@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org > > > > Change-Id: Iabcd0386f28787f5042e1f252c9e330330cc525f > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663403 > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > Commit-Queue: Ben Pastene <bpastene@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#669922} > > TBR=alph@chromium.org,caseq@chromium.org,bpastene@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org > > Change-Id: Ia917b8b41af985303dbf6a129ee2d281f7cecc1f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665168 > Reviewed-by: Johannes Henkel <johannes@chromium.org> > Commit-Queue: Johannes Henkel <johannes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#670151} TBR=alph@chromium.org,caseq@chromium.org,bpastene@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org Change-Id: I8aa1016737e46461bbd7917d645b14a26f8f3abe No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663847Reviewed-by:
Johannes Henkel <johannes@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#670152}
-
Johannes Henkel authored
This reverts commit 3a73cee4. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "[DevTools] Roll inspector_protocol and migrate to std::vector." > > This reverts commit dc15ca61. > > Reason for revert: suspected to be causing link failures on android > "ld.lld: error: thunk creation not co" when linking lib_components_browsertests__library.so > eg: https://ci.chromium.org/p/chromium/builders/try/android-kitkat-arm-rel/288408 > > Original change's description: > > [DevTools] Roll inspector_protocol and migrate to std::vector. > > > > New revision: 83b1154a9661d22bba9a368d368214cc20880419 > > > > This updates the usages of the protocol types to the new > > definitions, using std::vector-based implementations > > of protocol::Array. > > - In many places we can now use the C++11 style for( : ) loops. > > - We use std::make_unique for creation. > > - We use emplace_back to insert elements, which sometimes > > allows us to create strings etc. in place. > > - Accessing strings in arrays is cheaper, since vector[i] > > returns a reference (protocol::Array::get made a copy!). > > - One can assert equivalence of vectors with strings > > in tests (EXPECT_THAT(foo, testing::ElementsAre("bar", "baz")); > > - Overall the code is shorter, as the vector API is > > more concise. > > > > Change-Id: I6c8e152987fb0dcfbb01f9086ee48b284a0e5adb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657628 > > Commit-Queue: Johannes Henkel <johannes@chromium.org> > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > Reviewed-by: Leonard Grey <lgrey@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#669857} > > TBR=alph@chromium.org,caseq@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org > > Change-Id: Iabcd0386f28787f5042e1f252c9e330330cc525f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663403 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669922} TBR=alph@chromium.org,caseq@chromium.org,bpastene@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org Change-Id: Ia917b8b41af985303dbf6a129ee2d281f7cecc1f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665168Reviewed-by:
Johannes Henkel <johannes@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#670151}
-
shrekshao authored
We now use an unordered_set to cache the hash of successfully compiled shaders in memory. So that when querying COMPILE_STATUS we don't have to always do shader compile if the shader object is not present even if the linked program is in cache. Some very simple profiling (improved investigation): (Detailed profiling data and some explanations could be found here: https://docs.google.com/spreadsheets/d/1_kAuC9lJ5QGxuKiM_hHF77rS7rmukAErr_hotF8EHd4/edit?usp=sharing) For a javascript program that creates and links 100 programs (200 different shaders in total, no randomized constant introduced) and query the compile status of shaders afterwards: 1. The first launch: There will be no difference between the cached version and no-cache version. Because there's no program cache at all. All shaders will get compiled in DoLinkProgram. The gpu::gles2::Shader instance will stays in memory. Future DoGetShaderiv calls where pname == GL_COMPILE_STATUS will directly access the gpu::gles2::Shader instance for whether it's valid or not. The query time for 200 shaders is ~36ms. (Time taken number afterwards all stands for query COMPILE_STATUS of these 200 shaders) 2. Refresh the page: Now there will be cache hit happened when program link so that shaders won't get compiled at program linkage. As a result, querying COMPILE_STATUS now in no-cache version will lead to shader->DoCompile, which would take ~400ms. For the cached version, as successfully compiled shaders have their hash stored in an unordered_set, There's no shader compilation happen, we simply look at if there's an entry of the shader hash in that set, which would take ~50ms. If the javascript program continues to query COMPILE_STATUS after the first query (though unlikely in a real-world scenario) The cached version will take slightly more time (~50ms) because it didn't have the compiled shader in memory but keeps looking into the unordered_set for shader hash. While no-cache version simple accesses gpu::gles2::Shader instance (~40ms). Future update on Angle might be needed as well. Bug: 775247 Change-Id: I08629e99a603c29d9a4e332b602bf669e074939a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593640 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#670150}
-
Tarun Bansal authored
Add regression test for the case where the loading hints arrive late in Blink. A new HTML file is added that loads resources using link-rel preload. The existing browsertest fails in that case. Bug: 891328 Change-Id: Id100da5b7c16c357132dcbf875d1d2048968c7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663355 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#670149}
-
Darin Fisher authored
A nice side-effect of this change is that it moves complexity out of RenderProcessHostImpl. Originally reviewed here: https://chromium-review.googlesource.com/c/chromium/src/+/1654238 Change-Id: I9ce1fafebef8f314c6603ab122dab9a777b2e839 Bug: 967834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660157Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670148}
-
Robbie McElrath authored
I initialized the TestBrowserThreadBundle with REAL_IO_THREAD in crrev.com/c/1658644 to get around some fuchsia-specific behavior. That wasn't the correct way to fix it, this CL is. Bug: 974365 Change-Id: I55a2d533654f15d9280215bf26e652e1163be74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662968Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#670147}
-
Darwin Huang authored
This reverts commit ff7bc1fd. Reason for revert: SetTimeDialogBrowserTest.All Original change's description: > Only allow timezone changes when done button is clicked > > Instead of changing the system timezone when a new value is selected on > the list, it is only applied when the set date time dialog is closed. > This is necessary to ensure that only parents can change time and > timezone settings for children. > > Bug: 921145 > Change-Id: If5f3460381fc60607741828e59912c669af05a9b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658858 > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#670069} TBR=xiyuan@chromium.org,agawronska@chromium.org,hgrandinetti@chromium.org Change-Id: I1d839ca4446c4f79d0809d1fa6e402a5f657abe7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 974835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664110Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670146}
-
Lukasz Anforowicz authored
The test used to just check if the request succeeded or not, but didn't look at the response body which since M73 was getting blocked by CORB. This CL: - Makes the test actually inspect/verify the response body - Use resource type that is not covered by CORB Bug: 940068 Change-Id: I755bb445e5241f1082f3981ac8506aaf185d64da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650283 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670145}
-
Collin Baker authored
Layers added beneath views weren't handled in WindowReorderer::ReorderChildWindows(). When this method was called, any layers beneath would end up incorrectly stacked above all other sibling layers. This bug surfaced recently with an ink drop painting above its view. This CL exposes a View method that returns all layers associated with it that should be immediate children of its parent. ReorderChildWindows() is modified to call this instead of simply restacking the view's main layer. Bug: 973243 Change-Id: I65b5a3266bbe20afe9adb5db4acf709c6c506b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663037 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#670144}
-
Jacob DeWitt authored
Samples that will be published along with xr-barebones.html: - magic-window.html - teleportation.html - gamepad.html For those samples, cleanup the code and add some comments. Also update the OT token referenced by those pages so that they work with the M76 OT. Added some scripts that assemble the subset of samples and upload them to the bucket where they are hosted. Also fixed an issue with teleportation.html that caused the initial scene displayed in the inline session to be at floor-level instead of head-level. Bug: 966565, 954388, 974041 Change-Id: Ia21b2833351d44ec4633d2cbebaf6c673abd4c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662848Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#670143}
-
Michael Crouse authored
Checks if a user should be notified that Lite mode now optimizes HTTPS pages for Lite mode users when HintsFetcher is first enabled if it has not already been shown. This ensures that when HintsFetcher is enabled for Lite mod users that they see the infobar that describes this change before hints are fetched from the remote optimization guide service. Bug: 943846 Change-Id: Id9887c4d3994a87bf516c11414637538e2d7e90c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663053Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#670142}
-
David Bokan authored
Today, FlingBooster works by observing gestures during a fling. While it decides whether or not the fling will be boosted, the incoming gestures are filtered. This leads to a loss of responsiveness in this period. In this CL, we radically simplify the FlingBooster/FlingController. We no longer defer gestures during an active fling. When a FlingCancel is received, the current fling is immediately stopped. The fling booster still tracks gestures in the same way but allows them to be dispatched so that scrolling remains responsive. If a fling occurs and meets all the existing criteria for boosting, we start a new fling and add the previous fling's velocity to it. This change makes scrolling feel more responsive during a fling and also significantly simplifies the fling and gesture code since we're no longer modifying the gesture stream. Change-Id: I47c0466861395f2064c4ce68d300955afd3668ec Bug: 905593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630537Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#670141}
-
Brian Sheedy authored
This reverts commit 44984340. Reason for revert: crbug.com/976331 Original change's description: > [AdTagging] Add support for asynchronous stacks in AdTagging > > What: Label async tasks as ad or not. > > Why: So that the AdTracker knows if a running task is due to an async > task registered while ad script was on the stack. > > How: Modified the async probes to take a AsyncTaskId* instead of a > void*. The AsyncTaskId* stores the bit of whether ad script was on > the stack at the time of creation. This is *much* better than the > previous approach (https://crrev.com/c/1291232) in that there are no > memory leaks, no extra map lookups, and we don't have to worry about > cancelasynctask being called. It does require a modification to all > probe locations to hold a AsyncTaskId member. > > Bug: 851531 > Change-Id: I92e25b3ab3b8746611c3a3f9a9a7265bab4a601e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648886 > Commit-Queue: Josh Karlin <jkarlin@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669884} TBR=dgozman@chromium.org,alph@chromium.org,japhet@chromium.org,jkarlin@chromium.org Change-Id: I36397d0e78d33fb3522301ff4e11b27cb679fdda No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664201Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#670140}
-
Sidney San Martín authored
Web content now performs substitutions as configured in System Preferences → Keyboard → Text, including quotes, dashes, and custom replacements. To do: - Add standard Edit menu options (see TextEdit). - Maybe: tweak about how substitutions work with undo. - Maybe: support reverting and changing suggestions via the standard UI. - Maybe: offer automatic spelling and grammar correction. - Probably: more! This is just a first pass. Bug: 42434 Change-Id: I35ed072a9a390296f9ab250c788e11b9147dc24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652661Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#670139}
-
Haohao Wang authored
This CL completes the UI option for Button_GM2; resolves remaining comments in CL 1653575. Bug: 963148 Bug: 974811 Change-Id: Ia340a7bfca850e05be3473a2e04b3eb46737776c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661376 Commit-Queue: Haohao Wang <hhw@google.com> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#670138}
-
Matthew Webb authored
This is the last CL implementing functionality for authenticatorBioEnrollment, finishing off with CTAP2.1 §5.7.8, removing enrollments. Implementation is almost identical to the rename command, just without the name parameter. Change-Id: I0d3b608cb08766f32a22f8287842b1dbb0ce461b Bug: 974046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658759Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Matthew Webb <noviv@google.com> Cr-Commit-Position: refs/heads/master@{#670137}
-
Toby H authored
Eliminated the OWNER enum from Ash because it is not used and can be replaced by USER. Bug: 713380 Change-Id: Ic9c8e9dd42ea15d604e3c711893bdeaae2a48f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654488Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#670136}
-
W. James MacLean authored
This CL adds PageMsg_UpdatePageVisualProperties and causes it to be sent to all renderers for a page when the viewport is resized. At present, the mainframe renderer continues to act on the viewport size it receives via RenderWidget::SynchronizeVisualProperties, but any oopif renderers receive it via RenderViewImpl::OnUpdatePageVisualProperties(). This CL also removes ResizeVisualViewport from the WebWidget API and moves it to the WebView API. Bug: 939050, 599688 Change-Id: I04097ea936e8d87792155278c9c1b8823f6aaf45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621868Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#670135}
-
sczs authored
These will be used for a simple sequencing analysis. Bug: 976066 Change-Id: I93df27f382e2ed5c630294742e473a1390c0e220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663013 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670134}
-
Lucas Furukawa Gadani authored
Change-Id: Icbbf7bc4a242f89eb6be5841783c14c116f42c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660040Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#670133}
-
li authored
supported_proivder_type will be used to change the behavior of OPEN_APP action and Android media action. Currently, we always send ANDROID_APP as supported_provider_types which enables launching media intent. The plan is to rollout in M77 instead of M76. This changes will be cherrypicked into M76 to disable the feature in M76 and enable with a finch experiment. Bug: b:135487605 Test: Manual Change-Id: Ia07ccf425126be9433c7d4043f3780dd39107713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663396Reviewed-by:
Yue Li <updowndota@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670132}
-
Mark Cogan authored
This CL removes unneeded includes from tab.h and tab.mm, and removes unneeded dependencies from tabs/BUILD.gn. Forward declarations were added to tab_private.h and tab_view_delegate.h to correct for types that were coincidentally included alongside them. Change-Id: I8ba0a260cede6212935308414f46a28c47db1ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664073 Auto-Submit: Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#670131}
-
Yasmin authored
Bug: 972063 Change-Id: Iae4119912493dcc796eb7d7d5b0e2502442b6f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663138Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#670130}
-
Ian Kilpatrick authored
This uses a rare-data pattern to reduce the size of a layout result. On 64-bit machines this is almost a 50% reduction (120 -> 64). On 32-bit machines I think this reduces it to 48. There is a slight (~1%) performance regression on microbenchmarks due to this change. Bug: 962108 Change-Id: Ia673fa34b986f851c53b6becc44025e16891d12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648887 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670129}
-