- 24 Jun, 2020 4 commits
-
-
Tom Anderson authored
This CL includes 2 event fixes that were originally part of CL [1] to fix similar event-related issues. * event.h - "As() const" always called back into itself, causing an infinite loop. The intention was to call the non-const As() function. * event.cc - Xlib modifies the event data when parsing some events, but we never do, so let us parse the event before Xlib. * gen_xproto.py - Ensure the extension is present before creating extension events. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2253223/ BUG=1098194, 1098204 R=thestig Change-Id: I414acd9c138a92fbddd09da705127f1d7f60b552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261177 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#781615}
-
Ian Kilpatrick authored
As above - there should be no behaviour change. Bug: 842296 Change-Id: If04aee8a0bf9c0decf9a829e86ed7e440c618f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261428 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#781614}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592927234-93fd17f09f62ae1a92f26a9127978b7f390ce8f1.profdata to chrome-win64-master-1592935173-8e4ecbeaa648b10e168b33ede78da61a4b393ac3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I323b92d2fd6940046bf23b9a1995496af6e2909c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261477Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781613}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8dbca52cb29a..49e6f89bf28a 2020-06-23 patrick.brosset@microsoft.com Grid: shift grid labels a bit when they're inside the grid and at the corner If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1096629 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I35e2d1660fb9912dfb1b088566991fceeea31f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261452Reviewed-by:
-
- 23 Jun, 2020 36 commits
-
-
Wenhan (Han) Zhang authored
Change-Id: I5534ce0a95a967804c9a757e75fe523447e54469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255381 Commit-Queue: Wenhan (Han) Zhang <zwenhan@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#781611}
-
Nico Weber authored
Generated files in infra/config/generated by running: lucicfg generate infra/config/main.star TBR=mark@chromium.org Bug: 1098454 Change-Id: I8096cef8111688010492184deccb1c9f85dafaf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261369Reviewed-by:Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#781610}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fc5464c325c9..a6c1ece07a47 2020-06-23 bpastene@chromium.org cros_test: Use Simple Chrome's cached version as default when flashing. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com,bpastene@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com,bpastene@google.com Change-Id: Iee4aebadd0003aaaaa65309f7fb64377c116ebe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261479Reviewed-by:
-
Evan Stade authored
This flag enables third party cookie management in the page info bubble on WebLayer. Bug: 1071775 Change-Id: If41e96859475bf7790ccdc6534cf0190863892de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258859 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#781608}
-
Erik Chen authored
As part of prototyping for Lacros, these DCHECKs are deterministically hit by meet.google.com during screen sharing. Given that at least one of these DCHECKs is also being hit in the wild via DCHECK enabled canary asan builds, I am removing these for now. Bug: 990711 Change-Id: I614fc932aadeab92e033de299a3482fb91d440a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261102 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#781607}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b47cc50aadb6..62a2f51304f9 2020-06-23 syoussefi@chromium.org Vulkan: Remove DispatchHelper 2020-06-23 nguyenmh@google.com Re-enable presubmit commit message format check 2020-06-23 jmadill@chromium.org Update glslang_validator binary for Windows. 2020-06-23 syoussefi@chromium.org Add mip-related corner-case tests 2020-06-23 syoussefi@chromium.org Update glslang_validator binary for Linux. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I6b839f91c107b340a25beb7c6161600b05245ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261062Reviewed-by:
-
Jimmy Gong authored
- Set minimum window size to 600x320 as per UX guidelines as it is the minimum size that displays all informational columns for a print job. Bug: 1053704 Change-Id: I8f122affd87cd8e5cfac20d5ce8d935e3237a49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259133Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#781605}
-
Matthew Mourgos authored
This change adds two new app list spoken feedback tests. These tests ensure that app item reordering and folder creation are announced correctly in the app list. Also in this change, the incomplete NavigateAppLauncher test has been removed as its purpose it no longer required. In its place, the tests PeekingLauncherFocusTraversal and FullscreenLauncherFocusTraversal already exist which cover the same relevant test case for app list focus traversal. Bug: 784942 Change-Id: I02120a6eff8ba1dad698a86bf1977aa9895988d7 AX-Relnotes: n/a. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242917 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#781604}
-
Ian Kilpatrick authored
As above - there should be no behaviour change. Bug: 842296 Change-Id: I84c388fcdc18b36f6e0a8821a3bd7031645ae49f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261100 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#781603}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8194c8c76cf2cb270208203fc35daaf6f3ddedb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261425Reviewed-by:
-
Xianzhu Wang authored
Timing stats [1][2] show that debug builds are much more than 2~3x slower than release builds, so the original 3x timeout was too short. We also have seen more timeouts on debug bots because of that. [1] One sample of release build timing stats: (click the "Timing stats" link at the top-right corner) https://test-results.appspot.com/data/layout_results/linux-blink-rel/36524/blink_web_tests%20%28with%20patch%29/layout-test-results/results.html [2] One sample of debug build timing stats: https://test-results.appspot.com/data/layout_results/linux_chromium_dbg_ng/7051/blink_web_tests%20%28with%20patch%29/layout-test-results/results.html Change-Id: I0eeeecf3547e576046238338246aa6849386166f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259134Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781601}
-
Alex St-Onge authored
Bug: 1091502 Change-Id: Ic6d77a89e54c8c0b7db729509005fcb9731584e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261395Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Alex St-Onge <alstonge@chromium.org> Cr-Commit-Position: refs/heads/master@{#781600}
-
Ella Ge authored
This CL fixes a bug in location delegation that it only checks the client app's ACCESS_COARSE_LOCATION but not ACCESS_FINE_LOCATION. The #hasAndroidLocationPermission method will: 1. returns true if at least one of the two permission is granted 2. returns false if at least one of the two permission is requested, but none of them are granted 3. returns null if none of them are requested. This CL also fixes a typo in installed_webapp_geolocation_bridge.cc The error code should be set to "position", not "current_position_" Bug: 1069506 Change-Id: I9171cc5e8d47a237b431369cb8c86e88ea3d3f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258312Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#781599}
-
Chris Cunningham authored
Add IDL for AudioDecoder and associated IO/callbacks/init. Bug: 1094087 Change-Id: I9dca7ab13a8feeaabb8714faa37df5c901789cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255142 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#781598}
-
Reilly Grant authored
This change removes the uninclusive term "master" from the name of this class. Bug: 1097189 Change-Id: I1d268411316529d33e6bbe8c6228b065c7ad5634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261365 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781597}
-
rbpotter authored
Reland of https://chromium-review.googlesource.com/c/chromium/src/+/2233827, now that unpack_pak changes to prevent colliding generated directories have landed in https://chromium-review.googlesource.com/c/chromium/src/+/2251050 This adds an optimized Polymer 3 build target for the OS settings page. Bug: 1045266 Change-Id: Idfeeb0c28b2e2b48226d06ab727cc833861beb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253215 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#781596}
-
Jon Mann authored
In the recent change to sync networks after they are configured, the check to see if a network was configured by sync was executed before the metadata has actually been set. Bug: 966270 Change-Id: If8bce1c693f8ee6f55f35bc49a64d4ceaf734bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259378 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#781595}
-
Jian Li authored
Bug: none Change-Id: Iad6d5575615324bf5748b48db547104008e976f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253146 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#781594}
-
David Staessens authored
This CL hooks up everything required to pass the medialog object to the ChromeOS video decoder. In the future this can be used to provide move detailed information about the ChromeOS video decoders to chrome://media-internals. TEST=./video_decode_accelerator_tests --use_vd on nocturne BUG=b:158716673 Change-Id: I52775eb85675a9d9d91d6c3d52f6a44ab7386d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895015Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#781593}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/37b62e51e50c..5afeb6651bad 2020-06-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: If56e4acd21d51a73616521ab32e197826cf72448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261456Reviewed-by:
-
Albert J. Wong authored
Allow implementation sharing of the LowerASCII() and UpperASCII() code in StringImpl and StringView. Also clean up LowerASCII() and UpperASCII() implementations to avoid extra conditionals and rely more on compiler vectorization as opposed to hand-rolled optimizations. Inspiration taken from Richard Townsend's CL here https://chromium-review.googlesource.com/c/chromium/src/+/2237979 This is partially broken out of https://chromium-review.googlesource.com/c/chromium/src/+/2204539 which in turn is broken out of https://chromium-review.googlesource.com/c/chromium/src/+/1557854 Bug: 1083392 Change-Id: I8831acc511e1630cb733fc5062321e626b682b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259143 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#781591}
-
David Bertoni authored
This test was disabled for flakiness. The fix is to use a ChromeExtensionTestNotificationObserver instance to observe changes in page action icon visibility, instead of trying to force round trips between the browser and the renderer. Bug: 339896 Change-Id: Ib16b1e9f47b506dcb64c5df746a3a76333309e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258776Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#781590}
-
Timothy Loh authored
As Plugin VM uses the same registry backend as Crostini, we need avoid treating Plugin VM apps as Crostini apps. This CL fixes the logging of Crostini.AppsInstalledAtLogin to not count Plugin VM apps, instead logging those in a separate histogram PluginVm.AppsInstalledAtLogin. Change-Id: If8f32c80f3c16cb7b2c88d62d67b84102d3ce939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257122Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Katie D authored
Prepares for multiple features by making load/unload callbacks generic rather than specific to autoclick. Also refactors the extension so that it can load/unload functionality for each feature separately. Does not yet load AccessibilityCommon for FocusHighlight feature because the extension functionality does not yet exist, but adds a TODO for later. AX-Relnotes: n/a Bug: 960373, 1096759 Change-Id: I1d2c15af3eb8ef1282c430d3366b740e587fe884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253181 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#781588}
-
Tommy Steimel authored
When a user tries to open a media file with Chrome that Chrome doesn't have access to, we currently crash with a SecurityException. Instead, this CL will just catch and log the error. This CL also adds a new histogram to track whether the launch was successful. Bug: 901292 Change-Id: I46dd6faf5be0a18410fb7dcfa89bcf662c9a46a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255133 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
As above. This adds two use-counters to give us web compat data for: https://github.com/w3c/csswg-drafts/issues/129 The use counters will trigger if we have non-zero inline-end padding, and we have block-level children (inline children already account for padding), and are either "overflow: scroll" or "overflow: auto". Change-Id: Idcee6d7aa6e5d970874352e82507fc5cce4ecc28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261404 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#781586}
-
Tina Wang authored
Change the UI to managed when the pref is managed by policy. Bug: 1093169 Change-Id: I2aaf5c5b1d948501a48ab600d40a1af5ab8ce733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255627 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#781585}
-
My Nguyen authored
This reverts commit 84ec7a41. Reason for revert: unittests fixed. Unittests failure is due to uninitialised value of "show_tab" of "struct SuggestionDetails" created in the test. See https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8877186004329749328%2F%2B%2Fsteps%2Funit_tests%2F0%2Flogs%2FDeterministic_failure%3A_AssistiveWindowControllerTest.ConfirmedLength0SetsSuggestionViewBound__status_CRASH_%2F0 Original change's description: > Revert "Use SuggestionDetails struct for showing suggestion" > > This reverts commit b1d0fc82. > > Reason for revert: failures of AssistiveWindowControllerTest > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests?limit=200 > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/19523?blamelist=1#blamelist-tab > > > Original change's description: > > Use SuggestionDetails struct for showing suggestion > > > > In preparation for adding show_setting_link param for personal info > > suggestion. > > > > Bug: 1094267 > > Change-Id: Id9e4a5d5de335613df93bf80142a3df8bb564fd0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243073 > > Commit-Queue: My Nguyen <myy@chromium.org> > > Reviewed-by: Keith Lee <keithlee@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#779566} > > TBR=keithlee@chromium.org,curtismcmullan@chromium.org,myy@chromium.org > > Change-Id: I66864faf4aac2f9c8ad10ecc22eba71b32005750 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1094267 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250107 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779742} TBR=kolos@chromium.org,keithlee@chromium.org,curtismcmullan@chromium.org,myy@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1094267 Change-Id: I1123a3ca410a8143a5e37c9a6c8ead5753d70c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251862 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#781584}
-
Sammie Quon authored
Test: none Bug: none Change-Id: Ibc087b3fb0579ea3980ecb03a92b1e2133aa8d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258856 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#781583}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/39d00b97..df9f2eb5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I608671fd78b3b056c332f2accff9b94cfc259438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261512Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781582}
-
Alexander Surkov authored
Bug: 1095619 Change-Id: Ia66fb236b6d1f4d365d8a878066832058ec7ab9f AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257261Reviewed-by:
-
manuk authored
This CL adds rich autocompletion to the providers and autocompletion classes. With this CL, basic rich autocompletion should work. No behavior changes if rich autocompletion is disabled (default). - Adds fill_into_edit_additional_text and prefix_autocompletion fields to AutocompleteMatch, similar to the existing fill_into_edit and inline_autocompletion fields respectively. - Updates OmniboxViewViews and OmniboxEditModel to display those fields. - Adds the AutocompleteMatch::TryRichAutocompletion method to populate those fields. - The document, HQP, HistoryUrl, and Bookmark providers invoke TryRichAutocompletion and support non-prefix and title autocompletion. - The search provider will set fill_into_edit_additional_text to the match description (e.g. 'Google Search') for consistency with the other providers but will not support non-prefix and title autocompletion. This CL builds off the previuos rich autocompletion CLs: - crrev.com/c/2107796 added chrome://flags flags - crrev.com/c/2108780 supported multiselection in textfield views - crrev.com/c/2199859 Add complementary omnibox view - crrev.com/c/2204545, crrev.com/c/2219891, crrev.com/c/2223012, & crrev.com/c/2242126 OmniboxView support for rich autocompletion Design doc: go/richomniboxautocompletion Change-Id: I7d422a979032254d1e3f055c19ebe20f6c8621a6 Bug: 1062446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253339 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#781580}
-
Nico Weber authored
Generated files in infra/config/genrated by running: lucicfg generate infra/config/main.star Generated testing/buildbot/*.json changes by running: testing/buildbot/generate_buildbot_json.py Bug: 1098454 Change-Id: I323c370f3f6272b0d13bb6926ca163881616dd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261224 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#781579}
-
dpapad authored
iron-animated-pages was consuming bubbling "iron-select" events erroneously. This caused a bug where the "back" button was unexpectedly focused when switching between tabs in the certificate-manager UI. Fixed: 1097684 Change-Id: I53774148334b2ffa2ec57d89b05d67a8e13c92df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259014 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#781578}
-
Ian Kilpatrick authored
As above. Bug: 842296 Change-Id: I7262d7d4b0425f59871604bf4b3dbaf7be2e76e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261429 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#781577}
-
Xida Chen authored
This CL does some clean up to the Event.* histograms, here is the list: Event.Latency.ScrollBegin.Touch.TimeToHandled2 Event.Latency.ScrollBegin.Touch.HandledToRendererSwap2 Event.Latency.Scroll.Wheel.TimeToHandled2 We extend the above histograms by one year as they are key input metrics. Event.CoalescedCount.Mouse: this is marked obsolete, as it doesn't provide useful info to us. Event.FractionOfTimeWithoutUserInput: this is extended by one year, I believe this is useful, but not certain. Bug: 1059794, 1037077, 1037075, 1037068, 975931 Change-Id: I27ea8e2e19b4355e6a1f05fd53ab8afe32a8f61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254938Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#781576}
-
