- 24 Oct, 2019 40 commits
-
-
Christopher Grant authored
For a period of time, LLD couldn't produce partitions in debug builds, and hence a workaround was needed for the debug non-component case. The same workaround would kick in if partitioning were disabled on release builds (ie. a kill switch). Now, LLD is fixed and partitions have soaked long enough to drop the kill switch. Bug: 1011834 Change-Id: I00bdb911c61a7e7e7cd7359daa996074494b8b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873910Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#709047}
-
Steven Bennetts authored
Bug: 965089 Change-Id: I1a29243c5dd4ab9a446baa7c4ddebb3408e7f5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875485Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#709046}
-
Henrique Nakashima authored
Also remove DOWNLOAD_TAB_MANAGEMENT_MODULE since it becomes unused. Bug: 1012975 Change-Id: I8a687bc395ebb1d0f775eb7b83321047ba4ecb52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863033Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#709045}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia455a6ec86eda0230ff287ba2b2ca0348b57771e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878611Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709044}
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: I07244066da4394b74830765f6219b630f66b2cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876977Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#709043}
-
Emily Stark authored
We previously created this directory to hold safety tips code, but we haven't actually used it. This CL moves the safety tips code from chrome/browser/lookalikes/safety_tips to chrome/browser/reputation. Mostly an automatic transformation with tools/git/move_source_file.py, but some manual fixup was required. TBR=dtrainor@chromium.org Bug: 1017369 Change-Id: I9a0f6511cc0eca929ef81d3fb27262110a835ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875514 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#709042}
-
John Z Wu authored
//ios/web_view does not support any data migration between accounts Change-Id: Ic357556ba9c6d7f71611c3a839b3675f6b169d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869018Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#709041}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6b54b963. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I22ae9c9213c10d6d90601b2dbaf805cef9f394d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877377Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709040}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/137a46738b35..38c2b4512e74 git log 137a46738b35..38c2b4512e74 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 lalitm@google.com Merge "trace_processor: add test for custom clock power rails" Created with: gclient setdep -r src/third_party/perfetto@38c2b4512e74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I3ffe846abc872a3a8d2c48267e3edf3d9a4259d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878608Reviewed-by:
-
Stephen McGruer authored
TBR=benwells@chromium.org Bug: 1017305 Change-Id: If6820dc2e87850a5f3965a8bef663e5a0ff0c531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878908Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#709038}
-
Chris Lu authored
Since BadgeState is a mask, a direct equality comparison to BadgeState values for the BadgeItem properties is not the correct way to assess if a badge is accepted. To add testing support for this case, accepted a11y identifiers for BadgeButtons are created, and they will be properly set in setAccepted: in BadgeButton. Bug: 976901, 1016793 Change-Id: Id17eb82e0764fbbf80b871df0b974fe148c2339f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872938 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#709037}
-
Ben Kelly authored
This CL is inspired by the previously attempted crrev.com/c/1434754. That was reverted due to excessive renderer crashes. As an interim step this CL instead ignores code cache when the origin seems wrong. We also add a UMA to see how often its triggering in practice so we can start trying to isolate the unexpected circumstances. Bug: 925035 Change-Id: Iec4d0206ba5ed74950537d74a4ad180ee6b98905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860775 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#709036}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/b186cfaa74..910988b619 TBR=bmeurer@chromium.org Change-Id: Id0732c2609248441793fcae31e514988b661cc82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878688Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#709035}
-
Martin Robinson authored
Orca expects this signal, so we make sure to fire it when popup menus are closed. We also send the ax::mojom::Event::kMenuPopupEnd event after the ax::mojom::Event::kMenuEnd event to make sure that any "focus override" in the Views code is unset. We do this because we need to query the currently focused item after the menu is closed. Bug: 1011864 Change-Id: I0137527c349bb7f3a6ade66fd9ceadba3e0d546e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855742 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#709034}
-
Miyoung Shin authored
This CL cleans up AudioLogFactoryPtr that is left in only AudioServiceListener class with the conversion to new mojo types. Bug: 955171 Change-Id: Ifd88a1a007120f9aa598d5011e5fa45c210b2a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871691Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#709033}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I61a234aad9d086aa558f5672b2a8bceb95844168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878169Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709032}
-
Julie Jeongeun Kim authored
This CL cleans up service_worker_version_unittest::TestServiceImpl since it's not used anywhere. Bug: 955171 Change-Id: I74c800049a2c3ed22775ee9d8f57d5dd6f73c994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872577 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
Jaeyong Bae authored
This patch means bug fixing that Name doesn't get cleared from chrome://settings/addresses page after editing address. Bug: 965437 Change-Id: I8ebeee9e6eaa230f0293d9fa1c44cb9d975d7a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830479Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#709030}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3d8b9b834731..4ab4e641f151 git log 3d8b9b834731..4ab4e641f151 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 bsalomon@google.com Narrow fix for creating BGRA backend texture from pixmaps on desktop GL. Created with: gclient setdep -r src/third_party/skia@4ab4e641f151 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: If626610b38df99bb2533a40d5871aa0ebdf94fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878449Reviewed-by:
-
Stephen McGruer authored
This reverts commit 919aab84. Reason for revert: Suspected of breaking compile for xcode-ios-bots - https://ci.chromium.org/p/chromium/builders/ci/ios-device-xcode-clang/113639 Original change's description: > [iOS][MF][EG2] Migrate credit card tests > > Consolidate Manual Fallback matchers in one place. > Consolidate credit card Autofill helpers in the respective app > interface. > > TBR= eugenebut@chromium.org > > Bug: 1017685, 1016367 > Change-Id: Ib91e2baba9e72f6e065e8ebf08fdd5f5d3c0c9bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878197 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709020} TBR=stkhapugin@chromium.org,javierrobles@chromium.org Change-Id: I644e9e91acab68e69d7cba86af2037fd43603b36 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017685, 1016367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878911Reviewed-by:
-
Robbie Gibson authored
This was something that we wanted to do after the omnibox UI refresh, which happened last year. Now, we don't need the AutocompleteTextFieldDelegate or the NSNotifications in OmniboxViewController. Bug: 866446 Change-Id: I674bcdb65baecace0b22f6494545985deb22b47a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866632Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#709027}
-
Alex Oldemeier authored
In the wider team sync it has been discussed that ideally we get these metrics for one more year, so this CL extends their lifetime until end of 2020. Test: compile Bug: 1016434 Change-Id: If8babc01ef23778fd69bb2c813b801187906b932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878408Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#709026}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2c6f0545..396ace2f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ide52f1798118a60386d696850d5f26f01eef4511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877376Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709025}
-
Daniel Rubery authored
This CL removes the expired histograms: SBClientDownload.ZipArchiveUncompressedSizeOverflow SBClientDownload.ZipCompressionRatio SBClientDownload.ZipEntrySize Since they were not being used, and extends the expiration of: PasswordProtection.DomFeatureExtractionDuration SBClientDownload.RarHeadersEncrypted SBClientDownload.ExtractDmgFeaturesTimeMedium DomFeatureExtractionDuration is still being consulted as we try to reduce timeouts of feature extraction. RarHeadersEncrypted is important to detect potentially incomplete data in Safe Browsing pings. ExtractDmgFeaturesTimeMedium was added in August, and hasn't been in Stable long enough for me to consider it historically stable. Fixed: 988802, 988756, 988758, 988767 Change-Id: I457479ab0b34b799a8a709493fe64501afa692c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875274Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#709024}
-
Martin Robinson authored
This version checks at runtime for atk_value_set_value during testing. This should allow the change to work on bots running trusty. Original commit message: > The introduction of text-change signals for the omnibox included a > regression that prevented the emission of AtkValue property change > signals. Fix this error and also add an implementation of > atk_value_set_value. The implementation is used in a test to verify the > correct behavior. > > The fix is that we correct the misuse of a logical operator and now > always try to emit AtkValue property change events when receiving the > kValueChanged event in AXPlatformNodeAuraLinux. Bug: 1015387 Change-Id: I486b44f9d0f212d951487bdc9f953401a94f9dff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876850 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#709023}
-
Mihai Sardarescu authored
This CL avoids passing the unifiedConsentEnabled as a loadtime variable to the Chrome desktop settings javascript code. A follow-up CL will also remove the "unified-consent-enabled" argument from all JavaScript settings files. Bug: 1015805 Change-Id: I3d6bf2deb1b0123129b8f8f3c665ed4277e5a495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869657 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#709022}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/eec39190ce14..fc78aaceea0a git log eec39190ce14..fc78aaceea0a --date=short --no-merges --format='%ad %ae %s' 2019-10-24 sprang@webrtc.org Batches video frame packets when posting to pacer 2019-10-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f656c810..d7338c33 (708845:708965) Created with: gclient setdep -r src/third_party/webrtc@fc78aaceea0a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I70b85113b82aa7e42e6d2fc6d6d921d8b62dd691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878448Reviewed-by:
-
Javier Ernesto Flores Robles authored
Consolidate Manual Fallback matchers in one place. Consolidate credit card Autofill helpers in the respective app interface. TBR= eugenebut@chromium.org Bug: 1017685, 1016367 Change-Id: Ib91e2baba9e72f6e065e8ebf08fdd5f5d3c0c9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878197 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Add profile methods to autofill app interface. Add GREYKeyboard dependency to earl_grey_test.h. TBR=eugenebut@chromium.org Bug: 1017175,1016367 Change-Id: I5bff0672282c20114677cf6500a601a9ed5c4f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878248 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3c19bdb0a8ce..13b94d068bdf git log 3c19bdb0a8ce..13b94d068bdf --date=short --no-merges --format='%ad %ae %s' 2019-10-24 perezju@chromium.org [Telemetry] Remove results.PopulateHistogramSet Created with: gclient setdep -r src/third_party/catapult@13b94d068bdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:921000 Change-Id: Id6c998969daad99d97f8fbfcb1a1a4d413d47128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878447Reviewed-by:
-
Marina Ciocea authored
This is a reland of 916c54c5 Original change's description: > Add browsertests for tab sharing UI views. > > Add tests to verify tab sharing UI elements: infobars, contents border > and tab sharing indicator. > > Bug: 996722 > Change-Id: I5fa5ec7e4a48a66c1ba9b08ff76b84a105961352 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847287 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707368} Bug: 996722 Change-Id: Ic325cb95314cbe299253895f15534a83ef8b193e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878409Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#709017}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/90a30f154a61..0a3d2bb99b45 git log 90a30f154a61..0a3d2bb99b45 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 filmil@gmail.com [doc] FT_Open_Args: Clarify the ownership of `pathname'. 2019-10-22 wl@gnu.org * src/sfnt/sfwoff2.c (woff2_open_font): Avoid undefined shift. Created with: gclient setdep -r src/third_party/freetype/src@0a3d2bb99b45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I74ee7a30c06129de62eb5706b529c9f73b2f3792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873498Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#709016}
-
Andrey Zaytsev authored
Bug: 1015841 Change-Id: Iacec36c6666d855d113e074148a101b21ab0e76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856846 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Florian Uunk <feuunk@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#709015}
-
Robbie Gibson authored
Before any conversion, the tests failed when run on the bots with other tests. After conversion, the tests pass when run by themselves locally in both EG1 and EG2. The tests fail on EG1 bots when submitting, and I can't tell whether they pass on EG2 bots because I can't find these bots. I'm submitting with them only disabled on EG1, with the hope that the EG2 migration will fix the ordering issue. Bug: 987646 Change-Id: I006671d67f02fb2263c60eee6b330e419f5dfd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871880 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Rohit Rao authored
Mirrors the division we have for EG1 tests. BUG=987646 Change-Id: Id0d57402b5241799f376eb60f440e3fa53caae2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869330Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#709013}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e8843ab060ac..137a46738b35 git log e8843ab060ac..137a46738b35 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 eseckler@google.com processor: Move proto_trace_parser/tokenizer to importers/proto/ Created with: gclient setdep -r src/third_party/perfetto@137a46738b35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:141459049 Change-Id: Iff5df44d20e66076eaea49c136521a7c4f0404e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877606Reviewed-by:
-
Elly Fong-Jones authored
This change adds a browser test (actually an interactive ui test) that ensures that flags that expire actually end up hidden in the UI. To avoid depending on the real flag metadata, this change also adds flags::testing::SetFlagExpiredPredicate to allow tests to control which flags are considered to have expired. Bug: 1010678 Change-Id: If6275735105fa552779429f7978d7bf9e76f3687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876469Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#709011}
-
Miyoung Shin authored
This CL converts AudioLog{Ptr, Request} in content and services to the new Mojo type, and usese pending_receiver<AudioLog> in audio_logging.mojom. Bug: 955171 Change-Id: I34ac38228c93723dc258f87c36aa2938d4d7bc1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872090 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Sam McNally <sammc@chromium.org> Reviewed-by:
-
Adithya Srinivasan authored
Previously, in multiple instances, we used a navigation observer to wait for the first portal navigation with the assumption that navigation wasn't already complete. This assumption was incorrect, the portal could navigate before we return from the ExecJs call that initiated the navigation. This CL creates the observer before calling ExecJs Bug: 990717, 998107 Change-Id: I8d73b2c39e343e625fa9423291568af2c69e35cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873239Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#709009}
-
Jérôme Lebel authored
Updating the expiration date from 2019-11-01 to 2020-11-01. Bug: 1006978 Change-Id: Ia60beec8b686a681d36ba390e4076592b904d26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878407 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
