- 14 Aug, 2020 40 commits
-
-
Clark DuVall authored
This reverts commit 98a0a1d3. Reason for revert: Seems this should be fixed by crrev.com/c/2354124. Original change's description: > Disable DownloadCallbackTest.testBasic on Android > > org.chromium.weblayer.test.DownloadCallbackTest.testBasic fails on > Android, > https://analysis.chromium.org/p/chromium/flake-portal/flakes/ > occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVybwsSBUZsYWtlImRjaHJvbWl1bUB3ZWJs > YXllcl9pbnN0cnVtZW50YXRpb25fdGVzdF9hcGtAb3JnLmNocm9taXVtLndlYmxheWVyLnRl > c3QuRG93bmxvYWRDYWxsYmFja1Rlc3QjdGVzdEJhc2ljDA, > disable it for now until it is fixed. > > TBR=jam@chromium.org > > Bug: 1116248 > Change-Id: I24f0ab8414f4b17ff3689f3686e3f58682c48b37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354162 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797990} TBR=jam@chromium.org,lanwei@chromium.org Change-Id: I0c18d0e319ee49770b5e453af435d22a5a0a182f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116248, 1116311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357637Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#798284}
-
Anthony Vallee-Dubois authored
Bug: 1112795 Change-Id: I2bd6282c859c93ea2a193759713d2da08d2be5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340003Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#798283}
-
Mehran Mahmoudi authored
This removes the existing uptime histogram and replaces it with multiple new histograms that are categorized by the exit cause. Format Bug: 1109991 Change-Id: I3d50585b860dafc55764929bd17bfa6c3fbb8241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349921Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#798282}
-
nancylingwang authored
Click the open with button at the browser url bar, then shutdown the system, it crashes due to access the null pointer. So add the null pointer checking to avoid the system crash. BUG=1116344 Change-Id: I4c45983f8d626eabd98a8e0f188c32255ffbe0b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353779 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798281}
-
Egor Pasko authored
We intend to make a wider rollout/experiment of the feature to discard the code cache. No changes are expected in the lab. Update the config to confirm no effect on bots. Bug: 1045052 Change-Id: I5c0a6443f9cefac93391d957a1fcefffc72adea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356709Reviewed-by:
-
spdonghao authored
Bug: 1111824 Change-Id: I1b95c1c1c9f1b823e9b077cc9937d0a01f302f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332317 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798279}
-
adoneria authored
Bug: 1109373 Change-Id: I012f3bc8021a7c2f7fc8a2f6349db1607aa82752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354556Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#798278}
-
Patrick To authored
xrEndSession should only be called in the XR_ERROR_SESSION_NOT_STOPPING per the OpenXr spec, so checking for the running state isn't necessary. Bug: 1116111 Change-Id: I089846d868441d8cd2d6d9bd82534859966d8772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357511Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#798277}
-
Ahmed Fakhry authored
This CL fills in more impl of the capture session: - Paints the capture region according to the current selected source. - Add support for event handling. - Pressing ESC dismisses the session, while ENTER performs the capture and dismisses the session. BUG=1116137 TEST=Manual Change-Id: Ic86fd1230dea04d8d59ed19cbf7455e70d0a7795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354567Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#798276}
-
Elly Fong-Jones authored
This test asserts that closing a parent NSWindow deallocates the child NSWindow if the parent held the last reference. This is all well and good, but needs to account for AppKit's habit of autoreleasing refs to things while operating on them (eg, https://crbug.com/998773). Do this by allowing the autorelease pool to drain before checking for dealloc. Bug: 1114245 Change-Id: I46426f163b5fbdc3822ec4c4019c722cac787c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356910 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#798275}
-
Matthew Mourgos authored
Before this, sometimes the standardized icons are not given a white background circle when they appear within the shelf or launcher suggestion chips because the icons were incorrectly being detected as already circular shaped. This CL changes some of constants used for circle detection so that icons of smaller sizes are correctly detected as being non-circular. Bug: 1115812, 1113576 Change-Id: I51e04c63457bb48bb12a1898edc4e94467169362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355493Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#798274}
-
Wenbin Zhang authored
[benchmarking] disabling media.desktop/video.html?src=smpte_3840x2160_60fps_vp9.webm&seek on win-10_laptop_low_end-perf Per discussion on crbug.com/1114681#c2, disabling the story in win 10 low end laptop, using the tag win-laptop. Bug: chromium:1114681 Change-Id: I3dc6624093e8f0c93d813711b8b021ef6363f14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355013 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798273}
-
sczs authored
- Creates DiscoverFeedService, a BrowserState KeyedService - Creates DiscoverFeedServiceFactory to create and own DiscoverFeedServices - Initializes DiscoverFeedService in main controller. - Updates DiscoverFeedProvider interface with methods to start the Feed and update when the Identity changes. Bug: 1085419 Change-Id: Ie39653f6263915f9ef69b68d5c1e2182d15c7ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344503Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#798272}
-
Haiyang Pan authored
As all Pixel 1s will be flashed to from NJH47F to PQ3A.190801.002 (See crbug.com/1111436#c17 for more detail), there won't be devices for android-nougat-arm64-rel Bug: 1111436, 1095778 Change-Id: Id80bb9e09ee96c743c47325a9cf99fe62c8d80af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356972 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#798271}
-
Allen Bauer authored
Bug: 648382 Bug: 1010217 Change-Id: I1da966eb685b96832017317853c90fb3d744a491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353058 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#798270}
-
Dan Harrington authored
Bug: b/162435720 Change-Id: If23e4026e65ea28c6f78c7064dc05bb6c7cfcf86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354417 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#798269}
-
Xianzhu Wang authored
Background: transformed rasterization is used to render sharp text in a composited layer with fractional transform. It snaps the composited transform of the layer to whole pixels, then applies the fraction during rasterization. Previously we disallowed transformed rasterization in blink for directly composited layers (excluding backface-visibility:hidden and trivial 3d transforms such as translateZ(0)), especially for will-change:transform because change of fractional transform would cause re-rasterization which would defeat the purpose of will-change:transform. Now for a layer that was not eligible for transformed rasterization, calculate the initial raster translation which achieves sharp text rendering with the initial transform. When the transform of the layer changes, keep its original raster translation to avoid invalidation of tilings, to ensure animation performance. The rendered result will be blurry during animation but the initial rendering result is sharp. Remove blink-side transformed rasterization conditions and let cc decide it based on screen and draw transforms of the layers. Bug: 1111195 Change-Id: If0455be2f29e69cd7152c951626e6e8cc143b5bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351164Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798268}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/241a4a92fb96..4c3752c7f677 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I44729297da477c5b71397cdf754dd76748d3fe4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355277Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798267}
-
cfredric authored
audioBitsPerSecond} for identifiability study. These web IDL annotations will automatically add instrumentation (using blink::Dactyloscoper) in the bindings code to record how much entropy these APIs leak about users' cross-site identity. Bug: 973801 Change-Id: I6c61c13bb5c98f65415678f000e5137d016ba55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354153 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#798266}
-
Sergey Ulanov authored
VideCaptureDeviceFuchsia wasn't handling sysmem buffer collection allocation failures. Fixed it to handle them properly. Also added a unittest. Bug: 1111761 Change-Id: Ic56f570dfd8826a3663c5752db15487289bff234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335651 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798265}
-
Lindsay Pasricha authored
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/a1c3b1271dcd..3f5086309f48 $ git log a1c3b1271..3f5086309 --date=short --no-merges --format='%ad %ae %s' 2020-08-10 tirodkar Fix touch injection for iOS 13.5+ device tests. 2020-08-10 tirodkar Ensure the failure handler prints the hierarchy for GREYAssertionDefines as well. 2020-08-07 albertbow Use GREYErrorMakeWithUserInfo for distant object. 2020-08-07 tirodkar Fix assertion error format when there's a single element mismatch. 2020-08-07 tirodkar GREYError cleanup of description dicts. 2020-08-06 chanheepark Override localizedDescription of GREYError to print out the whole error description. 2020-08-04 tirodkar Remove GREYScrollActionError from xcode proj. 2020-08-03 tirodkar Delete the old failure formatter. 2020-07-31 tirodkar Create new error macro for userInfo + description. 2020-07-29 tirodkar iOS 14 Keyboard support 2020-07-23 mobile-devx-github-bot Remove the #errors for tvOS, only return nil. 2020-07-23 tirodkar Moving error domains / code to GREYErrorConstants. 2020-07-22 chanheepark Add underlying error to scroll action failure. 2020-07-21 tirodkar Variable changes in GREYTimedIdlingResource. 2020-07-21 mobile-devx-github-bot Add tvOS support to AppFramework, TestLib, UILib. Created with: roll-dep src/ios/third_party/earl_grey2/src Bug: 1115121,1109205 Change-Id: I12d62cb5da31999c8294863c948aaedbd47a2de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348536 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798264}
-
nancylingwang authored
Sometimes, when shutdown the system, the instance could be updated, but the window might have been destroyed. Also ARC CTS might have the unusual event flow to set the task active when the window is killed. So observing all windows when update the instance could cause crash. Actually CL:2307669 added observing all windows mainly because browser tabs are not observed. So redo CL:2307669: 1. Observe browser tabs during the system init phase 2. Observe the new inserted tab To avoid crash, OnInstance checks whether the window is observed, and if not, remove the instance. BUG=1116041 BUG=1116033 b:163005244 Change-Id: Idfb675b61592176da183be092dcecff1e464ec2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355163 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Jonathan Mengedoht authored
Integrate ChangePasswordUrlService in WellKnownChangePasswordNavigationThrottle to provide change password url overrides. ChangePasswordUrlService::GetChangePasswordUrl is now sync. Bug: 1086141 Change-Id: If843098ed0f384e1b118ccc91c346c7089ca226a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317191 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#798262}
-
Emily Stark authored
In some variants of the simplified domain field trials, we show the full URL on page load and elide to a simplified version of the domain after the user interacts with the page. Originally we considered any user interaction (as received via WebContentsObserver::DidGetUserInteraction) a trigger for elision, but then started ignoring mouse clicks in https://chromium-review.googlesource.com/c/chromium/src/+/2327289, to avoid flashing when the user clicks on links. This proved to be a bit too coarse, since we want to at least elide the URL when the user focuses a form text field. This CL thus elides the URL when WebContentsObserver::OnFocusChangedInPage() reports that an editable node has been focused. Bug: 1104280 Change-Id: Ib0b4a5b19d035c38a2e529c6f526c421f537cff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357074Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#798261}
-
Guillaume Jenkins authored
The experiment name for the Windows native spell checker integration does not match the name of the Chrome variation field trial configuration entry. This changes the name in the field trial configuration so it matches the Finch experiment name. Bug: 978460 Change-Id: If10344fd9312535b5e8c1917cf6d3c7a6a80fd7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356689 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#798260}
-
Robert Flack authored
Updating timelines can enqueue tasks related to ready and finish promises which should run before animation events and updated rendering. Bug: 1116020 Change-Id: Ica1927bb3921eef574abeaca23bb198dda658ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354164Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798259}
-
Nate Fischer authored
No change to logic. This disables a flaky test. Tbr: mastiz@chromium.org Bug: 1103515 Test: None Change-Id: I807fb635cf761a75013f5bde622df32909009f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357469Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798258}
-
Joshua Pawlicki authored
On Mac, uninstall deletes the app data dir altogether. On Win, uninstall deletes the app's grandparent dir, which contains the program executable, logs, and prefs file. Bug: 1115135 Change-Id: Ife281abeafd265b1cd50f6fcb67212b49eccc5ef Fixed: 1115135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353192 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798257}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.48-1597052523-benchmark-86.0.4231.0-r1 to 86-4183.48-1597052523-benchmark-86.0.4232.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iff5064a06d563d001a6c4a83d6b41eb344f91d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357549Reviewed-by:
-
James Hawkins authored
R=khorimoto@chromium.org Bug: none Test: none Change-Id: Ie63e7d3235b70b18b7934d4dc9369caead386b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355672 Auto-Submit: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#798255}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/66f621ae9064..a2a426bd66bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC thestig@google.com,juanmihd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1107989 Tbr: thestig@google.com,juanmihd@google.com Change-Id: I04209206e09d973fa2425aad56ae9eeaf6351c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354502Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798254}
-
Merissa Tan authored
- Add exo::Gamepad interface. - Add exo::GamepadObserver interface. - Add WaylandGamepadVibratorImpl to handle vibration and cancel vibration requests from the client. - Refactor WaylandGamingSeatDelegate so that WaylandGamepadDelegate handles all gamepad-specific events. - Add Wayland protocol to support gamepad rumble. The zcr_gamepad_vibrator_v2 interface is created when the server calls the vibrator_added event. The client can then trigger/disable vibration events on a gamepad vibrator through the interface. BUG=b:158686809 TEST=Add unit tests in gamepad_unittest. All tests pass in exo_unittests. Change-Id: Ie4b1b3b5f9748f31846c54c97cb4f7c315d09a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313976 Commit-Queue: Merissa Tan <liyingtan@google.com> Auto-Submit: Merissa Tan <liyingtan@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#798253}
-
Rahul Singh authored
Windows devices Currently, GetCameraRotation() in video_capture_device_utils_win.cc assumes a landscape device. On upcoming Windows devices with naturally portrait displays this leads to the video capture feed being off by 90 degrees counterclockwise. This is because the camera continues to be mounted in a landscape orientation while the display is naturally portrait. This CL adds IsPortraitDevice() in video_capture_device_utils_win.cc which deduces whether we are running on a portrait orientation Windows device. This method is called as part of GetCameraRotation() and helps us correct the video rotation by 90 degrees counterclockwise for portrait orientation devices. Testing: Verified that with this change: 1. Front camera on portrait orientation devices rotates correctly. 2. We preserve existing rotation behavior on landscape orientation devices and when external cameras are attached. Bug: 1061541 Change-Id: I4a7e9552471242c544ee181ab0d0f4685c09f1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354539Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#798252}
-
Chris Harrelson authored
The code was added not for this use case, but to ensure that composited bounds were optimized to avoid parts of descendants that were clipped out. This change also unblocks deleting some code and removing one cache slot, which will save memory on PaintLayer. Change-Id: I0ca7592ab3609a784bedd095e0c7fb4315b7527a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353872Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798251}
-
Juliet Levesque authored
1) Set correct HTTP host, OAuth2 token, and UpdateDevice URLs. 2) Start the local device data manger. 3) Log the HTTP request URL. Bug: b/154863110 Change-Id: I6a2d758f52091f1cbbe290e2a4bed198f1584397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350541 Commit-Queue: Juliet Levesque <julietlevesque@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#798250}
-
Tim Van Patten authored
The memory_test target fails to build on Windows due to a variety of errors related to MOCK_METHOD(). For example: memory_test.cc(542,3): error: static_assert failed "(size_t) should be enclosed in parentheses." This is generated by the line: MOCK_METHOD(value_type*, allocate, (size_t)); "(size_t)" is clearly enclosed by parentheses (the error message even indicates this), but both clang and MSVC fail to compile correctly on Windows due to these errors. Bug: angleproject:4873 Bug: 1116473 Test: Build on Windows and Linux Change-Id: Ie83e7f2ebcdbd641b9e87ac7de7ef28f19b0bbac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353403Reviewed-by:Jamie Madill <jmadill@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com> Cr-Commit-Position: refs/heads/master@{#798249}
-
Lukasz Anforowicz authored
This CL finishes reverting r719801 (started in https://crrev.com/c/2327963) while preserving the test coverage added via MultiOriginSessionRestoreTest. Bug: 1107269 Change-Id: I5172e610b098cb4a09187972498a031f12ee8539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336506Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#798248}
-
Chris Lu authored
Re-enable EG2Tests that were disabled because content was being hidden behind the toolbar. Bug: 1107989 Change-Id: I123bcab04934051b7475f9debcefc5b8c6a85497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354727Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#798247}
-
Josh Nohle authored
Add a method to the certificate manager that returns all of the local device private certificates of a given visibility, converted to public certificates. This feature was requested in crrev/c/2346325. Bug: 1114765 Change-Id: Ifec56ec08a6072018f35e5e0121ecf9562201faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348295 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#798246}
-
Chris Hamilton authored
This adds an base::Optional<ExecutionContext> token to ExecutionContext to that all ExecutionContexts that have a well defined parent (in terms of lifetime associations) can be tracked. This will allow worklets to be associated with their parent LocalFrame, and DedicatedWorkers to be associated with their parent context. These information will be used by the performance.measureMemory API implementation. BUG=1085129 Change-Id: I52d4056e50ca3ce9b0090196342bdf1118c21865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343609 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#798245}
-
