- 03 Aug, 2017 40 commits
-
-
Nasko Oskov authored
Bug: 662160 Change-Id: If252b4f8765eb70218f6c89d8794c05566700fbe Reviewed-on: https://chromium-review.googlesource.com/600768Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#491817}
-
Eric Holk authored
Bug: v8:6514 Change-Id: Idcd54185eecc4d4b15756ab4e1633e1e6e7b2427 Reviewed-on: https://chromium-review.googlesource.com/599031Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#491816}
-
Karl Schimpf authored
Collect compile time separately form asm.js and Wasm functions. Depends on CL https://chromium-review.googlesource.com/c/598930 Bug: chrome:709684 Change-Id: Ic0ccb42445c8f98ce7175da5ac44d6f958114558 Reviewed-on: https://chromium-review.googlesource.com/598542Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Cr-Commit-Position: refs/heads/master@{#491815}
-
Sergey Ulanov authored
CancelableSyncSocket unittests were not testing all cases properly. There was only one test for Shutdown() that only verified that it works properly with ReceiveWithTimeout(). Receive() wasn't tested with Shutdown(). Bug: 741783 Change-Id: I722d328e8904d2b48c3b86a0b5ce15d3661c9b13 Reviewed-on: https://chromium-review.googlesource.com/598648 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491814}
-
Qiang Xu authored
changes: (1) no hover state highlight (2) update search result tile selection highlight (3) update search result simple row selection highlight (4) another opened search box background color change: when search box is opened (state is STATE_SEARCH_RESULTS), the background color should be #FAFAFC 100%. specs: https://screenshot.googleplex.com/thXHXNn3Vmt screenshot: https://screenshot.googleplex.com/UXtpfwpqHJY Test: test with and without fullscreen app list flag Bug: 750690 Change-Id: I090462bf36305393a55fcc1083c1c48fb5ae7a5a Reviewed-on: https://chromium-review.googlesource.com/600729 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#491813}
-
Scott Graham authored
TBR=wez@chromium.org Bug: 752220, 738275 Change-Id: I839aca92ea3d4421139ce0b2113983bce780dd16 Reviewed-on: https://chromium-review.googlesource.com/600493Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491812}
-
Luna Lu authored
This reverts commit 260cd28a. Reason for revert: suspect causing the failure on https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/62043 Original change's description: > Update the DEPS to use the most recent libaddressinput version. > > Bug: 752122 > Change-Id: I90870a875855161b49e03bd1b4e7870f76dec694 > Reviewed-on: https://chromium-review.googlesource.com/600289 > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491754} TBR=mathp@chromium.org,sebsg@chromium.org Change-Id: I642f76aa363a09951b64788615908ae4e618584e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 752122 Reviewed-on: https://chromium-review.googlesource.com/600635Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#491811}
-
chrome://net-exportchrome://aboutPierre Neter authored
Signed-off-by:
Pierre Neter <pierreneter@gmail.com> Bug: 751391 Change-Id: I6b2d4d1102f2424cff411147637bae6c31c1acd0 Reviewed-on: https://chromium-review.googlesource.com/596988 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491810}
-
sebsg authored
Change-Id: I2672c0ed867ed66a446b6483f4f54e81f4029d5d Reviewed-on: https://chromium-review.googlesource.com/587304 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#491809}
-
Xiaocheng Hu authored
This patch adds the interactive rebaseline functionality to test-expectations.html, so that after checking the test results, a selective rebaselining can be easier: 1. Click the "Select" button next to "Select tests to rebaseline" 2. A checkbox appears by each shown test 3. Check the checkboxes which needs rebaseline 4. Click the "Done" button 5. A dialog with some rebaseline script appears, with the script already copied to clipboard. Run the script [1] locally in your terminal in LayoutTests/ (or platform/xxx/, flag-specific/xxx/ if the tests are platform/flag dependent) to download the new expectation files to create a rebaseline patch. The initial purpose of this patch is to help the the development of TextIteratorNG [2], which creates a lot of unexpected failures. Some of them are due to resolution of existing bugs (and hence, these tests should be rebaselined), but others are due to new bugs (so these tests shouldn't be rebaselined). This patch makes the selective rebaseline much easier. [1] The script is currently Linux-only [2] https://chromium-review.googlesource.com/c/580371 Bug: Change-Id: If869509f27f8d32e938f9778f636513045845a01 Reviewed-on: https://chromium-review.googlesource.com/597388 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#491808}
-
Steven Bennetts authored
Bug: 750741 Change-Id: I2e9d55b9e08901d9ac80bd91634936c99831b5b7 Reviewed-on: https://chromium-review.googlesource.com/594640 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#491807}
-
Francois Doray authored
The ScopedAsyncTaskScheduler in chrome_component_updater_configurator_unittest.cc was useless. This CL simply removes it. Bug: 708584 Change-Id: Ia1cb9bfb343ddc5810421dc655227128c3a40979 Reviewed-on: https://chromium-review.googlesource.com/591949 Commit-Queue: Francois Doray <fdoray@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491806}
-
Nasko Oskov authored
This test passes with iteration count of 100 locally. It should not be flaky, but let's try and see. Bug: 660288 Change-Id: I8f190be7f6b6639e048ea59f040ca0421c3b51bd Reviewed-on: https://chromium-review.googlesource.com/600492Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#491805}
-
Tommy C. Li authored
Fixes HistoryUrlProvider's match_in_foo implementation, and adds tests. Bug: 732582 Change-Id: I5f63a74bb02a6cc97c771b26080217ea9559eb3b Reviewed-on: https://chromium-review.googlesource.com/597170 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#491804}
-
Daniel Cheng authored
WebLocalFrame and WebFrameClient should have a 1:1 relationship, which makes the parameter unnecessary. Bug: 361765 Change-Id: I5462b3185698241654f26391f872200228009c66 Reviewed-on: https://chromium-review.googlesource.com/544362 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#491803}
-
kapishnikov authored
Bug: 751212 Change-Id: I2214931d49ba27c5237582dcacdc2d85512f875e Reviewed-on: https://chromium-review.googlesource.com/596748Reviewed-by:
smut <smut@google.com> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#491802}
-
Wez authored
Change-Id: I310dcfaa28be9c06c9bcd4524ceae32a38362ce7 Reviewed-on: https://chromium-review.googlesource.com/572502Reviewed-by:
Hector Dearman <hjd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#491801}
-
Sean Kau authored
USB printers are installed automatically if we are sure of the configuration. Log these printers with USB attributes and the fact that they were configured automatically. Bug: 740270, 725739 Change-Id: I50d4596cbf94fc9de8871cf5c8e02ded75e05681 Reviewed-on: https://chromium-review.googlesource.com/598691Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#491800}
-
Kevin Marshall authored
Fuchsia: stub out missing ProcessMetrics methods. The absence of Fuchsia stubs for these methods produced linker errors when compiling the headless shell. R: scottmg@chromium.org Bug: 750948 Change-Id: If9e13e80e17852fe7692164b2cd0c728bdded9f3 Reviewed-on: https://chromium-review.googlesource.com/596624 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491799}
-
Luna Lu authored
This reverts commit 9e21c73c. Reason for revert: suspect causing WebKit Android (Nexus 4) to fail on webkit_unit_tests https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/67957 Original change's description: > Fix overlay scrollbar at huge scroll offsets > > The overlay scrollbar ThumbPosition method was losing precision at very > high scroll offsets. This would cause it to drift away from where we > actually show the thumb from the compositor so the hit testing would be > unreliable. > > Looking at this method, there's no reason it should need to be any > different from the base class ScrollbarTheme::ThumbPosition which is > robust under high scroll offsets so the solution here is to simply > remove the override. Less code, less bugs. > > Bug: 739668 > Change-Id: Ib90152d989931cd0bcc0bddfb226d97d577ce575 > Reviewed-on: https://chromium-review.googlesource.com/598734 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491766} TBR=bokan@chromium.org,jbroman@chromium.org,dtapuska@chromium.org Change-Id: I44f227bc5956899ff43e7c6d96e7c5596666ae36 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 739668 Reviewed-on: https://chromium-review.googlesource.com/600848Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#491798}
-
Doug Turner authored
Bug: 742592 Change-Id: I92fe2330345f60d599e6fd7c77d5c74c20237268 Reviewed-on: https://chromium-review.googlesource.com/599569 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#491797}
-
Kuang-che Wu authored
If Vp9Parser::ParseNextFrame returned error and the client continued to call the parser, this may lead to out-of-bounds read. This issue only affected the fuzzer. BUG=741244 Change-Id: Ic60a5e21a85301af520753cecf2b725e66eddb6d Reviewed-on: https://chromium-review.googlesource.com/566753 Commit-Queue: Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#491796}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/698edfecef12..1a2e3e1e77bf $ git log 698edfece..1a2e3e1e7 --date=short --no-merges --format='%ad %ae %s' 2017-08-03 mtklein Store float and byte constant colors. 2017-08-03 mtklein funnel all constant colors through append_constant_color() 2017-08-03 mtklein Rename append_uniform_color() to append_constant_color(). 2017-08-03 mtklein _very_ minor srcover speedup 2017-08-03 mtklein improve HSW 16->8 bit pack Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I2887f4440a4385382c2a5309faf720923a9b54d5 Reviewed-on: https://chromium-review.googlesource.com/600528Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#491795}
-
Sigurdur Asgeirsson authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: Ie52b94fb16a240c5f6549560e6e99982fc28b924 Reviewed-on: https://chromium-review.googlesource.com/596416 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Robert Shield <robertshield@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491794}
-
Dave Tapuska authored
A new test was added to the legacy_input_router_impl_unittest but wasn't cloned over to the new input_router_impl. Add the missing code. BUG=727866 Change-Id: Id7df047f173be06e4447d9ff99c383b85f2e3fed Reviewed-on: https://chromium-review.googlesource.com/598545 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#491793}
-
Xiaohui Chen authored
This reverts commit 1737b40c. Reason for revert: Reland after removing base::TimeTicks::since_origin() usage that does not exist in M61 branch. Original change's description: > Revert "Add animated voice interaction icon." > > This reverts commit 875aa3d7b80dd3d6a2f0a265d4ca1875b502abc6. > > Reason for revert: > > Breaks the M61 branch build > > cc -o obj/ash/ash/voice_interaction_overlay.o > ../../ash/shelf/voice_interaction_overlay.cc:170:43: error: no member named 'since_origin' in 'base::TimeTicks' > uint64_t now = base::TimeTicks::Now().since_origin().InMilliseconds(); > > Original change's description: > > Add animated voice interaction icon. > > > > BUG=b:62276007 > > TEST=build flash locally, see animation as spec > > TBR=xiaohuic@google.com > > > > (cherry picked from commit cc92f7ae) > > > > Change-Id: I5542b68e084fe465c2f8b424b521c8faef51f686 > > Reviewed-on: https://chromium-review.googlesource.com/585245 > > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Cr-Original-Commit-Position: refs/heads/master@{#490447} > > Reviewed-on: https://chromium-review.googlesource.com/595143 > > Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> > > Cr-Commit-Position: refs/branch-heads/3163@{#198} > > Cr-Branched-From: ff259bab-refs/heads/master@{#488528} > > TBR=kaznacheev@chromium.org,oshima@chromium.org,xiaohuic@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: b:62276007 > Change-Id: Ie8e554ca79f054e0e4d18621402123455950aa9c > Reviewed-on: https://chromium-review.googlesource.com/597071 > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Original-Commit-Position: refs/branch-heads/3163@{#229} > Cr-Original-Branched-From: ff259bab-refs/heads/master@{#488528}(cherry picked from commit 020cdf35035e30942aa34ca571fce561bff18cf6) > Reviewed-on: https://chromium-review.googlesource.com/598507 > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491521} Bug: b:62276007 Change-Id: I7c07a6edca4f853cd8e73664217c662eb29fc27d Reviewed-on: https://chromium-review.googlesource.com/598688Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#491792}
-
clamy authored
This CL removes most of the usages of RenderFrameHostTester::SimulateNavigationStart outside of content/ in favor of using NavigationSimulator. The goal is to have embedders of content/ use the NavigationSimulator exclusively when writing unit tests that involve navigation. This allows several tests to work with PlzNavigate or OOPIF enabled. BUG=728571 Change-Id: Iab0efe63d3c892da62ffe4e5cc2641e9af0f03a3 Reviewed-on: https://chromium-review.googlesource.com/582949 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#491791}
-
Luna Lu authored
This reverts commit 90a73c37. Reason for revert: <INSERT REASONING HERE> Original change's description: > [WebPayments] Clicking selected row goes back > > Changing behavior when clicking on the currently selected item in an > ItemList. Was a no-op; now goes back to the main sheet. > > Bug: 748552 > Change-Id: I43f716145c059b6d95d5f01526b1224528fb0ad3 > Reviewed-on: https://chromium-review.googlesource.com/585370 > Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org> > Commit-Queue: Tommy Martino <tmartino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491751} TBR=anthonyvd@chromium.org,tmartino@chromium.org Change-Id: I8a5d7de3da2f0e7f47bff11e9c6980e31590c38d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 748552 Reviewed-on: https://chromium-review.googlesource.com/600847Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#491790}
-
Bin Zhao authored
- Moved device count metrics into its own class - Added Cast device count metrics Bug: 687377 Change-Id: Id7ca7b7a529a79a8827889ad63f51b1da74db1db Reviewed-on: https://chromium-review.googlesource.com/596615 Commit-Queue: Bin Zhao <zhaobin@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#491789}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ee634fd9..ad701e38 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Id86ce5d4109e5142f098cbadb1a456a8b5810521 Reviewed-on: https://chromium-review.googlesource.com/600113Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#491788}
-
Sigurdur Asgeirsson authored
This is copy of https://codereview.chromium.org/2867063002 with all the install_static refactoring removed to avoid bug:748949. Bug: 718437 TBR: alexclarke@chromium.org Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I3341f9af6a73dd83fc631bbde5f5b0473ff9de55 Reviewed-on: https://chromium-review.googlesource.com/591827 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Pierre-Antoine Manzagol (departed) <manzagop@chromium.org> Cr-Commit-Position: refs/heads/master@{#491787}
-
Francois Doray authored
ScopedTaskScheduler is deprecated. Bug: 708584 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I583be368ed89cdc687078bd8b72fcf2edf240afa Reviewed-on: https://chromium-review.googlesource.com/586912Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#491786}
-
Elliot Glaysher authored
Also enables services_unittests on the linux asan bots. Bug: 751853 Change-Id: Ia4ea33100405c657fd0ee40fe15306e997193ce8 Reviewed-on: https://chromium-review.googlesource.com/599038Reviewed-by:
Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491785}
-
Dale Curtis authored
Per discussions with the Android team they recommend we skip resampling when using low power audio. This CL expands the workaround we already have in place for ChromeOS into a more maintable state by introducing AudioLatency::IsResamplingPassthroughSupported(). This method returns true on ChromeOS and on Android when the right criteria are met. There are several changes to the buffering size logic, but none should result in any actual changes to the buffering size outside of the new pass-through case. The pass-through case will prefer the larger of the hardware buffer size or ~20ms to avoid issues with massive bluetooth output buffers. As part of this change I've cleaned up the logic in the mixer manager for determining when to allow passthrough. Per a battor run done by liberato@ this is a ~34% power reduction (!), with a basic mp3 playback going from 0.265W to 0.175W. BUG=731860,747541 TEST=verified resampling is not invoked for basic playback. Change-Id: Ia885f41bc50d6fe36934587d34ae646d1ef89364 Reviewed-on: https://chromium-review.googlesource.com/590737 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#491784}
-
Stephen McGruer authored
Initial version of the README.md covers how cc/animation itself works (with some TODOs for trickier details), and dips briefly into the clients of cc/animation. Future CLs will expand on the details of how clients interact with cc/animation. Bug: 740070 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib89a29a77630e46abcd1bd0f90e4158e9ffc0f23 Reviewed-on: https://chromium-review.googlesource.com/579587 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Walter Korman <wkorman@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#491783}
-
Wez authored
Previously we would only clone the stdio FDs into the child if the option.fds_to_map was empty. Callers instead expect that stdio FDs will always be cloned into the child, but can also be overridden via the fds_to_map option. Bug: 706592 Change-Id: Ifd401b75ceda3b8fe1fb69604ff361ba50b2f40d Reviewed-on: https://chromium-review.googlesource.com/598749 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491782}
-
Jonathon Kereliuk authored
and enable previously failing tests Should fix: https://bugs.chromium.org/p/chromedriver/issues/detail?id=1852 for python tests, but not java tests Bug: chromedriver:1852 Change-Id: Iebe5ec09bff943ab54200590c9943713c899f05f Reviewed-on: https://chromium-review.googlesource.com/594653 Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#491781}
-
Doug Turner authored
Bug: 742592 Change-Id: I5d263b00a4d5d1ab0489217f09e73a353c3021b0 Reviewed-on: https://chromium-review.googlesource.com/599568Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#491780}
-
Bruce Dawson authored
When running battor_agent.exe for the first time one is likely to encounter the message "Unable to find a BattOr." Once a BattOr is found and battor_agent starts running there is a more informative help message printed if you type <enter>, but that is too late. This change prints an informative help message when a BattOr cannot be found, and also adds a bug link to the code to explain why BattOrs are not auto-found on Windows. BUG=588244 Change-Id: I1206f906b32c2f2e6ec18517e6c184aaf44bb7a7 Reviewed-on: https://chromium-review.googlesource.com/598657Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#491779}
-
Francois Doray authored
ScopedAsyncTaskScheduler is deprecated. Bug: 708584 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I89b92c36e714f4eb02b84f5130a75edf377cd8bf Reviewed-on: https://chromium-review.googlesource.com/591880Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
John Bauman <jbauman@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#491778}
-