- 21 Nov, 2018 40 commits
-
-
khachatryan authored
Disabling failing tests testDownloadDirectoryOverridesExistingPreferences and testExistingDevToolsPortFile on Waterfall on Windows build bot Bug: 907608:chromedriver:2673 Change-Id: I74adcfa17f6349aa74805e6905fa630661ea4a9b Reviewed-on: https://chromium-review.googlesource.com/c/1347613Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#610254}
-
Toni Barzic authored
Removes oauth2_token_fetcher_ and auth_url_loader_factory_ from OAuth2LoginManager, as they are no longer used - the usage was removed in CL:1212962 BUG=None Change-Id: Ia025818376f239e406dd285cdd288dca164c0ed2 Reviewed-on: https://chromium-review.googlesource.com/c/1347447Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#610253}
-
Xi Cheng authored
Change-Id: I07f07f12c0799e1e93d648419ff2488fff5db2da Reviewed-on: https://chromium-review.googlesource.com/c/1347580Reviewed-by:
Xi Cheng <chengx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#610252}
-
Owen Min authored
The option is read from the Registry with the same key as the enrollment token. The value is CloudManagementBlockOnFailureEnabled. Bug: 904983 Change-Id: Ia8bada4e79d236fb9f85320e38ed6588f34a5ad8 Reviewed-on: https://chromium-review.googlesource.com/c/1345211Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610251}
-
Darwin Huang authored
Helps fix errors in apps which prefer text/plain content while pasting over img, even though it is less spec-conformant to provide fewer types than possible. As noted in the crbug, these apps (ex. Messenger) generally prefer text/plain content due to compatibility issues with Microsoft Word. This does also make us more consistent with other platforms (ex. Windows/Linux), where we don't provide the text/plain field. Also moved a browser test to a layout test for future ease of testing. The browser test wasn't able to generate text/plain to reproduce the bug, due to images only previously producing text/plain output on images with alt text, and execCommand only operating on iframe DOM objects (not image DOM objects) Bug: 838808 Change-Id: I28b2d8d223c2448f47e887323afccae73d6bcf44 Reviewed-on: https://chromium-review.googlesource.com/c/1319032Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610250}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eacc22d07da8..e89f85283d4c Created with: gclient setdep -r src-internal@e89f85283d4c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I90152301df4986c82048f98057fa78848fa65544 Reviewed-on: https://chromium-review.googlesource.com/c/1347076Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610249}
-
Antonio Gomes authored
BUG=907533 Change-Id: Ib8714aa26040bbfb9338454c5c327f9194a20d32 Reviewed-on: https://chromium-review.googlesource.com/c/1347149Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#610248}
-
Sean Kau authored
Bug: None Change-Id: If683748053284fd0912c4652481de1b37783f033 Reviewed-on: https://chromium-review.googlesource.com/c/1345547 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#610247}
-
Eric Karl authored
We currently track various GL values (format/type/swizzle) for each viz::Format on SharedImageBackingFactoryGLTexture. Depending on whether we plan to use TexStorgae2D or TexImage2D, we calculate these differently. With the ability to upload data at texture creation time, we need to dynamically chose TexStorage2D or TexImage2D. Rather than duplicate the calculate format/type/swizzle, this CL ensures that these were actually the same all along (and fixes some cases where they weren't). This lets us simplify our format info calculation logic a bit. Bug: 906794 Change-Id: I4c97aade94ecf267df8a1adfb45aeda8e14d1c12 Reviewed-on: https://chromium-review.googlesource.com/c/1345538 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610246}
-
Joe Mason authored
Now there are an extreme number of permutations of test params, so this also splits off all the tests where the cleaner process does not start to cut down on redundant tests. R=csharp@chromium.org Bug: 907443 Change-Id: I015c02dd9ed72e3c5951acbdfc8163c89b1bc3ea Reviewed-on: https://chromium-review.googlesource.com/c/1347437Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#610245}
-
Xiaocheng Hu authored
This patch changes |PreviousSentencePosition()| to utilize |TextSegments| class to make it work with LayoutNG. Since the original implementation is a duplicate of |StartOfSentence|, so is the new implementation. Bug: 778507 Change-Id: I7ba9fe19c74ff87c121d6c2bfce7f28765976ca1 Reviewed-on: https://chromium-review.googlesource.com/c/1337282 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610244}
-
Jesse McKenna authored
Replace Sequence reference held by Sequence::Transaction from a scoped_refptr to a raw pointer, and replace the call to WrapUnique() in Sequence::BeginTransaction() to a move-constructor invocation. This change addresses a speed regression caused by https://chromium-review.googlesource.com/c/chromium/src/+/1327548. Bug: 889029 Change-Id: I7037f5863d4a9189a78434781e8593c10ac42713 Reviewed-on: https://chromium-review.googlesource.com/c/1340584 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#610243}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ea02708e078c..2ed782097044 git log ea02708e078c..2ed782097044 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 reed@google.com use SkFont in a lot of places 2018-11-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-21 brianosman@google.com Use GrVertexColor in various oval ops 2018-11-21 bsalomon@google.com Disable sampler objects when using ES2 shading language on ES3 contexts. 2018-11-21 benjaminwagner@google.com Upgrade Windows in Skolo. 2018-11-21 caryclark@skia.org fix bookmaker Created with: gclient setdep -r src/third_party/skia@2ed782097044 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: Ib264c4a8c29f6add0a35bf3b3dc45fe3973d47a9 Reviewed-on: https://chromium-review.googlesource.com/c/1347513Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610242}
-
Jesse McKenna authored
TaskScheduler: Move Sequence::traits() behind lock and add non-lock-protected shutdown_behavior() accessor Bug: 889029 Change-Id: I045aea22fb8d5a32fee3e3bd64c0b091c9336dd3 Reviewed-on: https://chromium-review.googlesource.com/c/1343178 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
-
Eric Willigers authored
Test computed values for various properties from - css-animations - css-shapes - css-transitions - css-ui - css-writing-modes - filter-effects Change-Id: Iad28fe2030f922bdcaa80d6ade383c69106b8822 Reviewed-on: https://chromium-review.googlesource.com/c/1345955 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#610240}
-
Becky Zhou authored
Bug: 907308 Change-Id: I472fdf61148d8f023a4b670d041593d3455c9f9f Reviewed-on: https://chromium-review.googlesource.com/c/1347048Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610239}
-
Eugene But authored
This is a step in multistep refactoring. The next steps will be: 1.) web::NavigationContext::URL is never set to placeholder URL and always represents navigation URL 2.) Same web::NavigationContext will be reused for placeholder navigation to extend it's lifetime. 3.) WebStateObserver::DidFinishNavigation will be caller after placeholder navigation is finished and will use original web::NavigationContext passed to WebStateObserver::DidStartNavigation This will partially fix crbug.com/903497 and will call WebStateObserver::DidFinishNavigation after committed URL actually changed. Originally Reviewed-on: https://chromium-review.googlesource.com/c/1331044 Bug: 903497 Change-Id: I0ee2ecdfb4d20d2f14fd62e99028e8de1b81ff3b Reviewed-on: https://chromium-review.googlesource.com/c/1347212Reviewed-by:Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#610238}
-
siyua authored
This CL patched another CL by jsaul@ https://chromium-review.googlesource.com/c/chromium/src/+/1334834 1) Added No thanks button as required by legal. 2) Changed the title to better explain its usage. Uploaded screenshot in the bug comment#4. Bug: 905393 Change-Id: Idc6e2e89a9cad9d4f5530ea4d4a1b2731feeff5e Reviewed-on: https://chromium-review.googlesource.com/c/1343281Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#610237}
-
Max Moroz authored
1) Avoid using std::string as a container for non-string data. The problem is that the underlying std::string buffer is bigger than the data we put inside (at least by 1 byte (null terminator), and might be even bigger). This may hide buffer overflow errors from ASan. 2) Make FuzzedDataProvider portable (remove //base dependency). 3) Make the types it returns more explicit (e.g. `int32_t` instead of `int`). Bug: 907103, 906080 Change-Id: Ibe1cd5ef6cb72140459a8ba3ac301f8c2bef48b9 Reviewed-on: https://chromium-review.googlesource.com/c/1344993 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#610236}
-
Gang Wu authored
Specifics: +62,440 bytes main lib size +467,552 bytes main dex size +745,805 bytes normalized apk size InstallSize: +280,953 bytes APK size +827,989 bytes Estimated installed size (Android Go) +2,169,863 bytes Estimated installed size InstallBreakdown (+2,168,374 bytes): +2,700 bytes unwind_cfi (dev and canary only) size +2,146 bytes Non-compiled Android resources size +62,440 bytes Native code size +353 bytes Package metadata size +2,086,323 bytes Java code size +14,412 bytes Compiled Android resources size Dex: +2,396 entries fields +3,284 entries methods +772 entries types +1,681 entries strings Change-Id: I173abfb7ba5c75d10ade40de047b7f0bba257763 Reviewed-on: https://chromium-review.googlesource.com/c/1344292Reviewed-by:Filip Gorski <fgorski@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#610235}
-
Kristi Park authored
Thumbnails have been deprecated as of M69. Removing the multi-iframe thumbnails used in third-party NTPs. Bug: 893362 Change-Id: I6dbc1ddf8a204d9661f437bb0b0db30888ec48dd Reviewed-on: https://chromium-review.googlesource.com/c/1324449 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#610234}
-
Becca Hughes authored
Add seek backwards and forwards buttons to the media notification. BUG=893296 Change-Id: If4a0263295e0b824a78f214e63a9747ba89db4c9 Reviewed-on: https://chromium-review.googlesource.com/c/1306734 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Tony de Luna authored
The goal is to make Mobile network status be more apparent to the user, even when WiFi or Ethernet network is connected. To do this we now have independent tray network icons. One Tracks Wi-Fi, the other Mobile network state. This cl adds different rendering strategies for network icons in the system tray. In the future we may also want to allow Tethering icon to be displayed on its own. We can add a new strategy when the spec is ready. Feature is developed behind feature flag 'SeparateNetworkIcons'. Bug: 902409 Change-Id: I878aa4fbe02676bd235eba60979155fb57207175 Reviewed-on: https://chromium-review.googlesource.com/c/1340807 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO till 11/26) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#610232}
-
CJ DiMeglio authored
This CL makes using ReleaseSoon with scpoed_refptr easier. It encapsulates the call to AddRef, and forces the uses to use std::move when calling ReleaseSoon with a scoped_refptr. Both are required to make ReleaseSoon run safely (and correctly), but it isn't obvious that they are needed. An example of its use is included with this CL. Bug: 900010 Change-Id: Ic1de31d0433ffeee52d98b630cafe643c223ed18 Reviewed-on: https://chromium-review.googlesource.com/c/1306639 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Bothing ScriptingPermissionsModifier and PermissionsAPI unittests convert URLPatternSets to strings for easy comparison (using gmock utilities). Extract this functionality into a shared method in permissions_test_util. Bug: None Change-Id: I54f681bc69d87c4ba20c8b2973159ef671f1bbe0 Reviewed-on: https://chromium-review.googlesource.com/c/1347100Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610230}
-
Meilin Wang authored
Record the number of users who enabled/disabled Assistant service on their devices, the sum would be the number of all eligible users. Note that we simply report this metrics with every UMA upload and should only depend on unique users count to take advantage of the de-dupe logic implemented on the server-side. Ignore potential reboot or crash for now. Test: local compile and manually test. Bug: b:117518834 Change-Id: I5cee656db986f60104999502b4feebb8d072c79f Reviewed-on: https://chromium-review.googlesource.com/c/1292111 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#610229}
-
bsheedy authored
Removes three sources of flakiness in the existing VR RenderTest: 1. Switches the test page to a blank one, as the text on the original one sometimes resulted in several pixels being different due to AA. 2. Removes the flaky sleep while waiting for the permission prompt to appear in favor of a new waitForUiQuiescence. 3. Ensures that the UI is quiescent after accepting the permission before dumping the second image. Also drive-by changes several methods in NativeUiUtils to try/catch the call that throws an InterruptedException to make it less annoying to chain multiple actions together. Bug: 904012 Change-Id: Ic25432c947adeeba210c6c63b355a53c5c63ef14 Reviewed-on: https://chromium-review.googlesource.com/c/1344905Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#610228}
-
kylechar authored
HardwareDisplayController::GetRefreshInterval() was using the integer rounded refresh rate instead of a float value. The rounded refresh was used to construct PresentationFeedback, which ultimately gets used to set the begin frame and exo vsync interval. On veyron_minnie this changed the interval from 16819us to 16666us incorrectly. Bug: 907625 Change-Id: I0e7a2a776cdadfa0bb99b67735ab93beb90a0f63 Reviewed-on: https://chromium-review.googlesource.com/c/1347444Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#610227}
-
S. Ganesh authored
Bug: 833687 Change-Id: I45108654865ccdfe7b1570c93f86b4c9676942c6 Reviewed-on: https://chromium-review.googlesource.com/c/1343059 Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610226}
-
Richard Knoll authored
If a notification title is between 22 and 26 characters long, it might get truncated in the view. This is because we calculate different line counts for a title in the layout and draw phases. This is related to crbug.com/682266. Instead of relying on the layout phase, we now just set a wider right-border on the first element in the view, to make space for the control buttons. Bug: 785589 Change-Id: I4c6e157d732065224612766dbe02a3f21f377b2f Reviewed-on: https://chromium-review.googlesource.com/c/1341924 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#610225}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8da7b350cf93..5eae1d994e20 git log 8da7b350cf93..5eae1d994e20 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 Peter) Slatala Remove legacy SetTargetTransferRateObserver 2018-11-21 Peter) Slatala Add check for media transport and bundle policy 2018-11-21 Peter) Slatala Create 'MaybeCreateMediaTransport' function 2018-11-21 sakal@webrtc.org Add sakal@ to OWNERS in android tests / aarproject directories. 2018-11-21 kron@webrtc.org Move HdrMetadata to ColorSpace 2018-11-21 alessiob@webrtc.org AGC2 adaptive digital: remove unnecessary flag. Created with: gclient setdep -r src/third_party/webrtc@5eae1d994e20 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8cba4140f98d3698aa8f895567586561f54042a3 Reviewed-on: https://chromium-review.googlesource.com/c/1347030Reviewed-by:
-
John Chen authored
Updating capabilities returned from New Session command for W3C spec compliance. Change verified by Web Platform Tests (13 additional new_session tests passed). Bug: chromedriver:1997 Change-Id: I7683acb33cbf2739a867787ba2a3fedd28be32c5 Reviewed-on: https://chromium-review.googlesource.com/c/1347065 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#610223}
-
Ryan Hansberry authored
To support legacy Smart Lock hosts which did not mark themselves as supporting EASY_UNLOCK_HOST (because they couldn't have), simply ignore lack of a kSupported bit if kEnabled is present, and set the host device as an enabled Smart Lock host. Bug: 896082 Change-Id: Id8fb1ade25113fcb108a7658738e7bf9e0c996a0 Reviewed-on: https://chromium-review.googlesource.com/c/1345123Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#610222}
-
Robert Ogden authored
This CL corrects the metrics in PLM which are thrown off by the restarting of navigations for this preview type. In order to serve this preview, we cancel and then posttask a new navigation to our own server. This causes PLM to loose track of the original navigation start time. To correct this, I've added functionality to PLM that accepts a TimeDelta penalty that will be added to all metrics once the page load completes. Persisting the original navigation start time is done by copying a ServerLitePageInfo struct between navigations and which lives on PreviewsUserData during navigation and page load. Bug: 874150 Change-Id: Ib31d1694ecdbd310f975a431f76a76c7e47774d7 Reviewed-on: https://chromium-review.googlesource.com/c/1334944Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#610221}
-
Carlos Caballero authored
Bug: 901345 Change-Id: I3fb2bcdab9a61fc818da6a4cc6439635f9421b31 Reviewed-on: https://chromium-review.googlesource.com/c/1346834Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#610220}
-
Erik Luo authored
Adds the "Inspect Elements" (Ctrl-Shift-C, Mac: Cmd-Alt-C) to X11's main menu and Mac's developer menu. This matches locations for "Javascript Console" (Ctrl-Shift-J). Screenshot: https://imgur.com/a/jOFOmTn TBR=cpu@chromium.org Bug: 881534 Change-Id: Id17b9ca123ebc54c8e753ec25f31604ab3248f3d Reviewed-on: https://chromium-review.googlesource.com/c/1343513Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#610219}
-
dpapad authored
The original change at r608013 caused WebUI regressions, some of which are unclear on how to fix because of a separate issue with tabindex -1 and Custom Elements, https://github.com/w3c/webcomponents/issues/774. Need to address WebUI affected cases, before the flag is re-enabled by defalut. Bug: 907284 Change-Id: Ie8a41df1df663d25cf06a0ed6ae42ac80512df0c Reviewed-on: https://chromium-review.googlesource.com/c/1347429 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#610218}
-
Christopher Grant authored
Credit to digit@ who supplied much of this change via a reference CL. Rather than including one of two static linker scripts, generate the desired script instead. This allows an arbitrary list of additional exported methods to be supplied if desired. BUG=874587 Change-Id: I88eb0469dfb764bf910b8c3fe76fd4ed2c91c1e4 Reviewed-on: https://chromium-review.googlesource.com/c/1338141 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610217}
-
Morten Stenshorne authored
(writing-mode has nothing to do with it, FWIW) Legacy layout is buggy here, so the expected rendering was wrong. Also wrote a new wpt test for this. When calculating quirky line height, the legacy engine makes room for whitespace that is to be collapsed. Bug: 845902 Change-Id: I004d024578bb147d4f70c58fc1e3213a14174fd7 Reviewed-on: https://chromium-review.googlesource.com/c/1346465Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#610216}
-
Nico Weber authored
https://chromium.googlesource.com/chromium/buildtools.git/+log/da9b2941cbf6..04161ec8d7c7 $ git log da9b2941c..04161ec8d --date=short --no-merges --format='%ad %ae %s' 2018-11-21 thakis Roll gn to version 1496 (0790d304). Created with: roll-dep src/buildtools Bug: none Change-Id: Iddc4c9ad79f28d024b32c41162e0df7b2a7cd1f7 Reviewed-on: https://chromium-review.googlesource.com/c/1347335Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610215}
-
