GitLab

Revert 99440 - Changed Mac, Linux and Win Official Chrome build to drop default app CRXs in the build/installer output.

BUG=94920
TEST=Do an Official build in mac and win. Ensure that after installing the app, you can find the default apps under the install's directory structure. For win, this is under a default_apps directory, for mac, this is under a "Default Apps" directory.
Review URL: http://codereview.chromium.org/7827021

TBR=stevet@chromium.org
Review URL: http://codereview.chromium.org/7795038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99878 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=When frozen tab becomes reponsive, the Hung Renderer Dialog should disappear.


Review URL: http://codereview.chromium.org/7824039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99877 0039d316-1c4b-4281-b951-d872f2087c98

If the ProfileIOData isn't ever lazily initialized, the URLBlacklistManager will be deleted with the ProfileParams on the wrong thread.

BUG=95510
TEST=sync_integration_tests aren't breaking because of destruction of URLBlacklistManager on the wrong thread


Review URL: http://codereview.chromium.org/7841004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99876 0039d316-1c4b-4281-b951-d872f2087c98

TEST=run with --force-compositing-mode and --show-fps-counter, verify
that the counter shows up on about:blank and not on other about: pages
BUG=95107


Review URL: http://codereview.chromium.org/7779022

TBR=jamesr@chromium.org
Review URL: http://codereview.chromium.org/7782021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99875 0039d316-1c4b-4281-b951-d872f2087c98

Original issue is codereview.chromium.org/7792022.
Problem was a race between Connection destruction and TerminateAllIO. If TerminateAllIO won the race,
it would call Abort() on a Connection object *after* the BridgedConnection destructor had run, while
~Connection was waiting on the termination lock.  This would cause a purecall exception.

BUG=93829, 19757
TEST=SyncAPIServerConnectionManagerTest, integration tests

Review URL: http://codereview.chromium.org/7841013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99874 0039d316-1c4b-4281-b951-d872f2087c98

To split the ConstrainedWindow feature off of TabContents entirely (moving it
to a helper object on TabContentsWrapper), I'll need to first make each
constrained window TabContentsWrapper aware first. I started just hacking

BUG=95257
TEST=compiles


Review URL: http://codereview.chromium.org/7831051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99872 0039d316-1c4b-4281-b951-d872f2087c98

The contract for Get/PutCurrentFrame() is that you have to return the original frame, not NULL.


Review URL: http://codereview.chromium.org/7795027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99871 0039d316-1c4b-4281-b951-d872f2087c98

TBR=groby
BUG=77376
TEST=none

Review URL: http://codereview.chromium.org/7838015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99870 0039d316-1c4b-4281-b951-d872f2087c98

- Why remove the special case?

WebKit's script controllers have a special-case for the window script object, which deallocates it regardless of reference-count, on the assumption that by the time the relevant call (clearScriptObjects) is made, no callers can remain which hold references to it - this prevents it from lingering indfinitely if the plugin forgets to release it.

WebPluginDelegateProxy has a special-case for handling the window script object, which tries to cope with the case where clearScriptObjects has been called before the plugin is destroyed (which should never happen), by avoiding trying to release the window script object, and instead relying on WebKit deallocating it.

This workaround doesn't actually work; if WebKit is behaving then the object exists at plugin teardown time, and it's safe for code to touch it.  If it doesn't exist any more, then we may still touch it if the plugin tries to script the window, or to release the reference.  Even if neither of those occur, the stub for the object may release it when the last plugin instance's channel is torn-down, before the workaround can be hit.

We still need to explicitly tear-down the window script object's stub if the plugin failed to release it, so that it won't linger and end up being released after WebKit has already deallocated it.

Review URL: http://codereview.chromium.org/7696016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99869 0039d316-1c4b-4281-b951-d872f2087c98

Fixes clients that set CXX to a custom clang, such as ASAN.

BUG=none
TEST=asan bot goes green again.

Review URL: http://codereview.chromium.org/7838013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99868 0039d316-1c4b-4281-b951-d872f2087c98

TBR=groby
BUG=91157
TEST=none

Review URL: http://codereview.chromium.org/7837016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99867 0039d316-1c4b-4281-b951-d872f2087c98

Contributed by gideonwald@chromium.org
I'm recreating http://codereview.chromium.org/7840001/
gideonwald can't dcommit and binary files break git cl patch.
So I copied and added his pngcrushed image from the bug.

Patch from Gideon Wald <gideonwald@chromium.org>
BUG=94112
TEST=This change just adds the icon, so there should be no user-visible change yet.

Review URL: http://codereview.chromium.org/7841017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99866 0039d316-1c4b-4281-b951-d872f2087c98

This updates the page listing licenses of third-party
software for R15.

BUG=chromium-os:18058
TEST=no errors from script; manual inspection of page and added/removed packages looks okay to me
TBR=zelidrag

Review URL: http://codereview.chromium.org/7795034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99865 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:17167
TEST=None


Review URL: http://codereview.chromium.org/7840013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99864 0039d316-1c4b-4281-b951-d872f2087c98

R=aa@chromium.org


Review URL: http://codereview.chromium.org/7828103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99863 0039d316-1c4b-4281-b951-d872f2087c98

TBR=groby
BUG=91491
TEST=none

Review URL: http://codereview.chromium.org/7837015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99862 0039d316-1c4b-4281-b951-d872f2087c98

BUG= http://code.google.com/p/chromium/issues/detail?id=94320
TEST= various nacl exmaples, try bots
Review URL: http://codereview.chromium.org/7737013

TBR=nfullagar@google.com
Review URL: http://codereview.chromium.org/7782020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99861 0039d316-1c4b-4281-b951-d872f2087c98

TBR=groby
BUG=91771
TEST=none

Review URL: http://codereview.chromium.org/7789015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99859 0039d316-1c4b-4281-b951-d872f2087c98

The code prior to this CL invoked a copy constructor during static initialization.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98924

Review URL: http://codereview.chromium.org/7785016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99858 0039d316-1c4b-4281-b951-d872f2087c98

dependency on crypto (needed by downloads), http_server (needed by
the debugger), and fix the additional libraries for geolocation so that
they get picked up either by the current target (content.dll) or
the dependent target (content.lib inside chrome.dll)

R=darin@chromium.org
BUG=90442

Review URL: http://codereview.chromium.org/7740064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99857 0039d316-1c4b-4281-b951-d872f2087c98

Previously it was limitted to functions taling a single void* argument.

Review URL: http://codereview.chromium.org/7831021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99856 0039d316-1c4b-4281-b951-d872f2087c98

BUG= http://code.google.com/p/chromium/issues/detail?id=94320
TEST= various nacl exmaples, try bots
Review URL: http://codereview.chromium.org/7737013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99855 0039d316-1c4b-4281-b951-d872f2087c98

- Split spinner css from oobe.css into spinner.css;
- Update references: oauth-enroll-spinner -> spinner, throbber -> spinner;

Also make the version label wider so that RTL label shows right aligned.

BUG=chromium-os:19181
TEST=Verify the Gaia loading UI uses segmented spinner now for chromium-os:19181 and RTL chromeos shows proper right aligned version info in login screen.


Review URL: http://codereview.chromium.org/7841005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99854 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for complex message structures that need to marshall a lot of params (like ViewHostMsg_FrameNavigate_Params).

R=darin@chromium.org
BUG=90442

Review URL: http://codereview.chromium.org/7828067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99853 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94925

Review URL: http://codereview.chromium.org/7837013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99852 0039d316-1c4b-4281-b951-d872f2087c98

This is neccessary to make the interface usable with stanzas generated
by JingleMessage::ToXml().

BUG=None
TEST=Unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99801

Review URL: http://codereview.chromium.org/7809003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99851 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a crash that occurred when multiple hosts were shared in the same
browser.

BUG=92078
TEST=manual

Review URL: http://codereview.chromium.org/7648042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99850 0039d316-1c4b-4281-b951-d872f2087c98

After http://src.chromium.org/viewvc/chrome?view=rev&revision=97284 the title is populated when the total page count is received. We can still do it  a bit earlier (from within onLoad()).

BUG=92428
TEST=See bug description.

Review URL: http://codereview.chromium.org/7818010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99849 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/7837008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99848 0039d316-1c4b-4281-b951-d872f2087c98

The bookmark sync test case SC_AddFirstBMWithFavicon fails on the
mac_sync trybot.

This patch marks it as failing till such time that a fix is landed.

TBR=akalin@chromium.org
BUG=94941
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/7841014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99847 0039d316-1c4b-4281-b951-d872f2087c98

also change the cursor to pointer. Also make some graphical updates to the contents of the menu.

BUG=95043, 94784
TEST=manual

Review URL: http://codereview.chromium.org/7795025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None.
TEST=Run PyAuto remote_host/chromoting_basic on Mac.

Review URL: http://codereview.chromium.org/7841010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99845 0039d316-1c4b-4281-b951-d872f2087c98

This will defer the load of app icons on non-selected apps pages until that page is selected. Anecdotally this provides a noticeable speedup when 50ish apps are loaded.

I don't think this is really covered by any NTP startup test as it requires a lot of apps installed to have any effect. In lieu of creating such a test (which should be a TODO), I  tested locally the time to finish painting by inserting debug statements in NewTabUI::PaintTimeout(). I conducted these tests with the most visited page as the default. For browser startup, this patch reduced paint times from ~560 to ~460 ms on my setup (paint times were pretty consistent across runs). For just NTP startup (without another NTP already open), this patch reduced paint times from ~395 to ~295 ms (and these times were extremely consistent, never varying by more than 10ms from the mean). For reference, I also tested ntp3 and found the browser startup case to be about 570ms and NTP startup to be around 495ms (meaning NTP4 is a win with or without this patch, but especially with this patch).

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/7839013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99844 0039d316-1c4b-4281-b951-d872f2087c98

Replaced by hexa literal in the two ui_unittests that need it.

This will make any later changes easier to perform, and it also eliminates the
problem of having binary files which are ignored by patches in the repo.

BUG=none
TEST=ui_unittest:{DataPackTest.*, ResourceBundle.*}


Review URL: http://codereview.chromium.org/7779019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99842 0039d316-1c4b-4281-b951-d872f2087c98

Trivial fix of out of sync IDL files.

TEST= none
BUG= none
TBR= yzshen@chromium.org
Review URL: http://codereview.chromium.org/7789014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99841 0039d316-1c4b-4281-b951-d872f2087c98

Generalizes disabling of OptionsUITest.LoadOptionsByURL.  Seen on Linux.

BUG=64619
TEST=Valgrind goes green on Linux bot.
TBR=csilv@chromium.org

Review URL: http://codereview.chromium.org/7840016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99840 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/7828055/ moved all sync test collateral
from chrome/tests to chrome/browser/sync/test.

This patch renames the browser/sync/test/live_sync directory to
browser/sync/test/integration, to differentiate the integration tests
from other test categories (like unit tests, sync engine tests, etc.)

It also renames the class LiveSyncTest to SyncTest, in keeping with the
name changes that went in with the recent sync integration test
framework refactor.

BUG=90905
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/7841007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99839 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60215
TEST=test_shell_tests,media_unittests

Review URL: http://codereview.chromium.org/7823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99838 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7248018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99837 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of unnecessary chrome_main_ files now that most of the code has been removed from them. I just kept the Mac one since we need a file that can include objective c files.
Review URL: http://codereview.chromium.org/7779018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99836 0039d316-1c4b-4281-b951-d872f2087c98