- 09 May, 2018 10 commits
-
-
Noel Gordon authored
Again, PulseAudio layer is unsupported in a target_os="chromeos" build and VideoPlayerBrowserTest produce LOG errors about that. Again, use a fake audio layer to eliminate it, cargo cult crrev.com/556704. Good enough until a future CL provides a more general fix, but step #1 is to kick the VideoPlayerBrowserTest's tyres on the bots. Bug: 835626,835742,835642 Change-Id: I58cc1c188e95d39f8e75230a761e7b69ff99cabb Reviewed-on: https://chromium-review.googlesource.com/1049768Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#557023}
-
Eugene Ostroukhov authored
Bug: 836892 Change-Id: Iad5856428bc60cbb410a8c97076078f8adbbea5d Reviewed-on: https://chromium-review.googlesource.com/1048060Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#557022}
-
Eugene Ostroukhov authored
Bug: 836887 Change-Id: Id13521c9f15f0f3a3e5c1fd4047b40b8883dcbcf Reviewed-on: https://chromium-review.googlesource.com/1048045Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#557021}
-
Alex Moshchuk authored
Change-Id: Icdbad110266ba00386486355ec996c45d8660869 Reviewed-on: https://chromium-review.googlesource.com/1050792Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#557020}
-
Xing Liu authored
Currently we use an extra menu with two items to show download location settings and show/hide disk space info. This CL removes the extra menu and uses a new menu item to only show download location setting. The icon uses a setting icon, which will be replaced later for correct color. Bug: 838738,792775 Change-Id: Ic2f65df05ea9a46d8d49885b15d5fa6a9273ba07 Reviewed-on: https://chromium-review.googlesource.com/1043362 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#557019}
-
Lukasz Anforowicz authored
Cross-Origin Read Blocking (CORB) tries to protect certain resource types (e.g. text/html). To be resilient against HTTP responses mislabeled with an incorrect Content-Type, CORB sniffs the response body to confirm if it truly is the protected type. Before this CL the confirmation sniffing logic blocked resources that are both a valid html and a valid javascript. Blocking of such resources is undesirable, because it is disruptive to existing websites that use such polyglot responses in <script> tags. After this CL, CORB sniffer takes into account the https://www.ecma-international.org/ecma-262/8.0/index.html#prod-annexB-SingleLineHTMLCloseComment rule which means that the sniffing doesn't resume immediately after "-->" characters, but instead also consumes all the characters until the first line terminator. Bug: 839945 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7c8221acc2013adffe8095d188ae22e1c6a2fdab Reviewed-on: https://chromium-review.googlesource.com/1047851 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#557018}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 494ded10. With Chromium commits locally applied on WPT: 9180e0b3 "Move AudioContext tests to WPT" a1bc6550 "Fix resource-timing.https.html test" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17163 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, mikhail.pozdnyakov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor jsbell@chromium.org: external/wpt/resources TBR=danyao No-Export: true Change-Id: I6d529ae1d2dbd5bb3a62eaaad2105efbe610ff9b Reviewed-on: https://chromium-review.googlesource.com/1050826 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557017}
-
Thomas Guilbert authored
After successfully creating a CastSession via the presentation service, we do not switch to using the FlingingRenderer. This CL adds the signals to switch to/from using the FlingingRenderer. This is done by asking WMPI to pick a new media::Renderer, by going through a suspend/resume cycle. The RendererFactorySelector should automatically choose the FlingingRendererClientFactory, based on the fact that the RemotePlaybackClientWrapper has a valid presentation ID. Bug: 790766 Change-Id: Ibab887c8a1791620ad1dcd92406c7ee618eec36d Reviewed-on: https://chromium-review.googlesource.com/1043279Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#557016}
-
Paul Miller authored
Variations' EntropyProvider requires a random but stable seed value. WebView uses the metrics client ID for this. In the WebView-variations prototype, variations read the client ID synchronously on the main thread. This wasn't terrible, because the client ID file was very small. But it's better to do it in the background. Add AwMetricsServiceClient.preloadClientId to load the client ID in Java, before native init. Call this in VariationsSeedLoader's background task. Then use the preloaded value in native variations and metrics code. If preloading fails (either because there was no client ID file, or because the background task took too long), then variations will be disabled, while metrics will load or create the client ID as normal. The client ID file will never exist the first time an app uses WebView; this implies variations will always be disabled on the first run. But this was already the case, since no variations seed will be present on first run either. BUG=678288 Change-Id: Ied9b4a73fe4cface9911e825bc5a3f282a4d1eff Reviewed-on: https://chromium-review.googlesource.com/1043063 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#557015}
-
wutao authored
In guest session, we use two different profiles for "Suggested App" and apps in Launcher. The later uses the profile of AppListSyncableService which alwasy uses the original profile. However, the original profile is not allowed in guest session. This cl fixes this bug by returning guest profile in AppListSyncableService in guest mode. Bug: 840293 Test: manual. Change-Id: I30d9464597eaacba9a08560ca03e0679a9e906bf Reviewed-on: https://chromium-review.googlesource.com/1049005 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557014}
-
- 08 May, 2018 30 commits
-
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a6dce8334230..f25391b703a2 $ git log a6dce8334..f25391b70 --date=short --no-merges --format='%ad %ae %s' 2018-05-08 nednguyen Making browserless benchmark runnable on story_runner 2018-05-08 chiniforooshan Telemetry: set duration hist label only when given Created with: roll-dep src/third_party/catapult BUG=chromium:840428 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I0a63708b574dc41520c38f8204e4d0c41b58403b Reviewed-on: https://chromium-review.googlesource.com/1050811 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557013}
-
Jennifer Apacible authored
Currently, only one video can be gracefully sent to Picture-in-Picture mode from each initiator content::WebContents. Media controls do not work as they are only set once. This change allows us to enter Picture-in-Picture from more than one video on the same initiator, though one at a time. Another patch handles pausing the previously PiP'd video. BUG: 823172 726619 Change-Id: Ie9eae108c5c8ce902458aa520b6553042096fb7a Reviewed-on: https://chromium-review.googlesource.com/1044773 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#557012}
-
Stuart Langley authored
LoaderController's logic is used outside of ChangeListLoader, splitting out the class into it's own definition and implementation file to make it simpler to re-use. Also fixed some linter errors and some small c++ modernization changes. Bug: 715355 Change-Id: I53c283af3deec939d98d1dc99d26e46f9577b403 Reviewed-on: https://chromium-review.googlesource.com/1034486Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#557011}
-
Jennifer Apacible authored
On light colored videos, the white media controls are hard to see or invisible. This change adds a transparent, dark layer between the video and the media controls to make them more visible. BUG: 836389 Change-Id: I3f0a959c2d0a9fec83dbc71ae1cbcf2335a24566 Reviewed-on: https://chromium-review.googlesource.com/1045091 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#557010}
-
Christian Biesinger authored
Not all callers of ChildLogicalHeightForPercentageResolution need the actual height, and all codepaths either return -1 or OverrideContentLogicalHeight(). To simplify all that, just return a boolean and have the caller call OverrideContentLogicalHeight if needed. Also renames the function as appropriate. R=eae@chromium.org,dgrogan@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7da546757607a94a56f835c23717284681ff1cae Reviewed-on: https://chromium-review.googlesource.com/1050474 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557009}
-
Yuri Wiitala authored
This is a reland of f1b4c43b Original change's description: > The SnooperNode: Audio loopback for a single stream. > > An audio::GroupMember::Snooper that records the audio from a GroupMember > on one thread, and re-renders it to the desired output format on another > thread. Since the data flow rates are known to be driven by different > clocks (audio hardware clock versus system clock), the SnooperNode also > uses its resampler to compensate for skew and re-synchronize the audio > going into and out of it. > > Bug: 824019 > Change-Id: I87d410724fd00f9372232bfffdfbb89ada0b3de8 > Reviewed-on: https://chromium-review.googlesource.com/1041657 > Commit-Queue: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Xiangjun Zhang <xjz@chromium.org> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556719} TBR=chcunningham@chromium.org,olka@chromium.org Bug: 824019 Change-Id: I579b99bda7bc53710004470c0cc07f8a06cdd8b5 Reviewed-on: https://chromium-review.googlesource.com/1050403Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557008}
-
Pedro Amaral authored
Bug: 814528 Change-Id: Ifb3138411966d4abe4b6bc05b5b520a6e3787db0 Reviewed-on: https://chromium-review.googlesource.com/1045425Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#557007}
-
Hector Carmona authored
Bug: 812926 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I813c42ac1114c902e812094618dded87581f7327 Reviewed-on: https://chromium-review.googlesource.com/1043495 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#557006}
-
https://webrtc.googlesource.com/src.git/+log/5b2b692079e6..4e268edb533b $ git log 5b2b69207..4e268edb5 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:none,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I70e966bf1ff612cda1acd5e27c5ff7fabfd822c7 Reviewed-on: https://chromium-review.googlesource.com/1050568Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557005}
-
rodmartin authored
The problem was race conditions between the session rename (line 688) and the check if the Error message is displayed (line 692). Change-Id: I0f23317645488ce2a507168a8b09971d15de072d Reviewed-on: https://chromium-review.googlesource.com/1050645Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Martin Rodriguez <rodmartin@google.com> Cr-Commit-Position: refs/heads/master@{#557004}
-
Oliver Chang authored
The mutate/generate methods were leaving handles and interface fields as null, leading to them never being set later as getHandleDeps() will not include them. Bug: 607649 Change-Id: Ic5ee3a190a72fe3406dac19e225e85491bff1306 Reviewed-on: https://chromium-review.googlesource.com/1041627Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#557003}
-
Emil A Eklund authored
A number of WPT tests have test expectations with one or more FAIL line checked in. Some of these pass on LayoutNG but are marked as failing as the output doesn't match the expectations. Fix these by rebaselining. Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I9479eae19a458cd50c6075f2091826f967b35a59 Tbr: atotic@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1050873Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#557002}
-
Nate Chapin authored
This reverts commit d6bb2dcc. Reason for revert: offending CL reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1050847 Original change's description: > Disable some service-worker and a fetch test with the network service. > > I believe these most likely broken by > https://chromium-review.googlesource.com/1048133 > > TBR=japhet@chromium.org, jam@chromium.org > NOTRY=true > > Bug: 729848, 706331 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: I4b3525af8d2f06fbccf311e40a9f64e7af70ffcd > Reviewed-on: https://chromium-review.googlesource.com/1049831 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556972} TBR=falken@chromium.org,jam@chromium.org,japhet@chromium.org,mmenke@chromium.org Change-Id: Ib6b665dba5810a5c50f2c7081a0647bcd22e58bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 729848, 706331 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1050500Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#557001}
-
Nate Chapin authored
This reverts commit 54591366. Reason for revert: broke some layout tests with NetworkService enabled: https://chromium-review.googlesource.com/c/chromium/src/+/1049831 Original change's description: > Use off-main-thread loading for WorkerClassicScriptLoader::LoadSynchronously > > This removes the last usage of WorkerThreadableLoader. I'll delete it in a > followup. > > Bug: 706331 > Change-Id: I6d452c5ae4a4e6ea99d14dd9d4ba048c66c2cbdc > Reviewed-on: https://chromium-review.googlesource.com/1048133 > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Commit-Queue: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556819} TBR=falken@chromium.org,horo@chromium.org,kinuko@chromium.org,japhet@chromium.org,nhiroki@chromium.org Change-Id: Ie703d84972b1b40e35f8c7ade24d9b6d0c3f3d36 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 706331 Reviewed-on: https://chromium-review.googlesource.com/1050847Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#557000}
-
Boris Sazonov authored
This CL modifies AccountSigninActivity and SigninActivity to extend SynchronousInitializationActivity instead of duplicating initialization code. It also annotates SynchronousInitializationActivity.onCreate with @CallSuper. Bug: None Change-Id: I0889351e2520ce5192c45d3d3393714cc225c4df Reviewed-on: https://chromium-review.googlesource.com/1047765Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#556999}
-
Ryan Daum authored
- Change the back gesture so it triggers as the finger is dragging rather than as the finger is released. - Set up a shared delegate (CastBackGestureDispatcher) that can be used by multiple CastContentWindow implementations. - Define a minimum horizontal threshold for the drag. Fixes accidental triggering on touch of the screen margin. - Horizontal threshold defaults to 80px but is configurable by switch. Test: manual Bug: internal b/78397215 Bug: internal b/78346262 Bug: internal b/79217373 Change-Id: I31581816810568908bf20a5d1eb7f441191e99c7 Reviewed-on: https://chromium-review.googlesource.com/1048466 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#556998}
-
Alexander Alekseev authored
We need to make sure that whenever UserContext is constructed, and this user already exists locally, the user parameters from UserContext match existing user. This CL introduces UserContext(User*) constructor. Where possible, new constructor is used now. Bug: 836015 Change-Id: I11c244b8f6c5252d692a659b06127b1e2a74c4d8 Reviewed-on: https://chromium-review.googlesource.com/1045906Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#556997}
-
Rakina Zata Amni authored
We are mojoifying browser<->renderer communication of Find-in-page. In this CL, we are introducing the FindInPage mojo interface, which currently only have the ClearActiveFindMatch function in it and its implementation on the browser and renderer side. We are also removing the old IPC messagefor ClearActiveFindMatch and functions related to it. ClearActiveFindMatch is called when the browser side wants to remove the current active match highlighting in a frame. Previous CLs (refactoring): crrev.com/c/956648 crrev.com/c/1025242 crrev.com/c/1027013 Future CLs: Mojoify other find-in-page functions Mojoifying doc: https://goo.gl/JenyGm Bug: 819919 Change-Id: I3ca9835819c6a46fbee0e2bf20a665c0bd0f5d22 Reviewed-on: https://chromium-review.googlesource.com/1027393Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#556996}
-
Ryan Landay authored
MobileTabSwitched is an UMA event that's supposed to log when we switch tabs in the Android tab switcher. It's logged by TabModelImpl when the current index in the stack changes. We currently do not handle the case where current model (normal or incognito) changes without changing the active index in that model. This CL adds logging for this case. Unfortunately, it's not possible to fix this in TabModelImpl without significant refactoring because StackLayout changes the active model when swiping between the normal and incognito stacks, but doesn't change the active tab until the tab switcher is closed (we can't really; until a tab actually gets tapped, the current tab switcher doesn't have a concept of what the active tab is other than the one that was active when it was opened). So this CL adds logging for this case in StackLayoutBase itself. This CL also handles the case where the tab is switched by swiping over to the other stack and tapping the tab switcher button on the toolbar. Bug: 828224 Change-Id: Ieba12c08894df54e309d6db9faa1e20962600c1f Reviewed-on: https://chromium-review.googlesource.com/1049166 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#556995}
-
Max Morin authored
This was found when testing the audio service out of process. Probably something with audio device enumerations were preventing it from showing up before. Bug: 840373 Change-Id: Ia3af9366a2a57fad92b8bfb077bbbb786ccd5693 Reviewed-on: https://chromium-review.googlesource.com/1049652 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#556994}
-
Kouhei Ueno authored
Before this CL, - MockScriptLoader* Create() actually called SetupForNonStreaming() inside, and - SetupForStreaming() was called after SetupForNonStreaming(), twice. This CL fixes these confusing behavior. - Splits MockScriptLoader::Create{InOrder,Async} - Unmocks StartStreamingIfPossible and turning it to an explicit state machine. - Rewrites TryStreamWhenEnqueingScript so that it wouldn't rely on previously: -- .WillOnce(Return(false)).WillRepeatedly(...) Bug: 838761 Change-Id: I71a827a769467c23004be90daa084fdd9e95a3df Reviewed-on: https://chromium-review.googlesource.com/1039112Reviewed-by:Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#556993}
-
Eric Roman authored
Bug: 839566 Change-Id: I51eb05bc52587d84592966870387ccae9d8db5d7 Reviewed-on: https://chromium-review.googlesource.com/1044751 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#556992}
-
John Budorick authored
The default explicitly targets 14.04, which obviously doesn't work for the xenial bot. Bug: 812051 Change-Id: Ifd713b6c6bd255fcbbf86ca1459ddda8904dbe19 Reviewed-on: https://chromium-review.googlesource.com/1050488Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#556991}
-
Ryan Landay authored
Currently, we log the MobileToolbarShowStackView UMA event on Android when tapping the tab switcher button on the toolbar, regardless of whether the tap is actually opening or closing the tab switcher. This CL changes the logging so that: - We stop logging the event for taps that close the tab switcher - We start also logging the event for toolbar swipes that open the tab switcher, as well as for any other entry point we might currently have or add in the future. NOTRY=true Bug: 828224 Change-Id: I908471b9dccafd409e14502f9bd776ae695b9e2a Reviewed-on: https://chromium-review.googlesource.com/1048042 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#556990}
-
Paul Miller authored
Add sVariationsAlwaysEnabled, so that variations can be enabled as a 1-line change. Remove ReadVariationsSeedDataFromFile, since the seed is loaded in Java. Use VariationsSeedBridge.setVariationsFirstRunSeed to pass the seed from Java to native via prefs. When a seed is loaded successfully, automatically enable the WebView variations cmd flag. This means that passing the flag manually will have no effect. The flag will be removed in a later change. BUG=678288 Change-Id: I6f63eba040a0fe4ad189ded5580f45d518c066c0 Reviewed-on: https://chromium-review.googlesource.com/1049049 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#556989}
-
Saman Sami authored
Don't allocate a new id for the first navigation. The browser might have already embedded the old surface so if the renderer doesn't submit to the old surface there will be a flash. Bug: 834449 Change-Id: Ie9e79dba0b8afcfb43929c8264cc7e3c2c4a0792 Reviewed-on: https://chromium-review.googlesource.com/1048118Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#556988}
-
Esmael El-Moslimany authored
Bug: 720246 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I299f27870787919eabd9553d21d026e447cd470f Reviewed-on: https://chromium-review.googlesource.com/1047971 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#556987}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/21cb8d2c..9c5f77a1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I08596995e9157faa8b330851cc468344f7b9b435 Reviewed-on: https://chromium-review.googlesource.com/1050473Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#556986}
-
Maks Orlovich authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia0dec7ee73750261b1e19a425ad2d00742962770 Reviewed-on: https://chromium-review.googlesource.com/1016669 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#556985}
-
Mohammad Refaat authored
This reverts commit cbab9a8e. Reason for revert: Keep iTunes handler enabled for M68 Original change's description: > Disable iTunes URL handling feature by default > > Bug: 840903 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Ic40fdc4ad194301c51d1c9b4d06720cf63a9aac1 > Reviewed-on: https://chromium-review.googlesource.com/1050569 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556938} TBR=eugenebut@chromium.org,mrefaat@chromium.org Change-Id: Ic56c79148b1cf44c8ff83a9b761126971418b286 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840903 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1050750Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#556984}
-