GitLab

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/7057035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86190 0039d316-1c4b-4281-b951-d872f2087c98

This is a virtual method, so it shouldn't use the unix_hacker style.

Note: This was a TODO for ben.

BUG=None
TEST=None

R=ben@chromium.org

Review URL: http://codereview.chromium.org/7056027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86189 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=83459
Review URL: http://codereview.chromium.org/7054028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86188 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/7048020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86187 0039d316-1c4b-4281-b951-d872f2087c98

This is the removal of code to disable security restrictions on disk IO,
originally needed so that the GL bindings could be initialized. The GL
libraries now manage this in a separate thread with the necessary permissions.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6990019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86186 0039d316-1c4b-4281-b951-d872f2087c98

again, backend updates are not hooked up yet (because no backend exists)

1. allow tile pages to accept drags of non-tiles (with stub implementation of the tile's appearance)
2. refactor ugliness of dealing with multiple drag events into event handler thunks. This will also hopefully make it easier to hook up synthesized touch drag events.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/7038051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86184 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Connect still works.

Review URL: http://codereview.chromium.org/7033042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86183 0039d316-1c4b-4281-b951-d872f2087c98

BUG= none
TEST= none


Review URL: http://codereview.chromium.org/7038050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86182 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76997
TEST=NONE
Review URL: http://codereview.chromium.org/7056019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86181 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76997
TEST=NONE
Review URL: http://codereview.chromium.org/7042019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86180 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/7055024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86179 0039d316-1c4b-4281-b951-d872f2087c98

Lingesh's recent about:sync improvements added this bug.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7054017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86178 0039d316-1c4b-4281-b951-d872f2087c98

The non-DEPS changes were recommended by bsalomon in http://codereview.chromium.org/7052001/

BUG=none
TEST=none
TBR=vandebo

Review URL: http://codereview.chromium.org/6961031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86176 0039d316-1c4b-4281-b951-d872f2087c98

both the bookmark bar and wrench menu and wires bookmarks into the
wrench menu.

BUG=81263
TEST=thoroughly test bookmarks in the wrench menu to make sure there
     aren't any crashes/weird behavior.
Review URL: http://codereview.chromium.org/7054020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86175 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81985
TEST=PrerenderDownloadTest.PrerenderDownloadIframe and 3 others

TBR=dominich@chromium.org
Review URL: http://codereview.chromium.org/7055022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86174 0039d316-1c4b-4281-b951-d872f2087c98

Taking into account for strict number checking based on country selected during aggregation.
First 3 phone digits '123' is not considered valid for US numbers.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6961037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86173 0039d316-1c4b-4281-b951-d872f2087c98

The previous way did not fool LTCG optimization.

I tested that this works by doing and LTCG build without this change and verified that the compiler strips out the assignment to program_counter in MessageLoop::RunTask. Then I repeated with this change and verified that the compiler did not strip it out.

TEST=compiles plus the above
BUG=81449
Review URL: http://codereview.chromium.org/7054025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86172 0039d316-1c4b-4281-b951-d872f2087c98

Set content offset using fill_into_edit's length and not the length of the originally typed term.

BUG=82994
TEST=Added unit test. Manual test: 1) Delete the 'History Provider Cache' file, 2) Start Chrome, 3) Type 'about:flags' into omnibox and <ret>, 4) Type 'about:flags/' or 'about:flags@' into omnibox. There should no longer be an assert at this point.
Review URL: http://codereview.chromium.org/7004042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86171 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=Host plugin accepts connection if Access Code supplied to Viewer is valid.


Review URL: http://codereview.chromium.org/7004046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86170 0039d316-1c4b-4281-b951-d872f2087c98

Add Browser::OnWindowActivated
Add reload in Browser::OnWindowActivated

BUG=chromium-os:12596
TEST=tested manually

Review URL: http://codereview.chromium.org/6973047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86168 0039d316-1c4b-4281-b951-d872f2087c98

The SetToken mock was using the command header as the token value. Also, the ringbuffer test didn't support the jump command, so if the number of entries in the command buffer is too small then the test breaks.

BUG=
TEST=


Review URL: http://codereview.chromium.org/6990002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86167 0039d316-1c4b-4281-b951-d872f2087c98

r66321 silently broke it because we were not running the tests, just listing the
tests and yet returning success.
This fixes it as well as some regressions in the tests themselves.

BUG=none
TEST=ui_tests

Review URL: http://codereview.chromium.org/7055002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86166 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83010
TEST=See bug for more details

Review URL: http://codereview.chromium.org/7043023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86164 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=local

Review URL: http://codereview.chromium.org/7055017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86163 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromeos-partner:3744, chromium-os:15270
TEST=make sure we can play content from file shelf with the media player
Review URL: http://codereview.chromium.org/7058001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86162 0039d316-1c4b-4281-b951-d872f2087c98

Also test that hosted apps do not receive WebUI.

BUG=83289
TEST=AppApiTest.AppProcess

Review URL: http://codereview.chromium.org/7048015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86161 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83023
TEST=See bug.

Review URL: http://codereview.chromium.org/7038041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86160 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

R=csilv@chromium.org

Review URL: http://codereview.chromium.org/7034045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86159 0039d316-1c4b-4281-b951-d872f2087c98

The WebKit bug has been fixed.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6961034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86158 0039d316-1c4b-4281-b951-d872f2087c98

Remove useless member from conflictresolver (it was always empty and had no effect).  Add histograms to conflictresolver to verify the hypothesis that this code is unreachable in practice.

BUG=83006
TEST=unittests


Review URL: http://codereview.chromium.org/7042028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86157 0039d316-1c4b-4281-b951-d872f2087c98

 - testPreFetchInstantURLNotInHistory
 - testPreFetchInstantURLGeneratesNoPopups
 - testPreFetchInstantURLSetsNoCookies

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7033039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86156 0039d316-1c4b-4281-b951-d872f2087c98

Previously, all passwords tests were diabled in pyauto.  This CL
re-enables passwords.PasswordTest.testSavePassword (by explicitly
disabling all other passwords tests).

BUG=73078
TEST=None

Review URL: http://codereview.chromium.org/6994005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86154 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/7037045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86153 0039d316-1c4b-4281-b951-d872f2087c98

No visible changes.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7057012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86152 0039d316-1c4b-4281-b951-d872f2087c98

In webkit_glue::DecodeImage(), the WebImage
is of type SkBitmap instead of CGImage, so
take the general case if USE_SKIA is defined.

The generic version of WebCursor defines
SetCustomData and ImageFromCustomData only if
WEBKIT_USING_SKIA is enabled, so disable the
corresponding routines in the Mac version.

In webkit_glue::WebThemeEngineImpl::paintScrollbarThumb(),
map the WebCanvas (i.e. SkCanvas) to a CGContext
to paint the scrollbar thumb, using the SkiaBitLocker
utility class.

SkiaBitLocker is described in
http://codereview.chromium.org/7031006/

These changes make no functional change to any
existing port, so have no new tests.

BUG=79463
TEST=none

Review URL: http://codereview.chromium.org/6840057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86151 0039d316-1c4b-4281-b951-d872f2087c98

- Remove network section h3 specifics since options_page.css is using
  the latest UI now. And this makes network UI looks the same way as
  other parts. That is, buttons and network list are aligned instead of
  immediately following the section headers.
- Move "-webkit-margin-start: 15px" into the div container
  "network-general-div" and get rid of related css rules from its
  children;
- Remove stale css rules of "details-button", which no longer exists;

BUG=none
TEST=Verify ChroemOS network settings works as before. The only visual
change is the button strip and network lists are now left-aligned
instead of immediately following the section headers.

Review URL: http://codereview.chromium.org/7038043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86150 0039d316-1c4b-4281-b951-d872f2087c98

Linux: split ProxyConfigServiceLinux::SettingGetter::Setting into several enums, one for each type of setting. This provides additional type safety.

Review URL: http://codereview.chromium.org/7033040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86149 0039d316-1c4b-4281-b951-d872f2087c98

Testing the LevelDB backend from the webkit unit tests requires it
create a temporary file system. In order to clean this up
(and on all platforms) we are going to make the scoped_temp_dir
functionallity available to LayoutTestController.


TEST=This is a thin wrapper on ScopedTempDir which is already covered by unit testing. This will be connected to LayoutTestController (a future patch in WebKit).

Review URL: http://codereview.chromium.org/7034047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86148 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83430
TEST=none
Review URL: http://codereview.chromium.org/7054021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86147 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81916
TEST=Follow repro setps in bug report, verify that crash no longer occurs.
Review URL: http://codereview.chromium.org/7050031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86146 0039d316-1c4b-4281-b951-d872f2087c98