- 30 Nov, 2017 40 commits
-
-
Bill Orr authored
This change is a targetted fix to send the VRViewerType metric from multiple locations - both keeping the existing Android-only location in VrShellGl, and adding a new location in OpenVRDevice. The two metrics will trigger when we enter VR through the respective platform-specific VR entry points. These two entrypoints will be reconciled in a subsequent change that moves more VR metrics to a cross-platform location. BUG=782865 Change-Id: I17505eaa9bdefccb275dba0f5863a248c78c5968 Reviewed-on: https://chromium-review.googlesource.com/798028 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#520751}
-
Joy Ming authored
Bug: Change-Id: I2a724e96e1fc180d1a17d358a3a3b0b602a9f154 Reviewed-on: https://chromium-review.googlesource.com/802139Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Joy Ming <jming@chromium.org> Cr-Commit-Position: refs/heads/master@{#520750}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/c3fc7aa9c6bf..3ebc2fd9fe64 $ git log c3fc7aa9c..3ebc2fd9f --date=short --no-merges --format='%ad %ae %s' 2017-11-30 benjhayden Fix another bug in the simplified dropdown. 2017-11-30 eakuefner [Dashboard] Call DeduplicateDiagnostics in add_histograms Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I09c6a1080ef90586f7c3e25fabfb3aa813b7e9c4 Reviewed-on: https://chromium-review.googlesource.com/802088 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520749}
-
Mike Dougherty authored
Users on a Captive Portal network without an internet connection may see an error interstitial or experience timeouts. These metrics will help to identify users in these scenarios. Bug: 783315, 785548 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I911b6d9a57a017d2827ee0feeb07d8721acfa849 Reviewed-on: https://chromium-review.googlesource.com/783694 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#520748}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4e481ca7. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/6549 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes jsbell@chromium.org: external/wpt/FileAPI TBR=qyearsley No-Export: true Change-Id: Ib15a83ebc7c4ef9217fb6fbfa007edb0da20c6f6 Reviewed-on: https://chromium-review.googlesource.com/801454 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520747}
-
John Budorick authored
Bug: 729135 Change-Id: Ib8c512e675157d46c6009f53bc462c0d9511fbfe Reviewed-on: https://chromium-review.googlesource.com/798641 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#520746}
-
Yuzhu Shen authored
The previous code leaks the original handle. BUG=788068 Change-Id: If6674b1b72b3a4b3e065e541c8ab2f4f20318298 Reviewed-on: https://chromium-review.googlesource.com/801234 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#520745}
-
David Dorwin authored
This does not match the planned "VR." namespace structure, which won't be fully defined in time for this release. Thus, use a name that is consistent with the other existing histograms. All will be migrated soon per https://crbug.com/790682. This renames histograms added in https://crrev.com/c/795670. Since they were just added so this should not affect data. Change-Id: I60ec91ca7e6857653d9bee1d8029ea899169e56d Reviewed-on: https://chromium-review.googlesource.com/801220 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#520744}
-
Kurt Horimoto authored
This was only flaky on iOS9 devices, but iOS9 is no longer supported. I ran this test several hundred times locally on an iOS11 device with no flake. Bug: 780824 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I61b33e8cb3c0e4dab760b75361649fda56b4e6a1 Reviewed-on: https://chromium-review.googlesource.com/802082Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#520743}
-
Scott Graham authored
TBR: avi@chromium.org Bug: 790751 Change-Id: Ic8f16dda831989e3d2af60a96da3b3fc4cb39974 Reviewed-on: https://chromium-review.googlesource.com/802177Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#520742}
-
Chris Mumford authored
There were some base::File::Error values that had 1:1 equivalents in net::Error which were not handled. Added more mappings. Bug: None Change-Id: I5487a3b02c1aa98427d35d34f2ea36ae772a09a3 Reviewed-on: https://chromium-review.googlesource.com/798052 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#520741}
-
Steven Bennetts authored
An edge case was recently introduced where a call into NetworkStateHandler from NetworkConnectionStateChanged or NetworkPropertiesUpdated might trigger EnsureCellularNetwork which might delete the network passed to other observers. We have also seen a handful of crashes in these observers that may be caused by a different edge case. This CL fixes the known issue and forces a crash for any existing or future regressions. Bug: 774430 Change-Id: I03ecf5ab46c572ee966be1f3c049c6d0906ac9e8 Reviewed-on: https://chromium-review.googlesource.com/798636Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Ben Chan <benchan@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#520740}
-
Jason Chase authored
This CL adds support for applying the [OriginTrialEnabled] attribute to individual members of a dictionary in IDL. The resulting behaviour is similar to the existing support for [RuntimeEnabled]. For [RuntimeEnabled], the existing behaviour is that a controlled member on a dictionary will be ignored in the input to a method, unless the flag is enabled. Specifically, the member value provided in JavaScript will not be copied to the internal C++ data representation. This same behaviour has been implemented for [OriginTrialEnabled]. The other change is to apply both [RuntimeEnabled] and [OriginTrialEnabled] to dictionaries created internally, and output to JavaScript. Previously, all dictionary members were returned, regardless if [RuntimeEnabled] was applied. NOTE: This means that there could be some dictionary members that were always visible to JavaScript, but will be no longer. e.g. MediaTrackSupportedConstraints: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/mediastream/MediaDevices.idl?type=cs&l=14 Bug: 788196 Change-Id: I110aa286fa4ff237b9716a6bce136093e25d9e4e Reviewed-on: https://chromium-review.googlesource.com/794670Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#520739}
-
Derek Cheng authored
The new controls (which contains option to enable/disable remoting) should not be shown if the user does not have remoting enabled. Bug: 774245 Change-Id: I9f77f360f7af89736bb3be7efb5537dbbff4951e Reviewed-on: https://chromium-review.googlesource.com/798357 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#520738}
-
Dominick Ng authored
BUG=None Change-Id: Icac624660d9fa153683cb1bcd60685e597c19930 Reviewed-on: https://chromium-review.googlesource.com/798230Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#520737}
-
Robert Sesek authored
Tbr: halliwell@chromium.org Change-Id: Ib28440078d41316de19a35ca2d7334563c1df2b5 Reviewed-on: https://chromium-review.googlesource.com/802055Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#520736}
-
Tom Sepez authored
This forces stat (and variants like stat64) and rename to execute in the broker process rather than in the network service itself. Bug: 715679 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie58d695bcf6c2fb5b2940a88571219645b3b2e56 Reviewed-on: https://chromium-review.googlesource.com/783882 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#520735}
-
Dale Curtis authored
Has been flaking for over a month without action. BUG=767427 TEST=none Change-Id: I751f18e8a625b21c0efbcdf09446fa648fbf28e2 Reviewed-on: https://chromium-review.googlesource.com/802135Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#520734}
-
Mark Pearson authored
chrome/browser/ui/omnibox/ - because I've made a number of changes there myself and am familiar with this code chrome/browser/ui/views/omnibox/OWNERS - because sometimes I review changes outside of this directory that have purely mechanical changes within it and it's annoying that a second omnibox owners approval is needed in these cases. I also know how to pass the buck when I'm in over my head. Bug: Change-Id: I7f9f44d75b5f03e16bd4df4eb1e2414eb37a71fe Reviewed-on: https://chromium-review.googlesource.com/802083Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#520733}
-
Gheorghe Comanici authored
See the corresponding bug for situations where this was problematic. In particular, the omnibox edit model is using this permanent text to generate an AutocompleteInput object that gets sent to the autocomplete controller to generate matches. See link below for details: https://cs.chromium.org/chromium/src/components/omnibox/browser/omnibox_edit_model.cc?l=903 Baseline code does not update this permanent_text and generates an AutocompleteInput object that is inconsistent with the actual page for which suggestions are generated. For more details on what are the consequences of this inconsistency, see examples in the link for the bug. For the choice of permanent text that is used in the added line, see https://cs.chromium.org/chromium/src/chrome/browser/ui/views/omnibox/omnibox_view_views.cc?l=220 Bug: 788162 Change-Id: I10a8f088f9c5ba47dd9f0b652599c53ab3c1ecfa Reviewed-on: https://chromium-review.googlesource.com/797750 Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#520732}
-
Mehran Mahmoudi authored
The TextView in BarBanner for Contextual Search was not vertically aligned, but instead fixed at a vertical position. This CL vertically aligns the TextView. Change-Id: I7ffaf487ab7c93b98f530b49ae72f077237445ca Reviewed-on: https://chromium-review.googlesource.com/795172 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#520731}
-
Michał Pichliński authored
During fallback from ANGLE to SwiftShader it is required to unload ANGLE libraries, otherwise SwiftShader will fail to load its own libGLESv2.dll. Fixed ANGLE platform reset. Fixed order in ShutdownGL. Bug: 760063 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If8797b49f2b5d04cb610302f96c82011dee9b3a9 Reviewed-on: https://chromium-review.googlesource.com/774296 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#520730}
-
Lei Zhang authored
Change-Id: Id2a6ec0f8b3f086d289b932a369eece3615ca2d5 Reviewed-on: https://chromium-review.googlesource.com/798353Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#520729}
-
Sandra Sun authored
The name change was decided here [1]. This patch renames every ScrollBoundaryBehavior in the codebase to OverscrollBehaior. It is a follow-up patch of https://chromium-review.googlesource.com/c/chromium/src/+/737090 [1] https://github.com/WICG/overscroll-behavior/issues/24 Bug: 789590 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I43609da09f707ec0d09cab94c3b005007868a1b1 Reviewed-on: https://chromium-review.googlesource.com/797351Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dimitri Glazkov <dglazkov@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#520728}
-
Dale Curtis authored
Per code inspection and commentary from ffmpeg developers, we need to be using a stride that is aligned to 32 for software video frames. It seems at somepoint we might be able to use av_cpu_max_align(), but even ffmpeg doesn't follow this internally and has exceptions for when H264 content is used, so just leave a TODO for now. BUG=773673 TEST=no more ubsan failure. Change-Id: I012bf7ca5531559df63061fc1edc9fdeaebf4c08 Reviewed-on: https://chromium-review.googlesource.com/801775Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#520727}
-
Scott Graham authored
Previously, when formatting binary operators, gn format would only try to break around the operators, but the determination of whether a list was single or multiline was only determined by the number of elements in the list (and in some cases, the LHS of the assignment). Instead now, check if spliting a single line list into multiline would avoid going past 80 columns. A test run of running this new behaviour on all of chromium/src is at https://chromium-review.googlesource.com/c/chromium/src/+/801660/, and it seems like a universal improvement, fixing a number of misformattings. Bug: 790021 Change-Id: I06ab6f06388dc9429a75407864769484d3fcea41 Reviewed-on: https://chromium-review.googlesource.com/801658Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#520726}
-
Chris Blume authored
The local_id is really the parent_id. And since we will soon be adding a child_id to the mix, we should rename this to clarify. BUG=789259 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I29b48e21de5b1d137a4df4f4d9e9a3169e82c284 Reviewed-on: https://chromium-review.googlesource.com/794374Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#520725}
-
Ian Vollick authored
As of crrev.com/c/741451, SwapBuffers now requires an argument. TBR=cjgrant@chromium.org Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2bc85fe0d232ca2dac3758bb1ba88d6f329f4021 Reviewed-on: https://chromium-review.googlesource.com/802018 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#520724}
-
khmel authored
Bug: b/69813150 Test: Manually on device. No OOBE OptIn page and ARC starts Change-Id: I915d9d6a426e42b26e2f74decb76eadba3f32081 Reviewed-on: https://chromium-review.googlesource.com/792632 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#520723}
-
Michael Thiessen authored
Not sure what the race here was, but this seems to fix it. This moves animation cancel code from onActivityShown back into onResume. Bug: Change-Id: I0c3735537844c47119bc61bb5be4f8e186d85786 Reviewed-on: https://chromium-review.googlesource.com/802014Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#520722}
-
Victor Costan authored
Bug: Change-Id: I688dbbfbb5dc6cae4b724443060081932231194d Reviewed-on: https://chromium-review.googlesource.com/795189Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#520721}
-
Justin Novosad authored
This change adds a call to ProduceTextureDirectCHROIMIUM to disassociate a mailbox from its texture in case the texture gets recycled by skia, in which case the mailbox name would be leaked. BUG=789742 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic07fc9897a2fa9e42bc5b1202e044c4171ca9f9a Reviewed-on: https://chromium-review.googlesource.com/801496Reviewed-by:
Olivia Lai <xlai@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#520720}
-
Zhenyao Mo authored
This CL was originally reviewed in https://chromium-review.googlesource.com/c/chromium/src/+/773538. Patchset 1 is exactly the same. Later patches are new fixes. BUG=783512 TEST=bots R=piman@chromium.org TBR=sadrul@chromium.org Change-Id: If664ad636da5382fad35a49766e3a3162031f1ab Reviewed-on: https://chromium-review.googlesource.com/801333 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#520719}
-
Tibor Goldschwendt authored
Bug: 788768 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifd74ce6a4384a4585631e15effc09b29d2244949 Reviewed-on: https://chromium-review.googlesource.com/794041 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#520718}
-
Mitsuru Oshima authored
Moved methods that are meaningful for xdg to XdgShellSurface, and ones for remote_shell to ClientControlledShellSurface. Updated the unit test to use the correct ShellSurface instance. I found that a few tests used wrong one (that never actually used in real scenario), so I fixed them. There is one test that was failing because it's testing the scenario that does not exist. I'll fix it in a follow up CL. Bug: 773461 Change-Id: I91124da7c6274cd3dabc2e49e2abca1034dadffd Reviewed-on: https://chromium-review.googlesource.com/770454 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#520717}
-
Michael Giuffrida authored
We normally log a TabMetric UKM when an existing tab is backgrounded. If a new tab is opened in the background, we should log that as well so we have an entry to correlate it with when it is later closed or foregrounded. Similarly, if a tab navigates to a new URL while in the background (e.g. via JavaScript), we should log a new TabMetric to capture that URL. To support testing this, add a version of WebContentsTester::Create that takes a CreateParams so we can specify whether a WebContents (tab) starts hidden. This enables other tests to also override CreateParams fields when necessary. Bug: 784639 Change-Id: I189af4535a238767bb257f39ee97301bac2a4171 Reviewed-on: https://chromium-review.googlesource.com/797930 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#520716}
-
Leo Zhang authored
Add turn on/off translate switch. Read accept_langauges from native and show them in the languages page. For each language item, add a fake option memu. Screenshot: https://screenshot.googleplex.com/0HOVztouukP Bug: 783049 Change-Id: If420d76fe12ecbff277bcd6e4ab7a3a7a3419f63 Reviewed-on: https://chromium-review.googlesource.com/762540 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#520715}
-
Hector Carmona authored
Bug: 789718 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifd5d6153a4ea4e835c9187c8dab0ede871a052c1 Reviewed-on: https://chromium-review.googlesource.com/799031 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#520714}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/0ee7aab89cf2..c3fc7aa9c6bf $ git log 0ee7aab89..c3fc7aa9c --date=short --no-merges --format='%ad %ae %s' 2017-11-30 eakuefner [TBMv2] Deduplicate all diagnostics 2017-11-30 nednguyen Move cache flushing logic out of Browser constructor into PossibleBrowser classes 2017-11-29 eakuefner [TBMv2] Port DeduplicateDiagnostics to Python Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I13b530124363be50acf0c35f52a9fbbcfe6eeaee Reviewed-on: https://chromium-review.googlesource.com/801356 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520713}
-
Ted Choc authored
Lint warning: warning: [JdkObsolete] Vector performs synchronization that is usually unnecessary; prefer ArrayList. None of the usages are used outside of a single function, so no need for any synchronization. BUG= Change-Id: Ic54e896451415531ee4195d4868a55f1bb936df2 Reviewed-on: https://chromium-review.googlesource.com/801262Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#520712}
-