- 11 Jul, 2016 34 commits
-
-
kouhei authored
No behavioral change. - Avoid duplicate member init in HTMLConstructionSite c-tor. - Use Document& instead of Document* as the document can't be nullref - Clarify that HTMLTreeBuilder can be invoked for generic Document (with a fixme comment) BUG=None Review-Url: https://codereview.chromium.org/2126043003 Cr-Commit-Position: refs/heads/master@{#404615}
-
hbos authored
This file contains an interface that is about to be removed (https://codereview.webrtc.org/2034013003) since it is no longer used by chromium (https://codereview.chromium.org/2033353002). The build files have to be updated before the file is removed from the webrtc repo or else the webrtc roll will cause chromium to break. BUG=webrtc:5708, webrtc:5707 NOTRY=true Review-Url: https://codereview.chromium.org/2120493002 Cr-Commit-Position: refs/heads/master@{#404614}
-
jkrcal authored
The previous src tag collides with the one used by desktop NTP (in the remote NTP). BUG=626235 Review-Url: https://codereview.chromium.org/2125133004 Cr-Commit-Position: refs/heads/master@{#404613}
-
kouhei authored
Follow-up to https://chromium.googlesource.com/chromium/src/+/3854a2102cfd8a10f28cf5123f593b87aaac3af0 BUG=None Review-Url: https://codereview.chromium.org/2134043002 Cr-Commit-Position: refs/heads/master@{#404612}
-
ricea authored
WebURLResponse can directly point to a ResourceResponse object instead. BUG=625529 Review-Url: https://codereview.chromium.org/2133693002 Cr-Commit-Position: refs/heads/master@{#404611}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6cad5da3c39e..4160831d2082 $ git log 6cad5da3c..4160831d2 --date=short --no-merges --format='%ad %ae %s' TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2135893002 Cr-Commit-Position: refs/heads/master@{#404610}
-
maksim.sisov authored
There are two cases when cache is flushed: 1) MEMORY_PRESSURE_LEVEL_MODERATE: flush expired sessions only. 2) MEMORY_PRESSURE_LEVEL_CRITICAL: flush everything. BUG=622069 Review-Url: https://codereview.chromium.org/2131883002 Cr-Commit-Position: refs/heads/master@{#404609}
-
haraken authored
It's now unused. BUG=610176 Review-Url: https://codereview.chromium.org/2134033002 Cr-Commit-Position: refs/heads/master@{#404608}
-
thestig authored
Review-Url: https://codereview.chromium.org/2129083002 Cr-Commit-Position: refs/heads/master@{#404607}
-
maksim.sisov authored
URLRequest::Delegate::OnBeforeNetworkStart is not used by anything, despite having a lot of plumping. It was added to try experimenting with having the ResourceScheduler delay requests only once they needed to go over the network, so responses that could be served out of the cache. BUG=479994 Review-Url: https://codereview.chromium.org/2123093002 Cr-Commit-Position: refs/heads/master@{#404606}
-
falken authored
This symbol no longer appears in the codebase. BUG=27837 Review-Url: https://codereview.chromium.org/2134023002 Cr-Commit-Position: refs/heads/master@{#404605}
-
ericwilligers authored
The code is simpler without this extra method. Review-Url: https://codereview.chromium.org/1798743002 Cr-Commit-Position: refs/heads/master@{#404604}
-
tkent authored
Using optinList() instead of listItems() simplifies the code. This CL should not have any behavior changes. Review-Url: https://codereview.chromium.org/2141483002 Cr-Commit-Position: refs/heads/master@{#404603}
-
haraken authored
BUG= Review-Url: https://codereview.chromium.org/2136913002 Cr-Commit-Position: refs/heads/master@{#404602}
-
falken authored
It was blocked on https://crbug.com/274855 which is now fixed. BUG=387045 Review-Url: https://codereview.chromium.org/2136833003 Cr-Commit-Position: refs/heads/master@{#404601}
-
falken authored
The symbol no longer appears in the codebase. BUG=403544 Review-Url: https://codereview.chromium.org/2140483002 Cr-Commit-Position: refs/heads/master@{#404600}
-
yukishiino authored
Removes crash keys and temporary instrumentations to investigate the issue crbug.com/621730 . The crash keys and instrumentations were introduced at https://crrev.com/2107773002 https://crrev.com/2101283002 BUG=621730 Review-Url: https://codereview.chromium.org/2133743002 Cr-Commit-Position: refs/heads/master@{#404599}
-
haraken authored
This CL introduces Document::unthrottledTaskRunner() and move one task in HTMLCanvasElement to the unthrottled task runner. We'll move more tasks to the unthrottled task runner. BUG=624696 Review-Url: https://codereview.chromium.org/2133623002 Cr-Commit-Position: refs/heads/master@{#404598}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/3ab14ca950d9..6af677ff8f54 $ git log 3ab14ca95..6af677ff8 --date=short --no-merges --format='%ad %ae %s' 2016-07-10 dvonbeck Changed SkLightingShader API to take in a shader as color source CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel TBR=msarett@google.com Review-Url: https://codereview.chromium.org/2141473002 Cr-Commit-Position: refs/heads/master@{#404597}
-
fukino authored
To show the up-to-date storage information, this CL modifies storage manager to update the information every 5 seconds while the manager overlay is visible. Also, avoiding updating storage size while computing size is ongoing. BUG=625071 TEST=manually tested CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2137463002 Cr-Commit-Position: refs/heads/master@{#404596}
-
kouhei authored
Before this CL, Document::baseElementURL was used to initialize PreloadScanner. However, this URL can be !isValid(). This CL introduces Document::validBaseElementURL() which returns baseElementURL only when its valid, end returns empty URL when its invalid. This can safely be used to initialize preload scanner. BUG=623365 Review-Url: https://codereview.chromium.org/2132283002 Cr-Commit-Position: refs/heads/master@{#404595}
-
falken authored
ScopedCrashKey(blah, blah) should be ScopedCrashKey key(blah, blah) BUG=625040 Review-Url: https://codereview.chromium.org/2134003002 Cr-Commit-Position: refs/heads/master@{#404594}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/4c42eebc5551..3ab14ca950d9 $ git log 4c42eebc5..3ab14ca95 --date=short --no-merges --format='%ad %ae %s' 2016-07-10 robertphillips Fix misplaced guard 2016-07-10 reed Revert of change mapRectScaleTranslate to pass args/ret by value (patchset #1 id:1 of https://codereview.chromium.org/2137853002/ ) 2016-07-10 reed change mapRectScaleTranslate to pass args/ret by value CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel TBR=msarett@google.com Review-Url: https://codereview.chromium.org/2136883002 Cr-Commit-Position: refs/heads/master@{#404593}
-
sungmann.cho authored
BUG=3333 TEST=None Review-Url: https://codereview.chromium.org/2129373002 Cr-Commit-Position: refs/heads/master@{#404592}
-
tkent authored
Remove listItems() usage from: - HTMLOptionElement::index() - HTMLSelectElement::saveListboxActiveSelection() - HTMLSelectElement::selectedOption() - HTMLSelectElement::deselectItemsWithoutValidation() We use optionList() instead. These changes don't improve computational complexity. However we can avoid to update m_listItems when we add/remove OPTIONs. Other changes: - HTMLSelectElement::updateListBoxSelectioN() needs to be updated to synchronize with saveListboxActiveSelection(). m_cachedStateForActiveSelection now represents OPTIONs instead of listItems, which includes OPTGROUP and HR. - Change the arguments of OptionList and OptionListIterator to |const| so that we can create them in const member functions of HTMLSelectElement. - Remove the optimized fast path in HTMLSelectElement::setRecalcListItems(). We don't use m_listItems in critical paths any longer. So the optimization isn't necessary. This CL improves performance because of the removal of the fast path. blink_perf.dom: select-multiple-add: 1,772 runs/s -> 1,912 runs/s select-single-add: 867.9 runs/s -> 944.7 runs/s select-single-remove: 137.9 runs/s -> 145.5 runs/.s BUG=577989 Review-Url: https://codereview.chromium.org/2131073002 Cr-Commit-Position: refs/heads/master@{#404591}
-
yinjie authored
Propagate force_use_new_methods_for_test and SetDecoderHeaderTableDebugVisitor to the nested SpdyFramerDecoderAdapter, if present. This fixes several test failures, if --use_nested_spdy_framer_decoder=true. This CL lands server change 126441874 by jamessynge. BUG=488484 Review-Url: https://codereview.chromium.org/2130193002 Cr-Commit-Position: refs/heads/master@{#404590}
-
mgiuca authored
This item is only shown when in fullscreen, and allows users to exit fullscreen using the mouse (for users who don't have a keyboard attached). This is still not foolproof (as it won't work on a site that captures the right-click menu) but should work in the majority of cases. BUG=594868 TEST=https://permission.site. Click Fullscreen. Right-click background; should see "Exit full screen ... Esc". TEST=F11 to go fullscreen. Right-click background; should see "Exit full screen ... F11". Review-Url: https://codereview.chromium.org/2116973002 Cr-Commit-Position: refs/heads/master@{#404589}
-
dgozman authored
We issue a fine-grained runtimeEnabled/runtimeDiabled notification. Introduced a new setting forceMainWorldInitialization, which inspector uses to force contexts in all frames to be able to evaluate there. Moved scriptBlockedByCSP pause reason to DOMDebugger agent, similar to scriptFirstStatement. BUG=580337 Review-Url: https://codereview.chromium.org/2112593003 Cr-Commit-Position: refs/heads/master@{#404588}
-
glevin authored
BUG=598841 TEST=Not easily testable, as this CL removes code that is no longer active after a first Quirks server check; we expect nearly all devices should have made a server check as of M-54, if they're ever going to. Review-Url: https://codereview.chromium.org/2006143011 Cr-Commit-Position: refs/heads/master@{#404587}
-
rohitrao authored
AddingNonStringRemovesCachedString was failing because it is now an error to copy an empty UIImage to the pasteboard. BUG=626686 Review-Url: https://codereview.chromium.org/2134853002 Cr-Commit-Position: refs/heads/master@{#404586}
-
yinjie authored
No functional change, not flag-protected. This CL lands server change 126437339 by dahollings. BUG=488484 Review-Url: https://codereview.chromium.org/2130153002 Cr-Commit-Position: refs/heads/master@{#404585}
-
nainar authored
This patch trivially encapsulates Layout Tree Construction code in its own function -> Element::buildOwnLayout(). No behaviour change is expected from this patch since it is merely moving code around. With lots of help from @bugsnash Design doc: http://bit.ly/29MBWvf BUG=595137 Review-Url: https://codereview.chromium.org/2118393002 Cr-Commit-Position: refs/heads/master@{#404584}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/48898561db7d..4c42eebc5551 $ git log 48898561d..4c42eebc5 --date=short --no-merges --format='%ad %ae %s' 2016-07-10 update-skps Update SKP version CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel TBR=msarett@google.com Review-Url: https://codereview.chromium.org/2136843002 Cr-Commit-Position: refs/heads/master@{#404583}
-
yukishiino authored
Revert of Simplify ppapi Graphics3D size propagation a bit (patchset #5 id:80001 of https://codereview.chromium.org/2136743002/ ) Reason for revert: Build breakage on Win8 GYP. https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/builds/507 FAILED: nacl64.exe nacl64.exe.pdb E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True nacl64.exe "E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /OUT:nacl64.exe @nacl64.exe.rsp" 1 mt.exe rc.exe "obj\chrome\chrome_nacl_win64.nacl64.exe.intermediate.manifest" obj\chrome\chrome_nacl_win64.nacl64.exe.generated.manifest ..\..\build\win\compatibility.manifest ppapi_ipc_win64.lib(ppapi_ipc_win64.ppapi_messages.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl gfx::Size::Size(void)" (__imp_??0Size@gfx@@QEAA@XZ) referenced in function "public: __cdecl std::_Tuple_val<class gfx::Size>::_Tuple_val<class gfx::Size>(void)" (??0?$_Tuple_val@VSize@gfx@@@std@@QEAA@XZ) nacl64.exe : fatal error LNK1120: 1 unresolved externals Original issue's description: > Simplify ppapi Graphics3D size propagation a bit > > - after https://codereview.chromium.org/2104403003/ we parse the attributes from > the plugin side, so we know the correct size from the start, and we don't need > to track the original size. > - we can also pass gfx::Size through IPC with some extra validation (negative > coordinates) in common code. > - overall net fewer lines > > BUG=None > > Committed: https://crrev.com/1135d428cd8f5b19d458c5e67ba90776c4e09381 > Cr-Commit-Position: refs/heads/master@{#404580} TBR=erikchen@chromium.org,bbudge@chromium.org,dcheng@chromium.org,danakj@chromium.org,piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2135063002 Cr-Commit-Position: refs/heads/master@{#404582}
-
- 10 Jul, 2016 6 commits
-
-
rtenneti authored
Revert of QUIC - Race Cert Verification with host resolution if certs are (patchset #6 id:140001 of https://codereview.chromium.org/2120703003/ ) Reason for revert: Net unit tests are failing on buildbot Original issue's description: > QUIC - Race Cert Verification with host resolution if certs are > availiable when race_cert_verification network session param is enabled. > > This experiment is not enabled in chromium. > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation > > R=eroman@chromium.org, mef@chromium.org, rch@chromium.org, > TBR=eroman@chromium.org (for net-internals changes) > > Committed: https://crrev.com/74acd6f26ea2e71a06a6d09cd2eb2f6d751627cc > Cr-Commit-Position: refs/heads/master@{#404568} TBR=eroman@chromium.org,mef@chromium.org,rch@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2137843002 Cr-Commit-Position: refs/heads/master@{#404581}
-
piman authored
- after https://codereview.chromium.org/2104403003/ we parse the attributes from the plugin side, so we know the correct size from the start, and we don't need to track the original size. - we can also pass gfx::Size through IPC with some extra validation (negative coordinates) in common code. - overall net fewer lines BUG=None Review-Url: https://codereview.chromium.org/2136743002 Cr-Commit-Position: refs/heads/master@{#404580}
-
leon.han authored
This CL removes InterfacePtr::WaitForIncomingResponse definition and replaces usage of them with either [Sync] call or a nested MessageLoop waiting asynchronously. BUG=622438 Review-Url: https://codereview.chromium.org/2096293002 Cr-Commit-Position: refs/heads/master@{#404579}
-
chrome-cron authored
Cr-Commit-Position: refs/heads/master@{#404578}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/443023975e33..48898561db7d $ git log 443023975..48898561d --date=short --no-merges --format='%ad %ae %s' 2016-07-09 pdr Update markdown docs to specify --local for the local devserver 2016-07-09 dvonbeck Abstracted diffuse color map out of SkLightingShaderImpl into a generic SkShader CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel TBR=msarett@google.com Review-Url: https://codereview.chromium.org/2135043002 Cr-Commit-Position: refs/heads/master@{#404577}
-
dgozman authored
Introduced Runtime.exceptionUnhandled and Runtime.exceptionRevoked methods which report exceptions when Runtime is enabled. Internally, we share the storage with console messages. That means exceptions can be evicted before Runtime.enable was called due to excessive number of console messages. Rough edges: - console.clear also clears the storage for exceptions; - releaseObjectGroup("console") releases exception objects as well; - integration on the frontend reuses ConsoleMessage and is somewhat ugly; - we may want to separate console vs exceptions on backend side. BUG=613882 Review-Url: https://codereview.chromium.org/2116563003 Cr-Commit-Position: refs/heads/master@{#404576}
-