GitLab

Now that we have early trace events, remove the only instance of
android.os.Trace in Chrome.

Review-Url: https://codereview.chromium.org/2164483007
Cr-Commit-Position: refs/heads/master@{#406888}

Unused variables were found via pylint.

There are a few types of circumstances where we have unused variables,
so there are a few types of transformations:

 1. variables that are simply unused, e.g.
    a = f()  =>  <delete>

 2. functions that return tuples but only some arguments are used, e.g.
    a, b = f()  =>  a, _ = f()

 3. functions that have side effects and also a return value, e.g.
    a = do_something()  =>  do_something()

 4. exception variables that are unused
    except Exception as e:  =>  except Exception:

Review-Url: https://codereview.chromium.org/2136793002
Cr-Commit-Position: refs/heads/master@{#406887}

Revert of H264 HW encode using MediaFoundation (patchset #11 id:420001 of https://codereview.chromium.org/2058413003/ )

Reason for revert:
Build break:

https://bugs.chromium.org/p/chromium/issues/detail?id=630335

Original issue's description:
> H264 HW encode using MediaFoundation
>
> This CL adds MediaFoundationVideoEncodeAccelerator which enables H264 encode support
> using MediaFoundation on Windows 8.1+. Also, it includes a refactor of common
> MediaFoundation classes under mf_helpers.*.
>
> Note that, this is the first CL and H264 codec is still behind a flag.
>
> Design Doc(with perf measurements): http://goo.gl/UCnwyA
>
> BUG=590060
> TEST= Tested AppRTC loopback with Chrome flag "--enable-webrtc-hw-h264-encoding" and
> "--enable-mf-h264-encoding" on https://apprtc.appspot.com/?debug=loopback&vsc=h264
> Also, added WIN specific sections at vea_unittests.
>
> Committed: https://crrev.com/e75bb4429ddcf2e79ae678a544064069718ee7a0
> Cr-Commit-Position: refs/heads/master@{#406876}

TBR=ananta@chromium.org,posciak@chromium.org,wuchengli@chromium.org,sandersd@chromium.org,grt@chromium.org,avi@chromium.org,emircan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590060

Review-Url: https://codereview.chromium.org/2172703002
Cr-Commit-Position: refs/heads/master@{#406886}

Revert of Redirect users without sync passphrase to passwords.google.com (patchset #50 id:980001 of https://codereview.chromium.org/2092723002/ )

Reason for revert:
The tests are checking their expectations on the wrong thread.

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35372/steps/chrome_public_test_apk/logs/stdio

I  703.521s run_tests_on_device(0ca41989032f9f23)    java.lang.AssertionError
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at org.chromium.base.ThreadUtils.assertOnUiThread(ThreadUtils.java:192)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at org.chromium.chrome.browser.sync.ProfileSyncService.get(ProfileSyncService.java:104)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at org.chromium.chrome.browser.preferences.PasswordViewingTypeTest.testUserRedirectSyncSettings(PasswordViewingTypeTest.java:133)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at java.lang.reflect.Method.invokeNative(Native Method)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:129)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

Original issue's description:
> Redirect syncing users without sync passphrase to passwords.google.com
>
> This CL redirects syncing users without a sync passphrase to https://passwords.google.com instead of natively displaying passwords. The changes created in this CL are hidden behind the ViewPasswords feature.
>
> BUG=623488
>
> Committed: https://crrev.com/13085d446efc3b8cd2c26338738c04a7516953a8
> Cr-Commit-Position: refs/heads/master@{#406823}

TBR=vabr@chromium.org,bauerb@chromium.org,dozsa@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=623488

Review-Url: https://codereview.chromium.org/2165333002
Cr-Commit-Position: refs/heads/master@{#406885}

https://chromium.googlesource.com/skia.git/+log/1f3923e4e5bf..0ae097d116f4

$ git log 1f3923e4e..0ae097d11 --date=short --no-merges --format='%ad %ae %s'
2016-07-21 vjiaoblack Creating framework for drawShadowedPicture GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003
2016-07-21 robertphillips Minor change to Ganesh path renderers
2016-07-21 caryclark fix builder fuzz
2016-07-21 robertphillips Revert of Remove DrawFace enum from GrPipelineBuilder (patchset #2 id:20001 of https://codereview.chromium.org/2165283002/ )
2016-07-21 bsalomon Update build_command_buffer.py to copy libcommand_buffer_gles2.so from the correct dir on linux
2016-07-21 robertphillips Remove DrawFace enum from GrPipelineBuilder

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2165273003
Cr-Commit-Position: refs/heads/master@{#406884}

I'm not really sure what "old style Ports" were, but it appears that
this section of dead code can be removed quite cleanly.

Review-Url: https://codereview.chromium.org/2131013003
Cr-Commit-Position: refs/heads/master@{#406883}

Done with autoflake -i $(find . -name '*.py' | grep -v thirdparty)

Review-Url: https://codereview.chromium.org/2137803002
Cr-Commit-Position: refs/heads/master@{#406882}

This removes the need for tracking a parent view and a window
in each ViewAndroid. Instead the WindowAndroid is now just the root
View.

Review-Url: https://codereview.chromium.org/2136373002
Cr-Commit-Position: refs/heads/master@{#406881}

This is a follow-up to https://codereview.chromium.org/2120683002,
suggested in https://codereview.chromium.org/2120683002/#msg38.

BUG=

Review-Url: https://codereview.chromium.org/2163223005
Cr-Commit-Position: refs/heads/master@{#406880}

With this change, it's possible to set a GN arg "use_experimental_allocator_shim" to true to enable the generic allocator shim on Windows. This only works in non-component builds due to the way the allocator is intercepted on Windows.

BUG=550886

Review-Url: https://codereview.chromium.org/2138173002
Cr-Commit-Position: refs/heads/master@{#406879}

The class GLES2DecoderImpl::CALayerSharedState has a gfx::Transform member,
which in turn has a SkMatrix44 member. In gyp, this means that the command
buffer service target needs to depend on Skia.

BUG=629899
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2166813004
Cr-Commit-Position: refs/heads/master@{#406878}

BUG=612331
TEST=none
R=jamescook@chromium.org
TBR=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2166793005
Cr-Commit-Position: refs/heads/master@{#406877}

This CL adds MediaFoundationVideoEncodeAccelerator which enables H264 encode support
using MediaFoundation on Windows 8.1+. Also, it includes a refactor of common
MediaFoundation classes under mf_helpers.*.

Note that, this is the first CL and H264 codec is still behind a flag.

Design Doc(with perf measurements): http://goo.gl/UCnwyA

BUG=590060
TEST= Tested AppRTC loopback with Chrome flag "--enable-webrtc-hw-h264-encoding" and
"--enable-mf-h264-encoding" on https://apprtc.appspot.com/?debug=loopback&vsc=h264
Also, added WIN specific sections at vea_unittests.

Review-Url: https://codereview.chromium.org/2058413003
Cr-Commit-Position: refs/heads/master@{#406876}

BUG=

Review-Url: https://codereview.chromium.org/2167713005
Cr-Commit-Position: refs/heads/master@{#406875}

Changes:
  e84dcb4 Convert libyuv to a static library in GN.
  e497bc8 Revert "roll chromium same as webrtc jun9"
  6126968 Revert "Roll chromium_revision 7fa6701b..1a73d11e (398458:399420)"
  81d6597 Roll chromium_revision 7fa6701b..1a73d11e (398458:399420)
  a817c15 roll chromium same as webrtc jun9
  6508580 roll chromium from 1:48 to 2:59 may 24 revision.

TBR=fbarchard
BUG=627637

Review-Url: https://codereview.chromium.org/2163313003
Cr-Commit-Position: refs/heads/master@{#406874}

As I was inspecting cc/surfaces clients, I noticed some dead code in
bitmap_uploader. This CL deletes it.

BUG=none

Review-Url: https://codereview.chromium.org/2165253002
Cr-Commit-Position: refs/heads/master@{#406873}

BUG=629555

Review-Url: https://codereview.chromium.org/2165773002
Cr-Commit-Position: refs/heads/master@{#406872}

Adding this to support building Robolectric 3.0 in Chromium.
Robolectric has several .properties files and several native
libraries that would be best to include in some of the
Robolectric jars.

BUG=

Review-Url: https://codereview.chromium.org/2044223005
Cr-Commit-Position: refs/heads/master@{#406871}

ExternalDataUseObserver should batch data use objects before posting to
the UI thread. This will reduce the overhead due to thread hopping.

BUG=570884

Review-Url: https://codereview.chromium.org/2169773002
Cr-Commit-Position: refs/heads/master@{#406870}

Refactor ios-{device,simulator}{,-gn}.json files so that the difference
between gyp and gn bot is limited to the "comment" and "mb_type" fields.

Sort "gn_args" values so in the same order as the corresponding value
in "GYP_DEFINES" (this make it easier to check that both gyp and gn are
using the same settings).

Convert ios-simulator-gn.json to build a fat binary and run the tests
on both a 32-bit and a 64-bit device as ios-simulator.json is doing.

BUG=621708

Review-Url: https://codereview.chromium.org/2162133003
Cr-Commit-Position: refs/heads/master@{#406869}

BUG=625254

Review-Url: https://codereview.chromium.org/2136723002
Cr-Commit-Position: refs/heads/master@{#406868}

Previously if there are queued messages, MultiplexRouter may dispatch method
calls or connection error notifications while it is paused.

BUG=626869

Review-Url: https://codereview.chromium.org/2165153002
Cr-Commit-Position: refs/heads/master@{#406867}

The problem has been fixed: https://codereview.chromium.org/2168903002/

BUG=630215

Review-Url: https://codereview.chromium.org/2166373002
Cr-Commit-Position: refs/heads/master@{#406866}

https://chromium.googlesource.com/skia.git/+log/9b43094bf207..1f3923e4e5bf

$ git log 9b43094bf..1f3923e4e --date=short --no-merges --format='%ad %ae %s'
2016-07-21 robertphillips Deprecate SkDevice::accessBitmap method
2016-07-21 brianosman Adding color space to SkSpecialImage
2016-07-21 msarett Refactor parsing and storage of SkGammas

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2168943002
Cr-Commit-Position: refs/heads/master@{#406865}

[OfflinePages] Do not start background loading on low-end devices if app has any visible Activities.

BUG=627884, 622508

Review-Url: https://codereview.chromium.org/2164503003
Cr-Commit-Position: refs/heads/master@{#406864}

Previously if a tab was closed using the back button and it was the
only tab, the browser would stay in StaticLayout. Opening an external
link after this would trigger the overview mode because there was no
tab, then immediately switch to StaticLayout again. This would leave
the toolbar is a bad state. This change adds a check to determine if
there are any other tabs when closing with the back button, if not
overview mode is opened.

BUG=625077

Review-Url: https://codereview.chromium.org/2165053002
Cr-Commit-Position: refs/heads/master@{#406863}

The test has somewhat better logging than before (r359674), so maybe
we'll have some visibility into why the move fails.

BUG=460584
R=pmonette@chromium.org

Review-Url: https://codereview.chromium.org/2167003004
Cr-Commit-Position: refs/heads/master@{#406862}

Whether a redirect is cross-origin or not, the result will be a new
document and should not reuse the provisional HistoryItem during a
back/forward navigation.

BUG=585194
TBR=clamy
TEST=http/tests/navigation/back-to-redirect-with-frame.php
     in --isolate-sites-for-testing mode.

Review-Url: https://codereview.chromium.org/2159093002
Cr-Commit-Position: refs/heads/master@{#406861}

Now includes the CoreText fixes for issue crbug.com/132252 and
crbug.com/625606.

BUG=630275
R=kojii,eae,behdad

Review-Url: https://codereview.chromium.org/2163983005
Cr-Commit-Position: refs/heads/master@{#406860}

Lines 39 to 41 seem to declare a variable, instead of setting the
transform method provided in webrtc_test_common.js

BUG=6137

Review-Url: https://codereview.chromium.org/2172623002
Cr-Commit-Position: refs/heads/master@{#406859}

With crbug.com/626431 fixed, texImage2D(ImageBitmap) is able to support
more formats for WebGL2.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2165243002
Cr-Commit-Position: refs/heads/master@{#406858}

interacting with it.

This fixes a regression where the icon lingered after the user pressed
"Done". Luckily this regression only affected the protocol handler icon
and didn't change functionality (the user's choice was still respected).

This also improves on the behavior of said icon by hiding it when the
user dismisses the bubble via other means (e.g. clicking outside the
bubble), so long as they've explicitly interacted with the bubble by changing
the setting.

BUG=629645

Review-Url: https://codereview.chromium.org/2169453003
Cr-Commit-Position: refs/heads/master@{#406857}

If there's no title or close button present, BubbleFrameView still needs some
top padding to avoid the content being hard up against the top edge. Always pad
as though the close button was visible, even if it's not, unless there's a
title.

BUG=622859

Review-Url: https://codereview.chromium.org/2148963002
Cr-Commit-Position: refs/heads/master@{#406856}

This tool allows to inspect the resource_prefetch_predictor database,
for instance after pulling it from an Android device.

# Per tools/OWNERS comment.
TBR=thakis

Review-Url: https://codereview.chromium.org/2168083002
Cr-Commit-Position: refs/heads/master@{#406855}

This test has been added in https://codereview.chromium.org/2100303002
and appears to be flaky on the Android Tests (dbg) bot, see
crbug.com/630286 for details.

BUG=630286
TBR=rsleevi@chromium.org,tedchoc@chromium.org,dadrian@google.com
NOTRY=true

Review-Url: https://codereview.chromium.org/2164303002
Cr-Commit-Position: refs/heads/master@{#406854}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/60ef2530645f..cb90e4130adf

$ git log 60ef25306..cb90e4130 --date=short --no-merges --format='%ad %ae %s'

BUG=628239

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2171753002
Cr-Commit-Position: refs/heads/master@{#406853}

It's only used by content/browser, so it can stay there.

Also update URL related typemaps so that they can be used by mojoms in Blink. This is copied from https://codereview.chromium.org/2043753002/.

BUG=161070

Review-Url: https://codereview.chromium.org/2158913006
Cr-Commit-Position: refs/heads/master@{#406852}

Add notification surface to manager after commit so that it has
the correct content size when creating the hosting view.

BUG=629854

Review-Url: https://codereview.chromium.org/2169513003
Cr-Commit-Position: refs/heads/master@{#406851}

https://chromium.googlesource.com/skia.git/+log/ec336deffbf5..9b43094bf207

$ git log ec336deff..9b43094bf --date=short --no-merges --format='%ad %ae %s'
2016-07-21 mtklein Roll buildtools for latest GN binary.
2016-07-21 caryclark fix fuzzer bug

BUG=629962

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2165273002
Cr-Commit-Position: refs/heads/master@{#406850}

Specifically:
1. Migrated the fast user switching buttons view (triggered by right-clicking the avatar button) back to user menu's main page;
2. Added a "Guest" and "Close all your windows" button. Implemented with createMaterialDesignOptionsViewWithRect, which is based on/parallel to createOptionsViewWithRect;
3. Made UI modifications on paddings, seperators/not, using new skia icons, etc.

See screenshot:
https://drive.google.com/a/google.com/file/d/0B7Fvv7JszRyGTndKT2pBWlhRY2s/view
Mocks:
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu/specs#%2Fspec-2.png
Design doc:
https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.ulgws5x4kc7r

BUG=615893

Review-Url: https://codereview.chromium.org/2171473002
Cr-Commit-Position: refs/heads/master@{#406849}