- 20 Jul, 2017 40 commits
-
-
Christian Fremerey authored
This CL is part of the Mojo Video Capture work. Design doc for dev work [1]. Before this CL, the following situation could happen: 1. VideoCaptureManager calls ServiceVideoCaptureProvider::GetDeviceInfosAsync( callback). 2. ServiceVideoCaptureProvider makes a request to the service and waits for an answer 3. The service process crashes (or otherwise loses connection) => |callback| is never run This CL also adds a test for the scenario described above and a fix in the production code. The approach for the fix is to wrap the callback in a media::ScopedCallbackRunner to makes sure that it always gets run. This change required moving some of the Callback types to OnceCallback, which is work we want to do anyway. Bug: 584797 [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing Change-Id: Id60b6ffd04de4f7118218099cc1ccd437744d5fb Reviewed-on: https://chromium-review.googlesource.com/575786 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488433}
-
Yi Gu authored
threaded-rendering@chromium.org doesn't exist. Change the name to valid threaded-rendering-dev@. As tdresser@ suggested, we should try to avoid including public lists as owners. Updated the two entries created by me. Bug: Change-Id: Idac0ea44dbdf4d30e4ff0199ada90d76e0559737 Reviewed-on: https://chromium-review.googlesource.com/579959Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#488432}
-
Florin Malita authored
(remove SK_SUPPORT_LEGACY_TILED_BITMAPS) Change-Id: Ic4552ede98e6690d3067695e01c90c81cb357cef Reviewed-on: https://chromium-review.googlesource.com/545816 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#488431}
-
Tommi authored
Bug: Change-Id: Iea73537e5b586307596579afe1eb1e5d5ea4de89 Reviewed-on: https://chromium-review.googlesource.com/579729 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488430}
-
Toni Barzic authored
BUG=737067 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I29bbaeec11a59d8b1e9cab9cf584b03442ec1086 Reviewed-on: https://chromium-review.googlesource.com/580392Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#488429}
-
Kyle Horimoto authored
This URL was provided by the Help Content team. Note that it is not currently active, but the site will be uploaded soon. Bug: 672263 Change-Id: I702a36b79b1d667049daf8358431105ee8f9ce0f Reviewed-on: https://chromium-review.googlesource.com/580350Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#488428}
-
Dmitry Skiba authored
We suspect that library prefetching slows startup on low-end devices. This CL adds an experiment to verify that hypothesis. Bug: 735799 Change-Id: I5bc969e7d417f07520caef28fc4e0598e545d51b Reviewed-on: https://chromium-review.googlesource.com/578711 Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#488427}
-
Benjamin Pastene authored
From 16 min to 25 Seems to timeout occasionally: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/43919 https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/43911 https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/43907 https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/44123 R=jbudorick@chromium.org Bug: Change-Id: I95f1c034c4c5154b44e4cec5df956456ad53eedc Reviewed-on: https://chromium-review.googlesource.com/580248Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#488426}
-
Scott Chen authored
This CL eliminates the redundant css rules for paper-button in favor of reusing the styling in the shared cr_elements location. Bug: 740758 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieba6ab6bf03e2c063a52323ecacaafc5919e4dfa Reviewed-on: https://chromium-review.googlesource.com/577027Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#488425}
-
Eric Karl authored
With the angle fix here: https://chromium-review.googlesource.com/c/533684/ We can re-enable D3D11. Bug: 730126 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib04b49ecf66464baf92a517c364625c461785c47 Reviewed-on: https://chromium-review.googlesource.com/580187Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#488424}
-
Eugene But authored
Context menu is sometimes invoked for parent elements. f.e. a link can be a parent element of an image and even though user has pressed on the image, context menu is still shown for link, not for image. This CL checks -webkit-touch-callout style on element it is about to present a menu for (which can be a parent). Before the change -webkit-touch-callout was always checked for a parent causing system context menu to show up. Bug: 736480 Change-Id: I9239d75a1bfd9926dd67d1c742763c56837b0c38 Reviewed-on: https://chromium-review.googlesource.com/578215 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#488423}
-
Bret Sepulveda authored
Also fixed formatting script to not output \r\n on Windows. Bug: 706105 Change-Id: I69f8f9c39cbf72d6d568ed2689244d96488fdb0c Reviewed-on: https://chromium-review.googlesource.com/576410 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#488422}
-
vasilii authored
Android Autofill saves credentials in the wrong format. origin and signon_realm have no trailing '/' which prevents proper handling in Chrome. This CL migrates them to the proper format with '/'. The original entry stays on the server and it's kept up to date. In the future the credentials without '/' are to be removed from the Sync data. BUG=739101 Review-Url: https://codereview.chromium.org/2981293003 Cr-Commit-Position: refs/heads/master@{#488421}
-
Misha Efimov authored
Bug: 710801 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I147c082f7ac74ad2bd2843b9c7ca789bac2cec7b Reviewed-on: https://chromium-review.googlesource.com/579955Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#488420}
-
Peter Kasting authored
Some code that currently assumes it's running on the UI or DB threads can simply use "the current thread" or "the background thread" or similar. Bug: 689520 Change-Id: Ide84528d7abea223939bef247c1f4d9c47bb8752 Reviewed-on: https://chromium-review.googlesource.com/578144 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Selim Gurun <sgurun@chromium.org> Cr-Commit-Position: refs/heads/master@{#488419}
-
Lei Zhang authored
Wrap the one remaining new call with make_scoped_refptr() to show it is ref-counted. Change-Id: I248f156c730fb83e9c6486b9f0ac6346d7115c22 Reviewed-on: https://chromium-review.googlesource.com/578574Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#488418}
-
Yuke Liao authored
EarlGrey 1.10.1 has a bug that the scrollToTop action hangs indefinitely if the UITableView's navigation bar is translucent. Given that it makes no difference whether the view is translucent or not, this CL makes it not translucent to unblock rolling EarlGrey to 1.10.1. Bug: 747116 Change-Id: Idd48cf6f3f024c4b88bedcca412692598cd1a493 Reviewed-on: https://chromium-review.googlesource.com/580357Reviewed-by:
Ed Chin <edchin@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#488417}
-
Matt Menke authored
HostResolver already has a check before lookups reach that point. Added a DCHECK instead. Also remove a histogram that was broken in https://chromium-review.googlesource.com/569298. Bug: 496468 Change-Id: Ie2f78c48c2d251e8c563323464270516a6a00ff3 Reviewed-on: https://chromium-review.googlesource.com/578168 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#488416}
-
Reid Kleckner authored
This reverts commit 4979aac4. Reason for revert: None of these tests pass with Clang on Windows. That suggests that there are side effects that depend on order of function call argument evaluation, but I haven't been able to pin it down. http://crbug.com/746971 Original change's description: > RTCPeerConnectionHandler: Keep track of senders. > > https://chromium-review.googlesource.com/c/566806 showed that the > WebRtcRtpBrowserTest.AddAndRemoveTracks* tests would reliably crash > if the garbage collector was invoked between addTrack and getSenders. > Tracks that were added using addTrack would have their track adapters > (glue between blink and webrtc) kept alive only by the blink layer > sender holding on to a reference, since these were not kept alive by > any "local streams" holding a reference. > > The blink::RTCPeerConnection now holds a strong reference to senders > and receivers to prevent GC while in-use, with TODOs to remove ones > no longer used when addStream/removeStream is implemented using > addTrack/removeTrack. > > Furthermore the content::RTCPeerConnectionHandler holds on to the > content layer representation of senders so that their associated set > of streams are not forgotten between addTrack and getSenders. > > Having the handler keep track of senders is good practice, this gets > rid of the assumption that blink layer senders have to be kept alive. > A TODO was added to do the same for receivers (not yet required because > blink layer receivers are kept alive). > > With this change, the AddAndRemoveTracks* tests pass and are > re-enabled. > > Bug: 740650 > Change-Id: Iec3a39a994bef31904f2969d791125867ec1e398 > Reviewed-on: https://chromium-review.googlesource.com/567184 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487430} TBR=hbos@chromium.org,deadbeef@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 740650 Change-Id: Ie514367178863307b3596a5a34d2fdaed0fac817 Reviewed-on: https://chromium-review.googlesource.com/580367Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#488415}
-
Sean Kau authored
Ensure that manufacturer, model, and make_and_model are all populated. manufacturer and model are populated for backward compatability. Bug: 730242 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8a31dbe57bfbc09e7f2e0f04bc7a1aa9b1599368 Reviewed-on: https://chromium-review.googlesource.com/563521Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#488414}
-
Scott Violet authored
Mus and client code may need to know the id of the internal display. At a minimum mus uses this when setting the speed of the mouse. This patch plumbs the internal display id from the window manager to mus. BUG=701068 TEST=covered by test Change-Id: Ia93ddf4917fc0008f767cca60caabd0546c985c1 Reviewed-on: https://chromium-review.googlesource.com/580393Reviewed-by:
Elliot Glaysher <erg@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#488413}
-
Anthony Vallee-Dubois authored
Bug: 746544 Change-Id: I0b6813c118d90b47dd5b82c5721bac3d5e05aca1 Reviewed-on: https://chromium-review.googlesource.com/580070 Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#488412}
-
Mike Dougherty authored
The manual layout of the toolbar items for ios_web_shell is outdated and no longer works with iOS 11. Update the UIButtons to UIBarButtonItems and automatically lay them out with setItems: instead of adding items as subviews to the UIToolbar. Bug: None Change-Id: Id04d7bd7b630c28b0f76f3dc0f78510bca650ffd Reviewed-on: https://chromium-review.googlesource.com/580148Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#488411}
-
Hal Canary authored
Motivation: make https://review.skia.org/22543 work. Change-Id: Ib0c73056c57451a6f011288f4faa4814344a01ae Reviewed-on: https://chromium-review.googlesource.com/568463Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Hal Canary <halcanary@google.com> Cr-Commit-Position: refs/heads/master@{#488410}
-
Bin Zhao authored
(https://chromium-review.googlesource.com/c/574900/) breaks component extension. Need to update media_router_bindings.js as well. Bug: 574900 Change-Id: I1c23a475947752b29968984a0618e7fa62ef894e Reviewed-on: https://chromium-review.googlesource.com/580467Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#488409}
-
bsheedy authored
Adds test utility code that allows Chrome to think it's received an intent from a trusted app. This allows us to test Chrome's ability to auto present WebVR content when given a link from a trusted app (or test its rejection if the app is not trusted). Also adds one test using the new code. Also contains a drive-by fix for flakiness in WebVrTransitionTest#testNfcFiresVrdisplayactivate caused by a race condition when adding the vrdisplayactivate listener. Bug: 746086 Change-Id: Ic6b55df18d915a4e36b36ca43bd11f4c773f6d33 Reviewed-on: https://chromium-review.googlesource.com/578527 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#488408}
-
Daniel Bratell authored
All image decoder test have a helper function "CreateDecoder" which conflicts in jumbo builds where the tests are merged. This patch renames them "CreateBMPDecoder", "CreateJPEGDecoder" and so on. Bug: 745732 Change-Id: I2cfd108c39ade76a09059d77778557ab44b82752 Reviewed-on: https://chromium-review.googlesource.com/576098Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#488407}
-
Wez authored
Previously the |timeout| duration was being passed as the deadline, leading to the wait operation timing out as soon as Fuchsia's total up-time exceeded it. Any subsequent waits on process termination would then timeout instantly. This had the effect that any unit-test fixture that took longer than the per-batch timeout (less the Fuchsia boot timer under the test- runner) to complete would always fail, with UNKNOWN RESULT for tests from all later batches. Bug: 746775, 738275 Change-Id: I89b6d03f58caffe602bbf37a921b3bd20c09cee2 Reviewed-on: https://chromium-review.googlesource.com/578699Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#488406}
-
Ryan Landay authored
I'm working on a feature in content/public where I would like to use this style, but I am currently unable to since it's in chrome/android. We can fix this by moving it to ui/android. Bug: Change-Id: Iced9ecf8f03949291a5f80b9293ac16d9cbc6925 Reviewed-on: https://chromium-review.googlesource.com/578477 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#488405}
-
Stephen McGruer authored
Bug: 699244 Change-Id: I3ee97e123c4a94424f87ac45d77d39450e6fbfe8 Reviewed-on: https://chromium-review.googlesource.com/559512Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#488404}
-
Luke Zielinski authored
In preparation for launching the experiment to collect ad identifiers in existing SafeBrowsing reports. Hoping to also sanity check the plan for reusing this feature in the future if we want to change this param: When the trial launches, the finch config will go away and the feature will remain "disabled", so the code will revert to the Default value from this CL. If we later want to change the param, we create a new trial with a new param value, which will set the feature to "enabled" and the new value from the trial will be used instead. Bug: 674618 Change-Id: Ibb5cd5f2b4c95ecda592701084631027582a010a Reviewed-on: https://chromium-review.googlesource.com/578388 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#488403}
-
Tibor Goldschwendt authored
Bug: 737118 Change-Id: Ib14dfb4207a5cf37b173852a6a4fc13c9d13019f Reviewed-on: https://chromium-review.googlesource.com/575074Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#488402}
-
Brett Wilson authored
This is only populated with dummy data for now, but provides a place to hook up the process list and dumping function in the future. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I24934d3052dd8e36ad4a7b1372a5ef557ce716d4 Reviewed-on: https://chromium-review.googlesource.com/578559 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#488401}
-
Sergey Ulanov authored
net_unittests always fail because they run slowly under qemu Change-Id: Ief04c1ba39b5a507f0583fd7e31f4ff09492404c Bug: 745094, 738275 Reviewed-on: https://chromium-review.googlesource.com/580048Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#488400}
-
Rouslan Solomakhin authored
Before this patch, if a single web app manifest specified multiple sections of "related_applications" with different "id" (package name) fields and the user had several of these payment apps installed, then Chrome would display only one of these payment apps. The problem arose from an erroneous assumption of 1:1 relationship between web app manifests and payment apps. In fact, a single web app manifest can correspond to multiple payment apps, e.g., a dev and a prod version of the same app. The fix is to loop through the full web app manifest when looking for matching payment apps, instead of early-exiting when the first matching payment app is found. After this patch, if a single web app manifest specified multiple sections of "related_applications" with different "id" fields and the user had several of these payment apps installed, then Chrome displays all of the matching payment apps. Bug: 745765 Change-Id: I70f287cb792ac8b0b073c22e9c08eebec6ffae3e Reviewed-on: https://chromium-review.googlesource.com/579964Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488399}
-
Miriam Gershenson authored
This reverts commit 94fc8d93. Reason for revert: Cronet builders are breaking again, debug builders only this time: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20x86%20Builder%20%28dbg%29/builds/61964 We have an android_cronet_tester trybot but I don't remember if it does debug builds or not. Original change's description: > Reland "Android: Turn on UnusedResources lint check" > > Original CL: http://crrev.com/c/578488 > > Fixes: Cronet builders > > TBR=hanxi@chromium.org,agrieve@chromium.org,yuweih@chromium.org > > Bug: 731159 > Change-Id: I6a54dfbae76c1d55166dbcaaea7bbbc93e60bf34 > Reviewed-on: https://chromium-review.googlesource.com/580267 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488380} TBR=wnwen@chromium.org,hanxi@chromium.org,agrieve@chromium.org,yuweih@chromium.org Change-Id: I3360f01c815fe0674a05ae38622778bd5ed55305 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 731159 Reviewed-on: https://chromium-review.googlesource.com/580134Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#488398}
-
Geoff Lang authored
TBR=zmo@chromium.org NOTRY=true BUG=602688 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2490f77aadb5866a8af0d34ce16673e7be06d2b9 Reviewed-on: https://chromium-review.googlesource.com/580489 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#488397}
-
Bill Orr authored
This reverts commit 14020f57. Reason for revert: Hold off on API breaking change till M62, so we can have several that go out at the same time and we'll have a new origin trial. Original change's description: > WebVR: Update VRDisplay.GetFrameData to follow the current spec. > > The WebVR 1.1 spec was updated to clarify the behavior of getFrameData. > Now, GetFrameData should return false unless called within a > VRDisplay.requestAnimationFrame callback. > > BUG=736023 > > Change-Id: I14d9442a016817a78232ed7b1e71956c8dac614a > Reviewed-on: https://chromium-review.googlesource.com/578188 > Reviewed-by: Brandon Jones <bajones@chromium.org> > Commit-Queue: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487970} TBR=bajones@chromium.org,bsheedy@chromium.org,billorr@chromium.org Change-Id: Ia0491a7af887c6149b69178747f6a0e6a9b5f3d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 736023 Reviewed-on: https://chromium-review.googlesource.com/580167Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#488396}
-
Dmitry Gozman authored
BUG=590878 Change-Id: Idcebf0336623322813b4cdfac66183d37c28f2bd Reviewed-on: https://chromium-review.googlesource.com/573411 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#488395}
-
Mike Klein authored
GrGLFunction is a std::function today, but we'd like to slim that down. This will let us change its underlying type seamlessly. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9f9c3d4b56e6d6fb6db82c8f47ddf74fdca6476d Reviewed-on: https://chromium-review.googlesource.com/580129Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#488394}
-