GitLab

Change log for this release:
- Remove searchvox uncompiled js files.
- Allow aria live regions to be announced when observed on a background tab.
- Correctly speak live regions that have opacity 0 when shown but
  subsequently fade in.
- Announce changes to controls trigged on key up, not just on key down.
- Remove key echo work around so Google U.S. English (from the web store),
  can speak characters again.
- Don't read the entire contents of a dialog when first focused.


BUG=372552
TBR=dtseng@chromium.org

Review URL: https://codereview.chromium.org/274963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269945 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372349, 371626, 371204

Review URL: https://codereview.chromium.org/280583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269944 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372630
R=raymes@chromium.org

Review URL: https://codereview.chromium.org/284723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269943 0039d316-1c4b-4281-b951-d872f2087c98

In OpenVPN, it is up to the client to decide whether or not to
create a default route through the OpenVPN server.  Even when the
server supplies a gateway address, it isn't always clear if the
intent is for the client to set a default route through this
gateway.

By default, ChromeOS creates a default route to the gateway.
This CL adds an ONC configuration option to allow ONC to override
this default behavior, thus providing the means for a "split
tunnel" configuration in situations where the route configuration
provided by the VPN server is amenable to this.  Supplying this
option does not override any explicit routes pushed by the server.

BUG=370460
R=pneubeck@chromium.org

Review URL: https://codereview.chromium.org/275723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269942 0039d316-1c4b-4281-b951-d872f2087c98

Verifies that FindCursorPosition works with GetGlyphBounds values.

Prompted by a question reviewing Cem's WIP RenderTextHarfBuzz:
https://codereview.chromium.org/152473008/diff/100001/ui/gfx/render_text_harfbuzz.cc#newcode787
I thought RenderTextWin::GetRunContainingXCoord needed visual run order.
Logical run order is fine as-is, because it checks the range of x bounds.
(RenderTextHarfBuzz should probably do the same thing to be safe/correct)

BUG=NONE
TEST=NONE
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/276123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269941 0039d316-1c4b-4281-b951-d872f2087c98

Part 1: https://codereview.chromium.org/282533002/


BUG=n/a
TEST=content_unittests --gtest_filter=ServiceWorkerDatabaseTest.*

Review URL: https://codereview.chromium.org/285453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269940 0039d316-1c4b-4281-b951-d872f2087c98

In password_manager_unittests and password_form_manager_unittests.

Review URL: https://codereview.chromium.org/279193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269939 0039d316-1c4b-4281-b951-d872f2087c98

BUG=351245

Review URL: https://codereview.chromium.org/280603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269938 0039d316-1c4b-4281-b951-d872f2087c98

This adds the implementation for the second-layer sandbox, with tests, but
it does not wire it up for use in Chrome.

Design document:
https://docs.google.com/a/chromium.org/document/d/108sr6gBxqdrnzVPsb_4_JbDyW1V4-DRQUC4R8YvM40M/edit

BUG=367863
TEST=Covered by unit tests, manually verified on 10.6.8, 10.7.5, 10.8.5, and 10.9.2.

Review URL: https://codereview.chromium.org/264923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269937 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367677

Review URL: https://codereview.chromium.org/266883010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269936 0039d316-1c4b-4281-b951-d872f2087c98

This patch checks that the length passed to cfread() is non
negative. The individual read methods on cfread() check for failure
while reading a negative value, but the actual failure is a malformed
patch.

R=mark@chromium.org
BUG=chromium:372525
TEST=Manually run a local bad patch and check it fails with the new message.

Review URL: https://codereview.chromium.org/287483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269935 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/274443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269934 0039d316-1c4b-4281-b951-d872f2087c98

ViewEventTestBase (which this subclasses) installs a views_delegate,
so we don't need it here too.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/279273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269933 0039d316-1c4b-4281-b951-d872f2087c98

If there is an extra white space in the param, the param will not be used in the auto generated jni file

BUG=372459
R=trchen@chromium.org

Review URL: https://codereview.chromium.org/286563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269932 0039d316-1c4b-4281-b951-d872f2087c98

Removes the call to LayerTreeHost::CompositeAndReadback and just fail
immediately. This method should be replaced with an async readback
in order to get pixels again.

R=powei
BUG=252046

Review URL: https://codereview.chromium.org/273113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269931 0039d316-1c4b-4281-b951-d872f2087c98

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/101033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269929 0039d316-1c4b-4281-b951-d872f2087c98

Next, I need to write tests.

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/277083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367831
TEST=components_unittests --gtest_filter=BookmarkExpandedStateTrackerTest.*
R=sky@chromium.org,blundell@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/275773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269923 0039d316-1c4b-4281-b951-d872f2087c98

This test does not seem to need any ResourceBundle initialization and
does not seem to depend on any global state or extra setup, so it should
be fine to move it straightforward into gfx_unittests without any other
modifications.

BUG=331829
TEST=ui_unittests, gfx_unittests
TBR=ben@chromium.org, danakj@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/270773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269922 0039d316-1c4b-4281-b951-d872f2087c98

Don't allow .h files in mojo/embedder to include files from mojo/system
(except for system_impl_export.h).

R=sky@chromium.org

Review URL: https://codereview.chromium.org/283633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269921 0039d316-1c4b-4281-b951-d872f2087c98

This was factored out in r260482, but somehow I forgot to delete the old
definitions.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/277343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269919 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/280003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269917 0039d316-1c4b-4281-b951-d872f2087c98

Adds logic to have the model-thread NonBlockingDataTypeProcessor send
a message to the sync-thread SyncCore when it receives notifcation from
the ui-thread NonBlockingDataTypeController that it should stop syncing.
This message will allow the sync thread to stop requeting updates and
commits on behalf of the now-disabled type.

Fixes the handling of a race in the NonBlockingDataTypeProcessor.  The
race is as follows:
1. NBDTP receives a request to enable sync from the UI thread, and sends
   a connection request to the sync thread via SyncCoreProxy.
2. NBDTP receives a request to disable sync from the UI thread.  It
   updates its internal state accordingly.
3. NBDTP receives the connection OK response from the sync thread,
   which was genrated in response to its request in step 1.

Previously, the processor would wrongly set itself to the enable state
in step 3.  The fix is to use a new WeakPtrFactory and invalidate the
pointers it has issued in step 2 in order to prevent the response seen
in step 3 from being run.

Adds some more tests for this scenario and more.  The test framework had
to be made a bit more complicated in order to handle these tests, but
I think the extra complexity is worth it.  I don't know of any other
way to reliably defend against these race cases.

BUG=351005

Review URL: https://codereview.chromium.org/272323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269916 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370412
TEST=
1. open virtual keyboard in google.com
2. virtual keyboard window should have the default shadow

Review URL: https://codereview.chromium.org/280273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269915 0039d316-1c4b-4281-b951-d872f2087c98

Make command buffer generator infer GL array element type from the GL
prototype. Before, it was written in the function info specification.

This would simplify the usage if PUT functions that have two pointer
types would ever be supported.

BUG=344330

Review URL: https://codereview.chromium.org/272953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269914 0039d316-1c4b-4281-b951-d872f2087c98

So that https://codereview.chromium.org/284663003 can be CQ'd.

TBR=iannucci@chromium.org
BUG=372451

Review URL: https://codereview.chromium.org/281673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269913 0039d316-1c4b-4281-b951-d872f2087c98

This provides non-const didLoadingProgress() implementations for WebMediaPlayer subclasses in Chromium so that the interface can switch to being non-const. It also removes the const specifier from DidLoadingProgress() implementations (Pipeline and DemuxerHost) and the mutable specifier for their associated properties.

This is the first of three changes; the second is
https://codereview.chromium.org/272223004.

BUG=360251

Review URL: https://codereview.chromium.org/275303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269910 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=372585

Review URL: https://codereview.chromium.org/276563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269909 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:369679
BUG=chromium:368815
TEST=Tested manually on daisy

Review URL: https://codereview.chromium.org/278433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269908 0039d316-1c4b-4281-b951-d872f2087c98

Also implements TestURLFetcher::SaveResponseToTemporaryFile(),
and explicitly allows ScopedIO in TestURLFetcher, as it doesn't support
asynchronous IO by design.

Note to tree sheriffs: this CL can break tests using FakeURLFetcherFactory.

BUG=366614
TEST=none

Review URL: https://codereview.chromium.org/253833006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269907 0039d316-1c4b-4281-b951-d872f2087c98

For now we disable most baseline policy unittests under *SAN, until
we make the policy work with them.

BUG=372445
TBR=earthdok

Review URL: https://codereview.chromium.org/283643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269905 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/275223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269904 0039d316-1c4b-4281-b951-d872f2087c98

The case of a non-existing image file should be treated as an ordinary error case, just as a garbled JPEG image would be.

Update comment for UserImageLoader::Start() accordingly.

(The current behaviour breaks out/Debug/chrome (no parameters) compiled with chromeos=1.)

BUG=371295

Review URL: https://codereview.chromium.org/264483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269903 0039d316-1c4b-4281-b951-d872f2087c98

Major regression in chrome-si/initializers. Reverting for now to fix.

> linux_aura: Compile ash into chrome.
> 
> Running chrome with the "--open-ash" parameter will create an ash
> desktop window. Ash on Linux has some problems, but at least we're now
> compiling the code into the binary.
> 
> TODO: The applist isn't positioned correctly, and some details of the
> system tray aren't correct.
> 
> BUG=300084, 303862
> R=sky@chromium.org
> 
> Review URL: https://codereview.chromium.org/25108005

TBR=erg@chromium.org

Review URL: https://codereview.chromium.org/276773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269902 0039d316-1c4b-4281-b951-d872f2087c98

In order to avoid passing around ownership of SQS, expose default ctor,
and remove all function that returns scoped_ptr of SQS, meaning Create
and Copy function. Alternative of Copy function is CopyFrom function
that is called on raw pointer.

This follows 265823015 and 271703003.

BUG=344962
TEST=cc_unittests

Review URL: https://codereview.chromium.org/271683004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269901 0039d316-1c4b-4281-b951-d872f2087c98

Without this, the net-internals prerendering tests fail when a cancel
that creates a PrerenderContents is replaced with one that does not.

BUG=372471

Review URL: https://codereview.chromium.org/286433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269900 0039d316-1c4b-4281-b951-d872f2087c98

Uses VariationsSeedSimulator to simulate incoming
variation seeds and log the results of simulation
in histograms, as well as the amount of time taken.

Makes VariationsService take a MetricsStateManager
parameter for creating the entropy provider.

BUG=281474,315807

Review URL: https://codereview.chromium.org/238443008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269899 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Make ContentViewRenderView::CompositeToBitmap not CompositeAndReadback. (https://codereview.chromium.org/270933002/)

Reason for revert:
This is possibly breaking android telemetry pixel tests as per https://code.google.com/p/chromium/issues/detail?id=372562

Original issue's description:
> Make ContentViewRenderView::CompositeToBitmap not CompositeAndReadback.
> 
> The CompositeAndReadback is going away, and this method is thought to
> be unused. Make the method just fail and return false.
> 
> R=aelias, tedchoc@chromium.org
> BUG=371592
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269448

TBR=aelias@chromium.org,tedchoc@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=371592

Review URL: https://codereview.chromium.org/286513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269894 0039d316-1c4b-4281-b951-d872f2087c98

Aura uses the locations of some ending events which weren't
being assigned locations in the TDGF. To use the unified GR
on Aura, we need these locations to be assigned correctly.

We use the location of the first pointer down when the gesture was
created a the location of the gestures created by the TDGF.

BUG=371875
TEST=TouchDispositionGestureFilterTest.*

Review URL: https://codereview.chromium.org/277373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269893 0039d316-1c4b-4281-b951-d872f2087c98

Running chrome with the "--open-ash" parameter will create an ash
desktop window. Ash on Linux has some problems, but at least we're now
compiling the code into the binary.

TODO: The applist isn't positioned correctly, and some details of the
system tray aren't correct.

BUG=300084, 303862
R=sky@chromium.org

Review URL: https://codereview.chromium.org/25108005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269892 0039d316-1c4b-4281-b951-d872f2087c98