- 03 Sep, 2019 40 commits
-
-
tby authored
The latency of the call to the Item Suggest API is too long, causing UI issues with results popping into the list. This CL moves the call to immediately after the launcher is opened into peeking state, giving a longer window for the call to complete. Bug: 959679 Change-Id: Idc10c56f3807ed9079ac8924fc49417b1d427d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772788Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#692923}
-
Kenneth Russell authored
This reverts commit b04bb574. Reason for revert: root cause of flaky tests believed fixed in https://chromium-review.googlesource.com/1783297 . Original change's description: > [Sheriff] Disable Flaky ContextLost Tests on Mac > > TBR=kbr@chromium.org > > Bug: 999327 > Change-Id: I28240c209f4599978e0be64376629e5be7cce0c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781641 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692610} TBR=kbr@chromium.org,jdoerrie@chromium.org Bug: 999327 Change-Id: Ib9971cdf5d8b0ef221b920ca5786b2ff3ecd6530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783482Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#692922}
-
Maksim Ivanov authored
Decrease the spacing between the title and the subtitle in the security token PIN dialog shown during SAML sign-in. To achieve this, remove the extra <p> element that was adding extra margin/padding. Also adjust accordingly the position of the PIN keyboard, so that the spacing between the subtitle and the PIN keyboard stays the same after this CL. Bug: 964069 Test: verify in DevTools that (1) distance between bottom edge of title and subtitle is 32dp, and (2) distance between bottom edge of subtitle and top edge of the PIN input field is 78dp Change-Id: I6fc9e073e100870755830a8011087ecd90d4a49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777865Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#692921}
-
Hiroshige Hayashizaki authored
To enable `spec.src.json` to specify (possibly nested) source contexts, this CL adds `source_context_list_schema` that represents source contexts from where subresource requests are sent, and how policies are delivered (by source contexts or subresource requests). This CL adds `source_context_list` field to each `test_expansion` entry, of which value is the key of `source_context_list_schema` to be used. This CL adds `source_context_schema` and `subresource_schema` that represent supported delivery types and subresources for each source context or subresource type. These are used: - To filter out test files for unsupported combinations of delivery types, source contexts and subresources. A part of the filtering was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1717535 and this CL re-adds it (in a different form of implementation). - To determine what delivery types should be used for `anotherPolicy` placeholder. After this CL, the generate.py generates `source_context_list` and `subresource_policy_deliveries` fields that are passed directly without coversion. Specifically, - The conversion from `classic-data-worker-fetch` to `classic-data-worker` + `fetch-request` in mixed-content-test-case.js is removed. - <iframe srcdoc>-related tests for `img-tag` referrer-policy tests are split into separate tests, and related code in referrer-policy-test-case.sub.js is removed. Instead, to support tests inside <iframe srcdoc>, this CL adds `referrerSource` calculation that can support <iframe srcdoc>s. This CL also changes the structure of generated file names. Now all files are generated under a dedicated directory `gen/`. This CL creates `test-case.sub.js` instead of modifying `referrer-policy-test-case.sub.js` etc., because: After this CL, I'll commit new generated test HTML files, incrementally in order to monitor potential regressions, Because thousands of files are modified, split, and renamed. During the incremental commits, `test-case.sub.js` is used by new generated tests while `referrer-policy-test-case.sub.js` etc. are still used by old tests. After all commits are done, `referrer-policy-test-case.sub.js` etc. will be removed. This CL renames subresource names, to make the names of subresources, source contexts and source context lists consistent. `test-case.sub.js` reflects renaming of JSON keys and values done in previous commits. - opt_in_method -> delivery_type/value https://chromium-review.googlesource.com/c/chromium/src/+/1717107 - delivery_method -> delivery_type https://chromium-review.googlesource.com/c/chromium/src/+/1716109 - referrer_policy -> delivery_value https://chromium-review.googlesource.com/c/chromium/src/+/1717592 - source_protocol -> source_scheme https://chromium-review.googlesource.com/c/chromium/src/+/1717115 https://chromium-review.googlesource.com/c/chromium/src/+/1718991 - target_protocol + origin -> origin https://chromium-review.googlesource.com/c/chromium/src/+/1717470 - Use shorter values for origin and redirection https://chromium-review.googlesource.com/c/chromium/src/+/1717475 - referrer_url -> expectation https://chromium-review.googlesource.com/c/chromium/src/+/1717319 - source context names https://chromium-review.googlesource.com/c/chromium/src/+/1777110 Bug: 906850 Change-Id: Ia6695081e5a93355c29fb1bdb7e89ba6b673261f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586548 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#692920}
-
Eric Roman authored
Bug: 859536 Change-Id: I3cba0cfe960917dd87eff238ea9d6a11e5dc88ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783662 Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#692919}
-
Simon authored
TBR=crouleau@chromium.org Bug: 10004604 Change-Id: I96dbddaa7a234768c451323acf6238389ed674c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782735Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#692918}
-
Scott Violet authored
ContentView is needed for events and all sorts of other fun stuff. BUG=none TEST=none Change-Id: Ia8d02f0e322c3051c91fb0e37c6f2890834edcf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783582Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#692917}
-
Chisoon Jeong authored
Correct parameter names with capital character which is old style. Add missing parameter name of a method. Change-Id: Ib70e84411215bd0a20e7cb2c91c45d3141c33034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772952Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#692916}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5198ea1a702a..f790aa521cc6 git log 5198ea1a702a..f790aa521cc6 --date=short --no-merges --format='%ad %ae %s' 2019-09-03 simonhatch@chromium.org Pinpoint - Need to add these git hash inputs for try jobs Created with: gclient setdep -r src/third_party/catapult@f790aa521cc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1000421 Change-Id: I25ec33deb24dd5d563fc859aa47e26b8131ad32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783618Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692915}
-
John Lee authored
Bug: 989131 Change-Id: I91eae8668ef23531ba87c6fd97bfadf89b1b1f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779462 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#692914}
-
Michael Montvelishsky authored
It's not verbose, but would be a great help in narrowing down low level audio issues. Change-Id: Id84bc9894b554dab443a5a017cec1ef888418e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783718Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Michael Montvelishsky <mont@chromium.org> Auto-Submit: Michael Montvelishsky <mont@chromium.org> Cr-Commit-Position: refs/heads/master@{#692913}
-
Kurt Horimoto authored
The share menu requires JavaScript execution to capture the page's canonical URL, but script execution is halted when JavaScript dialogs are running. This CL adds LocationBarMediator as an OverlayPresenterObserver and disables the button when a overlays are displayed in OverlayModality::kWebContentArea. To accomplish this, the mediator needs access to the OverlayPresenter at that modality, which requires plumbing the Browser object through BVC to the LocationBarCoordinator. Bug: 987247 Change-Id: Ifccd68ae283e27c609e2204795be54cd0500516b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742889 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#692912}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/050b124d7838..feb8507f4b52 git log 050b124d7838..feb8507f4b52 --date=short --no-merges --format='%ad %ae %s' 2019-09-03 lujc@google.com Use VertexArrayID in place of GLuint handle Created with: gclient setdep -r src/third_party/angle@feb8507f4b52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: I461cd87c64eb32e04c17a8cdf16b73fef0faedce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783424Reviewed-by:
-
Christopher Thompson authored
This maps U+05D7 (ח) to lowercase Latin n and adds a test domain and test case for the mapping. Bug: 760855 Change-Id: I67f532b32785caba7aa1c7d497fdfd20b4820a56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780950Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#692910}
-
Xing Liu authored
This CL adds a life cycle metrics for scheduled notification. Tracked when notification is scheduled, shown, or deleted due to any reasons. Bug: 963298 Change-Id: Ibeb434ccc8b0b584cae54e829f6a56b5c878c3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773224 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#692909}
-
Antonio Gomes authored
This is a reland of 880ea642. This CL has no changes compared to the original one. The error was on CL https://crrev.com/c/1778671 (already relanded in https://crrev.com/c/1782514). Original change's description: > Move moar content::kWebRtcHWH* definitions to Blink > > Particularly, this CL moves the features definitions needed by > content/renderer/media/webrtc/rtc_video_encoder_factory.cc, > so that it can be moved to Blink in a later step. > > This CL is a precursor CL for phase 2.3 on the design document [1]. > > [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ > > BUG=787254 > R=guidou@chromium.org, haraken@chromium.org, thestig@chromium.org > > Change-Id: If68e934449c0b34235b82d2b605c62cd13d84b3d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778672 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692760} TBR=guidou@chromium.org Bug: 787254 Change-Id: I5e41c8f0546e175bbd1493d73e2e35c8286e1407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783301Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#692908}
-
Renjie Tang authored
Change-Id: I25775a3f2d7dfbde1661a4684851804714aeeefc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780914Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#692907}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb6fc83a0777..2a9114f34ad3 Created with: gclient setdep -r src-internal@2a9114f34ad3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I18851fc48a6ade9bbc38350accd95b98e74434a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783422Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692906}
-
Daniel Campello authored
Update notification strings to reference Dell BUG=b:126320709,b:131430497,b:131430518,chromium:991348,b:131430439,b:135125356,b:135126154,b:135127177 Change-Id: I06e6db813574bbebb82fd3acb765a4bd03d239ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783697 Commit-Queue: Daniel Campello <campello@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#692905}
-
Xiyuan Xia authored
Replace LayoutShelf() with animated UpdateBoundsAndOpacity() to fix the shelf autohide animation regression when overview animation finishes. Bug: 998031 Change-Id: Ied772044b19f667ee7a536bfcf6a3cf8311c32a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783480Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#692904}
-
Ovidio Henriquez authored
This change fixes a null pointer dereference crash that was introduced when getAvailability() was added to Web Bluetooth. The ExecutionContext* is not checked if not null before attempting to use it to check if the context is secure. Bug: 1000332 Change-Id: I0d9339f5cbc9435f9cbfc204b9fcbbdc954f6c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780129Reviewed-by:
Doug Turner <dougt@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#692903}
-
Natalie Chouinard authored
TBR=fgorski@chromium.org Bug: 1000437 Change-Id: Ide413a4756b209c9ca4b868949ee721df7110ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783484Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#692902}
-
Richard Knoll authored
UKM collection review doc (Google-only): https://docs.google.com/document/d/1XzUyVw9ZUi748P_d4ZUAa0vljYFN3OvfdI_dFuJ3ews/ Bug: 994194 Change-Id: I611bb8241fdbd90234c7189760c2c58b237ca4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755915 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#692901}
-
Max Li authored
Bug: 987872 Change-Id: Iee4f06fee212711a0742d0160f8271af703e0a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756720 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Max Li <themaxli@chromium.org> Cr-Commit-Position: refs/heads/master@{#692900}
-
Matt Jones authored
Bug: 901952 Change-Id: Iff78336a8ee670dd344f174722075d3abd8f1bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782668Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#692899}
-
Matt Jones authored
While this experiment introduced polish by way of smooth progress bar animation, we incur a performance hit due to a higher number of view invalidations/redraws. This patch removes the experiment flags and the related code. Bug: 759799 Change-Id: Ie9842f55ff23088e60c31a168b7c8fb59b3c2663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782665Reviewed-by:
-
Natalie Chouinard authored
Stop using ALL CAPS for any alert dialogs in Settings by switching to the base AlertDialog theme. Bug: 996293 Change-Id: I11724de5cdcfe7833387a0370accf0de53b551ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782988Reviewed-by:
-
Roman Sorokin authored
Looks like original redirect was removed (cl/181760069) Bug: none Test: manual Change-Id: Ie9c12d102e73989ee4cc32e05a0a8c5f2d174d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774444 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Martin Kreichgauer authored
This adds a delete button to the list of enrolled fingerprints shown in the fingerprint management dialog that can be accessed from the security keys settings subpage. Bug: 974046 Change-Id: I4ecdda5e571588fdafca70bf1a0c7491a97df7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767491 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#692895}
-
Nina Satragno authored
When the user taps an authenticator on a resident credential request, the active authenticators are cancelled. This means if they click the back arrow on the PIN entry or the confirmation sheets, there is no way to retry the request. This patch ensures we call StartOver() for the cases when the authenticators have been cancelled. This way, the authenticators become functional again. Bug: 1000347 Change-Id: I49aaecd5408b179eb54a1adcecc2221be83576ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783081 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#692894}
-
Theresa Wellington authored
BUG=1000315 TBR=wylieb@chromium.org Change-Id: Ib2a8aca97d828e96d218739c8bcdd0768e7dbc1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782991Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#692893}
-
Yasmin authored
The missing dependency is blocking https://chromium-review.googlesource.com/c/chromium/src/+/1778542. Bug: 988461 Change-Id: I29942ff384bec6f4256abe4552f5f735cc97a7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782803 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#692892}
-
tby authored
The SearchController constructs the SearchResultRanker, and passes it a piece of global state, a service_manager::Connector. This makes testing the SearchController nearly impossible because that state doesn't exist in tests. This CL refactors the SearchController to take that state as an argument to InitializeRankers, so that it can be faked for testing. Note: this CL fixes an issue where one of our tests will break in a debug build under a particular configuration of experiment flag default values. Bug: 931149 Change-Id: Ibbbdfa2589cd87f91d154417bbf914adc3f16466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732112 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
-
James Forshaw authored
This CL changes the StartupInformationTest.InheritStdOut test so that it should no longer be flaky. As an added bonus as it no longer runs code inside a child process it's always significantly faster to execute. Bug: 996357 Change-Id: I904a00dab629c2bb3d47bc9a82fe4423b97f5870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768895 Commit-Queue: James Forshaw <forshaw@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#692890}
-
Sergey Ulanov authored
This is a reland of 74c69a75 Original change's description: > [Fuchsia] Handle VULKAN feature flag in WebEngine > > Now WebEngine will enable Vulkan only when ContextFeatureFlags::VULKAN > is specified for web::Context. Also Context process now explicitly > disables hardware-accelerated compositing when VULKAN is not enabled > (otherwise it restarts the GPU process several times before it falls > back to software compositing). > > Bug: 962617, fuchsia:35009 > Change-Id: I74a463a1514df99134d929981fe44151c1d9dd17 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774967 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691856} TBR: backer@chromium.org Bug: 962617, fuchsia:35009 Change-Id: Ia284d035deb396c57684ef069d54ddb9b7d5b15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779064 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#692889}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/24a3df72b959..8df216c09227 git log 24a3df72b959..8df216c09227 --date=short --no-merges --format='%ad %ae %s' 2019-09-03 vapier@chromium.org import builtins from six.moves Created with: gclient setdep -r src/third_party/chromite@8df216c09227 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ifeaa19cc8e3e5127beb53324c8e8867dfe50fb1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782760Reviewed-by:
-
Andrew Xu authored
Move the code block that updates the layout strategy of OverflowBubble- View from CalculatePreferredSize to Layout. It makes preparations for landing the CL of focus rings for OverflowBubbleView Bug: 918024 Change-Id: I1a032e21d1a7b0fe307d62da9d94e7fa7fe3395b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783479Reviewed-by:
-
Mehran Mahmoudi authored
This removes touchless-specific code from the AddToHomescreen, which is required for the AddToHomescreen refactoring (More info in the bug). Bug: 994759 Change-Id: Ic74720cceb140ab58f32cea809848e30d663f57d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781774Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#692886}
-
Robert Ogden authored
Bug: 1000431 Change-Id: I384efcd3fc30de6723bdaf777763b4bfb4291695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783111Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#692885}
-
Dan Harrington authored
This has been verified to work with the updated server. Bug: 984787 Change-Id: Ie65f593fa885e759f62550fa53f53d2370124cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782972Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#692884}
-
