- 20 Aug, 2019 14 commits
-
-
Jinsuk Kim authored
https://crrev.com/c/1703624 moved the initialization of NavigationHandler in SwipeRefreshHandler from |start| to initWebContents/onViewAttached. It now is possible that start/pull/release from content layer see nulled-out NavigationHandler if the gesture navigation feature is disabled. Null checks are added to prevent the reported crash. Bug: 995204 Change-Id: If5ad85d71a303e203c8f6fd4df00f603eb77261c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760831Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#688351}
-
Michael Crouse authored
This change adds a dictionary pref to record the hosts that a successful hints fetch request was made, regardless if a hint was returned in the response. This will be used to determine the client-side coverage for the hosts navigated to be the client by the TopHostProvider and the HintsFetcher. The next change will add a UMA metric to record whether the host for each navigation is in the dictionary pref. Bug: 994931 Change-Id: I6c759ac568b04dbc0bb4ea90a307c10f859cd55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759209 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#688350}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/35b0708074d1..5817e8e9b288 git log 35b0708074d1..5817e8e9b288 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 ssid@google.com Merge "Add chrome version code to metadata" Created with: gclient setdep -r src/third_party/perfetto@5817e8e9b288 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Iab4425135729a4807541115e6d8135b184dc542e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761418Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688349}
-
Ramya Nagarajan authored
Bug: 986504 Change-Id: I3a7f449038173d97d413eabe214886e0b213f2c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761065Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#688348}
-
Daniel Cheng authored
This reverts commit 3c1f7d52. Reason for revert: causing a number of non-trivial perf regressions Bug: 994174, 994630 Original change's description: > Refactor VectorBuffer to use CheckedIterators. > > Currently VectorBuffer allows the access of buffer[size]. This is > because callers are using buffer[size] to get buffer.end(). In order to > avoid this, use CheckedRandomAccessIterators in VectorBuffer. This > required creating iterator versions for the DestructRange and MoveRange > functions. > > CheckedIterator's behavior now depends on the enable_checked_iterators > buildflag: when true, CheckedIterator will CHECK on spatial safety > violations; when false, CheckedIterator will merely DCHECK. This is > temporary, so that binary size regressions on Android can be studied > and explained: the eventual goal is to enable this universally and > remove the buildflag. > > BUG=chromium:817982 > > Change-Id: I2037bdb542c4442011fc9ebffdc50e50ccfafa7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674746 > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685387} TBR=palmer@chromium.org,dcheng@chromium.org,wez@chromium.org,gabimelchior@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:817982 Change-Id: I35d48a94d0f36b0c4cbd5cad6e4f5b12dc19afb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761338Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#688347}
-
James Cook authored
OS settings uses G Grey 700, weight 500, different spacing, and no border under the title. http://screen/61xziJEyQqx Bug: 994790 Change-Id: I71346581fcfb66da3a773f89c664544393472625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761066 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#688346}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/199e517c52c6..caaa058f628b git log 199e517c52c6..caaa058f628b --date=short --no-merges --format='%ad %ae %s' 2019-08-19 dhanyaganesh@chromium.org lib/git: Print Cmd everytime we push to branch Created with: gclient setdep -r src/third_party/chromite@caaa058f628b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I9590d2833c34dfc66f13636c6886dddb07d4c770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761416Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688345}
-
Will Harris authored
In the case where an approved DLL is being loaded, there is no point trying to create the section in the target process, because it will just fail. In this case, just call straight into the broker for the section to be created there. This also fixes issue 993450 as it causes the second call to NtCreateSection during the LoadLibrary of the chrome DLL to always be sent via the intercept to the broker. BUG=995338,993450 Change-Id: Ife7c8c6e1b8c43495e2b69baedbb1096b58a94a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759896Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#688344}
-
Esmael El-Moslimany authored
scrollHeight is 1px and another when the scrollHeight is more than 1px Also fixed the following edge case. 1. Two tabs are open with chrome://settings. 2. The background tab has not been viewed. 3. In the active tab, cycle through the on startup radios. 4. Then choose "continue where you left off". 5. Make the background tab active. 6. Change the on startup setting to show the specific pages list. The issue is the iron-list render code is running when the physical height is 1px. Initially the iron-list has zero physical items. It creates a minimum default of 3 physical items. After the render is completed, the scrollHeight is updated to the correct value and more physical items need to be created. This is done with a second iron-resize. Bug: 987893 Change-Id: I3a638ed8320e776a65a5b3b783514cdfecb47419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758219 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#688343}
-
Kai Ninomiya authored
This allows us to write expectations for tests, instead of having to modify the tests themselves (e.g. by removing a line from cts.html). I forgot I could do this in the original patch. Also fixes commit-queue.cfg to trigger Dawn CQ bots on appropriate files. Bug: 984818 Change-Id: I16e708c35209137266982da1107c1f34ff72026e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759393Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#688342}
-
Kyle Milka authored
Not launching. Bug: None Change-Id: I546fa7cabbbc1909eb1d690ffae8cef56f8a31eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759185Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#688341}
-
Changwan Ryu authored
We would like to publish system webview shell automatically such that WPT test can use it. Note that this is CI bot and we do not build per commit. Also, system webview shell is a very useful utility by itself. Once this lands, it will be packed into chrome-android.zip in one of the subdirectories here: https://commondatastorage.googleapis.com/chromium-browser-snapshots/ index.html?prefix=Android/ The APK size is 1.5 MB. The current chrome-android.zip is about 80 MB, so this will hopefully not increase the zip file too much. Bug: 993112 Change-Id: If35038968bdb52b2ed23086b0d9d7b75fa3c8906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761234Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#688340}
-
Adam Langley authored
This change isn't intended to have any semantic effect but adds infrastructure for a caBLE v2 handshake based around Noise NNpsk0. The implementation has been run against the Noise Explorer implementation[1] to confirm that it matches the spec. [1] https://noiseexplorer.com/patterns/NNpsk0/ Change-Id: Iff92bcddfb5b4d07280ef4df5331e471d18bdd18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752936 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#688339}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ic20ec56f1e3eea9e5e12c48aa62a4b5750b07527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700858Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688338}
-
- 19 Aug, 2019 26 commits
-
-
Scott Violet authored
This better indicates that they actually run with layout-ng disabled. BUG=none TEST=none Change-Id: I3b6d916fb1657e3f51fabe106137475c836a347d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754528Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#688337}
-
Xing Liu authored
This CL removes the sorting for impressions. Also move the logic that prunes expired impressions to the point when the database is just initialized. This can save APK size by 4000 bytes according to diagnose_bloat.py. Resource Sizes Diff: Specifics: -4,096 bytes main lib size -4,002 bytes normalized apk size InstallSize: -4,098 bytes APK size -4,098 bytes Estimated installed size (Android Go) -4,098 bytes Estimated installed size InstallBreakdown (-4,098 bytes): -4,096 bytes Native code size -2 bytes Package metadata size Bug: 972191 Change-Id: Ic6f2e971fb12de5c3b5affabd11c26b4512ea170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761331Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688336}
-
Kenneth Russell authored
This reverts commit b3c8de73. Reason for revert: broke ANGLE CQ, e.g.: https://ci.chromium.org/p/chromium/builders/ci/Win7%20FYI%20dEQP%20Release%20%28AMD%29/58198?blamelist=1#blamelist-tab https://ci.chromium.org/p/chromium/builders/try/win-angle-deqp-rel-32/328 Original change's description: > [base] Ensure that tests don't change the process priority (reland). > > The original CL > https://chromium-review.googlesource.com/c/chromium/src/+/1679434 > was reverted because of failures on test end on Mac OS 10.11. > This CL simply disables that check on Mac, so we can benefit from > process priority check on other platforms ASAP. > See diff: > https://chromium-review.googlesource.com/c/chromium/src/+/1760873/2..3/base/test/test_suite.cc > > This CL verifies that a test process is not backgrounded when it is > launched and before/after each test. The goal is to avoid having tests > that assume they run at normal priority be disabled because of other > misbehaving tests (e.g. https://crbug.com/931721). > > Bug: 931721 > Change-Id: Ib60d728c960f84026c84f24395d38847c1941573 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760873 > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Auto-Submit: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688201} TBR=gab@chromium.org,fdoray@chromium.org Change-Id: I8b7bf8c348390c774eda6943609244b1f87f49b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761517Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688335}
-
Adrienne Walker authored
Bug: 995481 Change-Id: I9a63542e9c6958a97a121bfea9b902c5f258f3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761335Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#688334}
-
Gang Wu authored
Bug: 995375 Change-Id: I021e31b1006bc1fb759d1a5a83e70f7097545686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761191 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#688333}
-
Michael Thiessen authored
This was a holdover from Document Mode, and no longer used. Change-Id: I13a2c72ca21eb8428bf78a620aa7425c0d083910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758658 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#688332}
-
Justin Cohen authored
On iOS 12 airplane mode back/forward navigations between restored session entries are same-document navigattions and were not triggering onload() or onpopstate() redirect to the actual target URL. As a workaround a reload is triggered. It appears this work-around isn't necessary on iOS13. TEST=Visit techmeme, wikipedia + a few articles, tab grid, close all, restore, airplane mode, back to tab, tap back to beginning. Bug: 995363 Change-Id: I0fcd6ad8ce5172b4808030c4cee0166289e6e22c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757298 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#688331}
-
Mohamed Heikal authored
After some extensive work with NativeBackgroundTask android as well as some additions with regards to servicification and reduced mode, adding new OWNERS to the chrome/android/java portion of background_task_scheduler. Since no OWNERS file existed previously also adding the OWNERS from components/background_task_scheduler/OWNERS Change-Id: Ibbba4a66d97f9afaeef70440fb75d845d92b4a56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761214 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#688330}
-
Jun Cai authored
This CL removes the duplicate C++ enums in the BluetoothScanningPromptAndroid and use the enums in BluetoothScanningPrompt. Bug: 994399 Change-Id: I038fe4b8346c5a1f04e045893704ec44d91dba9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758937Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#688329}
-
Kenneth Russell authored
This reverts commit 2b30b5a2. Reason for revert: broke ANGLE tryjobs, e.g. https://chromium-review.googlesource.com/1752334 . Original change's description: > Include tags for all GPUs in GPU integration tests' expectations. > > Update platform tags for gpu integration tests and webgl conformance integration tests > to include tags for all GPUs. > > Bug: 985486, 984780, angleproject:3701 > Change-Id: I17c3ad90e42e815b1aff26a1d202a0f63d6a2f81 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761193 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688268} TBR=kbr@chromium.org,dakshidnani@google.com Change-Id: Ief224046ed85e7dbfe0056074288bbb7e82445d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 985486, 984780, angleproject:3701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761610Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688328}
-
Xiaocheng Hu authored
Bug: 994488 Change-Id: I7d40a2a5faa0e030057c12119c1f0b2762bd091e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761397Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#688327}
-
Andrew Xu authored
Implement the gesture fling handler for ScrollableShelfView Bug: 973481 Change-Id: I1acee6b12cf8beeb55d637ceba1820e3cd088596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758596Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688326}
-
Wei-Yin Chen (陳威尹) authored
Bug: None Change-Id: I632edbdac0f9f40a6d34cf2efd9ffabb8b5a9ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761388 Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688325}
-
Hector Carmona authored
Bug: 993611 Change-Id: Ic55ad673343ace5faf48f7912ac5b615d0043d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751776Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#688324}
-
Ahmed Fakhry authored
This reverts commit 9cf67d23. Reason for revert: Causes a compile failure on linux-chromeos-google-rel BUG=995590 Original change's description: > [multi-profile]Speculative fix for crash while loading AppList search > > Either we are attempting to emplace() past the last element of the > vector, or the index is negative somehow. Fix the first condition and > check for the second. > > Bug: 992344 > Change-Id: Id3f6a71a9d5ab3ad41079f9ed1fa7067238faae8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761295 > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Reviewed-by: Matthew Mourgos <mmourgos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688279} TBR=newcomer@chromium.org,mmourgos@chromium.org Change-Id: I245a4b3c01aa86f5ba7178340647963b94a291f9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 992344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761345Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#688323}
-
Kenneth Russell authored
This was added in support of the Telemetry-based GPU tests and I should be able to review changes to this file and its header. Bug: 985486, 984780, angleproject:3701 Change-Id: Ib346b273b8e646b43747b081bf14002f3494be3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761159Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688322}
-
Ilia Samsonov authored
Added tests similar to TestLauncher unittests to run 3 simple content tests and validate the TestLauncher json result file. Common methods for validating resulting json file were moved to test_launcher_test_utils.h/cc. Bug: 936244 Change-Id: I8dee29f80f82ca5981f7343e9ffec4cacc95eeaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743099Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#688321}
-
Alice Boxhall authored
This fixes an issue which caused a crash, where a combination of re-creating a node and walking NextOnLine() caused a continuation to be set as the cached parent of an AXObject. When the actual node parent queried its children, the child for which the continuation was cached as a parent was reported as an "indirect" child, causing the child not to be properly cleaned up when moving in the DOM. Fixed by never allowing continuations to be non-ignored, or cached as parents. The test is a little unsatisfying as it's both not *guaranteed* to fail if the bug is present (though in my testing it always did), and it requires a series of reloads. I did spend a lot of time trying to find a better way, and failed. Bug: 989969 Change-Id: Ie268adb4679052443c4fe6ecea2149918147a1a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753378 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#688320}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9bf01811ac13..d41929adaddf git log 9bf01811ac13..d41929adaddf --date=short --no-merges --format='%ad %ae %s' 2019-08-19 thestig@chromium.org Split CPDF_CMapParser::ParseWord(). Created with: gclient setdep -r src/third_party/pdfium@d41929adaddf The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I03430b3fc9cb8786d33088d9bb659b5dfc00af36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761198Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688319}
-
Victor Vasiliev authored
R=csharrison@chromium.org base: :LazyInstance is officially deprecated Change-Id: I94f041f59362c44a9a2af15e05717899a0327dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761347Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#688318}
-
Marijn Kruisselbrink authored
I incorrectly assumed ProfileImpl was also used by incognito profiles, this fixes that assumption by also returning the correct permission context in OffTheRecordProfileImpl. Bug: 992516 Change-Id: Ia3286aa4d6903dc028a3839b36f00dac50cb2204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746837Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#688317}
-
Alison Maher authored
fast/css/forced-colors-mode/forced-colors-mode-12.html was detected as flaky. This tests animations in forced colors mode. Looking at other animation tests, it looks like the issue was that I needed to add "media="screen"" to the style element. Bug: 994465 Change-Id: I982343bf05e3aa4ac4df2caab0373103f5165cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758706Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#688316}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. CR+1 from all parties. NOPRESUBMIT=true Set due to folks in OWNERS files lacking permissions to LGTM. Bug: 977050 Change-Id: I3f82b04e138e65cd808670db46ab82a48dd580b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700855 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Michael Case <mikecase@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688315}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. CR+1 from all parties. NOPRESUBMIT=true Set due to folks in OWNERS files lacking permissions to LGTM. Bug: 977050 Change-Id: I17a6e403810ad7c2e1c011e561e7fce832ee541a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700912Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688314}
-
Charlene Yan authored
This mirror's MenuButton's implementation. Bug: 995182 Change-Id: I98f64d067980aed77a666fd8491c52b49d234da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760143 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#688313}
-
Alex Newcomer authored
Fix for a crash that occurs while the AppList is closing. We assume the layer exists, yet a few optimizations have been implemented which may result in layers being destroyed when they are no longer needed. Bug: 994409 Change-Id: I1d99f34c32e18ef70a3784b1e5337c1530cba872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761308 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#688312}
-