- 15 Jan, 2021 40 commits
-
-
Alice Wang authored
This CL creates SigninBridge for signin methods invoked by native code and moves openAccountManagementScreen() from SigninUtils to SigninBridge. The context from WindowAndroid is also used to open account management screen. Bug: 1165772 Change-Id: I7b28602d9a826d5291dfb0a4418142475001e2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624728 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#844055}
-
Mirko Bonadei authored
This reverts commit 99d693bc. Reason for revert: Looks like https://webrtc-review.googlesource.com/c/src/+/196903 was actually the culprit. Let's re-enable these tests. Original change's description: > Disable WebRTC browser tests on Android that prevent rolling. > > These tests fail before running due to https://crbug.com/1166107. > Running the tests on other platforms should be sufficient test coverage > until we figure out what the problem is. > > TBR=guidou@chromium.org > > Bug: chromium:1166107 > Change-Id: I49aeac8d2a43290eb3a23fd4aeb2f00f5c4379bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629308 > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843491} TBR=hbos@chromium.org,guidou@chromium.org,mbonadei@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: If05a9a289f8a41cd9c1c2f55405e2756e9429b6c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1166107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630685Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#844054}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610690109-4d1151c59ad39afee419f9fccf0374e5470965d9.profdata to chrome-linux-master-1610711423-18f006eac9d09987835ac3798b0f3a285cb6646c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icb30c044b5de61cfd67fe466806995658c2d5b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633165Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844053}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eaa61fcb0fb4..05149e977239 2021-01-15 tvanderlippe@chromium.org Remove ls from legacy-defs 2021-01-15 bmeurer@chromium.org Fix display of floating point values with scientific notations. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ied158c3bae98ea19e2e026e83dfdf401bbb040b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633146Reviewed-by:
-
Maksim Moskvitin authored
This CL puts content of invalidation_service_test_template into invalidation namespace (before global and "internal" namespace were used. It allows to avoid multiple "invalidation::" occurencies. Although test templates are not linked into prod code, it seems safe to keep them in invalidation namespace (and safer than keeping them in global namespace as before this CL). Bug: 1031125 Change-Id: I93543c33919b7f16a76ff33a3f1afce9690eb620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627860Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#844051}
-
David Van Cleve authored
AutoplayAllowedInIframe has been timing out on Linux; this CL disables the test on that platform. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=AutoplayExtensionBrowserTest.AutoplayAllowedInIframe R=rdevlin.cronin Bug: 1166927 Change-Id: I8812965c620729ccf3f1252dfa27358a224dc30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631406 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#844050}
-
Benoit L authored
This reverts commit 398eae2c. Reason for revert: The underlying issue has been fixed, re-enabling the test. Original change's description: > tools/perf: Disable rendering.mobile/microgame_fps on android pixel2 > > Change-Id: I4cfb20bd12e93c84bddb0ff7920e718c0fc03fc4 > No-Try: True > Tbr: wenbinzhang@google.com > Bug: 1166558 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626299 > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843462} TBR=eseckler@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1166558 Change-Id: I2df7afa204ef888d6bddd6340f979165e91ed501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632667Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#844049}
-
Benoit Lize authored
malloc() shims on Android work by wrapping symbols, which doesn't play well with component builds. This causes issues for developers, see linked bug. For details on the underlying reason, see https://docs.google.com/document/d/1qLqVXS9b99m04Sd0cWRaG8sEXfwulIfkRqSuhdYID_o/edit (Google-internal). Bug: 1166748 Change-Id: I8efc385d1e215ac78cbf07a605c477cb17b85a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631487 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#844048}
-
Andrey Zaytsev authored
Screenshot: https://screenshot.googleplex.com/4Nzb8xYfMfA8Xuk.png Mocks: https://docs.google.com/presentation/d/1_6jDegg169xJ5qgaABZ_wV3-Csd_OL5bf9H1NeUqS9Y/edit?pli=1#slide=id.gad295b4069_0_0 Bug: 1152351 Change-Id: I5ce89a47e48445bfb6f54db5c15f93fe47929433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605551Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#844047}
-
Aaron Leventhal authored
Before this CL, the following problems with parent traversal existed: 1. ComputeParent() was called many times before a parent was cached 2. It's technically possible for ComputeParent() to provide a different result than the object that added a child, although no known cases are identified, it's dangerous to have complex asymmetrical code. 3. Several methods such as Init(), UpdateCachedValueIfNeeded() and AddChildren() sometimes ended up reentering on the same object. This CL addresses these issues by: 1. Passing in the correct parent when a child is being added 2. Caching the parent when an object is initialized. Therefore ComputeParent() is only called once per object 3. Requiring that all non-root objects have a parent (DCHECK) 4. Do not allow Init(), UpdateCachedValueIfNeeded() or AddChildren() to reenter on the same object (DCHECK) In addition, the code is simplified by removing several parent-related methods that are no longer necessary, and by reducing the number of member variables related to ignored state. The ignored changes are from a previous CL that was reverted due to an incorrect assumption that a null parent meant that it was a first-time call to UpdateCachedValuesIfNeeded(). Clear improvements in a number of test results, including: - children-changed-only-on-ancestor.html (remove redundant events) - aria-owns-grid-expected.txt (now passes) - canvas-select-row-expected.txt (now passes) - 7.5% improvement in perf_tests for SendPendingAccessibilityEvents + ProcessDeferredAccessibilityEvents Bug: None Change-Id: I38478dca9e5c87645cbbfd35d8e4bbad6e29489a Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528573 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#844046}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/29eeb610bd49..5678b56f5e21 2021-01-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from fabc0b0b to 2ef9c5ff (556 revisions) 2021-01-15 syoussefi@chromium.org Vulkan: Generate gl_Position pre-rotation in SPIR-V If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I44ee0bfeed6d4faf6214b9120615cc3be46dfa92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632829Reviewed-by:
-
Christoph Schwering authored
This CL migrates the input and pattern base::string16 of autofill::MatchPattern() to base::StringPiece16. Bug: 1007974 Change-Id: I6c5c1b21ad39bc6317bbc51e1e5c3c4b24455aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628289 Commit-Queue: Matthias Körber <koerber@google.com> Auto-Submit: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#844044}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3abe4703fa62..eaa61fcb0fb4 2021-01-15 janscheffler@chromium.org [JSDOC2TS]: Migrate devices If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1158760 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9c96ddd9e160c3ba6d3eae335b6e260e879d759e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633065Reviewed-by:
-
Manuel Rego Casasnovas authored
The test paint/invalidation/outline/focus-ring-on-child-move.html has the same expectations for all platforms. Change-Id: I29bf9a55cd8034548e8ac2f312fa1a6c9e136a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631268Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#844042}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. AX-Relnotes: n/a. Bug: 1145565 Change-Id: Ide01818d784540cbb5302e7cfd1e98fbbeda175b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626183Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844041}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610679078-e6bf7486827a51823717a01d08f3ea1e32a813ef.profdata to chrome-win64-master-1610700976-d7ed4801f0bf655f1a5ed007c5aa96678f4cba28.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idff46878931b9499c5318e062c07ac4e77a5a60a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632828Reviewed-by:
-
Sanja Perisic authored
Added support for SystemDisabledMode policy for the Chrome Web Store, so that CWS can now be hidden if that is the preferred disabled mode. Bug: 1142785 Test: SystemFeaturesPolicyTest.DisableWebStoreAfterInstallWithModes Change-Id: I5cb731f6d071413f06563b19ea6ad365cb44c053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622375 Commit-Queue: Sanja Perisic <sanjaperisic@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844039}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f79e432021a1..428143ee24c5 2021-01-15 yyanagisawa@google.com Revert "Check whether goma is running when it is enabled" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1167064,chromium:868590 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ie275785c055678856f3c42e82fde84bf2a8bd8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632830Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f54810158ebb..f46e9e72306f 2021-01-15 perezju@google.com Remove experimental/long_term_health If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1060074 Tbr: oysteine@google.com Change-Id: I833e56d8a3af4b0167aad84ad8746375af9ad25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632826Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ibb45ef20ee6d1328a5fe9946f386bb07659ede50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632332Reviewed-by:
-
Mikel Astiz authored
The logic is behind a newly-introduced feature toggle: the idea is that bookmark commits to the server now contain a client tag hash, which is the hash of the bookmark's GUID. Populating this field is a simple change in BookmarkLocalChangesBuilder but additional sophistication is introduced to guard against in-flight commits and the time a user transitions from the feature being disabled to being enabled (which can theoretically run into duplicates). Note that the validation of the client tag hash for incoming updates is *NOT* behind a feature toggle, but that is believed to be non-controversial because there aren't many other options for defining the client tag for bookmarks. Bug: 1032052 Change-Id: I07448ad405849b29295c3090d3708d3a562e32e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623934Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#844035}
-
Frédéric Wang authored
SecurityOrigin::IsSecure() is very similar to the concept of "potentially trustworthy URL" defined in [1] and implemented by network::IsUrlPotentiallyTrustworthy(), but it has historically been hard to compare them. After previous refactoring they are quite close. This CL is yet another iteration. SecurityOrigin::IsSecure() is rewritten to use a similar implementation based on GURL and url::Origin. Spec comments are also added to make the difference more obvious. IsSecure() currently returns true if the URL scheme is in the secure list [2] or possibly one wrapped in a blob: or filesystem:. The constructor of url::Origin automatically unwraps this kind of URLs but is also more restrictive about accepted schemes [3]. In particular, about: and data: URLs or URLs with schemes registered as "secure" but not "standard" will now generate invalid origins. Special cases from network::IsUrlPotentiallyTrustworthy() are added to preserve behavior with about: and data: schemes, although some weird edge cases like "about:about" or "blob:about" are no longer treated as secure. Behavior for all standard secure schemes (including https, wss, quic-transport) are preserved. All these changes makes IsSecure() closer to the spec definition of "potentially trustworthy URL". The rest of the IsSecure() handles opaque and allowedlist origins, which is again just a subset of the work done by network::IsUrlPotentiallyTrustworthy() and can be rewritten accordingly. [1] https://w3c.github.io/webappsec-secure-contexts/#is-origin-trustworthy [2] https://source.chromium.org/chromium/chromium/src/+/master:url/url_util.cc;l=63;drc=65a062c4528790ff3651920ba9a3934df184e1bc [3] https://source.chromium.org/chromium/chromium/src/+/master:url/origin.cc;l=47;drc=721926d0cf09b42968ec8481792fcd6fa4edab7b Bug: 1153336 Change-Id: I8f4a42f89a9ae13016a20a1e242c1efd48874162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617709Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#844034}
-
Julie Jeongeun Kim authored
This CL refactors printing unit tests not to use OnMessageReceived since the printing legacy IPCs will be converted to mojo. It is a precursor of converting PrintHostMsg_DidStartPreview and PrintHostMsg_DidGetDefaultPageLayout. Bug: 1008939 Change-Id: I220076282c95e361d9ab3b8264dc0c754e4017db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615736Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#844033}
-
Clemens Arbesser authored
autofill_assistant:browser and its unittests should not depend on platform-specific stuff. Change-Id: I29c798130b0cbd171e87b47ccb3b8cbfceb9685e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631486 Auto-Submit: Clemens Arbesser <arbesser@google.com> Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#844032}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610679078-fe2bb289a257049a216843cebd228815ff771bd5.profdata to chrome-win32-master-1610690109-0f7956766f9641d6835b78b89edaf84f3a491ef2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9f9ff71006693aec5679616a931070bf7333bfdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632334Reviewed-by:
-
Titouan Rigoudy authored
Contrary to crrev.com/c/2627421, this did not need to make it into M89. Bug: chromium:1124358 Change-Id: Icfd9e4088286f7e8b5576e49c63bafa6c60bc5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628296 Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/091f5ac0a64c..f79e432021a1 2021-01-15 yyanagisawa@google.com Revert "Avoid capture_output to support Python 3.6" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1167064,chromium:868590 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: I0f4db8b68c0f22aba4e7dddee528ccb7f5739691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632825Reviewed-by:
-
Frédéric Wang authored
After previous refactoring, the body of SecurityOrigin::IsPotentiallyTrustworthy is essentially equivalent to network::IsOriginPotentiallyTrustworthy, except that it first DCHECKs the protocol is not "data" and handles opaque origins specially. This CL relies on network's method to implement SecurityOrigin's one in order to reduce code duplication. There should be no visible behavior change. Bug: 1153336 Change-Id: Ib88bd716174d4ac68c50bcc99a82fd2e51303b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615260Reviewed-by:
-
Yutaka Hirano authored
In order to fix crbug.com/1167013, we need to introduce a breaking change. Introduce a use counter to estimate the size of the impact. Bug: 1167014 Change-Id: I6f525aa8ec38fa1fa964f4ede3d1f55863d705d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631550 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844027}
-
Clemens Arbesser authored
Bug: b/176890422 Change-Id: I229923bf68af34376917a0def846cec0adff9183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627424 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#844026}
-
Asami Doi authored
The new test checks if `clients.matchAll()` can detect a blob URL worker client. The test passed when the PlzDedicatedWorker feature is enabled and fails when it is disabled. Bug: 1017034 Change-Id: Ib5b0916c2b9a4068b379769236bd0da2c6285a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629330 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#844025}
-
Francois Doray authored
[sheriff] Disable ExtensionInstallDialogViewInteractiveBrowserTest.InvokeUi_ManyPermissions on Windows for real. R=bsep@chromium.org Bug: 1166152 Change-Id: Id951f8454e6f15f2e7401bf92ab5590cd95c218b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626050 Auto-Submit: François Doray <fdoray@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#844024}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/d28e6c52e05e..cb31feffa500 2021-01-15 fabiansommer@chromium.org Enable saigo llvm regression tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106311 Tbr: mseaborn@chromium.org Change-Id: I51e1579a1af780afb801873266c45fa7e45f5600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631794Reviewed-by:
-
Benoit Lize authored
(v)asprintf() allocates internally, and is implemented by libc. This makes Chrome crash with PartitionAlloc on Android, since the allocated memory will be freed by PartitionAlloc even though it was not allocated by it. Implement (v)asprintf() ourselves, and wrap it. Bug: 1166558 Change-Id: I4b5ce4be55bd818a029009fa9eb37e123df7f2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629707 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#844022}
-
Martin Robinson authored
Instead of mapping the ARIA combobox role to other roles on MacOS, always use it unless it is applied to a multiline edit field. This matches the specified behavior and other browsers. These were originally mapped to other roles because of VoiceOver failures that have been fixed with other changes. Bug: 1125165 Change-Id: I26b8ccb006c15d6329da1c29193640f529fab781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611093Reviewed-by:
-
Alex Ilin authored
This CL adds an experiment parameter that allows to control after how many times user declined the profile switch bubble we stop showing the profile switch bubble. The parameter is called "max_profile_switch_declined_count". It can have the following values: - N < 0 - we always show the bubble when eligible - N == 0 - we never show the bubble - N > 0 - we stop showing the bubble after the user declines it N times Bug: 1166851 Change-Id: Ic165216a338a11d5730e582cd3c2045d107266f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630805Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844020}
-
Mihai Sardarescu authored
This CL ensures that GetStartupProfile() and GetStartupProfilePath() have the same behavior to return the Guest profile when the profile picker needs to be shown. This fixed the bug below as ProcessCommandLineAlreadyRunning() path uses GetStartupProfilePath while ChromeBrowserMainParts::PreMainMessageLoopRunImpl() was using GetStartupProfile(). Bug: 1166166 Change-Id: I53a363c87ae0957fdf35a197755979c33141c975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628990Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#844019}
-
Anastasiia N authored
Move `SigninHelper` class from chrome/browser/ui/webui/signin/inline_login_handler_chromeos.cc to chrome/browser/ui/webui/signin/signin_helper_chromeos.cc Bug: 1140469 Change-Id: Ia6c79410085240dc6c56e053ac595f9e3138d805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550546 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#844018}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/57654f96e343..3abe4703fa62 2021-01-15 szuend@chromium.org Revert "[module.json extensions] Migrate @ViewLocationResolver in elements/" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibefd6031050bd9d9fbe861f9b7f8141b7d6ef606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631791Reviewed-by:
-
Fredrik Söderqvist authored
Since the oBB is in unzoomed space but the <foreignObject> local-to-parent transform performs adjustment for zoom we need to perform correction when propagating it. Similarly change LayoutSVGForeignObject::StrokeBoundingBox() to return the same bounds as VisualRectInLocalSVGCoordinates() (which is zoomed). Bug: 1162993 Change-Id: I430cd7832b37475ef1d139997ef5ac5c0bcc17c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627491Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#844016}
-
