- 07 Nov, 2016 40 commits
-
-
eugenebut authored
finishHistoryNavigationFromEntry is not called anywhere externally. BUG=None Review-Url: https://codereview.chromium.org/2476363002 Cr-Commit-Position: refs/heads/master@{#430350}
-
piman authored
This can be used to keep the SurfaceFactory alive across CompositorFrameSink loss, to have its lifetime matchup better with the frame_sink_id_ registration, allowing further refactoring / simplification BUG=657959 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2475773005 Cr-Commit-Position: refs/heads/master@{#430349}
-
hiroshige authored
This CL replaces EventSender in HTMLLinkElement with postTask(): Instead of calling HTMLStyleElement::dispatchPendingLoadEvents() in Document::implicitClose() to enforce <style>'s onload events to be executed before the document's onload event, this CL blocks document's onload until <style>'s onload event using IncrementLoadEventDelayCount. This CL changes the timing of body onload, particularly causes some of the following events that were previously called AFTER document onload to be called BEFORE document onload: [A] The first layout. [B] Latter half of FrameLoader::finishedParsing(). [C] JavaScript function |f| scheduled as |setTimeout(f, 0)| in the <script> at the end of <body>. Notable test fixes (marked with the causes of failures): fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html: [A] Marked as flaky, because it depends on whether body onload is called before (Pass) or after (Failure) the first layout (crbug/651343). fast/scrolling/scrollbar-tickmarks-styled.html: [A] Fixed by https://codereview.chromium.org/2450793002. fast/scrolling/scrollbar-tickmarks-hittest.html: [A] Fixed by https://codereview.chromium.org/2484613003. virtual/rootlayerscrolls/fast/history/scroll-restoration/scroll-restoration-fragment-navigation-crossdoc.html: [B] Fixed by https://codereview.chromium.org/2467433002. svg/animations/animate-end-attribute-numeric-precision.html: [C] After this CL, calling executeTest() in svg/animations/script-tests/animate-end-attribute-numeric-precision.js causes sampleAnimation() to be called before document onload and test to fail. We set |animationStartsImmediately| true instead, in order to ensure the test is started in document onload. accessibility/inline-text-changes.html: [Race between the accessibility notification and document onload] Ignore the second call of the notification handler. Even before this CL, the notification is called multiple times, but the first notification terminated the test immediately by finishJSTest() because it is called after document onload. This CL makes the notification calls before document onload, and thus the test continues until document onload and we have to ignore the second call explicitly. fast/block/float/marquee-shrink-to-avoid-floats.html: The layout tree changes slightly, but it looks like acceptable because the image expectation matches. BUG=624697, 651343 Review-Url: https://codereview.chromium.org/2269043002 Cr-Commit-Position: refs/heads/master@{#430348} -
robliao authored
This brings desktop and Android default field trial testing support to iOS. Official builds, similar to desktop and Android, remain unaffected. As of this writing, the following variations are set by default with this change on iOS due to the field trial configuration: AutofillProfileCleanup:Enabled BrowserScheduler:Enabled PageRevisitInstrumentation:Enabled PasswordManagerSettingsMigration:Enable QUIC:Enabled TLS13Negotiation:Enabled TranslateRanker:EnforcementEnabled BUG=660554 Review-Url: https://codereview.chromium.org/2472753002 Cr-Commit-Position: refs/heads/master@{#430347}
-
meacer authored
BUG=594215 Review-Url: https://codereview.chromium.org/2476993002 Cr-Commit-Position: refs/heads/master@{#430346}
-
skyostil authored
BUG=662971 TBR=lanwei@chromium.org Review-Url: https://codereview.chromium.org/2481893002 Cr-Commit-Position: refs/heads/master@{#430345}
-
rtoy authored
https://codereview.chromium.org/2440583002/ missed a few places where the constant 128 was definitely referring to the render quantum size. Update the code to use kRenderQuantumFrames. BUG=657620 TEST=none Review-Url: https://codereview.chromium.org/2478283003 Cr-Commit-Position: refs/heads/master@{#430344}
-
shess authored
Some databases do not use the sql::MetaTable to handle versioning. The mmap verification pass uses the [meta] table to store progress for larger databases, and it uses detection of the [meta] table to distinguish new/empty databases from existing databases. For non-[meta] databases, store the status in an MmapStatus view. BUG=652359 Review-Url: https://codereview.chromium.org/2397753005 Cr-Commit-Position: refs/heads/master@{#430343}
-
dbeam authored
R=stevenjb@chromium.org BUG=none Review-Url: https://codereview.chromium.org/2472413003 Cr-Commit-Position: refs/heads/master@{#430342}
-
ryansturm authored
This tests the behavior of the SQL store backing previews opt outs and verifeis state is maintained correctly and errors are handled correctly. BUG=654464 Review-Url: https://codereview.chromium.org/2448313002 Cr-Commit-Position: refs/heads/master@{#430341}
-
rdevlin.cronin authored
Add an APIEventHandler that provides the ability to both create v8::Objects for extension API events (and provides the implementation for the event functions like hasListener()) and can dispatch events to specific contexts. Add specific event tests and update others to ensure it is wired in correctly. BUG=653596 Review-Url: https://codereview.chromium.org/2469593002 Cr-Commit-Position: refs/heads/master@{#430340}
-
rohitrao authored
BUG=656617 Review-Url: https://codereview.chromium.org/2477423002 Cr-Commit-Position: refs/heads/master@{#430339}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/18f26b66..5031a291 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2480363002 Cr-Commit-Position: refs/heads/master@{#430338}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/1e4a454317228d13d385b1065767946e70b90855 use_goma_module=True for nacl/sdk (tikuta@chromium.org) https://crrev.com/6739408c1342b8ed2f229325a80aafe6403b9fd1 Remove recipe for ozone_ecs (tikuta@chromium.org) https://crrev.com/c960819bf4e655ee80f821ffd230eda8077e6ae9 Dart: Use GN build on VM builders (whesse@google.com) https://crrev.com/40cec8a5d1de8c0a7f2659bb490b7309c0b64280 Revert "Dart: Use GN build on VM builders" (whesse@google.com) https://crrev.com/a4a0168ebf4bbdb6f1935ce352417558a7acb36d Updating perf recipe to upload legacy results as well as chartjson (eyaich@chromium.org) https://crrev.com/60d41cb475798dc075258ab0f3508c564589c092 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/33982e022c21a821bfa3e340bde30974e6ffa5fa Revert of Roll recipe dependencies (trivial). (patchset #1 id:1 of https://codereview.chromium.org/2477043003/ ) (agable@chromium.org) https://crrev.com/2f86b0f22c61d5f7ab15ed5c6accda5853cee36b Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/415fca33b55da747beb5c2b9b5999b5fca12853c Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/9c0d9a92ba7ed98478e66f750778c789ddc12768 Creating named directory for bisect test runs. (robertocn@chromium.org) https://crrev.com/8fd9dde8086d067ca8c6b9271aec9e61745edd32 use_goma_module=True for android emulator buildbot (tikuta@chromium.org) https://crrev.com/b527634f71f8bae30c9f5f1f9dcc500270d9eaaa use_goma_module=True for swarming buildbots (tikuta@chromium.org) https://crrev.com/52ebadfe0075133b1539c52bbb2c58511405d61c use_goma_module=True for chromium_codesearch buildbots (tikuta@chromium.org) https://crrev.com/a1af7ba20a24e1025a0b3fe44ec524137bd017db use_goma_module=True for android/builder buildbots (tikuta@chromium.org) https://crrev.com/dd5b78b68ea21f4f2f8a6b5fb91675f10f62fea6 Add option to not use compile.py in chromium recipe_module (tikuta@chromium.org) https://crrev.com/03b8919a338f141965d3320d4f60a22ae03085c9 use_goma_module=True for chromium_libfuzzer buildbots (tikuta@chromium.org) https://crrev.com/b78581e2d8b96f56424b901c3224b5268813b2f6 Stop supporting old Gerrit CQ tryjob properties. (tandrii@chromium.org) https://crrev.com/dcdd098c422f0faf3f1537dda52b325a14170d88 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/a403065c8e23d2ab53d9349519236f58a7250a52 Dart: Use GN build on VM builders (whesse@google.com) https://crrev.com/5251c5d4234940214b3e56626b91f896ac8f0d63 WebRTC: Replace Win32 Release with Win64 Debug in WebRTC FYI. (ehmaldonado@chromium.org) https://crrev.com/bb373a58224d53e35a9c6231ce7cbf999664a2ab [recipe_modules/test_result] Support uploading full json results format for upload_test_results.py (nednguyen@google.com) https://crrev.com/e21ee362bd0357572c633342ccd9dac6c49ff86c Change SwarmingIsolatedScriptTest to upload json format results (nednguyen@google.com) depot_tools: https://crrev.com/27b7a139de8ad92d094e6857807c02cb7fef5b74 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/e0b205e884ca787fb96c29799ac0260e6a07d84a Roll recipe dependencies (nontrivial). (recipe-roller@chromium.org) https://crrev.com/8c4faee3fa2bd4153a538228a59d0f8aa460e16a Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/39cec0e77bd8b70ee18cc3f47ebae9676e76c12f Disable coverage in depot_tools tests. (iannucci@chromium.org) https://crrev.com/a5025f62b8833c60f8421f465edb3538308eac7f Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/8c5a353e63ac55ace8f761478f085b3be5e65fc2 Implement and test git cl try for Gerrit. (tandrii@chromium.org) https://crrev.com/b8b5aaea9217f0a2e0b9a48bfa6e6fc054d74d23 fix swarmbucket infra path (nodir@chromium.org) https://crrev.com/3ac992bd93a00398ca0f1036ba349381a7aa3c3e Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/5da21889e50dd98d60db7dfe6aeb7fbb17f202ae Revert of fix swarmbucket infra path (patchset #3 id:40001 of https://codereview.chromium.org/2477033002/ ) (martiniss@chromium.org) https://crrev.com/dfe6bbbb22379ab9237e75597fd7244e56dd630c swarmbucket: git_cache must be in cwd (nodir@chromium.org) https://crrev.com/e4f0fe02a97d526b565fc13152436f6f165e05c6 fix git-cl-try without parameters (nodir@chromium.org) https://crrev.com/600d9dfd1a3a7a9b1ece14def1850eca4dc3f38d Roll recipe dependencies (trivial). (recipe-roller@chromium.org) recipe_engine: https://crrev.com/2ecaa8b5944f016f6bda5cbe93ec6f54e8ead4fb Delete tryserver_gerrit and its old properties. (tandrii@chromium.org) https://crrev.com/fabbc26432e0ba2e5492e01640722eb4641519c9 Add exit status proto (martiniss@chromium.org) https://crrev.com/2c474706779466f2e18e83a632f6d6debf63787f Fix issue overriding bug properties.test_api.tryserver for Gerrit. (tandrii@chromium.org) https://crrev.com/6b5af03500f8ab57a2905d11af2690de990961bd Remove unused --bootstrap-script option. (iannucci@chromium.org) https://crrev.com/0e5c8ab8680b51dfe55745ade2b26a7aa15e0f53 Add LogDog environment variables to whitelist. (dnj@chromium.org) https://crrev.com/6d04a2a25f68b37024e9d45ff32252e4d4903664 Revert of Delete tryserver_gerrit and its old properties. (patchset #1 id:1 of https://codereview.chromium.org/2464673002/ ) (martiniss@chromium.org) https://crrev.com/d6020a7ef29d3f7fb77d16a1cd6b32c7b2f09dc2 Delete tryserver_gerrit and its old properties. (tandrii@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2485543003 Cr-Commit-Position: refs/heads/master@{#430337}
-
sky authored
Revert of Restore maximized window position after detaching display. (patchset #2 id:20001 of https://codereview.chromium.org/2379063003/ ) Reason for revert: This resulted in a shortcut to move between monitors not working. See 656001. Original issue's description: > Restore maximized window position after detaching display. > > Sometimes Windows incorrectly changes bounds of maximized windows after > attaching or detaching additional displays. In this case user can see > non-client area of the window (that should be hidden in normal case). > > This workaround code restores window position if problem occurs. > > BUG=651449 > > Committed: https://crrev.com/6bb7f81927671c8616a89ad235d797159724cf09 > Cr-Commit-Position: refs/heads/master@{#424123} TBR=ananta@chromium.org,atimoxin@yandex-team.ru # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=651449 Review-Url: https://codereview.chromium.org/2484643003 Cr-Commit-Position: refs/heads/master@{#430336}
-
sadrul authored
The gfx::GpuMemoryBuffer implementations in the mus client lib do not do the right thing, and are not really necessary. Remove the code, and instead use the same implementation in gpu-client that content uses. The code is still not right: instead of getting memory buffer from the host, the code allocates shared memory on the client side. When returning memory, the code ignores the sync token. These issues will be fixed in future CLs. BUG=643746 Review-Url: https://codereview.chromium.org/2480023002 Cr-Commit-Position: refs/heads/master@{#430335}
-
kraush authored
Every method in DualControlLayoutTest is already tagged with TargetAPI JellyBean MR1. This change disabled one of the tests accordingly to not run on any devices prior to JellyBean MR 1. The other DualControlLayoutTest works fine. BUG=658263 Review-Url: https://codereview.chromium.org/2439083002 Cr-Commit-Position: refs/heads/master@{#430334}
-
sorin authored
This allows conveying more error information from the component installers to other layers of the component updater. Before this change, the component install execution path could only return one error. We are trying to understand the reasons why the component installers fail. BUG=615669 Committed: https://crrev.com/73769a84d74113a4a10e4152e63d219eb72f2630 Review-Url: https://codereview.chromium.org/2479633003 Cr-Original-Commit-Position: refs/heads/master@{#429995} Cr-Commit-Position: refs/heads/master@{#430333}
-
tedchoc authored
This was preventing bookmarks from appearing on the NTP. BUG= Review-Url: https://codereview.chromium.org/2485683002 Cr-Commit-Position: refs/heads/master@{#430332}
-
asvitkine authored
With this change, all files required to build chrome target on Mac have been migrated. This CL does not yet remove the include in base/metrics/histogram.h since files for other targets & platforms still need migration. BUG=416479 TBR=brettw@chromium.org Review-Url: https://codereview.chromium.org/2479093002 Cr-Commit-Position: refs/heads/master@{#430331}
-
rbyers authored
The only type of touch which now takes a user gesture is touchend/pointerup when it doesn't correspond to a touch scroll. Conceptually scrolling consume's the user's intent - no sensitive action should be triggered for the same gesture that does a scroll. For details see: https://docs.google.com/document/d/1oF1T3O7_E4t1PYHV6gyCwHxOi3ystm0eSL5xZu7nvOg/edit Intent to remove: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/gesture%7Csort:relevance/blink-dev/TO_x7FRkdmw/uCrOwufTCAAJ BUG=611981 Review-Url: https://codereview.chromium.org/2414273003 Cr-Commit-Position: refs/heads/master@{#430330}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/1c2ed9963fb8..67b39de70fb5 $ git log 1c2ed9963..67b39de70 --date=short --no-merges --format='%ad %ae %s' 2016-11-07 halcanary s/SkAutoTUnref/sk_sp/ in src/ part 1 2016-11-07 sylvestre.ledru Remove dead code in SkBitmapProcLegacyShader::ContextSize 2016-11-07 borenet Fix zero-padding in gerrit ref 2016-11-07 jvanverth Fix Vulkan command buffer assert on device lost 2016-11-07 halcanary fix android dm compile Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=scroggo@google.com Review-Url: https://codereview.chromium.org/2477373003 Cr-Commit-Position: refs/heads/master@{#430329}
-
scheib authored
Revert of Roll src/third_party/catapult/ 8ac279fd8..0adb6ef9b (1 commit). (patchset #1 id:1 of https://codereview.chromium.org/2477243003/ ) Reason for revert: Failed compile on official.desktop.continuous for win trunk https://bugs.chromium.org/p/chromium/issues/detail?id=662998 Link to Build: ------------- https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/49769 Link to Log Path: ------------------ https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/49769/steps/compile/logs/stdio Error log : FAILED: net_unittests.exe net_unittests.exe.pdb C:/b/depot_tools/python276_bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe /nologo /OUT:./net_unittests.exe /PDB:./net_unittests.exe.pdb @./net_unittests.exe.rsp c:\b\build\slave\win_trunk\build\src\v8\src\heap\mark-compact.cc(1278) : fatal error C1001: An internal error has occurred in the compiler. (compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 255) To work around this problem, try simplifying or changing the program near the locations listed above. Please choose the Technical Support command on the Visual C++ Help menu, or open the Technical Support help file for more information scheib@ could you please look into this. thank you Original issue's description: > Roll src/third_party/catapult/ 8ac279fd8..0adb6ef9b (1 commit). > > https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8ac279fd8db3..0adb6ef9b5dd > > $ git log 8ac279fd8..0adb6ef9b --date=short --no-merges --format='%ad %ae %s' > 2016-11-07 nednguyen [Telemetry] Remove the logic of killing stray adb processes > > BUG=656224 > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, see: > http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel > TBR=catapult-sheriff@chromium.org > > Committed: https://crrev.com/4711d631a805e410531fbba09e9c69278b2d17c0 > Cr-Commit-Position: refs/heads/master@{#430279} TBR=catapult-sheriff@chromium.org,catapult-deps-roller@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=656224 Review-Url: https://codereview.chromium.org/2484833002 Cr-Commit-Position: refs/heads/master@{#430328}
-
sky authored
Here's the specific case, and this only applies to the window manager: . Client other than WM creates window A. . Client adds A to the root At this point the WM knows about A via an OnWindowHierarchyChanged(). . Client removes A. . Client creates new window B. The WM doesn't know about B. . Client adds A to B. The WM still doesn't know about B, further the WM think's A's parent is null. . Client adds B to the root. This triggers an OnWindowHierarchyChanged() for the window manager with B and a parent of the root. Before the fix OnWindowHierarchyChanged() didn't contain A, so that the WM thought A still had no parent and would get confused later on if a OnWindowHierarchyChanged() was sent for A with a different parent. The fix is to make the last OnWindowHierarchyChanged() include A in the data parameter. This was uncovered in getting views to work with aura-mus. I've included test coverage of the case. BUG=660994 TEST=covered by test R=ben@chromium.org Review-Url: https://codereview.chromium.org/2472983004 Cr-Commit-Position: refs/heads/master@{#430327}
-
rsesek authored
BUG=606408 TEST=With WiFi turned on, go to https://maps.google.com, update current location, verify Net.WiFi histograms and AccessPointData. Review-Url: https://codereview.chromium.org/2472463002 Cr-Commit-Position: refs/heads/master@{#430326}
-
martijn authored
BUG= Review-Url: https://codereview.chromium.org/2483733003 Cr-Commit-Position: refs/heads/master@{#430325}
-
ellyjones authored
This was removed some weeks ago in an update to the Harmony spec, but the code was never updated to match. BUG=635176 Review-Url: https://codereview.chromium.org/2477333002 Cr-Commit-Position: refs/heads/master@{#430324}
-
wangxianzhu authored
TBR=pdr@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2477413002 Cr-Commit-Position: refs/heads/master@{#430323}
-
Krishna Govind authored
Cr-Commit-Position: refs/heads/master@{#430322} -
Matt Sarett authored
BUG=642462 R=scroggo@chromium.org Review URL: https://codereview.chromium.org/2482883002 . Cr-Commit-Position: refs/heads/master@{#430321}
-
skyostil authored
BUG=662959 TBR=perezju@chromium.org Review-Url: https://codereview.chromium.org/2484783002 Cr-Commit-Position: refs/heads/master@{#430320}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/470b5fa8f8db..9adabf886724 $ git log 470b5fa8f..9adabf886 --date=short --no-merges --format='%ad %ae %s' 2016-11-07 npm Revert of Compile fuzzer sources in standalone builds. (patchset #3 id:40001 of https://codereview.chromium.org/2480043002/ ) Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2477403002 Cr-Commit-Position: refs/heads/master@{#430319}
-
guidou authored
BUG=648183 Review-Url: https://codereview.chromium.org/2476153002 Cr-Commit-Position: refs/heads/master@{#430318}
-
boliu authored
The flake is probably due to the test server re-using the same url for different test pages. Changed so that each test page gets a new url. Then found out the test is still flaky because apparently onPageFinished doesn't mean blink has committed the new page so it's hit-testable. So also wait for the page commit signal. This replaces polling for title in the test. BUG=662078 Review-Url: https://codereview.chromium.org/2475163003 Cr-Commit-Position: refs/heads/master@{#430317}
-
estade authored
NativeScrollBar used to wrap NativeScrollBarViews, but it was almost entirely a pass-through shim. Thus, now we just have one layer of views scrollbars called ScrollBarViews. BUG=662605 Review-Url: https://codereview.chromium.org/2480763005 Cr-Commit-Position: refs/heads/master@{#430316}
-
sl.ostapenko authored
BUG=662534 Review-Url: https://codereview.chromium.org/2480763003 Cr-Commit-Position: refs/heads/master@{#430315}
-
sky authored
Revert of Don't apply maximized window bounds workaround if bounds aren't changed (patchset #1 id:1 of https://codereview.chromium.org/2454053004/ ) Reason for revert: This resulted in a shortcut to move between monitors not working. See 656001. Original issue's description: > Don't apply maximized window bounds workaround if bounds aren't changed > > In HWNDMessageHandler::OnWindowPosChanging() was added code that > restores correct maximized window's bounds after attaching or detaching > additional display (see crrev.com/6bb7f819). But this workaround also > applied if OnWindowPosChanging() was called with SWP_NOMOVE/SWP_NOSIZE > flags that leads to bugs such as crbug.com/659525 and crbug.com/655984. > > This CL adds additional check for SWP_NOMOVE/SWP_NOSIZE flags before > applying workaround and fixes this bugs. > > BUG=659525,655984 > > Committed: https://crrev.com/6279588b7ebc740f85409107dd91b5c3ce628065 > Cr-Commit-Position: refs/heads/master@{#428368} TBR=atimoxin@yandex-team.ru # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=659525,655984 Review-Url: https://codereview.chromium.org/2482933002 Cr-Commit-Position: refs/heads/master@{#430314}
-
rouslan authored
BUG=648051 Review-Url: https://codereview.chromium.org/2473053003 Cr-Commit-Position: refs/heads/master@{#430313}
-
riajiang authored
Reduce similar code in single-display screens. 1. ScreenBase doesn't set itself as the screen instance in display::Screen anymore, rather its subclass needs to decide if it wants to be the screen instance. 2. Moved Displays::iterator FindDisplayById(int64_t id); to private in DisplayList. 3. Fixed BlimpScreenTest since Display::SetScaleAndBounds also updates the work area of a display. 4. Fixed RenderWidgetHostViewAuraTest.PhysicalBackingSizeWithScale since added UpdateDisplay call in aura::TestScreen::SetDeviceScaleFactor. BUG=none, related to https://codereview.chromium.org/2361283002 TEST=covered by blimp_unittests, app_shell_unittests, content_unittests, unit_tests, mash_unittests, extensions_browsertests Review-Url: https://codereview.chromium.org/2431473002 Cr-Commit-Position: refs/heads/master@{#430312}
-
oshima authored
* If the raw device scale factor is lower than 1.0, shrink the font size further. BUG=646254 TEST=manual Review-Url: https://codereview.chromium.org/2441043002 Cr-Commit-Position: refs/heads/master@{#430311}
-
