- 25 Oct, 2018 40 commits
-
-
Avi Drissman authored
BUG=895514, 845389 Change-Id: I7e44184c8a88b3e905fe26fd131a4900969c8f48 Reviewed-on: https://chromium-review.googlesource.com/c/1287326 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#602916}
-
Josh Nohle authored
Currently, when a device is retrieved by CryptAuth, a boolean histogram "CryptAuth.DeviceSyncSoftwareFeaturesResult" logs "Success" for each feature that is supported and enabled, and logs "Failure" for each feature that is enabled but not supported. Here, we provide a more granular look into the latter case by adding another histogram, "CryptAuth.DeviceSyncSoftwareFeaturesResultFailures", that buckets each failure by feature type, i.e., by the enum cryptauth::SoftwareFeatures. This was tested manually; however, we could only get EASY_UNLOCK_HOST to be in a state where it was enabled but not supported. Bug: 896082 Change-Id: Ib4fae768f203d637caa87d0a9e0baa5bf596f515 Tested: Manual; added unit test Reviewed-on: https://chromium-review.googlesource.com/c/1297285Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#602915}
-
Katie D authored
This is still hidden behind the accessibility features flag. For more, see go/chromeos-dwell-design. Bug: 894907 Change-Id: I8566f2e46e3703c56ede43e6efa8f8b4cbd97abb Reviewed-on: https://chromium-review.googlesource.com/c/1297575Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#602914}
-
Liquan(Max) Gu authored
We need to report Last Image Paint to UKM and UMA. This CL uses mojo to send the metric from web performance (Blink) to the page load metrics (Browser). The browser then reports the metric to UKM and UMA. Bug: 869924 Change-Id: I680576ec2940558ed38910e2b4e2ff695a41ea30 Reviewed-on: https://chromium-review.googlesource.com/c/1298109Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602913}
-
Mason Freed authored
When running in single threaded mode, calls from OnBeginImplFrameDeadline() can make their way from the main thread to the impl thread, and then (erroneously) directly back to the main thread, causing a crash. See the stack trace below. With this CL, the call from viz::HostFrameSinkManager::OnFrameTokenChanged() is proxied back to the main thread for the call to content::DelegatedFrameHost::OnFrameTokenChanged(). A number of tests also call FrameSinkManagerImpl::SetLocalClient and/or surface_utils::ConnectWithLocalFrameSinkManager, and I did not want to change their existing behavior. So the additional task_runner parameter is defaulted to nullptr, and in that case the old behavior still applies - the call is not PostTasked. Example crash: [243567:243567:1023/120428.757147:FATAL:single_thread_proxy.cc(239)] Check failed: task_runner_provider_->IsMainThread(). #0 0x7f4d3b3bbccd base::debug::StackTrace::StackTrace() #1 0x7f4d3b0b8a2a base::debug::StackTrace::StackTrace() #2 0x7f4d3b12a59b logging::LogMessage::~LogMessage() #3 0x7f4d315b4e9b cc::SingleThreadProxy::SetNeedsCommit() #4 0x7f4d3149b8ef cc::LayerTreeHost::SetNeedsCommit() #5 0x7f4d312b28f1 cc::Layer::SetNeedsCommit() #6 0x7f4d312b8205 cc::Layer::SetBackgroundColor() #7 0x7f4d2cb5fd54 ui::Layer::SetColorFromAnimation() #8 0x7f4d2cb79024 ui::LayerAnimator::SetColor() #9 0x7f4d2cb56a5c ui::Layer::SetColor() #10 0x7f4d37f1b8a1 content::RenderWidgetHostViewAura::UpdateBackgroundColor() #11 0x7f4d37f2851e content::RenderWidgetHostViewBase::SetContentBackgroundColor() #12 0x7f4d37f222cb content::RenderWidgetHostViewAura::OnRenderFrameMetadataChangedAfterActivation() #13 0x7f4d37e81d5c content::RenderFrameMetadataProviderImpl::OnRenderFrameMetadataChangedAfterActivation() #14 0x7f4d37e8391f _ZN4base8internal13FunctorTraitsIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEvE6InvokeIS7_NS_7WeakPtrIS3_EEJS5_EEEvT_OT0_DpOT1_ #15 0x7f4d37e83805 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEENS_7WeakPtrIS5_EEJS7_EEEvOT_OT0_DpOT1_ #16 0x7f4d37e8377d _ZN4base8internal7InvokerINS0_9BindStateIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEJNS_7WeakPtrIS4_EES6_EEEFvvEE7RunImplIS8_NSt3__15tupleIJSA_S6_EEEJLm0ELm1EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #17 0x7f4d37e836f9 _ZN4base8internal7InvokerINS0_9BindStateIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEJNS_7WeakPtrIS4_EES6_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE #18 0x7f4d35ecd92e _ZNO4base12OnceCallbackIFvvEE3RunEv #19 0x7f4d37d2d8a3 content::FrameTokenMessageQueue::DidProcessFrame() #20 0x7f4d37ef17cd content::RenderWidgetHostImpl::DidProcessFrame() #21 0x7f4d37f2aeaa content::RenderWidgetHostViewBase::OnFrameTokenChangedForView() #22 0x7f4d3845b99f content::DelegatedFrameHostClientAura::OnFrameTokenChanged() #23 0x7f4d38483f90 content::DelegatedFrameHost::OnFrameTokenChanged() #24 0x7f4d1aaa7e8c viz::HostFrameSinkManager::OnFrameTokenChanged() #25 0x7f4d1b5b41dc viz::FrameSinkManagerImpl::OnFrameTokenChanged() #26 0x7f4d1b59594e viz::CompositorFrameSinkSupport::OnFrameTokenChanged() #27 0x7f4d1b61ab83 viz::Surface::ActivateFrame() #28 0x7f4d1b61920f viz::Surface::ActivatePendingFrame() #29 0x7f4d1b618f2a viz::Surface::OnSurfaceDependencyAdded() #30 0x7f4d1b62e241 viz::SurfaceDependencyTracker::OnSurfaceDependencyAdded() #31 0x7f4d1b6432ac viz::SurfaceManager::SurfaceDependencyAdded() #32 0x7f4d1b619b7f viz::Surface::UpdateActivationDependencies() #33 0x7f4d1b6194f3 viz::Surface::QueueFrame() #34 0x7f4d1b59a155 viz::CompositorFrameSinkSupport::MaybeSubmitCompositorFrameInternal() #35 0x7f4d1b598206 viz::CompositorFrameSinkSupport::MaybeSubmitCompositorFrame() #36 0x7f4d1b59801a viz::CompositorFrameSinkSupport::SubmitCompositorFrame() #37 0x7f4d1b5a4b08 viz::DirectLayerTreeFrameSink::SubmitCompositorFrame() #38 0x7f4d314d8e24 cc::LayerTreeHostImpl::DrawLayers() #39 0x7f4d315b8ee8 cc::SingleThreadProxy::DoComposite() #40 0x7f4d315bb087 cc::SingleThreadProxy::ScheduledActionDrawIfPossible() #41 0x7f4d3139c9b8 cc::Scheduler::DrawIfPossible() #42 0x7f4d31396581 cc::Scheduler::ProcessScheduledActions() #43 0x7f4d3139c7da cc::Scheduler::OnBeginImplFrameDeadline() #44 0x7f4d313a024d _ZN4base8internal13FunctorTraitsIMN2cc9SchedulerEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #45 0x7f4d313a0194 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN2cc9SchedulerEFvvEJPS5_EEEvOT_DpOT0_ #46 0x7f4d313a0145 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc9SchedulerEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #47 0x7f4d313a0089 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc9SchedulerEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #48 0x7f4d313a059e _ZNO4base12OnceCallbackIFvvEE3RunEv #49 0x7f4d313a0544 _ZN4base8internal22CancelableCallbackImplINS_12OnceCallbackIFvvEEEE11ForwardOnceIJEEEvDpT_ #50 0x7f4d3129de9f _ZN4base8internal13FunctorTraitsIMN2cc28ScrollbarAnimationControllerEFvvEvE6InvokeIS5_RKNS_7WeakPtrIS3_EEJEEEvT_OT0_DpOT1_ #51 0x7f4d3129de1a _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN2cc28ScrollbarAnimationControllerEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_ #52 0x7f4d3129ddb0 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc28ScrollbarAnimationControllerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #53 0x7f4d3137d0d9 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc12ResourcePoolEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #54 0x7f4d3b0683ee _ZNO4base12OnceCallbackIFvvEE3RunEv #55 0x7f4d3b0ba072 base::debug::TaskAnnotator::RunTask() #56 0x7f4d3b14f466 base::MessageLoop::RunTask() #57 0x7f4d3b14f7ee base::MessageLoop::DeferOrRunPendingTask() #58 0x7f4d3b14fc79 base::MessageLoop::DoWork() #59 0x7f4d3b1572b6 base::MessagePumpGlib::Run() #60 0x7f4d3b14eb5b base::MessageLoop::Run() #61 0x7f4d3b1fac6d base::RunLoop::Run() #62 0x7f4d372f8dfc content::BrowserMainLoop::MainMessageLoopRun() #63 0x7f4d372f8a52 content::BrowserMainLoop::RunMainMessageLoopParts() #64 0x7f4d37301050 content::BrowserMainRunnerImpl::Run() #65 0x0000018caad1 (anonymous namespace)::RunOneTest() #66 0x0000018ca696 (anonymous namespace)::RunTests() #67 0x0000018ca11d LayoutTestBrowserMain() #68 0x0000018c82c0 content::ShellMainDelegate::RunProcess() #69 0x7f4d39305d5a content::RunBrowserProcessMain() #70 0x7f4d39308bc7 content::ContentMainRunnerImpl::Run() #71 0x7f4d392feabc content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #72 0x7f4d13359c2a service_manager::Main() #73 0x7f4d393034b3 content::ContentMain() #74 0x00000075e165 main #75 0x7f4d13dcd2b1 __libc_start_main #76 0x00000075e02a _start Bug: 667551 Change-Id: Iab72ad842b4672f7c3e37060bd2085b2d8ce0803 Reviewed-on: https://chromium-review.googlesource.com/c/1297477Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#602912}
-
Chase Phillips authored
Also in this CL: - Add a :mojom_modules target to allow mojom files in this group to link against symbols that only exist in the modules layer. - Rename indexed*db_struct_traits* to _mojom_traits*. Bug: 717812 Change-Id: I85fa493b345bb6ab955316fe1725e4794ed4c99b Reviewed-on: https://chromium-review.googlesource.com/c/1265900 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602911}
-
Michael Giuffrida authored
Motivated by strings in chromium_strings.grd that use "Chrome": https://crrev.com/c/1294589 Bug: 897868 Change-Id: Ie90f92e67e8801f9e78bbdf478fa727b5fee3e22 Reviewed-on: https://chromium-review.googlesource.com/c/1294419Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602910}
-
Darren Shen authored
We're changing the keyboard tray action to toggle the virtual keyboard instead of always showing the virtual keyboard. Previously, we made it so that the VK hides when you interact with the shelf. So we also have to exclude the keyboard tray icon from this behaviour. Bug: 897672 Change-Id: I019f8acf2263a18a3f9248f232e51156c0b8a349 Reviewed-on: https://chromium-review.googlesource.com/c/1298513Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#602909}
-
Sergei Istomin authored
Added TestMediaMetadata for saving metadata observer and UpdateExternalMediaMetadata function for using in unittest (external_pipeline_control_unittests). Test: Unittests. Bug: internal b/117221273 Change-Id: I96266e1b5029ad8fbb5f3b0cf1252e3720f9c6f7 Reviewed-on: https://chromium-review.googlesource.com/c/1291772Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Sergei Istomin <sistomin@chromium.org> Cr-Commit-Position: refs/heads/master@{#602908}
-
erikchen authored
This allows Chromium developers to more easily distinguish between improvements that reduce start-up jank, and improvements that reduce non-startup jank. This CL removes the expiry from the Jank metrics as they are providing high utility for slow reports, and are being added as a heartbeat metric. Bug: 859155 Change-Id: Ida8bf44219717ba19c2eb13fefdec09d42f2569f Reviewed-on: https://chromium-review.googlesource.com/c/1299295 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#602907}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/02d100af0b2e..a9fb482b9859 git log 02d100af0b2e..a9fb482b9859 --date=short --no-merges --format='%ad %ae %s' 2018-10-25 bhthompson@google.com Make nocturne-paladin important Created with: gclient setdep -r src/third_party/chromite@a9fb482b9859 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Idd3c0d0182ffbccbe27490d96862eb54dfbc4614 Reviewed-on: https://chromium-review.googlesource.com/c/1299978Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602906}
-
Etienne Pierre-doray authored
Adds a meta-comment to thread_restrictions.h which coalesces all of the comments below. Change-Id: If02d9cd3403f18f46cb08f6f54298471c2765493 Reviewed-on: https://chromium-review.googlesource.com/c/1296684 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#602905}
-
Evan Stade authored
The test doesn't actually pass in Mash because of crbug.com/897260 but the test should pass once ImmersiveModeControllerAsh::OnWindowPropertyChanged is fixed. Bug: 897260 Change-Id: Ic5914a4c1b17ba49a899f3775be5b21b2f6e1cff Reviewed-on: https://chromium-review.googlesource.com/c/1297731Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Alexander Alekseev authored
1) Error-icon size set to 20 pixels. 2) Erorr-icon is displayed for errors only. 3) Error message centered vertically. Bug: 898721 Change-Id: Ifa1dcabbc0b8c8c0e5b6132268ed5c9c187ef21f Reviewed-on: https://chromium-review.googlesource.com/c/1298796Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#602903}
-
Esmael El-Moslimany authored
This functionality already exists in CrRadioButtonBehavior. https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_radio_button/cr_radio_button_behavior.js?l=19 Bug: 888922 Change-Id: Ie143f7605d858ea368be9ff7c3f876e05180739d Reviewed-on: https://chromium-review.googlesource.com/c/1298294Reviewed-by:
-
iOS Autoroller authored
TBR=smut Change-Id: I155114bba60788e0c8269181d305aae4492e383f Reviewed-on: https://chromium-review.googlesource.com/c/1299665Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#602901}
-
Wenzhao Zang authored
Bug: 896518 Change-Id: Ib6772296f96914fb8d2f6587c537d67afaffd72e Reviewed-on: https://chromium-review.googlesource.com/c/1294418Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#602900}
-
Robert Ogden authored
If the previews server responds with a bypass (307) and `chrome-proxy: host-blacklisted` then the original host should be blacklisted from previews for 30 days. This information is stored in prefs. Also adds a histogram to track whether or not a bypass is blacklisted. Bug: 864649 Change-Id: I42012e7ed3d2eb01d0233636ad8bac0202351946 Reviewed-on: https://chromium-review.googlesource.com/c/1297086Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#602899}
-
Yi Gu authored
This patch is similar to crrev.com/c/1289430. Previously the test was relying on worklet console log which might be racy on main. Using computed style is better and more compatible. Bug: 887659 Change-Id: I8060546f654b08642e7554c66dbd017574e3c7a5 Reviewed-on: https://chromium-review.googlesource.com/c/1297182Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602898}
-
Yue Cen authored
Bug: 898786 Change-Id: I83f38fb6c9a9471793f0faadaee619a9771eb7ce Reviewed-on: https://chromium-review.googlesource.com/c/1299521Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#602897}
-
Scott Chen authored
This CL makes the welcome_app check if the browser can be set as default, and hold off on initializing modules until we find out. Bug: 874122, 874255 Change-Id: I42e8427a200c717c2eacea04ad9932d15e65caba Reviewed-on: https://chromium-review.googlesource.com/c/1297283 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
-
Nico Weber authored
On the Windows bot, this step takes 20 minutes, half of it in the second half of the script where compare_deps() runs. The win whitelist contains 3 files with the same deps (which are virtually "all built files"), so we spend 10 minutes computing the same information 3 times. Cache it. On Mac, the step takes 25 minutes, and there we list almost all executables in the whitelist file, many also depending on virtually all files (performance_browser_tests, interactive_ui_tests, extensions_browsertests, ...). This should help the step on that bot as well. Bug: 314403 Change-Id: I3c0d5a62a3e430a031c6637516c070d9326ec7c5 Reviewed-on: https://chromium-review.googlesource.com/c/1300014Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#602895}
-
Ryan Hansberry authored
Create an enumerated histogram which emits an event each time a different page of the MultiDevice setup flow is opened. This allows us to determine user dropoff between subsequent pages. Bug: 898363 Change-Id: I7e56c0e3af71d7f78d6ef296cf1ab57e3dca5cf0 Reviewed-on: https://chromium-review.googlesource.com/c/1297456 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Ahmed Fakhry authored
Users of Chromevox may need to touch explore the webpage, and for things to remain consistent, we should disable hiding top-chrome with gesture scrolls as long as Chromevox is enabled. R=sky@chromium.org BUG=857331, 896514, 867063, 898502 TEST=Added a new browser test. Reviewed-on: https://chromium-review.googlesource.com/c/1284289Reviewed-by:
-
Kurt Horimoto authored
This CL enables the following flags: - BrowserContainerFullscreen - OutOfWebFullscreen Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ic3cf03cd8ba405d16799f39a72027d7744dabf5d Reviewed-on: https://chromium-review.googlesource.com/c/1284057 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#602892}
-
Erik Chen authored
The creation time of native events is no longer used because there is known noise on Windows, macOS and Linux. This CL is a refactor with no intended behavior change. Change-Id: I9eb860fb27b6642be25dfbbaa9d5615d0b619073 Bug: 859155 Reviewed-on: https://chromium-review.googlesource.com/c/1296619Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#602891}
-
David Bokan authored
This CL implements fractional scroll delta commit from CC to Blink for the "Blink Fractional Scroll Offsets" feature. Currenty, Blink stores scroll offsets in integral physical pixel units. This means offsets will be "fractional" in CSS pixels but only with a granularity based on the browser-zoom level. e.g. If we ctrl+ zoom into 200%, valid offsets are 0, 0.5, 1, 1.5, etc. At 100% zoom, only integer values are supported. CC stores scroll offsets in floats. For example, when pinch-zoomed into 400%, touch scrolling by 1 pixel on the physical screen should cause a scroll of 0.25 CSS pixels. Today, we reconcile this difference at commit. When CC commits scroll deltas to Blink, it sends only the rounded integer values to Blink but keeps the fractional part in CC. This ensures the scroller appears at the correct offset even with fine scrolling control but causes needless complexity and issues inside Blink. This CL allows CC to pass the full fractional delta to Blink when the feature flag is enabled. Major changes: - Add a setting to LayerTreeSettings so that CC knows whether to send fractional or integral values to Blink. Set this based on the Blink RuntimeEnabledFeature flag. We need to keep this rather than always sending fractional and clamping in Blink because the rounding behavior in CC is non-trivial. - Use this new setting when committing deltas in ScrollTree::PullDeltaForMainThread - Add a test to TreeSynchronizerTest and re-enable a previously failing LayoutTest that now passes as a result. Bug: 414283 Change-Id: I4f339aeea28e16c209a5515201e4d5d2b23dc2ea Reviewed-on: https://chromium-review.googlesource.com/c/1292964 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602890}
-
Devlin Cronin authored
webstore.json describes inline installation, which is now deprecated and removed. Remove it from the build so we don't generate schemas items. Leave the file in the source tree for posterity, but update each item to include the "deprecated" field. Bug: 882045 Change-Id: Ic9652df2c18c277fcf130a71fb9da494e2e257e0 Reviewed-on: https://chromium-review.googlesource.com/c/1298116Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#602889}
-
Raphael Kubo da Costa authored
Commit e366fe60 ("Servicified custom DNS configuration") added code that follows the following pattern: base::Optional<T> Foo() { T t; return t; } clang seems to automatically convert |t| to an rvalue reference, but GCC fails with: In file included from /usr/include/c++/7/vector:62:0, from ../../services/network/public/cpp/host_resolver_mojom_traits.h:10, from ../../services/network/public/cpp/host_resolver_mojom_traits.cc:5: /usr/include/c++/7/bits/stl_construct.h: In instantiation of ‘void std::_Construct(_T1*, _Args&& ...) [with _T1 = mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer>; _Args = {const mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer>&}]’: /usr/include/c++/7/bits/stl_uninitialized.h:83:18: required from ‘static _ForwardIterator std::__uninitialized_copy<_TrivialValueTypes>::__uninit_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = __gnu_cxx::__normal_iterator<const mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer>*, std::vector<mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer> > >; _ForwardIterator = mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer>*; bool _TrivialValueTypes = false]’ /usr/include/c++/7/bits/stl_uninitialized.h:134:15: required from ‘_ForwardIterator std::uninitialized_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = __gnu_cxx::__normal_iterator<const mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer>*, std::vector<mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer> > >; _ForwardIterator = mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer>*]’ /usr/include/c++/7/bits/stl_uninitialized.h:289:37: required from ‘_ForwardIterator std::__uninitialized_copy_a(_InputIterator, _InputIterator, _ForwardIterator, std::allocator<_Tp>&) [with _InputIterator = __gnu_cxx::__normal_iterator<const mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer>*, std::vector<mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer> > >; _ForwardIterator = mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer>*; _Tp = mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer>]’ /usr/include/c++/7/bits/stl_vector.h:331:31: required from ‘std::vector<_Tp, _Alloc>::vector(const std::vector<_Tp, _Alloc>&) [with _Tp = mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer>; _Alloc = std::allocator<mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer> >]’ ../../base/optional.h:49:64: required from ‘constexpr base::internal::OptionalStorageBase<T, <anonymous> >::OptionalStorageBase(base::in_place_t, Args&& ...) [with Args = {std::vector<mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer>, std::allocator<mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer> > >&}; T = std::vector<mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer> >; bool <anonymous> = false]’ ../../base/optional.h:146:33: required from ‘constexpr base::internal::OptionalBase<T>::OptionalBase(base::in_place_t, Args&& ...) [with Args = {std::vector<mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer>, std::allocator<mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer> > >&}; T = std::vector<mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer> >]’ ../../base/optional.h:518:67: required from ‘constexpr base::Optional<T>::Optional(U&&) [with U = std::vector<mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer> >&; typename std::enable_if<(((std::is_constructible<T, U&&>::value && (! std::is_same<typename std::remove_cv<typename std::remove_reference<_SrcTuple>::type>::type, base::in_place_t>::value)) && (! std::is_same<typename std::remove_cv<typename std::remove_reference<_SrcTuple>::type>::type, base::Optional<T> >::value)) && std::is_convertible<U&&, T>::value), bool>::type <anonymous> = 0; T = std::vector<mojo::InlinedStructPtr<network::mojom::DnsOverHttpsServer> >]’ ../../services/network/public/cpp/host_resolver_mojom_traits.cc:168:10: required from here /usr/include/c++/7/bits/stl_construct.h:75:7: error: ‘mojo::InlinedStructPtr<S>::InlinedStructPtr(const mojo::InlinedStructPtr<S>&) [with S = network::mojom::DnsOverHttpsServer]’ is private within this context { ::new(static_cast<void*>(__p)) _T1(std::forward<_Args>(__args)...); } ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Bug: 819294 Change-Id: Ic4233296aac5036131a43551eea7e7e8961ea1f8 Reviewed-on: https://chromium-review.googlesource.com/c/1298993Reviewed-by:
-
Scott Graham authored
This reverts commit 55729963. Reason for revert: Apparently this broke Fuchsia Cast somehow (on waterfall but not CQ) Original change's description: > fuchsia: Avoid unnecessary references to WindowEventFilter > > The link error I'm trying to avoid is this: > > [122->5/127 ~1] SOLINK ./libviews.so > FAILED: libviews.so libviews.so.TOC lib.unstripped/libviews.so > python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --strip=../../third_party/eu-strip/bin/eu-strip --sofile="./lib.unstripped/libviews.so" --tocfile="./libviews.so.TOC" --output="./libviews.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,-z,max-page-size=4096 -Wl,--icf=all -Wl,--color-diagnostics --target=aarch64-fuchsia -Wl,-z,stack-size=0x800000 -Wl,--no-as-needed -lfdio -Wl,--as-needed -Werror -Wl,--gdb-index -nostdlib++ --sysroot=../../third_party/fuchsia-sdk/sdk/arch/arm64/sysroot -L../../third_party/fuchsia-sdk/sdk/arch/arm64/lib -o "./lib.unstripped/libviews.so" -Wl,-soname="libviews.so" @"./libviews.so.rsp" > ld.lld: error: undefined symbol: views::WindowEventFilter::WindowEventFilter(views::DesktopWindowTreeHost*) > >>> referenced by memory:3118 (../../buildtools/third_party/libc++/trunk/include/memory:3118) > >>> obj/ui/views/views/desktop_window_tree_host_platform.o:(views::DesktopWindowTreeHostPlatform::OnNativeWidgetCreated(views::Widget::InitParams const&)) > > ld.lld: error: undefined symbol: views::WindowEventFilter::SetWmMoveResizeHandler(ui::WmMoveResizeHandler*) > >>> referenced by desktop_window_tree_host_platform.cc:106 (../../ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc:106) > >>> obj/ui/views/views/desktop_window_tree_host_platform.o:(views::DesktopWindowTreeHostPlatform::OnNativeWidgetCreated(views::Widget::InitParams const&)) > clang: error: ld.lld command failed with exit code 1 (use -v to see invocation) > > I'm not sure what the correct approach is; DesktopWindowTreeHostPlatform > depends on WindowEventFilter which uses LinuxUI. > > Since there's no available non-client area on Fuchsia currently, not > doing this seems correct for the time being. Or does Fuchsia really need > its own DesktopWindowTreeHostFuchsia implementation? > > Bug: 808287 > Change-Id: I2af683415ea00147607eb4236540d8d3e8643603 > Reviewed-on: https://chromium-review.googlesource.com/c/1298554 > Commit-Queue: Scott Graham <scottmg@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602860} TBR=sky@chromium.org,scottmg@chromium.org,thomasanderson@chromium.org Change-Id: I00a7631118f58db9413c391416079c4f94a974ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 808287 Reviewed-on: https://chromium-review.googlesource.com/c/1300101Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602887}
-
Mustafa Emre Acer authored
This CL adds a missing statement to the code that handles the top domain search in IDN spoof checker. If a top domain's ICU skeleton is the same as its domain name, the code was returning prematurely, causing the top domain match to be broken. Bug: 898343 Change-Id: Ia075b6010bcf68dcfc4ceab5e41bb7cede4a0ae7 Reviewed-on: https://chromium-review.googlesource.com/c/1297260 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#602886}
-
rbpotter authored
Bug: 898444 Change-Id: I483904f8d8f974b3354d89fd7fca581fc3dd202d Reviewed-on: https://chromium-review.googlesource.com/c/1298640Reviewed-by:
-
mrefaat authored
This cl is to be merged to M71 Change-Id: Ic2d3ab3afd52217f1dc06ca15bc67cfdb920f42d Reviewed-on: https://chromium-review.googlesource.com/c/1299734 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#602884}
-
liberato@chromium.org authored
When the SurfaceLayerMode is kOndemand, WMPI would wait until entering PIP before switching to SurfaceLayer. However, it missed the case where it started in PIP mode from a previous player. This CL adds a check to see if the client is already in PIP mode, and switches to SurfaceLayer immediately if so. Bug: 891619 Change-Id: If1d75982ebcfb3c633814fd8247470a8a595c3ef Reviewed-on: https://chromium-review.googlesource.com/c/1300093Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#602883}
-
Chris Mumford authored
When navigating to a page requesting auth credentials in incognito mode with the network service enabled the Authentication dialog will be dismissed. This is caused when there is one (or more) enabled extensions that use web request permissions, but none for that specific request. This fix calls the auth request callback (which was previously called only when there was an error) without specifying that it cancel the auth request. Bug: 896966 Change-Id: I67d7404df6674c14c568be16002a73e23e025d34 Reviewed-on: https://chromium-review.googlesource.com/c/1299975Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#602882}
-
Justin Cohen authored
Hide the error page that now shows for the NTP, Ignore |success| in -didLoadPageWithSuccess (as it's been meaningless for the NTP forever), and move NewTabPageTabHelper to activate on DidFinishNavigation as the NTP now loads asynchronously. Bug: 826369 Change-Id: I8899668daca1f7862a8d6c234d1ad6f3aa963ca0 Reviewed-on: https://chromium-review.googlesource.com/c/1298181Reviewed-by:
-
Jacob Dufault authored
Pressing the skip button leads to two LoginDisplayHost::Finalize() calls, which causes a double deletion eventually leading to a crash. The PIN setup skip button triggers two 'discover-done' events (fired in discover_ui.js::end_), and the observer in screen_discover.js sends a finished user action whenver it receives a discover-done event. Discover should not be sending discover-done twice. This CL just prevents the crash. Finalize #1 at HTMLElement.end_ at HTMLElement.fire at HTMLElement.onSkipButton_ at HTMLElement.onAuthTokenChanged_ at HTMLElement._observerEffect at HTMLElement._effectEffects at HTMLElement._propertySetter at HTMLElement.setter at HTMLElement.onSkipButton_ at HTMLElement.handler Finalize #2 at HTMLElement.end_ at HTMLElement.fire at HTMLElement.onSkipButton_ at HTMLElement.handler at HTMLElement.fire at Object.fire at Object.forward at Object.click at HTMLElement.handleNative Bug: 895250 Change-Id: I784ee5ef0ecfc5bffad515973451331bfc0aee3f Reviewed-on: https://chromium-review.googlesource.com/c/1299145Reviewed-by:Alexander Alekseev <alemate@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#602880}
-
Collin Baker authored
The backend will be notified of this event whenever a user reopens a tab using either CTRL+SHIFT+T or the recent tabs menu. This event will block reopen tab IPH from showing. Bug: 887991 Change-Id: Id6f7531787a39ec3e21e72795c9a0381124d3b8c Reviewed-on: https://chromium-review.googlesource.com/c/1299774Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#602879}
-
Robbie McElrath authored
Right now setting cookies is asynchronous, which can lead to race conditions where setting a cookie then sending a request doesn't result in the request having the cookie set (see the bug). Bug: 898704 Change-Id: I1d362b0312942f57b933352b85c60cc1ff855fba Reviewed-on: https://chromium-review.googlesource.com/c/1298489 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#602878}
-
Sammie Quon authored
This was a regression. Reparent the views tree so the title view is a child of the shield button. Test: manual Bug: 897763 Change-Id: I69a9468fbf58c95ee65b2795844f0b8fd32112ae Reviewed-on: https://chromium-review.googlesource.com/c/1298615Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#602877}
-
