- 21 Jan, 2021 40 commits
-
-
Matthew Denton authored
The ReconnectsAfterURLLoaderFactoryDisconnection test checks that there have been at most two requests after the URLLoaderFactory disconnects and reconnects, but it should have been checking for at least two requests. Bug: 1168193 Change-Id: I7c816e433a10e043e70dc1032519b8795253dd3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641141 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845671}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.101. R=hypan@google.com Bug: 1041619 Change-Id: I9a62d5ac6f4dc2d6a741571192442fa79b493327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641114 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#845670}
-
Alexander Surkov authored
Bug: 1136957 Change-Id: I8840cc3a469c55fbde6a7f78e1ce5158f5afa4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637716 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#845669}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3b349f3ea9c0..79b1b0af2eb9 2021-01-21 fmayer@google.com Add .cache to gitignore. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I445ce914f1b5fbcad6887ececa1c940489f0a762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642810Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845668}
-
Alex Ilin authored
This reverts commit e23f231d. Reason for revert: crash https://crbug.com/1169047 that was caused by the original version of this CL was fixed Original change's description: > Revert "[profiles] Don't show a profile being created in the picker and menu" > > This reverts commit e2de939b. > > Reason for revert: causes crash https://crbug.com/1169047 > > Original change's description: > > [profiles] Don't show a profile being created in the picker and menu > > > > This CL leverages the already existing kIsOmittedFromProfileListKey > > preference in ProfileAttributesEntry to mark profiles that shouldn't > > be shown to the user. > > > > kIsOmittedFromProfileListKey was created for profiles in the middle of > > being set up as new legacy supervised users. The preference was dead > > because it was never set to true. This CL revives it and adds additional > > checks to profile_picker_handler.cc and profile_menu_view.cc to not > > display omitted profiles. > > > > Bug: 1126913, 1166809 > > Change-Id: Ieb05f31d8951f2971201351bead7c108eb874473 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632752 > > Commit-Queue: Alex Ilin <alexilin@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#845372} > > TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I5133c4502f02b68c4e707fa7c86072bdabce4ff2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1126913 > Bug: 1166809 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642328 > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845616} TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: 1126913 Bug: 1166809 Change-Id: I8aba3d3ffef4e01a51228d449e7e0bac24b8f7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642329Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845667}
-
Sylvain Defresne authored
This function is useful to check whether the device supports having multiple scenes (which has impact on core behaviour of the application and not just on the UI). Move it besides other multi-window related functions. Fix compilation when targeting iOS x86 platform caused by the inclusion of partition_alloc header in base/memory/checked_ptr.h even when user_partition_alloc is disabled (which is always the case on iOS). Bug: none Change-Id: I31f7abb6479438176ed72467ddf9811624001911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640455 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#845666}
-
Tamer Tas authored
R=johnchen@chromium.org,machenbach@chromium.org CC=almuthanna@chromium.org,mythria@chromium.org Bug: 1158374 Change-Id: I2532943acfd955e9e956a5c3a12ab654a76c2614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642350 Auto-Submit: Tamer Tas <tmrts@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#845665}
-
Sylvain Defresne authored
To simplify the API of SessionServiceIOS in preparation of next refactoring, change it to always require a session identifier. Passing an empty string or nil will result in the same code path as calling the methods that took no session identifier. Bug: 1165798 Change-Id: I9739baf91cbcfcd21be61cd487c24b0d375289bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632760 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845664}
-
Todd Sahl authored
A change was introduced in http://crrev.com/c/2536794 to clean up RenderFrameHostManager::speculative_render_frame_host_ when a renderer aborts a NavigationRequest. However, the aborted request may or may not have been associated with the speculative RFH, and there may remain one or more active NavigationRequests that are associated with the speculative RFH. This change modifies the regressed call site that cleans up the speculative RFH to be conditional on there being no remaining NavigationRequests that are associated with it. Bug: 1159916: Crash report - NavigationRequest::OnStartChecksComplete Change-Id: Ifebe8361cf08480d170598e7c3fa973b3bb693d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595806 Commit-Queue: Todd Sahl <toddsahl@microsoft.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#845663}
-
Leonard Grey authored
Bug: 1143589 Change-Id: Ic9d59025575fa264c81384dbc11b531d0b7a227c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640834Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#845662}
-
Stepan Khapugin authored
Improves blocking UI in the following ways: 1. Fix handling of large fonts 2. Adjust font size when it's changed in settings 3. Add pointer support 4. Rounded corners are now round irrespectfully of the font size For this, the authenticate button gets its title as a subview label, and both buttons are width-constrained to fit. Bug: 1164922 Change-Id: Ib807ca40e544ec3bc016753b8cfe1501c69c61cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640439 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845661}
-
Peter Kasting authored
This reverts commit eb5180b3. Bug: 1169051 TBR: weili Change-Id: I145d7abe9d186abeb847fcbdb278fe378aaf829a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642743Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#845660}
-
Dave Tapuska authored
WebRect should go away with usage of gfx::Rect. This change removes WebRect usage on WebViewClient, WebPluginContainer, WebPlugin, WebRemoteFrame and WebLocalFrameClient. BUG=738465 Change-Id: I3f82b9356457c8438035308057fab302f3388411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639866Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#845659}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101210600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/rr1ZMp2yx7vK_LvYABkJ9aZLOr-jLutWfSkwC4lZUjMC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/178042652 Tbr: help-app@grotations.appspotmail.com Change-Id: Ieff34bd95632df9b78790fe68d98826308e6891c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642809Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845658}
-
Mathias Carlen authored
Before this patch users in autofill feature AutofillEnableSupportForMoreStructureInNames were not properly populating first and last names in forms. This patch finalizes the profiles proactively before they are being used to fill fields on the website. This has manually been verified to work on a few websites. The end goal would be to already receive finalized profiles from autofill. Meanwhile this patch addresses this regression until that is solved. Bug: b/175942816 Change-Id: I86579455b36538e32ca133f61b3f2a24defa498c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642356Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#845657}
-
Kushagra Sinha authored
Simplify version checks in AccountManagerFacadeImpl by using the synchronous version accessor in LacrosChromeServiceImpl Change-Id: I7a83a352f10977e0d3ce1d84528d76726688016c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640436 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#845656}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d5c88e60cff4..e41b3bb941a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC anastasiian@google.com,lgrey@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1151505,chromium:1168777 Tbr: anastasiian@google.com,lgrey@google.com Change-Id: Ie2a7475cdd16ee3408efc18cbf58cb924e940be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642808Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101210600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/VfjLSnBpe5wh7h4SqNeUqE6zmybZ1Sebm0S0ltU1uCoC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/172415656,b/173070498,b/174442020,b/174603791,b/177856222 Tbr: media-app@grotations.appspotmail.com Change-Id: Ia85aa41caab1be804448ac4645a16aabc7a71c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642806Reviewed-by:
-
stkhapugin authored
Track the session as open while there is at least one foreground window. Log this in a dedicated app agent to avoid polluting AppState. The same is done to IOSProfileSessionDurationsService's session start/end events. Bug: 1156586 Change-Id: I37586f989039206fbaa90f7ec4046fbf9582e70a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599870 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/87a055b02027..e0d023562bd9 2021-01-21 johnstiles@google.com Remove obsolete reference to Flex lexer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I4e2ccf610c033e37b20c81e03711b7215b8afc9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642819Reviewed-by:
-
Leonard Grey authored
This reverts commit cfd230fd. Reason for revert: Speculative due to https://crbug.com/1169160 Original change's description: > Files app: Enable JS modules by default > > Bug: 1133186 > Change-Id: I4a92f4f60ce7b98ef3bc8f35e115eab428dda298 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639351 > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Jeremie Boulic <jboulic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845564} TBR=lucmult@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,jboulic@chromium.org Change-Id: I62ac3ac7851d7e7e5fa52f944c2d8e6ab3b2705a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643021Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#845651}
-
Robert Flack authored
The reporting code no longer exists, and we haven't noticed missing this histogram so it should be safe to expire. Bug: 1089338 Change-Id: Iab50286cbdb4ddb3d403df83b6bfddafc50dd236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640750Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#845650}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f9033fa039cd..30152edff696 2021-01-21 szuend@chromium.org Add Trust Token pane in the Application Panel 2021-01-21 tvanderlippe@chromium.org Add network as dependency of security 2021-01-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-21 petermarshall@chromium.org Typo fix in DataGrid If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1126824 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I97115767363db6b75a0576d4e8b996b0579dfa3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642740Reviewed-by:
-
Robert Flack authored
We have been actively using these metrics to identify areas to invest scrolling improvements in and to gauge the success of improvements to scrolling. Bug: 1089343 Change-Id: I7fe4a4e76349259ca7b245c0653497a712434aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640643 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change prepares //net/proxy_resolution/win for the switch of base::string16 to std::u16string. Bug: 911896 Change-Id: If58c61761969fa355bea533d87b70e393951c7c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642146 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#845647}
-
Dominik Röttsches authored
According to b/177801059 and b/178006074 issues are resolved that had the the mirror repository flip-flopping between syncing the old and the new upstream source of truth, compare https://crbug.com/1168536. Relanding the forward roll. https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/03ceda9701cd..b594cd90bd05 $ git log 03ceda970..b594cd90b --date=short --no-merges --format='%ad %ae %s' 2021-01-19 apodtele * srd/base/ftlcdfil.c (FT_Library_SetLcdGeometry): Fix return value. 2021-01-15 madigens [afshaper] Fix hb_ot_tags_from_script deprecation warning. 2021-01-17 wl * src/tools/update-copyright-year: Fix single-year entry handling. 2021-01-17 wl Update all copyright notices. 2021-01-17 wl no-copyright: Updated. 2021-01-16 apodtele * builds/unix/unixddef.mk: Remove the second DEVEL_DIR definition. 2021-01-16 wl Documentation update for repository move to 'freedesktop.org'. 2021-01-16 wl .gitattributes: New file. 2021-01-16 wl README, README.git: First updates due to freedesktop.org migration. 2021-01-15 drott CHANGES: Mention 'COLR' v1 support. 2021-01-15 wl [sfnt] Additional checks for 'colr' table presence. 2021-01-14 drott Add config option to test for 'COLR' v1 support in headers. 2020-12-16 drott [base] Fill 'COLR' v1 API templates to make them work (#59703). 2020-12-16 drott [sfnt] Register 'COLR' v1 API in driver (#59703). 2020-12-16 drott [sfnt] Add 'COLR' v1 API to retrieve color layers (#59703). 2020-12-16 drott [sfnt] Add 'COLR' v1 API to iterate color stops (#59703). 2020-12-16 drott [sfnt] Add API to get actual paint from `FT_OpaquePaint` (#59703). 2020-12-16 drott [sfnt] Add API to retrieve 'COLR' v1 root paint (#59703). 2020-12-16 drott Add new methods required for 'COLR' v1 to public API (#59703). 2020-12-16 drott Add types required for 'COLR' v1 to public API (#59703). Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng Bug: 1167653 Change-Id: I29c46d893fff921fe8bb029466906d97b1c4a371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642345 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#845646}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/099b043d..ee9fbcba Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9160dcc900ab1efc1ba3dc323074cd6556ca2845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642739Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845645}
-
Michael Lippautz authored
A past refactoring translated `unique_ptr<TaskRunnerTimer>` to `Member<DisallowNewWrapper<HeapTaskRunnerTimer>>` to preserve semantics. Inline HeapTaskRunnerTimer which avoids a dynamic allocation. Change-Id: I8a859c068c9889b5e2bafb01619138ad2f1e0e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642326Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611219467-221ce2b3efda04c3b102ac62c26b5f5a8e2aaa76.profdata to chrome-win64-master-1611230296-6b85df13abed72480b96a917e46b214e59288b63.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If8a4925fe78ed1255a1d4c902e309091ed763ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642916Reviewed-by:
-
Wojciech Dzierżanowski authored
MediaPlayerId objects are supposed to be unique browser-wide. A well-behaved renederer process will not try to reuse them. Bug: 1168737 Change-Id: Iaa1d54face4bd475d6df8a00d282a5b88242b735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640381Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#845642}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611219467-390b4abe6a87e7c94cab88849ad56f5359438186.profdata to chrome-win32-master-1611230296-c6265b318ac69ceb3057c4103fbc67710d80a9da.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1f7848ef05366ca74c969e7ba1b4df16b2b0a0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642817Reviewed-by:
-
Danila Kuzmin authored
Bug: 1159859 Change-Id: I86c4e4f96c3d2fba164983f4017370e6c3e1f006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627423Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#845640}
-
danakj authored
We do this in unit tests already, which found some expensive waste. We have many browser tests which fail with timeouts during shutdown flakily. In order to diagnose and fix these, we need to know what task is running that is blocking shutdown. We can do that by using the TestTaskTracker in the ThreadPoolInstance. In order to use TestTaskTracker, we must have the browser test launcher able to override the creation of the ThreadPoolInstance. So we change the ContentBrowserClient API to be responsible for that creation, instead of just a query about whether it should be created or not. And we inject a test-only ContentBrowserClient that creates a ThreadPoolInstance through the base::Test::TaskEnvironment. We add tracking of the posted_from location of all running tasks in the TestTaskTracker, and introduce a timeout during shutdown. If the timeout is hit, we log all of the running tasks. Bug: 811470 Change-Id: I9f33a8224ab73f436656915f4a26067b1b7b5b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505733Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#845639}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9f4b159b7aa0..f28a06ba7281 2021-01-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3180f85f9bcd to f646afdb8929 (2 revisions) 2021-01-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 13257563 to 67fb6a84 (480 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Iabf5e01bc6fc9917ffb6028695cb1f28a0397740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642797Reviewed-by:
-
Oleg Davydov authored
This commit moves expire date of the following histograms: * Extensions.ForceInstalledManifestFetchFailedHttpErrorCode2 * Extensions.ForceInstalledReadyTime * Extensions.ForceInstalledStage2 The expire date is now in sync with other histograms owned by our team (Extensions.Force*). Bug: 1165254, 1165255 Change-Id: Ie7d7ce0e96fe813321f7dbab53b1667bdf82bc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642366 Auto-Submit: Oleg Davydov <burunduk@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#845637}
-
Julie Jeongeun Kim authored
On the current code, even though |preview_ui_| is checked before calling CheckForCancel(), the renderer could not get the reply as the print WebUI dialog is already closed on the browser. If then, the renderer gets blocked. Since CheckForCancel() is called multiple times while handling the print preview request and |preview_ui_| could be disconnected once the print WebUI is closed, this change moves CheckForCancel() to mojom::PrintManagerHost as PrintViewManager which implements it is alive while WebContents is available. Bug: 1166492, 1167170, 1008939 Change-Id: Iffc5d5354be3778ec7f33cff11051858432b5bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632023Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#845636}
-
David Jean authored
BVC would start an activity overlay when shutting down, creating a never ending animation. Bug: 1143708 Change-Id: I7654a7430325601fd71f7ba4b789b3c663b40353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637701Reviewed-by:
Zhaoyang Li <zhaoyangli@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#845635}
-
Hans Wennborg authored
New Clang warns on calling free() on stack objects by default. Bug: 1169073 Change-Id: I9f89e389308060b424832cfc400b2fef5c104120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642145 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#845634}
-
Ben Mason authored
Change-Id: I3c8d8d7c7db20be57c28f8ff0f04c13bf3cde9df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642856 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845633}
-
Bret Sepulveda authored
This patch creates a vector_icons target for components/permissions so that we can move there any icons not used anywhere else. The two existing icons for which this is true are accessibility.icon and usb_security_key.icon. Bug: 1110905 Change-Id: I13f6d2c9c54aabcae8beeb5d14ee40263c8ff62d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637598 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Illia Klimov <elklm@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#845632}
-
