GitLab

BUG=829068

Change-Id: I8966cf06a31c12d50804c810a6b85f9a53b9bf59
Reviewed-on: https://chromium-review.googlesource.com/996587
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548551}

https://chromium.googlesource.com/catapult.git/+log/5d3d40fb8894..883d59ef7027

$ git log 5d3d40fb8..883d59ef7 --date=short --no-merges --format='%ad %ae %s'
2018-04-05 eakuefner [Dashboard] Don't create summary stats for benchmark_total_duration

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I4fe8454a09519bd610dfb3b7a9e1ca424c8ad1e9
Reviewed-on: https://chromium-review.googlesource.com/998433
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548550}

There are no logic changes in this CL.

This CL adds comments to parameters of SuggestResult instance creation.
It also corrects a comment about NULL to nullptr.

TBR=mpearson@chromium.org

Bug: None
Change-Id: I2620d3fb9382513dbc2033760b2a14b8516a115a
Reviewed-on: https://chromium-review.googlesource.com/998189Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548549}

This test could be sensitive to platform configuration since it relied
on generating a filename extension based on a MIME type. In particular,
if the platform configration associated anything other than .htm on
text/html on Windows the test would fail. (Same for .html on Posix).

This change refactors the test for readability, and removes its
dependence on local configuration.

Bug: 828954
Change-Id: Iad2b838e0f044ccdbf7eb2caf2a08d65a4dab857
Reviewed-on: https://chromium-review.googlesource.com/996354
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548548}

This was added to WebRTC in
https://webrtc-review.googlesource.com/c/src/+/57220

Bug: 811683
Change-Id: I8a53ed68fd1b76ae222f82f3246120bba4ac3ee2
Reviewed-on: https://chromium-review.googlesource.com/998432Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548547}

Bug: webrtc:7932
Change-Id: I6d9a97754e6f19f5917927a24652786a4d9624c5
Reviewed-on: https://chromium-review.googlesource.com/986509
Commit-Queue: Seth Hampson <shampson@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548546}

This DCHECK has been hit by developers too often, making a checked build
useless. Disabling the DCHECK in the meantime while a fix can be done.

BUG=816490

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3b9d020978b4ebabf00233c35ba3059a8ba2f9fd
Reviewed-on: https://chromium-review.googlesource.com/998529
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548545}

This change implements the SetNextUnsubscribeFromNotifications function
for fake characteristics.

BUG=569709

Change-Id: I99c59a4caffd524e727921fcb54f48cc868d545f
Reviewed-on: https://chromium-review.googlesource.com/988223
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548544}

Wayland does implicit capture. This adds plumbing to track when the
WaylandWindow has implicit capture, and adds function to
PlatformWindow to test for capture.

Also notifies when activation changes.

BUG=none
TEST=covered by tests

Change-Id: I9d73ade6cb8e5e909fe3fe3940eb6f48b0dbd5c7
Reviewed-on: https://chromium-review.googlesource.com/998307
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548543}

This change updates the generated characteristics tests for
calling disconnect/device disconnecting before an operation on a
characteristic.

BUG=509038

Change-Id: I16b7ffbfd6df473ee0c4c0bfb34982473c41482f
Reviewed-on: https://chromium-review.googlesource.com/986890
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548542}

The tab grid was not behaving properly in rotations. The page would
change when it is not supposed to. This is due to the page being set
inside |-scrollViewDidScroll:| while the rotation was occurring.
The fix is to separately set the page for non-user-dragging scroll
in |-scrollViewDidEndScrollingAnimation:|.

Bug: 828735
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib325eb6ef5d5ebb98274ec565cdbb03a21b8e9e1
Reviewed-on: https://chromium-review.googlesource.com/998055Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548541}

Adds conversion from gfx::ColorSpace to SkYUVColorSpace.

Bug: 754986
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I22260ea9542afc5306c82b7ec6d2e2d0cf4b7a0a
Reviewed-on: https://chromium-review.googlesource.com/869147Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548540}

NOTRY=true
TBR=nednguyen@google.com

Bug: 829504
Change-Id: Id45cfb893bde4cced66a95ee2a1b1e73a9d430ec
Reviewed-on: https://chromium-review.googlesource.com/998622Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548539}

This implements support library callbacks (WebViewclientCompat). This
creates a new layer (support_library/callback) which the glue layer
depends on. This dependency lets us instantiate a
SupportLibWebViewContentsClientAdapter inside setWebViewClient(), and
benefit from the glue layer's parameter cleanup code (e.g., in
onReceivedError2()).

The support_library/callback glue must be a separate layer from
support_library/ glue, as that already depends on the webkit glue to
initiate state. Implementing callbacks as a separate target avoids the
circular dependency.

This refactors the (post-L) glue layer callback methods to take the
following precedence:

 1. SupportLibWebViewContentsClientAdapter (if it supports the callback)
 2. WebViewClient (if on the appropriate platform level)
 3. Default behavior (implementation provided by the glue layer)

This implements both category 1 and 2 APIs.

Design doc: http://go/wv-support-library-callbacks

Bug: 781764
Test: manual - built test application with latest support-lib changes
Change-Id: I21e28493873e670cfd428c7eeef12b0e212aeec4
Reviewed-on: https://chromium-review.googlesource.com/989015Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Gustav Sennton <gsennton@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548538}

Adds support for using the VrCore head tracking service in VR
instrumentation tests. This can be used either via an annotation, which
results in slightly faster test execution, or directly in a test via a
utility class.

Bug: 828190
Change-Id: Id4f806939b7242c084ac467bed2214b7b0c73911
Reviewed-on: https://chromium-review.googlesource.com/996901
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548537}

This CL allows the PageScheduler to know whether its main frame is local or
remote. If a renderer process has no local main frame, we do not report the
Expected Queueing Time.

Bug: 826753
Change-Id: I92a0ccd54d820778e769bf3f2f24c3a22e3cc42a
Reviewed-on: https://chromium-review.googlesource.com/984296Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548536}

arc: bluetooth: Add DisbleAdvertisement() to allow advertisers to stop advertisement while retaining handles

Rename BraodcastAdvertisement() into EnableAdvertisement().
Also fix the race condition among advertisement calls by a task queue.
For example, the potential race condition between EnableAdvertisement()
and ReleaseAdvertsiementHandle() could cause a handle released w/o
advertisement disabled. We fix it by queuing the work in ReleaseAdvertsiementHandle()
until EnableAdvertisement() is done.

BUG=b:73743210
TEST=./out/Default/unit_tests --gtest_filter="ArcBluetoothBridgeTest.*"

[1/4] ArcBluetoothBridgeTest.DeviceFound (6 ms)
[2/4] ArcBluetoothBridgeTest.LEDeviceFound (3 ms)
[3/4] ArcBluetoothBridgeTest.GetGattDB (3 ms)
[4/4] ArcBluetoothBridgeTest.SingleAdvertisement (2 ms)
SUCCESS: all tests passed.
Tests took 4 seconds.

Change-Id: I15b95541121fd305f536be1867116f136a97307b
Reviewed-on: https://chromium-review.googlesource.com/967369
Commit-Queue: Qiyu Hu <qiyuh@google.com>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548535}

Add extra set of UMA statistics for Child accounts.
This is required to run finch experiment for dogfooders.

Test: Manually
Bug: 824447
Change-Id: I3d0ebb82e0740bec75d0ecc9bc7932fe67a20230
Reviewed-on: https://chromium-review.googlesource.com/996898
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548534}

Other .so files were being skipped since we assumed only a single .so
file would be in each apk. Now they are added as .other symbols.

Bug: 829464
Change-Id: If23e124caac6e2097891015a183b19bfc8687ed8
Reviewed-on: https://chromium-review.googlesource.com/998527Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548533}

Before this patch, if binding failed or the Android payment app
disconnected from Chrome midway through the payment process, Chrome
would unbind on its own side, which would result in an
IllegalArgumentException.

This patch adds a boolean mIsServiceConnected that tracks whether the
payment app's service is connected to Chrome. If this boolean is false,
then Chrome does not attempt to unbind from the payment app service.

After this patch, if the Android payment app disconnects from Chrome
midway through the payment process or the binding fails,
Chrome does not bother to unbind on its own side and thus avoids
the IllegalArgumentException.

Bug: 828852
Change-Id: I653b3bef07562f815d8e53d62c7aff97649bcac5
Reviewed-on: https://chromium-review.googlesource.com/995618
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548532}

Proper script offset is important for DevTools and JavaScript stacks.

Bug: chromium:827696
Change-Id: I9786e41b63cea532637b573505ae445f90d866cf
Reviewed-on: https://chromium-review.googlesource.com/996531Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548531}

This was found by ClusterFuzz, see test case in bug.

Bug: 828810
Change-Id: I68e3050023d2475917334c54b5d85b7d20565775
Reviewed-on: https://chromium-review.googlesource.com/995962Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548530}

The embedding aura::Window must be attached to a root window so that
window server could figure out the correct display and pass it to the
other side. Deferring the EmbedUsingToken call until RemoteViewHost
is added to a widget.

Bug: 812434
Change-Id: Ie65d12d8b883b1a74426c33c3f106bbb637c0f69
Reviewed-on: https://chromium-review.googlesource.com/998498Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548529}

This CL introduces concrete usage examples.

Bug: 
Change-Id: I9ecc5731aff810fb6b5e2cbf818f610ab6c1a7a8
Reviewed-on: https://chromium-review.googlesource.com/657259
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548528}

This reverts part of commit 8a556164.
The original change that caused the problems this was working around was
reverted, so also revert the workaround to fix the issues the workaround
caused.

Bug: 813224
Change-Id: Ic0659a38b6ddcf828c2476d6b9fa4e266c364b57
Reviewed-on: https://chromium-review.googlesource.com/998436Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548527}

When testing binary size I often only care about Release-iphoneos and
it'd be nice to be able to specify that when invoking the script.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I58a0ba0d470d1bbef3c405b42c62468fb64028c4
Reviewed-on: https://chromium-review.googlesource.com/996555Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548526}

This reverts commit f5bbb138.

Reason for revert: breaks Windows build

Original change's description:
> Add SubmitFrameMissing mojo call for WebVR/WebXR
> 
> Goal is that we get a clean lifecycle for a functioning WebVR/WebXR
> presentation render loop. It's started by a presenting SendVSync, calls
> GetVSync to schedule the next frame, and is ended by a SubmitFrame
> call. If there was nothing drawn, it uses SubmitFrameMissing instead of the
> usual SubmitFrame/SubmitFrameWithTextureHandle.
> 
> In WebVR 1.1, submitFrame is a JS call, and the app can exit its animation
> loop without calling it. WebXR had an analogous feature where SubmitFrame
> was skipped if the framebuffer wasn't touched by drawing calls. This
> made it hard to tell for the device side if a frame is done or not.
> 
> WebVR 1.1 worked around this by deferring a GetVSync call until after
> SubmitFrame, but this was complex:
> 
> -  // The logic here is a bit subtle. We get called from one of the following
> -  // four contexts:
> -  //
> -  // (a) from requestAnimationFrame if outside an animating context (i.e. the
> -  //     first rAF call from inside a getVRDisplays() promise)
> -  //
> -  // (b) from requestAnimationFrame in an animating context if the JS code
> -  //     calls rAF after submitFrame.
> -  //
> -  // (c) from submitFrame if that is called after rAF.
> -  //
> -  // (d) from ProcessScheduledAnimations if a rAF callback finishes without
> -  //     submitting a frame.
> -  //
> -  // These cases are mutually exclusive which prevents duplicate GetVSync
> -  // calls. Case (a) only applies outside an animating context
> -  // (in_animation_frame_ is false), and (b,c,d) all require an animating
> -  // context. While in an animating context, submitFrame is called either
> -  // before rAF (b), after rAF (c), or not at all (d). If rAF isn't called at
> -  // all, there won't be future frames.
> 
> This CL removes those special cases and just always calls RequestVSync from
> requestAnimationFrame, collapsing cases (a) and (b) into an unconditional call.
> Cases (c) and (d) are now no longer needed and removed.
> 
> The layout tests now check the SubmitFrameMissing call count.
> 
> Also added a check for a WebXR exclusive session ending in the middle of a
> frame. (The layout tests revealed this since OnEndFrame no longer exits early
> on a clean framebuffer.)
> 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I5722097d421ca9448760e696ea379895a1320199
> Reviewed-on: https://chromium-review.googlesource.com/996614
> Reviewed-by: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Brandon Jones <bajones@chromium.org>
> Reviewed-by: Martin Barbella <mbarbella@chromium.org>
> Reviewed-by: Bill Orr <billorr@chromium.org>
> Commit-Queue: Klaus Weidner <klausw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548518}

TBR=vollick@chromium.org,bajones@chromium.org,mbarbella@chromium.org,klausw@chromium.org,billorr@chromium.org

Change-Id: I18f7e808840140c7a4c55139687700b8e1ceac8c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/998652Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548525}

will-change will force the media controls to use a different
layer. According to Pinpoint this will reduce CC memory usage
by 18% and GPU memory usage by 6%.

BUG=821961,821414

Change-Id: I13c62f79577dfef253acf5f3b89cecaf0c5c1ad3
Reviewed-on: https://chromium-review.googlesource.com/996309Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548524}

Prior to this patch, in rare circumstances represented in tests,
OnGotInitialHistoryDataAndIconURLCandidates() could be called twice
without actually receiving new candidates in-between (i.e. call to
OnUpdateCandidates()).

In the particular case of pages listing Web Manifests, this could lead
to the next candidate being processed by
DownloadCurrentCandidateOrAskFaviconService() in a situation where
actually all candidates were already processed, going out of bounds of
the candidates vector.

Bug: 828196
Change-Id: Ic4966db627b9e26252fb1c1b3f0512a054301df6
Reviewed-on: https://chromium-review.googlesource.com/995673Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548523}

This reverts commit cf7316a4.

Reason for revert: Suspect for crashes in crbug/827105

Bug:827105

Original change's description:
> Simple disk cache: fix inode problem caused by extremely small cache files
>
> On POSIX filesystems, when most of cache files are extremely small, they
> are hardly evicted by size limitation of cache and cache can be grow to
> maximum inode of the partition.
>
> So make cache watch the current available inodes and update its
> limitation on maximum cache files count periodically. Then evict cached
> resources not only depending on size limit, but also on count of cached
> files limit.
>
> This was originally authored by Yunsik Jang <yunsik.jang@lge.com>
>
> Change-Id: I4216c7602b2cc24fb0f445f8297836acbc08c431
> Reviewed-on: https://chromium-review.googlesource.com/964329
> Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545203}

TBR=pasko@chromium.org,gab@chromium.org,morlovich@chromium.org,jose.dapena@lge.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ib04a897431143a90bcf9f2d778247ae9b8201047
Reviewed-on: https://chromium-review.googlesource.com/995733Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548522}

NOTRY=true

Bug: 829499
Change-Id: I4196bdfd484c3ca3497a390528980d72795f5a3d
Reviewed-on: https://chromium-review.googlesource.com/998613Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#548521}

I overzealously landed https://crrev.com/c/990512 assuming that if a
TCP connection is open through an HTTP/2 proxy with an empty ALPN list,
then the server cannot negotiate HTTP/2.  Turns out that there are
already 11 crashes reported on the first day of the Canary release
that picked up this change.  This CL adds a unittest that triggers this
CHECK (verified locally), and changes Job::DoInitConnectionComplete() to
handle this case properly and avoid the crash.

Bug: 828865
Change-Id: I5bc8fb447a07d350970904b350f9aeb670e2da7d
Reviewed-on: https://chromium-review.googlesource.com/996878Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548520}

The patch updates most usages of |SessionID::id_type| as
well as other primitive types like |int| that actually represent
session IDs (i.e. window, tab or session identifiers). Instead,
SessionID instances are adopted, via the newly introduced API.

We do this as part of a larger effort to control better the lifetime of
SessionID instances. In particular, the goal is:
1. To avoid the direct use of the default constructor, which currently
   assigns new unique IDs (and we're planning to change that).
2. Reduce the usage of SessionID::id_type, int, int32_t etc. for the
   cases where SessionID can be used (which should be safer), so
   conversions from/to unsafe types is avoided.
3. Make the error-case (usually represented as ID -1) more homogeneous
   via the adoption of SessionID::InvalidValue().

As per behavioral differences: SessionID::FromSerializedValue()
squashes all negative numbers as well as zero into
SessionID::InvalidValue(), internally represented as -1. This should
be a no-op for most of the code, with some exceptions (like extensions
API) that I have excluded in this patch.

Bug: 823798
Change-Id: I2b6268d110cfe3fe7b531d4f95b3022d8f012e80
Reviewed-on: https://chromium-review.googlesource.com/989912
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548519}

Goal is that we get a clean lifecycle for a functioning WebVR/WebXR
presentation render loop. It's started by a presenting SendVSync, calls
GetVSync to schedule the next frame, and is ended by a SubmitFrame
call. If there was nothing drawn, it uses SubmitFrameMissing instead of the
usual SubmitFrame/SubmitFrameWithTextureHandle.

In WebVR 1.1, submitFrame is a JS call, and the app can exit its animation
loop without calling it. WebXR had an analogous feature where SubmitFrame
was skipped if the framebuffer wasn't touched by drawing calls. This
made it hard to tell for the device side if a frame is done or not.

WebVR 1.1 worked around this by deferring a GetVSync call until after
SubmitFrame, but this was complex:

-  // The logic here is a bit subtle. We get called from one of the following
-  // four contexts:
-  //
-  // (a) from requestAnimationFrame if outside an animating context (i.e. the
-  //     first rAF call from inside a getVRDisplays() promise)
-  //
-  // (b) from requestAnimationFrame in an animating context if the JS code
-  //     calls rAF after submitFrame.
-  //
-  // (c) from submitFrame if that is called after rAF.
-  //
-  // (d) from ProcessScheduledAnimations if a rAF callback finishes without
-  //     submitting a frame.
-  //
-  // These cases are mutually exclusive which prevents duplicate GetVSync
-  // calls. Case (a) only applies outside an animating context
-  // (in_animation_frame_ is false), and (b,c,d) all require an animating
-  // context. While in an animating context, submitFrame is called either
-  // before rAF (b), after rAF (c), or not at all (d). If rAF isn't called at
-  // all, there won't be future frames.

This CL removes those special cases and just always calls RequestVSync from
requestAnimationFrame, collapsing cases (a) and (b) into an unconditional call.
Cases (c) and (d) are now no longer needed and removed.

The layout tests now check the SubmitFrameMissing call count.

Also added a check for a WebXR exclusive session ending in the middle of a
frame. (The layout tests revealed this since OnEndFrame no longer exits early
on a clean framebuffer.)

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5722097d421ca9448760e696ea379895a1320199
Reviewed-on: https://chromium-review.googlesource.com/996614Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548518}

This is because shell extensions don't specifically target Chrome, they
just get automatically loaded by the OS. These will get blocked in phase
2 of third-party software blocking.

For IMEs, they are allowed because there is no viable alternative for
their implementation.

Bug: 829490
Change-Id: I501aad6e77734336161448f0e8e91ac78ec6d40d
Reviewed-on: https://chromium-review.googlesource.com/996586
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548517}

Not supported on iOS so dev builds will not show chrome://ukm data still.

Bug: 826400
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5d2b1ddc06256903949940638ed76e5d9231da51
Reviewed-on: https://chromium-review.googlesource.com/985017Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548516}

This CL extracts the call to vaCreateContext() out of VaapiWrapper's
CreateSurfaces() and into a new method VaapiWrapper::CreateContext().

The former still calls the latter, but this change allows for separating
the allocation of the surfaces from the creation of the context. In
particular, this is needed for decoding directly on client Surfaces
(see the bug and/or the experimental CL crrev.com/c/986353. from
which this code is separated).

Bug: 822346
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I37f28d2a0fe939264d3153f34bd25bbc6c77ba79
Reviewed-on: https://chromium-review.googlesource.com/995623Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548515}

ClientControlledShellSurface doesn't use configure to resize.

This is reland of https://crrev.com/c/994173/5

TBR=reveman@chromium.org
BUG=828586
TEST=manual

Change-Id: Id39f3d0ac5b680aa74fef13df7d0631d5b9ca742
Reviewed-on: https://chromium-review.googlesource.com/998339Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548514}

When steady state elisions is on, the user focuses the Omnibox, and
presses an arrow key, we should unelide and place the cursor correctly.

This adds a unit test for the above behavior.

Bug: 797354
Change-Id: I417603b21c89a634dc494dcbe3a764f19d7f0d27
Reviewed-on: https://chromium-review.googlesource.com/996295
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548513}

This fixes 3 things:
 1) No longer need a friended private variable on MessageLoop
    (this facilitates crbug.com/825327)
 2) Support backtraces that go through TaskScheduler (and eventual other
    TaskAnnotator users)
 3) Support backtraces for tasks posted when returning from a nested
    loop (MessageLoop would previously set the field to null rather than
    "previous" when returning from a task).

New TaskAnnotatorBacktraceIntegrationTests are largely based on previous
PendingTaskTests (plus testing support beyond simple MessageLoop/Thread).

Prefered making PendingTask::task_backtrace mutable to forcing all
PostTask annotations (TaskAnnotator::DidQueueTask and TaskTracker::WillPostTask)
to use a non-const pointer given this doesn't really modify the state of
the PendingTask but rather some internal tracing state.

This also revealed issue 826902.

Bug: 825987, 825327, 826902
Change-Id: Iae24c8d8745a6dadb2185f5c581fb1ff1d5b3f23
Reviewed-on: https://chromium-review.googlesource.com/982496
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548512}