GitLab

This is a purely mechanical rename done with Android Studio.

This class is being renamed to adhere to the conventions described in
go/clank-preferences-refactor.

Bug: 1029146
Change-Id: Ic564eca70b2abfabab219ea7bafab9f2d9f8c7d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947390
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722716}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: I747d7593985639dda16b028a18978210eeb70288
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955758Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#722715}

This CL disables a test that will be broken by the UI.ListControl
changes here [1] and fixed after that is merged here [2].

[1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880309
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1690089

Bug: 963183
Change-Id: Ie74c350af90e55961d12c819fe9f37e1eb085584
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881715Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#722714}

This CL removes unnecessary tab stops from the bluetooth-page element.
Secondary details that appear in the item viz. On/Off status are
already added in the button's aria description.

Tab stop for policy indicators were left as such since removing this
makes this detail inaccessible to some users.

Bug: 1025414
Change-Id: I40cc98b3871f7cc77a9252b05e39c669ebf12358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940813
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722713}

https://swiftshader.googlesource.com/SwiftShader.git/+log/c166eb7c0f9a..18c6a78448dd

git log c166eb7c0f9a..18c6a78448dd --date=short --first-parent --format='%ad %ae %s'
2019-12-06 bclayton@google.com SpirvShader: Use struct for MemoryVisitor callback.
2019-12-06 bclayton@google.com Regres: Update dEQP to include fence timeout fix.
2019-12-06 bclayton@google.com Vulkan: Tidy VkCommandBuffer.cpp

Created with:
  gclient setdep -r src/third_party/swiftshader@18c6a78448dd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I5087ca9e05a100fef7583edf81fb99d04e90c49c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956021Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#722712}

This can happen if the original network loader is not used for the
redirect, and the loader is recreated instead of calling
FollowRedirect().

Bug: 1029944
Change-Id: I51c76a8c2ba3db6b4ed523edf60bff3dd891440d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949403
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722711}

Validating command decoder hasn't been shipped since M75, but CQ bots
still use it for webgl conformance tests in preference to passthrough
command decoder which is only used on FYI waterfall.  This CL makes the
CQ bots test the shipping configuration by removing validating decoder
command line flag.  It also includes the following changes:

1) Explicit validating decoder variants for the conformance tests have
   been added and these are used on Linux and Mac GPU FYI bots where we
   need to test both configurations until passsthrough is shipped to
   those platforms and enabled by default.  Windows GPU FYI bots only
   run the passthrough variant of conformance tests.

2) gl_tests and command buffer perf tests which used validating decoder
   and were only run on Windows bots are removed. gl_tests_passthrough
   and gl_tests_validating test suites are also removed and so is
   gpu_command_buffer_perf_validating_isolated_scripts.
   gpu_win_specific_gtests test suite is removed since it's empty now.

3) gpu_fyi_win_and_linux_telemetry_tests and release_telemetry_tests are
   renamed to remove "win_and_" since these are only used for linux.

Bug: 1028850
Change-Id: I5e7f72effbf2103110bb2f4b75a9336cd9e91b46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939845
Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722710}

Security tests are disabled in crrev.com/c/1947944. This CL fixes the tests
to handle the new VisibleSecurityStateChanged event.

Bug: 946860
Change-Id: I70df252e54d6fa1776136364c78f530518d01010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947420
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#722709}

R=ganesh

Bug: 1031759
Change-Id: Ie10b00e0637b9f21ba00ddf1af72f868fa2d7550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956370
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: S. Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722708}

Replace the use of texture creation via skia with shared images in
ImageBitmap. The motivation behind this change is to ensure that the
resources created for ImageBitmap can be used by the compositor using a
different backend and to eliminate usage of skia in client code for
OOPR.

This change uses CanvasResourceProvider, instead of SkSurface, to
issue work executed using skia. This both replaces the resources
created with shared images and allows a natural transition to OOPR,
managed internally by CanvasResourceProvider, going forward.

R=kbr@chromium.org

Bug: 962630
Change-Id: Ibd9c9fc0358a2423b73c15c4e05e1926f6ebb640
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948237
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722707}

Real world PaintChunks are never empty, but previously we allowed empty
PaintChunks in unit tests.

Refactor tests to avoid empty PaintChunks.

The main change is in PaintArtifactTest which now creates a dummy
display item when the test doesn't specify any display item for a
PaintChunk.

Change-Id: I256151578afb5b98f656841b05ff60687a4b077e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955484Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722706}

https://quiche.googlesource.com/quiche.git/+log/5debd13b6484..b7ac1042fa4b

$ git log 5debd13b6..b7ac1042f --date=short --no-merges --format='%ad %ae %s'
2019-12-06 bnc Add header_list_size_limit_exceeded argument to OnHeadersDecoded().
2019-12-06 fayang gfe-relnote: When new 0RTT key is available, only allow client to write application data as server application data should be written in forward secure. Protected by gfe2_reloadable_flag_quic_use_handshaker_delegate2 which replaces gfe2_reloadable_flag_quic_use_handshaker_delegate.
2019-12-06 wub gfe-relnote: (n/a) Rename QuicRecordTestOutput to QuicRecordTrace. Test only rename, not protected.
2019-12-06 vasilvv Use client-supplied path instead of external configuration to switch between ECHO and DISCARD mode in QuicTransportSimpleServer
2019-12-06 vasilvv Parse the path component of the indication on the server.
2019-12-05 dschinazi Drop support for QUIC T048 and T049
2019-12-05 bnc Fix gcc compilation error.
2019-12-05 nharper gfe-relnote: deprecate gfe2_reloadable_flag_quic_enable_version_50
2019-12-05 renjietang Add stream number in GetSpdyDataStream() messages for better debugging.
2019-12-05 bnc Use IsStreamError() and friends gMock matchers in quic/core/crypto.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: Id82bf325818a47923ad0aa28740e500097b634fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956071
Auto-Submit: Nick Harper <nharper@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722705}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dca1c7eb4884..9777a8561d00


Created with:
  gclient setdep -r src-internal@9777a8561d00

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ia395fb1bdc99154e02540b005c46f31c17c9aa03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954334Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#722704}

Checking CanGoBack when constructing an interstitial from a throttle
(the way they are created with committed interstitials) resulted in
false negatives in some cases. This functionality is not used in Chrome
but is in Android Webview for safe browsing interstitials (they do not
show the Back To Safety button if there is nothing to go back to).
This CL introduces a separate method to check in that case.

Test: Covered by testSafeBrowsingDontProceedNavigatesBackForMainFrame

Bug: 1031620
Change-Id: I3638e173dcc226a18110153c6a33595a5cf45ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956120
Commit-Queue: Carlos IL <carlosil@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Auto-Submit: Carlos IL <carlosil@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722703}

- Remove setForeignSessions global function
- Replace chrome.send call in history.js with starting foreign session
fetch in C++ when the UI is constructed
- Convert getForeignSessions to use sendWithPromise
- Send sessions to JS on receiving getForeignSessions Web UI message

Bug: 1022212
Change-Id: Ia4613335a4cd3d0c8090f030cc0206661f81886d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949773Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722702}

See attached bug for reasoning and future plans

Bug: 1030744
Change-Id: I193d161ec55bef318d52ed27fca6fba45b2d232a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954143Reviewed-by: Caroline Rising <corising@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722701}

For pre-Q devices, Q-specific references causes ART verification
failures, and this slows down the creation time.

Move Q-specific references into a smaller class to minimize the time
taken for ART to re-verify verification failures at the run time.

Expected to reduce creation time by 7-10%.

      WebViewChromium

Test: list_class_verification_failures.py no longer shows
Bug: 1031362
Change-Id: I2a27079f22ef3f51b2a192182fba218af1ecf1eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954711Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722700}

From UX's feedback, the changes include:
 - Color link to Google Blue 600
 - Remove horizontal separator in Settings
 - Add space between policy indicator and the goggle

Test: visually looks good
Bug: chromium:893332
Change-Id: Ib24a44df02574301902012b6b480dc88a4b57f5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956067Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Victor Hsieh <victorhsieh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722699}

It is useful to keep this up to data to make it easy
to figure out costs of benchmarks.

Note that this is essentially a no-op from production
perspective.

This simply entailed running
/chromium/src/tools/perf$ ./generate_perf_sharding update-timing --waterfall=all


R=johnchen@chromium.org, ushesh@chromium.org

Bug: 1030840
Change-Id: I041e7f6b5668a6e86c97c343de69f2c4d228482a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956108Reviewed-by: Ushesh Desai <ushesh@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Ushesh Desai <ushesh@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722698}

This #define is only present in some downstream builds and should
probably not be used upstream. Use the upstream BUIDLFLAG(IS_CHROMECAST)
flag instead, so that upstream tests running with is_chromecast=true
take the right code path.

Bug: 1030969

Change-Id: Iffb1b41e616904450f4946e23899613b811fd2e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951982Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722697}

The UKM aggregation pipeline wasn't ready for additional aggregations
when https://crrev.com/c/1907147 was authored; now aggregations can be
added again.

Bug: 1025945
Change-Id: I634ca76bd9b3c189d2d60d4ceb41a91af2b190a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953667Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722696}

Fix a bug where empty incoming_transfer is not checked that would
cause cast_runner to panic.

Test: Manual test, passing an empty message port on control port would
not cause crash.
Bug: b/145814982

Change-Id: Icdeee7ad3f829e8ac07a08e8b544f364d106e916
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955089Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722695}

This reverts commit 9e845692.

Reason for revert: M80 branched @{#722274}

Original change's description:
> Disable use_dawn for the branch point
>
> Bug: chromium:985142
> Change-Id: Ifa9b692c47def3cbe1f3b030467a0bb122a2cfd9
> TBR: cwallez@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951895
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#721788}

TBR=kainino@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:985142, chromium:1031607
Change-Id: I4690e9cb042047c4d06db8412c0bb8729469857d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955087Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722694}

https://pdfium.googlesource.com/pdfium.git/+log/170f685582e1..95443cff5aef

git log 170f685582e1..95443cff5aef --date=short --first-parent --format='%ad %ae %s'
2019-12-06 tsepez@chromium.org Better tests for CJS_Field properties.

Created with:
  gclient setdep -r src/third_party/pdfium@95443cff5aef

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I9c616f1c30fa4c49aeb2bdaf938541f600211bb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954335Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#722693}

This CL takes out ZeroSuggest triggering on-focus for Desktop, as well
as some blacklisting logic.

Instead, we now trigger ZeroSuggest specifically on a select whitelist
of gestures.

This enables ZeroSuggest to work on repeated Ctrl+L presses now.

It also likely turns off ZeroSuggest for some focus events that are
triggered via Accessibility features. That's probably a good thing
though, as those users should get as little "noise" as possible.

TBR=thestig@chromium.org

Bug: 1026948
Change-Id: Iabbaca73a5ef93ae5676a363c1e44ece61cc74d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935208
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722692}

BlinkSchedulerDisableAntiStarvationForPriorities was enabled by default
in https://crrev.com/c/1952164, which obviates the need for these
virtual tests.

Bug: 979017
Change-Id: Ia520fb6370c635f8e3a6809583d1c31293968542
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953746Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722691}

Bug: internal b/143135800
Change-Id: I748a92d5239b1631a5fcf96aaf811a801c9a2264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956006Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722690}

Bug: 1028829
Change-Id: I4bf1a0b88de65fc9b6c084f058b1f430b03e1371
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947771
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722689}

We want to differentiate between first show attempt/result and
subsequent re-show attempts/results in UMA histograms for proactive
suggestions so that we can measure engagement of users the first time
they are presented w/ content in comparison to re-presentations of the
same content.

To accomplish this we add:
- Assistant.ProactiveSuggestions.FirstShowAttempt
- Assistant.ProactiveSuggestions.FirstShowAttempt.<Prefix>.ByCategory
- Assistant.ProactiveSuggestions.FirstShowResult
- Assistant.ProactiveSuggestions.FirstShowResult.<Prefix>.ByCategory
- Assistant.ProactiveSuggestions.ReshowAttempt
- Assistant.ProactiveSuggestions.ReshowAttempt.<Prefix>.ByCategory
- Assistant.ProactiveSuggestions.ReshowResult
- Assistant.ProactiveSuggestions.ReshowResult.<Prefix>.ByCategory

We mark the following pre-existing histograms as obsolete:
- Assistant.ProactiveSuggestions.ShowAttempt
- Assistant.ProactiveSuggestions.ShowAttempt.<Suffix>
- Assistant.ProactiveSuggestions.ShowResult
- Assistant.ProactiveSuggestions.ShowResult.<Suffix>

Bug: b:144875278
Change-Id: I8af637b43bb485d8ed1a7356311dd25a9aabb7e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951549
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722688}

This CL converts MediaDrmStorageRequest to PendingReceiver<MediaDrmStorage>.

Bug: 955171
Change-Id: Ia9b255c0a0719ad9a3a5aa0fef04dbd4a9d970e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954992Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#722687}

This CL converts P2PSocketManagerRequest to
PendingReceiver<P2PSocketManager> as well as renames
BindRequest to BindReceiver.

Bug: 955171
Change-Id: I11f552f9615fad2bfa0f04e5bb69394a3126ad7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954818Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#722686}

Adds the allowWithoutSanitization property to clipboard permissions, to support
raw clipboard access. This is exposed to the web as changing the permission
descriptor, so that navigator.permission, and later navigator.clipboard, can
expose allowWithoutSanitization. This change is web compatible, as no existing
web API usage is affected.

Blink: Adds the allowWithoutSanitization concept to blink-exposed classes,
such as ClipboardPromise, PermissionName, and permission.mojom. This matches
the direction proposed for specifications in the explainer[1].

Browser: Renames the existing CLIPBOARD_READ to CLIPBOARD_READ_WRITE, and
CLIPBOARD_WRITE to CLIPBOARD_SANITIZED_WRITE. This affects browser-side classes,
such as PermissionType and ContentSettings. This matches the direction proposed
for Chrome's permission model.

Translation: Translates between blink and browser permission models, where:
(1) CLIPBOARD_READ_WRITE = clipboard-write with allowWithoutSanitization:true,
                       and clipboard-read with any allowWithoutSanitization value.
(2) CLIPBOARD_SANITIZED_WRITE = clipboard-write with allowWithoutSanitization:false.

UMA: Renames histogram and enum values accordingly. This does mean new graphs
will be generated to track existing forms of clipboard permissions usage.

Test infrastructure: PermissionsHelper and TestRunner will have a visible change
in API, to use "clipboard-read-write" and "clipboard-sanitized-write".

Public-facing APIs: ChromeDriver, navigator.permission.query, and in the future
navigator.clipboard.{read,write} may now be able to access the new
allowWithoutSanitization property via updates to the permission descriptor.
Existing API use is not affected.

Here's a (slightly messy) diagram of Permissions classes and concepts relevant to this review: https://drive.google.com/file/d/1hjqE9oyCoI3cBxDDH7H1-Cl7xDqk4LJ5/view?usp=sharing

These permissions were first implemented through CLs in https://crbug.com/677564

Design Doc Permission Section: https://docs.google.com/document/d/1XDOtTv8DtwTi4GaszwRFIJCOuzAEA4g9Tk0HrasQAdE/edit#heading=h.121tek4wy4sh

[1]: https://github.com/WICG/raw-clipboard-access/blob/master/explainer.md

Bug: 897289
Change-Id: Ia5d20a1c602aff813c07ae37634914033b6c4418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895749
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722685}

This is a simple check to allow us to be able to easily run a limit
study to understand the effectiveness of previews. By limit study, we
mean showing Previews on all page loads for a subset of the population.
The limit study will still utilize the CanApplyPreview logic (e.g.,
hints and blacklists).

Bug: 1031593
Change-Id: I4fd6aec779447615a0660f3d22167091441d4e12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954710
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722684}

Also fixes throwing a raw Exception when led errors. This also got
lost in bad rebases earlier I think.

Change-Id: Icb02f538c70dd1425b4d6f8e825022813c8fecf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881813
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Auto-Submit: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722683}

Clicking on a link that would open a new tab should just navigate to
that website when the link is clicked in a preview tab.

The request for urls to be opened in a new tab goes through
WebContentsDelegate |shouldCreateWebContents| -> |webContentsCreated|
-> |addNewContents|. This CL handles it by having
|shouldCreateWebContents| return false so that no new WebContents
object is created. The passed URL is loaded into the preview
tab instead.

Bug: 1014777
Change-Id: If4fd76f563427aaae230af4e0519c2c388791fa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954990Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722682}

New CDP event to support localization of DevTools Security panel,
Security.visibleSecurityStateChanged, is checked in [1]. The handler for
this new event is currently behind an experiment [2]. To enable the new
hadnler in DevTools frontend, tests need to be fixed. This CL disables
security tests for now and later CLs will fix tests and re-enable these.

[1]: crrev.com/c/1646792
[2]: crrev.com/c/1880356

Bug: 946860
Change-Id: I2138f03e81b6aaf1d4f8ec96fa94eb52f40b9a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947944
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#722681}

Unfortunately, some child classes (Viewer Reference Spaces) have good,
valid reasons to override getPose (to guarantee that they can return
identity and not just near-identity which may have some interesting
rounding errors).  However, most child classes do not need to override
getPose. By forcing these children to implement MojoFromSpace or
SpaceFromMojo, their implementations of getPose can be simplified to
the parent implementation.

There were also some subtle bugs that lead to XRReferenceSpace's
SpaceFromMojo != Inverse(MojoFromSpace). Mainly this was that
MojoFromSpace post-multiplied the origin offset, which SpaceFromMojo did
not pre-multiply; but the pose for viewer space's was also wrong. This
was further complicated by the fact that one method required
mojo_from_viewer while the other didn't. Rather than plumb this value
through for all cases when really only the viewer space needed it, a
method was added to XRSession to get this transform when needed. This
allowed removing the SetMojoFromViewer method on XRFrame.

The DefaultViewerPose and SpaceFromViewerWithDefaultAndOffset methods
also had very limited and specific uses. By simplifying the way that
mojo_from_viewer was handled, DefaultViewerPose was able to be removed.
With this removed, SpaceFromViewerWithDefaultAndOffset is now basically
just a helper method to return InverseOriginOffset * SpaceFromViewer.

Unfortunately, different spaces have one of SpaceFromMojo/MojoFromSpace
that they can return more efficiently. It didn't seem worthwhile to
remove one or the other for the sake of simplicity when that could
cause some spaces to have a double inverse performed on the transform.
A helper TryInvert method was added to help simplify the "alternative"
method.

Bug: 1030413
Change-Id: Id4b047d0514ce8796412318585465d1a4e80fb13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954163Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722680}

Also using this public InkDrop interface from ConfigureBubbleMenuItem
to remove the hover animations.

Bug: 1015634
Change-Id: Iadc2256625c9b8aaca6ec283f96a95e8f06ae265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954938Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722679}

In the Autofill popup bubble, shows a "Use a virtual card number"
option if all the requirements are met.

Clicking on this new button is not handled yet. Will do that in next CL.

Attached screenshot in bug comment#4

Bug: 1020740
Change-Id: Ib0c85d7bc2233ea7c05b624ad9bdea0ec2eb2d80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947955
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#722678}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Ia0520570285882ac5f8dbabc5ebd7321af074d99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956128Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#722677}