- 12 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c4451adcce85..5697d3550bc8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6b20b774c51afa733e9c49e3378b083430b321fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351369Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797267}
-
Alexander Timin authored
Add a dedicated helper struct for holding WebContentsObservers. This allows us to ensure that iteration over all observers can be detected: - This can replace existing is_notifying_observer_ WebContentsImpl member and ensure that it's set for almost all observer iterations. - This allows us to emit a trace event covering observer iteration. Escape hatch is kept for now for the three places which want to return value as soon as matching observer is found. Also WeakPtr-based logic is added to RenderViewTerminated as some observers are actually trying to delete WebContents there. R=nasko@chromium.org Change-Id: Ic94cf9bbc83b2d9bfe93a3090a4f4af3fd8f60dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343269Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797266}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3e586480ca0f..51d97b104f79 2020-08-12 szuend@chromium.org [ts] Type-check ui/ThrottledWidget.js with TypeScript 2020-08-12 szuend@chromium.org [ts] Type-check ui/ResizerWidget.js with TypeScript 2020-08-12 szuend@chromium.org [ts] Type-check ui/Widget.js with TypeScript 2020-08-12 wolfi@chromium.org Show 'Opened Windows' in Application panel's frame tree 2020-08-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-12 szuend@chromium.org [ts] Type-check ui/SegmentedButton.js with TypeScript 2020-08-12 szuend@chromium.org [ts] Type-check ui/RootView.js with TypeScript 2020-08-12 szuend@chromium.org [ts] Store Widget scroll positions in WeakMap instead of the element 2020-08-12 szuend@chromium.org [ts] Move Element prototype wrangling to DOMExtension.js 2020-08-12 jacktfranklin@chromium.org Fix non-nullable bug in bridges interface output If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1107766 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id64662d12b5e8cdd8a786810cc004ba94ff90985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352353Reviewed-by:
-
Jan Wilken Dörrie authored
This change updates Chromium's copy of affiliation_api.proto to include the latest server side changes with regard to change password URLs. Bug: 437865 Change-Id: I566a5e05ff89ecc8d82d33e2a12dac5f28253522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351997 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#797264}
-
Karel Král authored
Add support for tracing of mojo sync response parameters in auto-generated methods. Thus provide more information for the developers who are debugging. Bug: 1103623 Change-Id: Ie0edadbe6007f0156d4c291775dba2e8777a2ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332819 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797263}
-
Peter Kasting authored
No need for temps if we call AddChildView() when constructing. Also, calling SizeToPreferredSize() in teh constructor allows simplifying Layout(). Bug: none Change-Id: I7a215cae407f9b48132045111c2818a467be6aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348196 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797262}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5697d3550bc8..09afd88dfed8 2020-08-12 treehugger-gerrit@google.com Merge "Check for failed OpenFile." 2020-08-12 taylori@google.com Merge "Roll trace_processor" 2020-08-12 hjd@google.com Merge "trace_processor: Add diff test for displayTimeUnit" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iffde4337fb876795160d339ea597fe4201a61afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352356Reviewed-by:
-
David Jean authored
Reset insets after changing configuration during a size change. Bug: 1114134 Change-Id: I3d32d5db03f5c2446830336d07821e325a443d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351833Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#797260}
-
Noel Gordon authored
Test is top flake in chromium as of today, mark as a [ Pass Failure ] on all bots. Tbr: sheriff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1049641 Change-Id: Ic56db02a7013af194ba8053aa2cc00de47368925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352570 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#797259}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9ca6a7f44301..780679454319 2020-08-12 fmalita@chromium.org [skottie] Initial audio layer plumbing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: Iba767c8600ff1e8a19123fe27ce7bf217b64ce22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351158Reviewed-by:
-
Victor Hugo Vianna Silva authored
None of the regressions from the previous rollout manifested so far, so let's try to enable by default again. This has no effect on Canary/Dev anyway since there's an ongoing experiment for the feature there. Bug: 906995 Change-Id: I4c9ca67c0e993f09b4903bae108fe25f9cfb2294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335452 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#797257}
-
Gayane Petrosyan authored
Create TextFragmentSelectorGenerator with page and set selection information when context menu is shown. This is done so that Java code can just call the GenerateSelector function without any arguments and generation can happen for the latest selected text. Follow-up CL https://chromium-review.googlesource.com/c/chromium/src/+/2341662 will connect to browser-side component. Bug: 1102382 Change-Id: I5574f5b40e5a74bef56698e2de5a9b1fea17e0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340734Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#797256}
-
Stephen McGruer authored
This reverts commit 4aa12de8. Reason for revert: Tentative revert as one possible cause of https://crbug.com/1115532 If revert doesn't fix failures, will reland (with apologies :)) Original change's description: > Oobe: add browser test for gaia screen > > Add browser test to verify behavior for back button on the gaia screen when kChildSpecificSignin feature is enabled. > > Bug: 1101318 > Change-Id: Ibaff1cf629520b3fbbe8cd620d8727bd35922295 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343068 > Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797176} TBR=antrim@chromium.org,rsorokin@chromium.org,yunkez@google.com Change-Id: I8347e80a1b22ab63f60688a8a23809be796b5039 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101318, 1115532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352550Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#797255}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/17a165467087..9642d3ae12e4 2020-08-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e697f4f1..54b8c1d0 (797077:797178) 2020-08-12 danilchap@webrtc.org Use non-deprecated EncodedImageCallback::OnEncodedImage in rtc_tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic41ef82be2bfec2153a31772c07ffba0e622480a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352354Reviewed-by:
-
sauski authored
Introduces functionality to the HatsNextWebDialog to support resizing of the dialog based on the size of the survey within the web contents. Size information is passed from the HaTS Next JS library through to native code by pushing URL fragments. Bug: 1110888 Change-Id: I70d7268cbc10c2da9e34d7dec338180a975f059f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274603 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#797253}
-
Michael Ershov authored
Before this CL tpm_challenge_key_unittest.cc contained tests for TpmChallengeKey, TpmChallengeKeySubtle and TpmChallengeKeyResult. Now it will test only TpmChallengeKey, other parts are separated into their own test sets (in previous CL). Bug: 1090723 Test: TpmChallenge* Change-Id: I66aa20a6d69e77a2865b77bacc819d0be61756d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228555 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#797252}
-
harrisonsean authored
Add support for safety check safe state and issues. Issues support includes deleting/managing in settings and on site. Add support for password check error popovers. Tests coming in later cl Bug: 1078782 Change-Id: I6c2b388fce4d397a1c1e01d161b4e0b35c91e9b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339322Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#797251}
-
Fergal Daly authored
Fix some grammar problems. Also mark "unload" as a non-translatable term. Change-Id: I422a2ad871a202c8576ad72b0166e8a4107dedab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342536 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4de6cfa5a936..0e99b9be0afe 2020-08-12 spang@chromium.org Revert "Remove use_relative_hooks now that all deprecated uses are removed." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1107325 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I3e79fab3be0cd06d61e742ba7cc8a597f8c062f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352355Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9c37bbd3e5eb..5276639d2789 2020-08-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 8e1380996d6a to 13a65b1aee42 (4 revisions) 2020-08-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from fcfe5a3b19d5 to e930c45863c6 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ia57d677ffdaa1caa43247da482c7e3f2e1666b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351156Reviewed-by:
-
Justin Donnelly authored
Change-Id: I42e41b63d6a8ecb4b06ed62bb45651a74570115c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350190Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#797247}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/689a3a9b..2d9546d5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I16b3b22d3fe83ea6f86a0181fcd8eb225e0deb5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351550Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797246}
-
Peter Beverloo authored
Bug: 1113148 Change-Id: Ie562df1e71f37bc8618d083ae68fb321a5cca1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351919 Commit-Queue: Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Auto-Submit: Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797245}
-
Stephen McGruer authored
This reverts commit 4fb20b8a. Reason for revert: Suspect for failures on WebKit Linux ASAN; https://crbug.com/1115526 Original change's description: > [Web Payment] Very long instrumentId string test. > > This patch adds a test for JSON serialization of a very long string > being passed into PaymentRequest API. > > Bug: 1110324, 1115091 > Change-Id: I7966d71c3752d1e4378a54f534a1915fb8fade39 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348411 > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Nick Burris <nburris@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797165} TBR=rouslan@chromium.org,nburris@chromium.org Change-Id: Ieef62c51b197a87a04b4bfc4fd6c91f8bcea85a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110324 Bug: 1115091 Bug: 1115526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352549Reviewed-by:
-
Richard Knoll authored
The final status flag is determined by the transfer status. Additionally this CL adds a Clone() method to TransferMetadataBuilder to be able to update fields from already build TransferMetadata objects. Bug: 1085067 Change-Id: Ie4a3cb335897f477329bc21189c33530ee7848ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349848Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797243}
-
Victor Hugo Vianna Silva authored
Reflecting the updated mocks. Bug: 1102294 Change-Id: If526eb2754bf4981affb0bb3a2be381f6ac5e143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352231Reviewed-by:
-
Sebastien Lalancette authored
Bug: 1093302 Change-Id: I8103a36420b9f99b3d8428e56f57fd244eb9f33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351953 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
-
Albert J. Wong authored
This removes the refcount thrashes in Element::setAttribute() avoiding nearly 13% of regression in blink_perf.bindings set-attribute.html story when StringImpl is made threadsafe. Bug: 1083392 Change-Id: Ia5fe7193c24ae8baa4f16a21a2a79f80e7dc0b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351950 Auto-Submit: Albert J. Wong <ajwong@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#797240}
-
Albert J. Wong authored
This is required for removing the refcount thrashes in Element::setAttribute() and ultimately avoids nearly 13% of regression in blink_perf.bindings set-attribute.html story when StringImpl is made threadsafe. Bug: 1083392 Change-Id: I904396d7913ad18ba0f097afd087aa796dd530ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351095 Auto-Submit: Albert J. Wong <ajwong@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d7901a45. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I921cc645a5e71ef8784d9e8026cc48bd933d7cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351549Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797238}
-
Nazerke authored
Current behaviour: The animation to enter fullscreen makes the Incognito badge next to the security icon appear as if it comes from the left. The animation to enter fullscreen makes icons on the far right (Share icon/ Mic icon) and left (Message badge/ Incognito badge) move towards the center before fading out completely. Intended behaviour: There should be no x translation, when the Incognito badge appears, but instead it should start animating from a scale of 0, while maintaining the current fade behaviour. The icon should not move towards the centre, but instead combine the current fadeout with a scale translation towards 0. Bug: none. Change-Id: Ie4b4c6844aa0618366d16bacb5b29adc26e8e03e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336837 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797237}
-
Danil Chapovalov authored
Bug: None Change-Id: I4b98e28ada4343a8674d4755dd9b8b224402b5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289778 Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#797236}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597211695-37c2210c4f6de3e68198b41f1297acfc22a0b10f.profdata to chrome-mac-master-1597233486-9b99859a3e8f91576b2a111cc083e1a4b72a89f4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic9006fb3c4fb3fe5526f76a6e8da322efd71eace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351157Reviewed-by:
-
Stephen McGruer authored
This reverts commit f0f5ad44. Reason for revert: Tentative revert for suspect of BackForwardCachePrintBrowserTest.DisableCaching failure; see https://crbug.com/1115515 If this does not resolve the issue, I will reland the CL (with apologies! :)) Original change's description: > Narrow the scope of page pause when printing. > > In the current implementation, sometimes the scope of a page's "pause" > is too wide compared to the definition in the spec [1], and sometimes it > does not pause at all. So narrow the scope to better conform to the > spec, and apply it consistently to all possible ways users can print. > > This is based on an earlier CL [2] which only did this for printing with > the system dialog, but not for Print Preview. Some of the trickier cases > handled, which require unpausing, are: > - Navigations while previewing. > - Printing selections, which require a navigation. > > [1] https://html.spec.whatwg.org/C/#printing-steps > [2] https://crrev.com/c/1669250 > > Bug: 956832 > Change-Id: I9bf274fcfb70eefe896fbbae9ce13a88b6f4dfc0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338819 > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797120} TBR=thestig@chromium.org,yukishiino@chromium.org,tkent@chromium.org Change-Id: I3518cb22f1b19fb4a2942c46fbcd9e7326d20863 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 956832, 1115515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352430Reviewed-by:
-
Viktor Semeniuk authored
This change hides Password Check section during search. Bug: 1075494 Change-Id: I5f0ce561bcb5d3282c1e477298cfecbce9224580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339747Reviewed-by:
-
W. James MacLean authored
This CL switches the order of checking origin isolation so that opt-in isolation (which is the stronger of the two), is checked before command- line isolation. Bug: 1067389, 1085275 Change-Id: I82eaa73eb4be67f35e8829334cf3e7f3868f87d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346906 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#797232}
-
Andrey Zaytsev authored
Bug: 1070620 Change-Id: Ic966e8f21ee31af7c47dc2be9a8073cd2e6f64ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351788Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#797231}
-
Yuki Shiino authored
Annotates some of bindings::V8SetReturnValue with 'inline' so that the perf on Android improves. blink_perf.bindings/node-type improves by ~7%. Bug: 839389 Change-Id: I32162c4712d828616785747ce7f5688f5511808c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348493 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#797230}
-
Avi Drissman authored
CTGetCoreTextVersion is deprecated as of macOS Big Sur. The recommended replacement is normal version checks, so migrate to the standard Chromium base::mac::IsOS() checks. Bug: none Change-Id: I782dd440d7fd04829eae4860cb57c7f7d1ffdb73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351161 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#797229}
-
Avi Drissman authored
On Big Sur, the system font has a full, real, 'opsz' axis rather than the 10.15 trick of gluing together two optical sizes. Adjust the test to match. Do some cleanup in the main .mm file. Switch from VLAs in VariableAxisChangeEffective() to WTF::Vector (as is used in the rest of the file) as VLAs are not allowed in Chromium nor Blink, and use #include as the style is to use #import for Objective-C headers. Bug: 1101448 Change-Id: I6043b53b9ac07cdddd082a19abf7bc8cbe3af58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351299 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
