- 16 Oct, 2019 40 commits
-
-
Dale Curtis authored
We've seen unusual statistics when we try to implicitly rely on the lack of an AudioCodec and VideoCodec to imply HLS support. So instead explicitly signal when we're using the MediaPlayerRenderer. This merely helps us differentiate watch time from MediaPlayer, it does not track HLS watch time directly. TEST=play hls, observe MediaPlayer in UKM fields. R=sandersd Change-Id: I7167504436af62a54eb4ebb20a02732e1f65a5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863858 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#706610}
-
Francois Doray authored
The policy was previously named TabLifecyclesEnabled and its name/description said that it controlled throttling, freezing and proactive discarding. It actually never controlled throttling and we decided to abandon the proactive discarding feature. Therefore, the name and description are changed to indicate that it controls tab freezing only. Also, the "future" tag is removed since we plan to ship tab freezing in M79. Bug: 844426 Change-Id: I6fdab954aa9d1c9fb5a63217ccda7b869726fc93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863382 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#706609}
-
Yue Zhang authored
* Tint the toolbar menu button properly. * When rotation happens, update the position of selection editor PopupWindow instead of re-showing it. * Calculate the dialog position instead of using getGlobalVisibleRect which doesn't deterministically happen early enough when rotating. * Pull out positioning-related logics from TabSelectionEditorLayout to TabSelectionEditorMediator and add tests. Bug: 1011269, 1011271 Change-Id: Iff3b5d993030f7798981b5ff5d945b28a2655188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846246 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#706608}
-
Bettina authored
https://screenshot.googleplex.com/T546MRqLTua Bug: 1010764 Change-Id: I2ab54c4a8c36980fb8f5307714b274b5284cb8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863638Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#706607}
-
Ana Salazar authored
- Increased the threshold to make it easier for users to drag the launcher from closed state to peeking state, so it's more tolerant in distinguishing between the intentions of the users. - Reduced the lower limit for the snapping thresholds for dragging the app list from shelf, so now peeking mode is set at a lower height. - Changed the downfling default resulting state to be peeking instead of closed, so that if the user end the drag with a downfling unintentionally, the launcher doesn't closes. Bug: 956173 Change-Id: I2cf8373b292518c8e1eaa3f9ee77b36db956f294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860109 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#706606}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fc9cfb00f341..c9f13b8d903d git log fc9cfb00f341..c9f13b8d903d --date=short --no-merges --format='%ad %ae %s' 2019-10-16 bpastene@chromium.org telemetry: Disable TestBrowserCreation.testCreateBrowserTwice on Chrome OS. Created with: gclient setdep -r src/third_party/catapult@c9f13b8d903d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:1014115 Change-Id: I44a8efdf81c55bcc76237b50bc56793adc7c7a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864814Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706605}
-
Brandon Goddard authored
This change builds off of https://chromium-review.googlesource.com/c/chromium/src/+/1729554 to allow the context menu key press inside a datagrid to add an 'Edit "<colName>" option that starts at the first editable column instead of the center column that is shown when using the mouse to right click on a dataGrid cell. This fixes the issue where the editing context menu would always show "Edit <middle Column>" due to how the event would assume the target is the visible center of the datagrid. Before: https://imgur.com/QE7VAKf After: https://imgur.com/a/iiKI2dk Bug: 963183 Change-Id: I20468e895a5df0cba368ad7ff954e34de17ac0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752769 Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Jeff Fisher <jeffish@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706604}
-
Brandon Goddard authored
This change adds 2 context menu entries for the IndexedDB datagrid to allow for expanding and collapsing the value objects from the keyboard. Note: This change does not currently work with the contextMenuKey due to an existing issue where contextMenuKey on the data grid will not target the selected node, but on whichever row happens to be in the center of the currently visible section of data grid. This issue will be resolved with this change: https://chromium-review.googlesource.com/c/chromium/src/+/1729554 Before: https://imgur.com/8Iz96jv After: https://imgur.com/UwSUVOh Bug: 963183 Change-Id: Iefb563dc744b524d3282b62141a9da12230e9911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725990Reviewed-by:
-
John Budorick authored
This reverts commit 63bc6538. Reason for revert: Still breaks UDPSocketTest. See https://bugs.chromium.org/p/chromium/issues/detail?id=1014916 for context. Original change's description: > Roll Fuchsia SDK from 889950275648 to 889942972119 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll > Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast > TBR=cr-fuchsia+bot@chromium.org > > Change-Id: Id87590c9ae2e3dddf858cfb5886ce359245409a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865033 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#706544} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org Change-Id: Iac0b3d0ceabe372b443d8a1897726073243051f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865544Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706602}
-
Tommy Steimel authored
Currently, the MediaNotificationView uses insets for the artwork based on the message center width. This works for ChromeOS (which uses message center to show the MediaNotificationView), but not for the Global Media Controls, which uses its own width. This CL fixes this issue by letting users of MediaNotificationView specify the width of the notification. Bug: 1011178 Change-Id: I267266a154b0bbd4e78ec4fec52734d32c2c9ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864417 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#706601}
-
Brandon Goddard authored
This change adds a context menu entry for the links that appear in the 'Functions' column in Heavy (bottom-up) and Top Down views in the Memory Allocation Sample and Javascript CPU Profiler tools. This allows the keyboard users to access these links with the context menu key. Note that this change is dependent on https://chromium-review.googlesource.com/c/chromium/src/+/1729554 for the context menu key in the DataGrid to target the currently selected node. Before: https://imgur.com/ErkPbIc After: https://imgur.com/a3R3rDB Bug: 963183 Change-Id: I3d5068b0efff0c31a46aeb6ee11ff5feb85bc58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832479Reviewed-by:
-
Tomasz Wiszkowski authored
This change removes custom Refinable icon from AnswerSuggestions in favor of base suggestion view. Change-Id: If460ec749cfd3786388b0423da2f61c805ec0c6f Doc: http://doc/1aL_UcW1gdeSLqNzuJZlQPBqMG0XAwVaoa05UTyVulp8 Bug: 982818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848391 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706599}
-
Jeremy Roman authored
While out-of-range tags are already rejected, tags which don't make sense for one or the other aren't currently handled gracefully. Instead of using the default case, we should explicitly deal with each enumerator. Bug: 1012581 Change-Id: I3aebb0a42bca66670ad6db65e514f74a6bd32530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865609 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#706598}
-
chrome://sync-internalsPeter Wen authored
Moves resources used in chrome://sync-internals out of components_resources.grd into its own GRD file. Also move these resources into the Dev UI Dynamic Feature Module (DFM) to save binary size on Chrome for Android. Update iOS dependency to include the new resource target. Original reason for revert: https://crbug.com/1013522 Relanding because a separate infrastructure issue was fixed: https://crrev.com/c/1864411 Tbr: huangs@chromium.org,dbeam@chromium.org,blundell@chromium.org,treib@chromium.org Bug: 927131, 1013522 Change-Id: I00f86462db5ac3cb397ee98e2e25bae41e69bbda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864564Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#706597}
-
Hiroki Nakagawa authored
This CL removes a thread check in WebDocumentSubresourceFilterImpl::BuilderImpl::Build() that is called during WorkerFetchContext creation. When the check was added, Build() was supposed to be called from the worker thread. However, PaintWorklet, which is a kind of workers but runs on the main thread, was implemented and broke the assumption. It should be safe to run it on the main thread, so this CL removes the check. This CL also adds tests for subresource filter for worklets to check the change. Bug: 887269, 1011208 Change-Id: Ieaa0ed4adb80523ec72af5916781c8593de28c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1242730Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#706596}
-
Raymond Toy authored
* The interpolation factor is constant so it can be lifted out of the loop. * Computation of the read_position only needs to be done once, and read_index1 can just be incremented in the loop * Cache write_index_ into a local * Change some doubles to floats Using spotify.github.io/web-audio-bench, without this CL we have: TEST μs MIN Q1 MEDIAN Q3 MAX Baseline 397 390 397 397 397 407 Delay-default 943 882 935 943 953 980 Delay-0.1 930 913 913 930 957 967 DelayAutomation-a-rate 1007 988 993 1007 1025 1032 DelayAutomation-k-rate 925 912 918 925 962 973 With thie CL: Baseline 393 323 383 393 393 400 Delay-default 213 210 212 213 253 278 Delay-0.1 235 232 233 235 283 343 DelayAutomation-a-rate 1043 1038 1040 1043 1043 1053 DelayAutomation-k-rate 245 238 243 245 285 313 The optimized version takes about 1/4 the time now. Bug: 1012198 Change-Id: I0de8f0980e9006241293dc97682d812af485bba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861036Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Andrew MacPherson <andrew.macpherson@soundtrap.com> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#706595}
-
Garrett Beaty authored
Bug: 790372 Change-Id: I27a30346a8a94feb6d92f35b97bbdd63d3a03eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865591 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#706594}
-
bttk authored
Annotate fields and methods that require synchronization with @GuardedBy Change-Id: I6f8fc772de470783459d458e5906e6ac18e48dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863852Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ender <ender@google.com> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#706593}
-
Hiroshige Hayashizaki authored
Because there are no ways to check console warnings from JavaScript. Bug: 990561 Change-Id: I5f3827c4383e35c74521148aa2e3b912b52a5f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843507 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#706592}
-
Kevin Bailey authored
Some methods appeared to have left off references or that are needlessly making copies. This CL converts these methods, only in unit tests, to pass by reference. Change-Id: I85c5b943e4c2ae0324e9170a08e0428325c3da0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863075Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706591}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d8b52989fe6b..341f30345fd1 git log d8b52989fe6b..341f30345fd1 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 lamontjones@chromium.org Revert "cros_build_lib.run: drop old signal workaround" 2019-10-16 lamontjones@chromium.org Mark lakitu temporarily non-crit. 2019-10-16 tcwang@google.com afdo: Switch benchmark-afdo-generate to use quota pool Created with: gclient setdep -r src/third_party/chromite@341f30345fd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I49435604dd839b633b256b6a51abaa8f8a158d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864816Reviewed-by:
-
Jesse McKenna authored
Corrects spelling of variable "enviroment_block" to "environment_block". Change-Id: Ic17c9691ecc5058436b5ad5c4eaaa36bf0a63779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863125Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#706589}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ebe5dcf0d9ad..01cc61ab9c9c git log ebe5dcf0d9ad..01cc61ab9c9c --date=short --no-merges --format='%ad %ae %s' 2019-10-16 natsu@google.com Remove hardcoded sdk_versions in third_party Created with: gclient setdep -r src/third_party/swiftshader@01cc61ab9c9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/138239233,chromium:b/142276229 Change-Id: I1f5e6634593845c93d94c18b430328556ad32459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865037Reviewed-by:
-
Kevin McNee authored
We test that methods for history manipulation work inside a portal context and that their behaviour is the same as in a non-portal context. We also test the new behaviour introduced with portals where a portal and its host do not form a joint session history. So unlike iframes, any session history change within a portal is done independently of its host. Bug: 914108 Change-Id: Ib1cdbe3e8d1c0e009eea1f05af28ef2971e8b353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807773Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#706587}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a14555a7928f..9a334fdadf3f git log a14555a7928f..9a334fdadf3f --date=short --no-merges --format='%ad %ae %s' 2019-10-16 jmadill@chromium.org Delete README.angle from googletest. 2019-10-16 timvp@google.com Vulkan: Mark destination buffers dirty after a copy Created with: gclient setdep -r src/third_party/angle@9a334fdadf3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: None Change-Id: I1753a2b13d9540e2002e195a310a98d685499be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865440Reviewed-by:
-
Hiroshige Hayashizaki authored
To test import maps without built-in module support. In import-maps-without-builtin-modules virtual tests, we skip wpt/import-maps/builtin-support/ tests because all of them are about built-in modules, but still run wpt/import-maps/imported/ tests because they still contain subtests that can pass without built-in modules/fallbacks. Bug: 1010751 Change-Id: I9ca8b9d2d40a699819ff38f6d652b7dc4be1b079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841813 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Oystein Eftevaag authored
https://chromium-review.googlesource.com/c/chromium/src/+/1834576 broke the legacy JSON upload of Slow Reports due to the data being truncated as data() has different semantics between RefCountedString and std::string, and the latter resulted in an unintended std::string constructor being implicitly invoked and the data being treated as a null-terminated string. R=ssid@chromium.org Bug: 1014589 Change-Id: If4d11ceb86106cf9cbee89735692dc83c1f7c35e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863855Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#706584}
-
Morten Stenshorne authored
Now that we support spanner margins, we need to make sure that we only apply the block-start margin before the first fragment generated from the spanner node. Bug: 829028 Change-Id: I76cc5c290009ad2c08ab78c6d780ef930f9b8641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865170 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706583}
-
shyam authored
Change-Id: Icf7368771f79d7c4e42c5845fb3a1fc6914a0469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864384 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Shyamsundar Parthasarathy <shyamsundarp@chromium.org> Reviewed-by:
-
Andrew Xu authored
The wrong radius was set by the culprit CL (crrev.com/c/1806015). This CL fixes such an issue. Bug: 1011013 Change-Id: I10659f593914fa3bdea0ca8b0f6f8bbb141c000f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865480 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0882b0ee. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I6accdaa09b7e5796792599bec37fd80a7628f549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864877Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706580}
-
Christopher Thompson authored
This refactors how Page Info handles showing the organization details for sites with EV certificates by moving creation of the subtitle text into the PageInfoBubbleView directly, since this is only used there. This fixes an issue where we were over-using the site_details_details_ member to track both EV details and Safe Browsing details, causing the certificate button subtitle to get filled with the wrong text for sites that have an EV certificate *and* trigger SB warnings. As part of this, tracking the organization name in PageInfo is no longer necessary, so this also removes that entirely. This change also includes two new tests: a unit test for checking that the certificate button subtitle text is correctly set for sites with EV certificates, and a regression browser test for sites that have an EV cert and trigger SB warnings. Bug: 1014240 Change-Id: I414cb07097fb5781c4b3a22ac7cca6e52bf14365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863643Reviewed-by:
-
Andrey Kosyakov authored
network_service_connection_error_handler_holder_ is used to update loader factories in page upon network service failure, so it should not be cleared upon navigation. Change-Id: I2103d633e47525ee8d8b33aa91324cb6c11ce9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863857Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#706578}
-
Owen Min authored
Change MachineLevelUserCloudPolicyRegisterWatcher to ChromeBrowserCloudManagementRegisterWatcher Bug: 1010704 Change-Id: I864d3427b7e4f79ba180706755c489049922e8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854225 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#706577}
-
Alex Cooper authored
This feature is intended to ship in 79, so the flag should be enabled by default. Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Nvll21RaKwM/fTn8qUaNBwAJ Bug: 1013739 Change-Id: I195c07cd61c2058533c2fa6640263567be248a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857008 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#706576}
-
Saman Sami authored
Instead of OverlayCheck_Params and OverlayCheckReturn_Params, use OverlaySurfaceCandidate and OverlayStatus respectively. The IPC structs are going away in the long term with the switch to mojo and they prevent us from adding more fields that may not be serializable (e.g. NativePixmap). Bug: 756454 Change-Id: I8fc8c975cd1f67706329c8ea9a38503e196068a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850537 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#706575}
-
Chris Harrelson authored
When a locked element becomes unlocked, it will compare its size before locking with the one after unlocking. Bug:964055 Change-Id: Ic9c32a68411e2ad5d7c9aaec4aeeb424cace044f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860597 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706574}
-
Christopher Grant authored
Some Android versions decode (some) symbols directly in Logcat output, even if a library lives uncompressed within an APK. Oddly, even for symbols within the same library, it may decode some and not others. Decoded symbols have the symbol name trailing the library offset, as follows: ...apk (offset 0x158a000) (logging::LogMessage::~LogMessage()+598) Currently, these lines are ignored by the decoder, which actually removes the information Android supplied. This change fixes the parsing to decode offset properly, and treat these lines the same as those without a decoded symbol. In the future, we ought to simply print the platform-decoded symbol names if present. R=agrieve Bug: 986622 Change-Id: Iec2b5968fe5e709f0dd37132a74d7f5c54957ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865203Reviewed-by:
-
Matt Mueller authored
Bug: 973650 Change-Id: I87468a94853789b2cc30fbc70d3bba20d89634b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853908 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#706572}
-
Garrett Beaty authored
Fix misspelling of coverage in docstring. Add section comments that I intended to add in https://crrev.com/c/1837196, but must have changed it on the wrong local branch. Bug: 1011908 Change-Id: I2cd0bea4d157dcd4e4c5b9a34f9d5dd0b64e4967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865534 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#706571}
-
